Bug#181971: psptools: psplpr loops with --dontincfeatures option

2003-02-21 Thread Arnaud Giersch
Package: psptools
Version: 1.2.2-7
Severity: normal
Tags: patch

Hi,

Using option "--dontincfeatures" makes psplpr looping:

$ psplpr --dontincfeatures -o - < foo.ps
%!PS-Adobe-2.0
[...]
%%BeginSetup
%%Feature: *Resolution 600dpi
%%Feature: *Resolution 600dpi
%%Feature: *Resolution 600dpi
[... line repeated infinitely ...]

foo.ps is a simple file generated with latex+dvips (which I can
provide if needed).

I tried to trace the problem and found that the following patch solves
the problem.  But as I don't speak Perl natively and I have no idea
what psplpr is supposed to do here, I don't know if it is correct.

--- psplpr.pl.in~   Fri Feb 21 14:22:52 2003
+++ psplpr.pl.inFri Feb 21 21:32:13 2003
@@ -402,7 +402,7 @@
$_ = readpsline($conformant);
 };
 
-while ($_) {
+for ( ; $_ ; $_ = readpsline($conformant)) {
if (!$code) {
last if (!/^%%/);
}
@@ -476,7 +476,6 @@
}
}
 
-   $_ = readpsline($conformant);
 }
 
 return ($_, $ps);


-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux dinadan 2.4.19-686 #1 Tue Nov 19 00:52:59 EST 2002 i686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED]

Versions of packages psptools depends on:
ii  perl  5.6.1-8.2  Larry Wall's Practical Extraction 

-- 
Arnaud



Bug#181970: psptools: psplpr make some images disappear

2003-02-21 Thread Arnaud Giersch
Package: psptools
Version: 1.2.2-7
Severity: normal

Hi,

When processing some files through psplpr, included images disappear.
E.g. the file



prints (or displays with gv) correctly without processing but not after 
using psplpr.

I used psplpr without arguments. A workaround is to use the arguments
"--dontchgfeatures" and "--dontincfeatures".

The printer is an HP LaserJet 2200, and I used the PPD file available at
. I 
also tested with Xerox PPD files and I got the same effects.

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux dinadan 2.4.19-686 #1 Tue Nov 19 00:52:59 EST 2002 i686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED]

Versions of packages psptools depends on:
ii  perl  5.6.1-8.2  Larry Wall's Practical Extraction 

-- 
Arnaud



Bug#181973: psplpr: useless argument parsing (-x)

2003-02-21 Thread Arnaud Giersch
Package: psptools
Version: 1.2.2-7
Severity: minor
Tags: patch

Hi,

If I understand the code correctly, the "-x" argument is parsed as a
synonym for "--warn", which is useless: "-x" is already used to change
"opt-prefix" at the beginning of argument processing.

--- psplpr.pl.in~   Fri Feb 21 22:36:55 2003
+++ psplpr.pl.inFri Feb 21 22:37:32 2003
@@ -834,8 +834,7 @@
 } elsif ($args[0] eq "--${lopt_prefix}silent") {
 $opt_verbose = 0;
close(STDERR);
-} elsif ($args[0] eq "-${opt_prefix}x"
-   || $args[0] eq "--${lopt_prefix}warn") {
+} elsif ($args[0] eq "--${lopt_prefix}warn") {
 $opt_warn = 1;
 } elsif ($args[0] eq "--${lopt_prefix}nodsc") {
$opt_nodsc = 1 unless $opt_nodsc;


-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux dinadan 2.4.19-686 #1 Tue Nov 19 00:52:59 EST 2002 i686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED]

Versions of packages psptools depends on:
ii  perl  5.6.1-8.2  Larry Wall's Practical Extraction 

-- 
Arnaud