Bug#810312: tracker.debian.org: Add debian/copyright link
Package: tracker.debian.org Severity: wishlist Tags: patch Dear Maintainer, I would like to access to the copyright information of packages on the distro- tracker. Examples https://sources.debian.net/copyright/license/python-django/1.9.1-1/ https://sources.debian.net/copyright/license/gnubg/1.05.000-3/ I attach a patch that provides a link in the links panel -- System Information: Debian Release: 8.2 APT prefers testing APT policy: (1000, 'testing'), (1000, 'stable'), (995, 'stable'), (750, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) >From 015cf0331508af79cd2afea4ab384964347ba5d0 Mon Sep 17 00:00:00 2001 From: Orestis Ioannou Date: Sat, 2 Jan 2016 14:36:46 +0200 Subject: [PATCH] Provide link to debsources copyright tracker --- distro_tracker/vendor/debian/tests.py | 13 - distro_tracker/vendor/debian/tracker_panels.py | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/distro_tracker/vendor/debian/tests.py b/distro_tracker/vendor/debian/tests.py index 5757b41..c641cad 100644 --- a/distro_tracker/vendor/debian/tests.py +++ b/distro_tracker/vendor/debian/tests.py @@ -2738,7 +2738,14 @@ class CodeSearchLinksTest(TestCase): def browse_link_in_content(self, content): html = soup(content) for a_tag in html.findAll('a', {'href': True}): -if a_tag['href'].startswith('https://sources.debian.net'): +if a_tag['href'].startswith('https://sources.debian.net/src'): +return True +return False + +def copyright_link_in_content(self, content): +html = soup(content) +for a_tag in html.findAll('a', {'href': True}): +if a_tag['href'].startswith('https://sources.debian.net/copyright'): return True return False @@ -2757,6 +2764,7 @@ class CodeSearchLinksTest(TestCase): response = self.get_package_page_response(self.package.name) self.assertTrue(self.browse_link_in_content(response.content)) +self.assertTrue(self.copyright_link_in_content(response.content)) self.assertFalse(self.search_form_in_content(response.content)) def test_package_not_in_allowed_repository(self): @@ -2771,6 +2779,7 @@ class CodeSearchLinksTest(TestCase): response = self.get_package_page_response(self.package.name) self.assertFalse(self.browse_link_in_content(response.content)) +self.assertFalse(self.copyright_link_in_content(response.content)) self.assertFalse(self.search_form_in_content(response.content)) def test_package_in_unstable(self): @@ -2784,6 +2793,7 @@ class CodeSearchLinksTest(TestCase): response_content = response.content.decode('utf-8') self.assertTrue(self.browse_link_in_content(response_content)) +self.assertTrue(self.copyright_link_in_content(response_content)) self.assertTrue(self.search_form_in_content(response_content)) def test_pseudo_package(self): @@ -2797,6 +2807,7 @@ class CodeSearchLinksTest(TestCase): response_content = response.content.decode('utf-8') self.assertFalse(self.browse_link_in_content(response_content)) +self.assertFalse(self.copyright_link_in_content(response_content)) self.assertFalse(self.search_form_in_content(response_content)) def test_code_search_view_missing_query_parameter(self): diff --git a/distro_tracker/vendor/debian/tracker_panels.py b/distro_tracker/vendor/debian/tracker_panels.py index 49ba680..35e3b2e 100644 --- a/distro_tracker/vendor/debian/tracker_panels.py +++ b/distro_tracker/vendor/debian/tracker_panels.py @@ -132,7 +132,9 @@ class SourceCodeSearchLinks(LinksPanel.ItemProvider): 'stable', 'oldstable', ) -SOURCES_URL_TEMPLATE = 'https://sources.debian.net/src/{package}/{suite}/' +DEBSOURCES = 'https://sources.debian.net/' +SOURCES_TEMPLATE = DEBSOURCES + 'src/{package}/{suite}/' +COPYRIGHT_TEMPLATE = DEBSOURCES + 'copyright/license/{package}/{suite}/' SEARCH_FORM_TEMPLATE = ( '
Bug#809211: tracker.debian.org: sqlite backend not usable
[ CCing upstream Django developer to have its opinion ] Hello, On Fri, 08 Jan 2016, Christophe Siraut wrote: > Sorry for the confusion, I have the same libsqlite3 version as you, and > it is that one I recompiled with SQLITE_MAX_COLUMN 32767. I can't reproduce the issue with Django 1.8. It looks like a regression of Django 1.9 that uses an SQL request to generate quoted values for the parameters fed into requests of the from "WHERE foo IN (...value list...)". Also does this also happen if you drop debug_toolbar from INSTALLED_APPS ? I have the feeling that this code path is only used when you actually want to print the SQL query that has been executed and this is usally only needed during development. The regression has been introduced by this commit: https://github.com/django/django/commit/4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5 commit 4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5 Author: Aymeric Augustin Date: Sun Sep 13 09:30:35 2015 +0200 Refs #14091 -- Fixed connection.queries on SQLite. It's supposed to fix https://code.djangoproject.com/ticket/14091 for SQLite. Christophe, can you verify that the issue is gone if you revert that change in your Django ? Aymeric, the above change is problematic because for a request that looks like MyModel.objects.filter(foo__in=my_array) it will break as soon as my_array goes above 2000 entries in length since that's the default limit for SQLITE_MAX_COLUMN and you will trigger it with your huge "SELECT QUOTE(?)," query. I know the query can also trigger the limit set with SQLITE_MAX_VARIABLE_NUMBER which defaults to 999 but at least on Debian we increased that limit significantly (to 25) so that limit is not a practical problem. The above limit is more problematic as we can't increase it to the same value (the max is 32767) and while the limit on the variable number was unreasonably low, I can understand the limit on the number of columns much better. See https://sqlite.org/limits.html Aymeric, what do you think ? Shall we open a ticket for this regression ? Can you update the code to process parameters by batch of less than 2000 entries ? You can look at https://bugs.debian.org/809211 for the former discussion in this bug report. Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#810312: tracker.debian.org: Add debian/copyright link
On Fri, Jan 08, 2016 at 09:09:01AM +0100, Orestis Ioannou wrote: > Package: tracker.debian.org > Severity: wishlist > Tags: patch > > Dear Maintainer, > > I would like to access to the copyright information of packages on the distro- > tracker. > Examples https://sources.debian.net/copyright/license/python-django/1.9.1-1/ > https://sources.debian.net/copyright/license/gnubg/1.05.000-3/ > > I attach a patch that provides a link in the links panel umh, that's already available, look at the panel "versioned links", the icon with the scales. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#810324: tracker: please make information actionable
package: tracker.debian.org Hi, https://tracker.debian.org/pkg/piuparts under "action needed" currently tells me that the package "depends on packages which need a new maintainer" but it doesn't tell me which those packages are, thus making this information pretty useless and somewhat annoying. Could you please add links to the packages which need a new maintainer?! cheers, Holger signature.asc Description: This is a digitally signed message part.
Bug#810312: tracker.debian.org: Add debian/copyright link
On 01/08/2016 11:40 AM, Mattia Rizzolo wrote: > On Fri, Jan 08, 2016 at 09:09:01AM +0100, Orestis Ioannou wrote: >> Package: tracker.debian.org >> Severity: wishlist >> Tags: patch >> >> Dear Maintainer, >> >> I would like to access to the copyright information of packages on the >> distro- >> tracker. >> Examples https://sources.debian.net/copyright/license/python-django/1.9.1-1/ >> https://sources.debian.net/copyright/license/gnubg/1.05.000-3/ >> >> I attach a patch that provides a link in the links panel > > umh, that's already available, look at the panel "versioned links", the > icon with the scales. > aha i didn't see this :) Wouldn't have guessed that the icon is about copyright! In any case its better since there are more accessible versions than just unstable. Thanks anyway. I guess it doesn't really make sense to change the link to debsources right? In that case please close the bug and sorry for the noise :) signature.asc Description: OpenPGP digital signature
Bug#810324: tracker: please make information actionable
On Fri, Jan 08, 2016 at 11:46:06AM +0100, Holger Levsen wrote: > https://tracker.debian.org/pkg/piuparts under "action needed" currently tells > me that the package "depends on packages which need a new maintainer" but it > doesn't tell me which those packages are, thus making this information pretty > useless and somewhat annoying. > > Could you please add links to the packages which need a new maintainer?! yes it does. you need to expand the item, with the little arrow down on the left, and it'll tell you: The packages that piuparts depends on which need a new maintainer are: adequate (#786808) Recommends: adequate -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#810324: tracker: please make information actionable
Hi, On Fri, 08 Jan 2016, Holger Levsen wrote: > https://tracker.debian.org/pkg/piuparts under "action needed" currently tells > me that the package "depends on packages which need a new maintainer" but it > doesn't tell me which those packages are, thus making this information pretty > useless and somewhat annoying. > > Could you please add links to the packages which need a new maintainer?! The links are there, you just need to click on the "chevron" on the left to toggle the display of the extra content. Do you have a suggestion to make it more obvious that more information is available? There's already a tooltip that says "click to toggle more details". Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/
Bug#810312: marked as done (tracker.debian.org: Add debian/copyright link)
Your message dated Fri, 8 Jan 2016 12:06:20 +0100 with message-id <20160108110620.gc29...@home.ouaza.com> and subject line Re: Bug#810312: tracker.debian.org: Add debian/copyright link has caused the Debian Bug report #810312, regarding tracker.debian.org: Add debian/copyright link to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 810312: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810312 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: tracker.debian.org Severity: wishlist Tags: patch Dear Maintainer, I would like to access to the copyright information of packages on the distro- tracker. Examples https://sources.debian.net/copyright/license/python-django/1.9.1-1/ https://sources.debian.net/copyright/license/gnubg/1.05.000-3/ I attach a patch that provides a link in the links panel -- System Information: Debian Release: 8.2 APT prefers testing APT policy: (1000, 'testing'), (1000, 'stable'), (995, 'stable'), (750, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) >From 015cf0331508af79cd2afea4ab384964347ba5d0 Mon Sep 17 00:00:00 2001 From: Orestis Ioannou Date: Sat, 2 Jan 2016 14:36:46 +0200 Subject: [PATCH] Provide link to debsources copyright tracker --- distro_tracker/vendor/debian/tests.py | 13 - distro_tracker/vendor/debian/tracker_panels.py | 10 -- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/distro_tracker/vendor/debian/tests.py b/distro_tracker/vendor/debian/tests.py index 5757b41..c641cad 100644 --- a/distro_tracker/vendor/debian/tests.py +++ b/distro_tracker/vendor/debian/tests.py @@ -2738,7 +2738,14 @@ class CodeSearchLinksTest(TestCase): def browse_link_in_content(self, content): html = soup(content) for a_tag in html.findAll('a', {'href': True}): -if a_tag['href'].startswith('https://sources.debian.net'): +if a_tag['href'].startswith('https://sources.debian.net/src'): +return True +return False + +def copyright_link_in_content(self, content): +html = soup(content) +for a_tag in html.findAll('a', {'href': True}): +if a_tag['href'].startswith('https://sources.debian.net/copyright'): return True return False @@ -2757,6 +2764,7 @@ class CodeSearchLinksTest(TestCase): response = self.get_package_page_response(self.package.name) self.assertTrue(self.browse_link_in_content(response.content)) +self.assertTrue(self.copyright_link_in_content(response.content)) self.assertFalse(self.search_form_in_content(response.content)) def test_package_not_in_allowed_repository(self): @@ -2771,6 +2779,7 @@ class CodeSearchLinksTest(TestCase): response = self.get_package_page_response(self.package.name) self.assertFalse(self.browse_link_in_content(response.content)) +self.assertFalse(self.copyright_link_in_content(response.content)) self.assertFalse(self.search_form_in_content(response.content)) def test_package_in_unstable(self): @@ -2784,6 +2793,7 @@ class CodeSearchLinksTest(TestCase): response_content = response.content.decode('utf-8') self.assertTrue(self.browse_link_in_content(response_content)) +self.assertTrue(self.copyright_link_in_content(response_content)) self.assertTrue(self.search_form_in_content(response_content)) def test_pseudo_package(self): @@ -2797,6 +2807,7 @@ class CodeSearchLinksTest(TestCase): response_content = response.content.decode('utf-8') self.assertFalse(self.browse_link_in_content(response_content)) +self.assertFalse(self.copyright_link_in_content(response_content)) self.assertFalse(self.search_form_in_content(response_content)) def test_code_search_view_missing_query_parameter(self): diff --git a/distro_tracker/vendor/debian/tracker_panels.py b/distro_tracker/vendor/debian/tracker_panels.py index 49ba680..35e3b2e 100644 --- a/distro_tracker/vendor/debian/tracker_panels.py +++ b/distro_tracker/vendor/debian/tracker_panels.py @@ -132,7 +132,9 @@ class SourceCodeSearchLinks(LinksPanel.ItemProvider): 'stable', 'oldstable', ) -SOURCES_URL_TEMPLATE = 'https://sources.debian.net/src/{package}/{suite}/' +DEBSOURCES = 'https://sources.debian.net/' +SOURCES_TEMPLATE = DEBSOURCES + 'src/{pac
Bug#810226: marked as done (tracker.debian.org: buggy_dependency link has an additional /pkg in URL)
Your message dated Fri, 8 Jan 2016 12:11:48 +0100 with message-id <2016010848.gd29...@home.ouaza.com> and subject line Re: Bug#810226: tracker.debian.org: buggy_dependency link has an additional /pkg in URL has caused the Debian Bug report #810226, regarding tracker.debian.org: buggy_dependency link has an additional /pkg in URL to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 810226: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810226 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Package: tracker.debian.org Severity: normal tag Dear Maintainer, Whenever a package is marked for autoremoval, the tracker has a message generated as the following (from 'distro_tracker/vendor/debian/templates/debian/autoremoval-action-item.h tml' in repo) ``` Version {{ item.extra_data.version }} of {{ item.package.name }} is marked for autoremoval from testing on {{ item.extra_data.removal_date }}. {% if bugs %} It is affected by {{ bugs|safe }}. {% endif %} {% if bugs_dependencies %} It depends (transitively) on {{ buggy_dependencies|safe }}, affected by {{ bugs_dependencies|safe }}. {% endif %} You should try to prevent the removal by fixing these RC bugs. ``` However, the link to the buggy_dependecies (generated by {{ buggy_dependencies|safe }}) has an additional '/pkg/' in the URL, which makes the redirection incorrect. I believe the attached patch fixes the issue. But, since I am not familiar with the codebase and this patch is created from a very quick glance over the code, it may be incorrect. But, the fix is quite easy as per my understaning. - -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 4.2.0-1-686-pae (SMP w/4 CPU cores) Locale: LANG=ml_IN, LC_CTYPE=ml_IN (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) - -- Regards Balasankar C http://balasankarc.in -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCgAGBQJWjm0QAAoJEJbtq5sua3Fx4MkH/2YTycxUYggmDrei5OHtKzhw S0b6YicmQm8tbF6CEeO5+DE6v/vOqzCP8/vRX4nqqlgpfdYT+ClOh/JXddAZqi3A CzZDeZCVXLapfr+eEG1QflHu/3Iq8wpughcaMGAMuDIzoPhPqSpWQ0DOUHpx8Djr dern7N01+skOvQ73y537jBdiudCPz5eMUQBs0jaBqEbMyGtCaUv5kJYDHUhNTZ38 h05AQe1ude2VcVwTkIyC5atEmKxTAMfKem7DFcDBAKO4J2DsfXqjMNhjJoiVIGuB JDnm61QT8gKIdzBTmTBwJC11j1pJHind8I/1nD2JABCjj4FNdH5H2q0X2N7ERDY= =jSpi -END PGP SIGNATURE- diff --git a/distro_tracker/vendor/debian/tracker_tasks.py b/distro_tracker/vendor/debian/tracker_tasks.py index e45623d..eaabe4f 100644 --- a/distro_tracker/vendor/debian/tracker_tasks.py +++ b/distro_tracker/vendor/debian/tracker_tasks.py @@ -2374,7 +2374,7 @@ class UpdateAutoRemovalsStatsTask(BaseTask): 'bugs_dependencies': ', '.join( link.format(bug, bug) for bug in bugs_dependencies), 'buggy_dependencies': ' and '.join( -['{}'.format( +['{}'.format( reverse( 'dtracker-package-page', kwargs={'package_name': p}), 0x2E6B7171.asc Description: application/pgp-keys --- End Message --- --- Begin Message --- Hello, On Thu, 07 Jan 2016, Balasankar C wrote: > However, the link to the buggy_dependecies > (generated by {{ buggy_dependencies|safe }}) has an additional '/pkg/' > in the > URL, which makes the redirection incorrect. > > I believe the attached patch fixes the issue. But, since I am not > familiar with the codebase and this patch is created from a very quick > glance over the code, it may be incorrect. But, the fix is quite easy as > per my understaning. It looks good, applied to git locally and will deploy it later. Thanks for your contribution. Do you feel like helping a bit more with tracker.debian.org? We have a couple of bugs for newcomers: https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=tracker.debian.org;tag=newcomer Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: http://www.freexian.com/services/debian-lts.html Learn to master Debian: http://debian-handbook.info/get/--- End Message ---
Bug#810324: tracker: please make information actionable
control: retitle -1 tracker: give more visual clues that some links are links Hi, On Freitag, 8. Januar 2016, Raphael Hertzog wrote: > The links are there, you just need to click on the "chevron" on the left > to toggle the display of the extra content. ah! > Do you have a suggestion to make it more obvious that more information is > available? There's already a tooltip that says "click to toggle more > details". make the "chevron" colored in blue, like the other links? cheers, Holger signature.asc Description: This is a digitally signed message part.
Processed: Re: Bug#810324: tracker: please make information actionable
Processing control commands: > retitle -1 tracker: give more visual clues that some links are links Bug #810324 [tracker.debian.org] tracker: please make information actionable Changed Bug title to 'tracker: give more visual clues that some links are links' from 'tracker: please make information actionable' -- 810324: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810324 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#809211: tracker.debian.org: sqlite backend not usable
Hello Raphael, Thanks for a great analysis. I can confirm this is a bug in Django. I didn’t realize SQLITE_MAX_COLUMN would be the limit here. Would you mind opening a ticket on https://code.djangoproject.com/? (Alternatively I can do it.) Best regards, -- Aymeric. > On 8 janv. 2016, at 10:55, Raphael Hertzog wrote: > > [ CCing upstream Django developer to have its opinion ] > > Hello, > > On Fri, 08 Jan 2016, Christophe Siraut wrote: >> Sorry for the confusion, I have the same libsqlite3 version as you, and >> it is that one I recompiled with SQLITE_MAX_COLUMN 32767. > > I can't reproduce the issue with Django 1.8. It looks like a regression of > Django 1.9 that uses an SQL request to generate quoted values for the > parameters fed into requests of the from "WHERE foo IN (...value > list...)". > > Also does this also happen if you drop debug_toolbar from INSTALLED_APPS ? > I have the feeling that this code path is only used when you actually want > to print the SQL query that has been executed and this is usally only > needed during development. > > The regression has been introduced by this commit: > > https://github.com/django/django/commit/4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5 > > commit 4f6a7663bcddffb114f2647f9928cbf1fdd8e4b5 > Author: Aymeric Augustin > Date: Sun Sep 13 09:30:35 2015 +0200 > >Refs #14091 -- Fixed connection.queries on SQLite. > > It's supposed to fix https://code.djangoproject.com/ticket/14091 for > SQLite. Christophe, can you verify that the issue is gone if you revert > that change in your Django ? > > Aymeric, the above change is problematic because for a request that > looks like MyModel.objects.filter(foo__in=my_array) it will break as soon > as my_array goes above 2000 entries in length since that's the default > limit for SQLITE_MAX_COLUMN and you will trigger it with your huge > "SELECT QUOTE(?)," query. > > I know the query can also trigger the limit set with > SQLITE_MAX_VARIABLE_NUMBER which defaults to 999 but at least on Debian > we increased that limit significantly (to 25) so that limit > is not a practical problem. The above limit is more problematic > as we can't increase it to the same value (the max is 32767) and > while the limit on the variable number was unreasonably low, I can > understand the limit on the number of columns much better. > > See https://sqlite.org/limits.html > > Aymeric, what do you think ? Shall we open a ticket for this regression ? > > Can you update the code to process parameters by batch of less than 2000 > entries ? > > You can look at https://bugs.debian.org/809211 for the former discussion > in this bug report. > > Cheers, > -- > Raphaël Hertzog ◈ Debian Developer > > Support Debian LTS: http://www.freexian.com/services/debian-lts.html > Learn to master Debian: http://debian-handbook.info/get/