Joining the team
Hi all, I would like to join the team. I'm intending to package mwic [1], Misspelled Words In Context, which is a spell-checker that groups possible misspellings and shows them in their contexts. This is useful for checking technical documents that often contain words that are not included in standard dictionaries. The upstream author is Jakub Wilk. I maintain some packages [2], and became a DM recently [3]. I'm "georg-guest" on salsa.d.o. I've read the team policy and accept it. Thanks in advance, cheers, Georg [1] https://jwilk.net/software/mwic [2] https://qa.debian.org/developer.php?login=georg%40riseup.net [3] https://nm.debian.org/process/419 signature.asc Description: Digital signature
Re: How to package my python module ?
Hi, On 18-03-16 17:16:23, 慕冬亮 wrote: > after I read the material Ben sent to me, I have a understanding of > the whole process. > > At first, I need to package my python module as a Debian package. > > Second, I need to find one sponsor to upload my package to the Debian > software repository(for now I don't have the privilege); > > Finally, after I am able to handle this procedure and believed by > sponsor, maybe I could get limited upload privilege. It might need some time up until you become a DM to be able to upload packages on your own, but in general, the above is correct. > I have registered in the mentors website and uploaded my GPG key. Now > it comes to one problem - how do I package my python module? Great! > For the materials about packaging a debian package, it is related one > general debian package. Is there document about how to package > one python module? Or find one debian package which is also python > module and borrow some experience from it? Have a look into the git repositories of other Python packages [1]. Also, these wiki articles [2] [3] might be worth a read. All the best, cheers, Georg [1] https://salsa.debian.org/python-team/modules [2] https://wiki.debian.org/Python/LibraryStyleGuide [3] https://wiki.debian.org/Python/AppStyleGuide signature.asc Description: Digital signature
RFS: mwic 0.7.4-1
Hi all, I'm searching a sponsor for the initial upload of mwic. Currently, the repo is at [1], I've pushed into the debian/0.7.4-1. Some further notes: - Could someone move the repo into the python-team namespace? I'm not able to do so, yet. - Running autopkgtest gives "SKIP no tests in this package". I've searched the Internets regarding this, but didn't found anything useful. I appreciate input and feedback regarding this. Thanks in advance, cheers, Georg [1] https://salsa.debian.org/debian/mwic signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
Hi Paul, On 18-03-17 11:28:51, Paul Wise wrote: > On Sat, Mar 17, 2018 at 5:29 AM, Georg Faerber wrote: > > I'm searching a sponsor for the initial upload of mwic. > > I'll be happy to sponsor this, but I will need you to upload the > source package to mentors.d.n first. Thanks a lot; sure, see [1]. Could you move the repo as well, or create a new one within the Python team? > > - Running autopkgtest gives "SKIP no tests in this package". I've > > searched the Internets regarding this, but didn't found anything > > useful. I appreciate input and feedback regarding this. > > In general, codesearch.d.n is a better place to find error strings > than web search engines. Yeah, I've used this as well, but in this case it's not that helpful as it finds the code defining the error [2]. > This is probably due to autodep8. Hm.. the manpage reads: "If a known package type is detected, autodep8 exits with 0 and prints the suggested contents of debian/tests/control to the standard output." Running it exits with 0 but there is no output. Not sure how to proceed here. Also, AFAIK, debian/tests/control is obsolete nowadays if debian/control contains Testsuite:. Thanks, Georg [1] https://mentors.debian.net/debian/pool/main/m/mwic/mwic_0.7.4-1.dsc [2] https://codesearch.debian.net/search?q=SKIP+no+tests+in+this+package signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
Hi Dimitry, On 18-03-20 00:46:16, Dmitry Shachnev wrote: > On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > > Also, AFAIK, debian/tests/control is obsolete nowadays if > > debian/control contains Testsuite:. > > This is not true. With autodep8 you can test only whether a package > can be imported. If you want to run some actual unit tests, you still > need debian/tests/control. In case you're referring to unit tests shipped upstream, that's not true. See this [1] and that [2] for an example. The tests are executed, but there is no debian/tests/control file. In case I've misunderstood you, and you're referring to unit tests shipped debian/tests/*, than yes, I agree. :) Cheers, Georg [1] https://ci.debian.net/data/autopkgtest/unstable/amd64/r/ruby-gettext-setup/20180313_122311/log.gz [2] https://salsa.debian.org/puppet-team/ruby-gettext-setup signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
Hi pabs, Thanks a lot for your review, and sorry for not responding earlier, too much stuff on my table: On 18-03-18 11:33:59, Paul Wise wrote: > The copyright years are missing 2012, I'm not sure if the ftp-masters > would reject the package on that basis. I've referred to the upstream git history, instead of the licence file. Fixed. > I require these things to be fixed before I would sponsor the package: > > doc/mwic.1 and tests/coverage are generated files, they should be > removed from the upstream VCS and tarballs and be always built from > source. If upstream refuses, you should remove them in `debian/rules > clean` and very early in `debian/rules build` so that the package will > never depend on the existing upstream files. I've searched quite a bit on the Internets how to do this, and leverage, for now, dh_clean. I hope that this is an acceptable method for this, I didn't found any "official" source. I'll approach upstream regarding these files. Also, the man page is now generated during dh_auto_install. I've added a build dependency on python3-docutils for this. > Some things that you may want to improve at some point: > > Please include the upstream signature in the source package. uscan > does the right thing these days, or you can rename it to > mwic_0.7.4.orig.tar.gz.asc and place it alongside the orig.tar.gz file > and rebuild the source package. Thanks for this pointer -- highly appreciated! Actually, I've debugged this for quite some time during the last year, and exchanged mails regarding this with Holger Levsen and Guido Günther seeking a way to include the upstream signature. Back then, I've read [1], and the man pages as well, but still couldn't figure it out - dropping the .asc into the top level directory didn't made a difference. After quite some time, I finally gave up. Up until yesterday I thought the tooling is currently limited. After reading your mail I debugged this again: It's not about the top level directory, at least if using gbp buildpackage, but about 'export-dir'. Placing a symlink inside there which points to the actual signature makes this work! :) The new upload should look better now in this regard. For now, I've wrote a wrapper script just for personal use, but I'll work on [2] and [3] to get this implemented in a proper way. > I like to wrap each of the fields in debian/watch on new lines. Although I think this is a matter of personal taste: fixed. > I like to use these wrap-and-sort parameters: > > wrap-and-sort --short-indent --wrap-always --sort-binary-packages > --trailing-comma See above. (Personally, I really dislike the trailing comma.) > misc/mwic4po seems like it would be worth installing in the package? There is no man page currently, and also, more importantly, out of the box this doesn't run in a non-interactive way. I guess, at least some people, might run mwic via a CI pipeline, that's why I don't ship this. I'll approach upstream regarding this. > Please add some upstream metadata: > > https://wiki.debian.org/UpstreamMetadata I've did this as well, although I'm unsure why this isn't defined in the policy. I'm aware that this was recently added to lintian, and reading the bug, again, makes me wonder what's the process of getting a new check into lintian. As it stands currently, some people take care of this, and some don't. This is of course not set in stone, but...well, not sure. > Output from automated checks is available at the very end of this > email. Thanks! > > Could you move the repo as well, or create a new one within the > > Python team? > > I'll leave that to someone who knows how to do that, I haven't dealt > with salsa yet. Alright! > > Yeah, I've used this as well, but in this case it's not that helpful > > as it finds the code defining the error [2]. > > I'd guess this is the source of the line you quoted: > > https://sources.debian.org/src/autopkgtest/5.1/runner/autopkgtest/?hl=144#L138 Correct. Still, my question stands: How do I enable autopkgtests for this package? > X: mwic source: upstream-metadata-file-is-missing Fixed. > check-all-the-things > > $ env PERL5OPT=-m-lib=. cme check dpkg > ... > Warning in 'control source Build-Depends:0' value 'debhelper (>= > 11~)': should be (>= 11) not (>= 11~) because compat is 11 > Warning in 'control source Build-Depends:1' value 'python3 (>= 3.2)': > unnecessary greater-than versioned dependency: python3 (>= 3.2). > Debian has oldoldstable -> 3.2.3-6; oldstable -> 3.4.2-2; > oldstable-kfreebsd -> 3.4.2-2; stable -> 3.5.3-1; unstable -> 3.6.3-2; > testing -> 3.6.4-1; unstable -> 3.6.4-1; > Warning in 'control binary:mwic Depends:0' value 'python3 (>= 3.2)': > unnecessary greater-than versioned dependency: python3 (>= 3.2). > Debian has oldoldstable -> 3.2.3-6; oldstable -> 3.4.2-2; > oldstable-kfreebsd -> 3.4.2-2; stable -> 3.5.3-1; unstable -> 3.6.3-2; > testing -> 3.6.4-1; unstable -> 3.6.4-1; Fixed. > $ doc8 > Scanning... > Validating... > .../mwic-0.
Re: RFS: mwic 0.7.4-1
On 18-03-20 20:21:20, Dmitry Shachnev wrote: > On Mon, Mar 19, 2018 at 11:31:07PM +0100, Georg Faerber wrote: > > On 18-03-20 00:46:16, Dmitry Shachnev wrote: > > > On Sat, Mar 17, 2018 at 10:49:26AM +0100, Georg Faerber wrote: > > > > Also, AFAIK, debian/tests/control is obsolete nowadays if > > > > debian/control contains Testsuite:. > > > > > > This is not true. With autodep8 you can test only whether a package > > > can be imported. If you want to run some actual unit tests, you still > > > need debian/tests/control. > > > > In case you're referring to unit tests shipped upstream, that's not > > true. See this [1] and that [2] for an example. The tests are executed, > > but there is no debian/tests/control file. > > > > [1] > > https://ci.debian.net/data/autopkgtest/unstable/amd64/r/ruby-gettext-setup/20180313_122311/log.gz > > [2] https://salsa.debian.org/puppet-team/ruby-gettext-setup > > This is a Ruby package. AFAIK autodep8 can run the unit tests for Ruby > packages and maybe for some other languages, but for Python it can > only test importability. I believe this is due to Python having (too) > many different test frameworks and ways to run them. > > See https://salsa.debian.org/ci-team/autodep8/blob/master/examples.md > which shows how the generated tests look like for different languages. Thanks for the insight and the pointer - I stand corrected. Cheers, Georg (No need to Cc: me, I'm subscribed to the list.) signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
Hi, On 18-03-20 18:11:50, Georg Faerber wrote: > > > Yeah, I've used this as well, but in this case it's not that > > > helpful as it finds the code defining the error [2]. > > > > I'd guess this is the source of the line you quoted: > > > > https://sources.debian.org/src/autopkgtest/5.1/runner/autopkgtest/?hl=144#L138 > > Correct. Still, my question stands: How do I enable autopkgtests for > this package? After reading the emails of Dimitry I've now integrated this. Changes pushed to git, package on m.d.n updated. Cheers, Georg signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
Hi, On 18-03-21 11:36:58, Paul Wise wrote: > On Wed, Mar 21, 2018 at 1:11 AM, Georg Faerber wrote: > >> doc/mwic.1 and tests/coverage are generated files, they should be > >> removed from the upstream VCS and tarballs and be always built from > >> source. If upstream refuses, you should remove them in > >> `debian/rules clean` and very early in `debian/rules build` so that > >> the package will never depend on the existing upstream files. > > > > I've searched quite a bit on the Internets how to do this, and > > leverage, for now, dh_clean. I hope that this is an acceptable > > method for this, I didn't found any "official" source. I'll approach > > upstream regarding these files. > > It needs to be done in both debian/rules clean and build, otherwise > building the package without the clean step will use the prebuilt > file. dh_clean is fine for the first one, but you need to override > dh_auto_configure or dh_auto_build for the second one. Fixed. I've used dh_auto_build to limit the needed override targets. > > Also, the man page is now generated during dh_auto_install. I've > > added a build dependency on python3-docutils for this. > > That is the wrong time to generate it, please change that to > dh_auto_build. Fixed. > > See above. (Personally, I really dislike the trailing comma.) > > The reason for the trailing comma option is that when you add a new > item to the end of a list of dependencies, you don't also have to > modify the line before it, making the diff easier to read, which is > most of the point of the wrap-and-sort tool. I see, thanks for the explanation, makes sense. > > I'm aware that this was recently added to lintian, and reading the > > bug, again, makes me wonder what's the process of getting a new > > check into lintian. > > The process for adding a check is to file a bug on lintian and wait a > day, lamby is incredibly active on incoming lintian requests. lamby does a great job, I didn't referred to him personally above. To put it differently, especially regarding this upstream metadata check: If someone opens a bug against lintian to add a new check, does "this new check" needs to be backed up by some general consensus within the project? Is there some "formal process" around this, besides opening a new bug? > > Correct. Still, my question stands: How do I enable autopkgtests for > > this package? > > I haven't yet dealt with autopkgtests so I'm not sure. This is fixed as well, see 20180321010428.GJ8754@debian. > > The texts are the same, there are only differences in special chars > > like ", so I guess this is a false positive. > > You may want to file a bug on license-reconcile about these false > positives re Expat vs MIT/X11. Will do, once mwic hits the archive, to serve as a proof of concept. Changes pushed to git, package on m.d.n updated. Thanks! Cheers, Georg signature.asc Description: Digital signature
Re: RFS: mwic 0.7.4-1
On 18-03-25 11:05:25, Paul Wise wrote: > On Wed, Mar 21, 2018 at 8:43 PM, Paul Wise wrote: > > I'll take a look, probably on Friday. > > Uploaded to NEW, thanks for your contribution. Thanks a lot, will tag accordingly once it hits unstable. > If you are so inclined, I would appreciated a commit (or patch) adding > mwic support to check-all-the-things: Will do. Cheers, Georg signature.asc Description: Digital signature
Re: Joining the team
On 18-03-15 22:04:39, Georg Faerber wrote: > Hi all, > > I would like to join the team. > > I'm intending to package mwic [1], Misspelled Words In Context, which > is a spell-checker that groups possible misspellings and shows them in > their contexts. This is useful for checking technical documents that > often contain words that are not included in standard dictionaries. > The upstream author is Jakub Wilk. > > I maintain some packages [2], and became a DM recently [3]. > > I'm "georg-guest" on salsa.d.o. > > I've read the team policy and accept it. > > Thanks in advance, > cheers, > Georg > > > [1] https://jwilk.net/software/mwic > [2] https://qa.debian.org/developer.php?login=georg%40riseup.net > [3] https://nm.debian.org/process/419 Friendly ping. mwic is by now in NEW, and I would like to move the repo. Thanks, cheers, Georg signature.asc Description: Digital signature
Re: Requesting team membership for DPMT on Salsa
On 18-04-05 16:53:36, Andreas Tille wrote: > On Thu, Apr 05, 2018 at 04:40:44PM +0200, Piotr Ożarowski wrote: > > [Andreas Tille, 2018-03-28] > > > I failed to find a button to ask for membership in the Salsa web > > > > let me know if you find it (bonus points for also letting me know how to > > disable it) > > May be it is just disabled? If you want to make sure: Check the group settings, especially "Allow users to request access." Cheers, Georg signature.asc Description: Digital signature
RFS: mwic 0.7.5-1
Hi all, Please review / sponsor mwic 0.7.5-1. Changes pushed to git [1], .dsc available via [2]. Thanks in advance, cheers, Georg [1] https://salsa.debian.org/python-team/modules/mwic [2] https://mentors.debian.net/debian/pool/main/m/mwic/mwic_0.7.5-1.dsc signature.asc Description: Digital signature
Re: Joining the team
Hi, On 18-03-15 22:04:39, Georg Faerber wrote: > I would like to join the team. > > I'm intending to package mwic [1], Misspelled Words In Context, which > is a spell-checker that groups possible misspellings and shows them in > their contexts. This is useful for checking technical documents that > often contain words that are not included in standard dictionaries. > The upstream author is Jakub Wilk. > > I maintain some packages [2], and became a DM recently [3]. > > I'm "georg-guest" on salsa.d.o. > > I've read the team policy and accept it. > > [...] > > [1] https://jwilk.net/software/mwic > [2] https://qa.debian.org/developer.php?login=georg%40riseup.net > [3] https://nm.debian.org/process/419 I became a DD now, could someone please add my new account "georg" to the team? Thanks, cheers, Georg signature.asc Description: PGP signature
Joining the team (again)
Dear all, I was part of the team in the past as 'georg-guest', I would like to join again as 'georg'. I do maintain anorack and mwic. I've read the team policy and accept it. Thanks, Georg
