Re: Review of package dunamai
Louis-Philippe Véronneau writes: > Hmm, whatever? It's really a matter of personal preferences. I tend to > be lazy and not want to build on experimental because the sbuild script > is more tedious... :) > Can I interest you in testing a wrapper script that I've been thinking about sharing for a while now? Basically it does a bunch of safety checks and convenience things, then builds for the right distro, then tags if the build was successful. Thus far it's based on a gbp paradigm, but some people on debian-backports said it would be nice if it could take source packages as input. Long-term, I'm not convinced that it would be a good fit for devscripts or git-build-package, since it's something in between. As you noted, experimental is its own case, as are backports, stable updates, security uploads, and I also don't like to think sbuild incantations. Maybe I should call the script dtrt-build? ;) Cheers, Nicholas signature.asc Description: PGP signature
Re: Review of package dunamai
Thank you for for the comprehensive yet friendly review! I've fixed all the things you pointed out in a new python-dunamai packaging repo: https://salsa.debian.org/python-team/packages/python-dunamai Salsa CI is green, lintian stays silent, unit tests pass, autopkgtests pass \o/ I've uploaded the initial package, let's see if it passes NEW. On 8/8/23 05:16, Louis-Philippe Véronneau wrote: 10. Your package doesn't actually run tests during build: "Ran 0 tests in 0.000s". You're missing "python3-pytest" as a build-dependency. With this dependency, all tests (and not only the unit tests) will be ran and they'll fail. I don't think you want to run the integration tests, or at least, this should probably be done in an autopkgtest instead. You can fix this by adding a "d/pybuild.testsuites" file containing "tests/unit" to specify what testfiles to add/keep. This file had no effect for me, all tests were run regardless. I found no mention of it in man or in other packages. (man pybuild for more info) I've used export PYBUILD_TEST_ARGS=tests/unit in d/rules to achieve the desired effect of only running unit tests. Cheers, and thanks for contributing to Debian! My pleasure and thank you for helping me contribute to Debian in higher quality! :) When you're ready for a review of poetry-dynamic-versioning, don't hesitate to ping me. Will do. I've opened ITP bug in the meantime (before dunamai hits sid): https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043360 There is already a question you might be able to answer. Cheers, Jakub Ružička OpenPGP_signature Description: OpenPGP digital signature
