Re: sphinxext-opengraph new upstream version and tests

2021-12-31 Thread Jeroen Ploemen
On Thu, 30 Dec 2021 14:27:09 -1000
Chiara Marmo  wrote:

> Dear list, Sandro,
> 
> I have uploaded on salsa a new upstream version of
> sphinxext-opengraph:
> https://salsa.debian.org/python-team/packages/sphinxext-opengraph/
> 
> I have also modified the way how tests are run... but I'm still in
> the process of understanding how autopkgtests works 

Enabling the CI on salsa for your package can be really helpful to
verify things work as expected. As an added benefit, it also lowers
the time and effort needed to review a package.

Anyway, the current autopkgtest has a number of obvious flaws:
* the binary package it's trying to test isn't actually installed at
  all because it's not listed as a test dependency;
* the same goes for the supported python versions the test loops over
  (i.e. the necessary dependency on python3-all is missing).
* on the other hand, dependencies of the package being tested (such
  as python3-sphinx) should not be duplicated as a test dependency;
* within the control file, the field identifying tests in a separate
  file is called 'Tests', not 'Test-Command'.


pgpok7AIgm01R.pgp
Description: OpenPGP digital signature


Re: Status of poetry

2021-12-31 Thread Taihsiang Ho (tai271828)
Hi everyone,

I gave the published deb a try by following this thread
https://lists.debian.org/debian-python/2021/11/msg00026.html and the binary
deb looks good to me. Thank you everyone for your effort. I appreciate your
effort so I could use poetry as a system-default package now.


More details regarding my testing if you are interested in:
I was aware that the package with the fixed python 3.10 testing error[1]
has been published when trying to fix the 3.10 testing error[1] during my
Christmas holidays, so I gave the published package a try instead by using
the binary deb.

The overall testing of the deb looks good for me. I used the binary deb
"python3-poetry"[2] to re-build my blog, which is a pelican-based project
managed by poetry, with Sid. I can smoothly re-build my blog and
publish/host it with an Apache server.


[1] Here is the elaboration of the error
https://lists.debian.org/debian-python/2021/11/msg00035.html and it seems
to be fixed by the patch debian/patches/PR3544.patch dd47cb90 committed by
Sandro
[2] The information of the packages
$ dpkg -l "*poetry*"
Desired=Unknown/Install/Remove/Purge/Hold
|
Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ NameVersion   Architecture Description
+++-===-=--===
ii  python3-poetry  1.1.11+dfsg-3 all  Python dependency
management and packaging made easy (Python 3)
ii  python3-poetry-core 1.0.7-2   all  Poetry PEP 517 Build
Backend

Cheers,
Tai


Re: Status of poetry

2021-12-31 Thread Emmanuel Arias
Hi!

On Fri, Dec 31, 2021 at 2:31 PM Taihsiang Ho (tai271828) 
wrote:

>
> More details regarding my testing if you are interested in:
> I was aware that the package with the fixed python 3.10 testing error[1]
> has been published when trying to fix the 3.10 testing error[1] during my
> Christmas holidays, so I gave the published package a try instead by using
> the binary deb.
>

Yes! Thanks for reporting the error, and yes, that was fixed by Sandro in
version 1.1.11+dfsg-3.


> The overall testing of the deb looks good for me. I used the binary deb
> "python3-poetry"[2] to re-build my blog, which is a pelican-based project
> managed by poetry, with Sid. I can smoothly re-build my blog and
> publish/host it with an Apache server.
>

That is amazing. Thanks for testing it!

Cheers!


Re: sphinxext-opengraph new upstream version and tests

2021-12-31 Thread Chiara Marmo
Thanks Jeroen for your time and your review

Enabling the CI on salsa for your package can be really helpful to
> verify things work as expected. As an added benefit, it also lowers
> the time and effort needed to review a package.
>

Indeed, I have enabled it.


> Anyway, the current autopkgtest has a number of obvious flaws:
> * the binary package it's trying to test isn't actually installed at
>   all because it's not listed as a test dependency;
> * the same goes for the supported python versions the test loops over
>   (i.e. the necessary dependency on python3-all is missing).
> * on the other hand, dependencies of the package being tested (such
>   as python3-sphinx) should not be duplicated as a test dependency;
> * within the control file, the field identifying tests in a separate
>   file is called 'Tests', not 'Test-Command'.
>

I think the configuration is better now, as the CI passed too.
Please let me know if the package is ready for the upload.

Also, happy new year 2022 to all the people on the list!

Best,

Chiara