[RFS] django-oauth-toolkit

2020-03-15 Thread Nilesh Patra
Hi,
Currently django-oauth-toolkit FTBFS with python3.8. I have fixed it, and
build + autopkgtest pass.
My changes have been pushed here [1].
Needs review and sponsorship.

[1]: https://salsa.debian.org/gi-boi-guest/django-oauth-toolkit

Thanks and regards
Nilesh


Re: [RFS] django-oauth-toolkit

2020-03-15 Thread Michael Fladischer

Hi Nilesh,


Am 15.03.2020 um 07:46 schrieb Nilesh Patra:
> Needs review and sponsorship.

just a quick glance at the commits: you do not need to replace 
autopkgtest-pkg-python with home-grown code, just tell it what to import:


echo oauth2_provider > debian/tests/pkg-python/import-name

Cheers,
Michael




Re: cannot allocate memory in static TLS block

2020-03-15 Thread Andreas Tille
Hi Faidon,

could you imagine to build jemalloc with --disable-initial-exec-tls
as Sergio suggests below to fix the issue in drmaa (and possibly other
packages)?

Should I open a separate bug report against jemalloc to request this?

Kind regards

  Andreas.

On Sat, Mar 14, 2020 at 05:18:49PM -0400, Sergio Durigan Junior wrote:
> > $ python3
> > Python 3.7.6 (default, Jan 19 2020, 22:34:52) 
> > [GCC 9.2.1 20200117] on linux
> > Type "help", "copyright", "credits" or "license" for more information.
>  import drmaa
> > Traceback (most recent call last):
> >   File "", line 1, in 
> >   File 
> > "/home/andreas/debian-maintain/salsa/med-team/python-drmaa/drmaa/__init__.py",
> >  line 65, in 
> > from .session import JobInfo, JobTemplate, Session
> >   File 
> > "/home/andreas/debian-maintain/salsa/med-team/python-drmaa/drmaa/session.py",
> >  line 39, in 
> > from drmaa.helpers import (adapt_rusage, Attribute, 
> > attribute_names_iterator,
> >   File 
> > "/home/andreas/debian-maintain/salsa/med-team/python-drmaa/drmaa/helpers.py",
> >  line 36, in 
> > from drmaa.wrappers import (drmaa_attr_names_t, drmaa_attr_values_t,
> >   File 
> > "/home/andreas/debian-maintain/salsa/med-team/python-drmaa/drmaa/wrappers.py",
> >  line 58, in 
> > _lib = CDLL(libpath, mode=RTLD_GLOBAL)
> >   File "/usr/lib/python3.7/ctypes/__init__.py", line 364, in __init__
> > self._handle = _dlopen(self._name, mode)
> > OSError: /usr/lib/x86_64-linux-gnu/libjemalloc.so.2: cannot allocate memory 
> > in static TLS block
> 
> This is an issue with jemalloc's handling of the TLS model when being
> dlopened..  See:
> 
>   https://github.com/jemalloc/jemalloc/issues/1237
> 
> The recommended way to build a libjemalloc that is suitable for being
> dlopened is to use '--disable-initial-exec-tls' when building it.  Take
> a look at the INSTALL.md file, and look for this option:
> 
>   https://github.com/jemalloc/jemalloc/blob/dev/INSTALL.md
> 
> There is a way to workaround this bug by doing an LD_PRELOAD of
> libjemalloc when invoking python, but this will only mask the problem
> and we can't expect users to do/know this.
> 
> The way I see it, you can try to convince jemalloc's maintainer to
> enable that flag.
> 
> BTW, the reason 'find_library' can't find drmaa's library is because the
> .so is being installed in a non-standard directory.  I don't know why
> the package was made like this, though.
> 
> Thanks,
> 
> -- 
> Sergio
> GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
> Please send encrypted e-mail if possible
> http://sergiodj.net/



-- 
http://fam-tille.de



Re: Re: [RFS] django-oauth-toolkit

2020-03-15 Thread Nilesh Patra
> just a quick glance at the commits: you do not need to replace
autopkgtest-pkg-python with home-grown code, just tell it what to import:

> echo oauth2_provider > debian/tests/pkg-python/import-name

Thanks, I didn't know about that. However, when I added that in, autopkgtest 
seems to fail with:

Removing autopkgtest-satdep (0) ...
autopkgtest [15:10:19]: test autodep8-python3: set -e ; for py in $(py3versions 
-r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c 
"import django_oauth_toolkit; print(django_oauth_toolkit)" ; done
autopkgtest [15:10:19]: test autodep8-python3: [---
Testing with python3.7:
Traceback (most recent call last):
  File "", line 1, in 
ModuleNotFoundError: No module named 'django_oauth_toolkit'
autopkgtest [15:10:19]: test autodep8-python3: ---]
autopkgtest [15:10:20]: test autodep8-python3:  - - - - - - - - - - results - - 
- - - - - - - -
autodep8-python3 FAIL non-zero exit status 1
autopkgtest [15:10:20]:  summary
autodep8-python3 FAIL non-zero exit status 1

The command I used: sudo autopkgtest -B ../*.deb -- schroot 
unstable-amd64-sbuild
Am I missing something here? Need your guidance here.

Thanks and regards,
Nilesh



Re: [RFS] django-oauth-toolkit

2020-03-15 Thread Michael Fladischer

Am 15.03.2020 um 10:54 schrieb Nilesh Patra:

autopkgtest [15:10:19]: test autodep8-python3: set -e ; for py in $(py3versions -r 2>/dev/null) ; do cd 
"$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import django_oauth_toolkit; 
print(django_oauth_toolkit)" ; done


Are you sure that debian/tests/pkg-python/import-name has the correct 
value? What does `cat debian/tests/pkg-python/import-name` show?


Anyways, thanks for your help, I made some minor tweaks and uploaded it 
a few hours ago.


Cheers,
Michael



Re: [RFS] django-oauth-toolkit

2020-03-15 Thread Nilesh Patra
> Are you sure that debian/tests/pkg-python/import-name has the correct
value?
I guess yes.

> What does `cat debian/tests/pkg-python/import-name` show?
[debian/master][~/packages/oauth-toolkit/django-oauth-toolkit]$ cat
debian/tests/pkg-python/import-name
oauth2_provider

Seems correct. I'm not really sure what is causing this.

> Anyways, thanks for your help, I made some minor tweaks and uploaded
it a few hours ago.
Thanks a lot for sponsoring the upload, :)
Could you as well review my changes for pytds[1] that are done here[2]?
That would be great.
I'm  planning to fix more packages in coming days, :)

[1]: https://lists.debian.org/debian-python/2020/03/msg00023.html
[2]: https://salsa.debian.org/gi-boi-guest/pytds

Thanks and regards,
Nilesh




Re: 2Removal: handling circular dependencies

2020-03-15 Thread Sandro Tosi
Hey Rebecca, do you have an updated list of these cycles?

On Wed, Oct 23, 2019 at 6:39 PM Rebecca N. Palmer
 wrote:
>
> [Summary of previous messages: I noted that packages with circular
> dependencies can't be removed one at a time without breakage.  Replies
> were to remove multiple packages at once if necessary, but ask first if
> other maintainers' packages are involved.]
>
> I have now checked what cycles we have:
>
> - 13 small sets (one of 13, others 2-4 each): small enough that "remove
> the whole set at once" is manageable.
>
> - One big tangle (159 packages).  This probably needs breaking up:
> --- Some of it involves documentation tools (e.g. sphinx).  These cycles
> can be broken by using the Python 3 version of the tool.
> --- Some of it is "A Suggests (or Recommends) A-extension, A-extension
> Depends on A" cycles (e.g. pandas<->statsmodels).  If A-extension is
> otherwise ready to remove but A is not, these can be broken by removing
> the Suggests from A.  (Assuming we're still using "broken Suggests are
> not allowed": this has previously been discussed, I forget where.)
>
> Full listing:
>
> 159 pyrex lxml html5lib sphinx mako python-scipy pandas patsy
> statsmodels seaborn sphinx-gallery matplotlib2 mpmath sympy
> texlive-extra nbconvert jupyter-notebook ipywidgets texlive-base dot2tex
> matplotlib numpydoc python-cycler ipykernel python-numpy mayavi2
> python-chaco python-envisage python-enable joblib pyzmq jupyter-client
> python-hypothesis chardet pygments python-pyface python-traitsui
> python-apptools python-traits ipython jupyter-core nbformat
> prompt-toolkit mercurial setuptools-scm python-py pytest-xdist pytest
> python-packaging python-importlib-metadata python-pluggy pyopenssl
> python-urllib3 python-future pyglet python-lz4 fdb sqlalchemy
> sphinxcontrib-websupport requests python-click incremental twisted
> automat python-service-identity python-gevent entrypoints python-flake8
> xcffib cairocffi python-keyring wheel python-pip keyrings.alt execnet
> sphinx-rtd-theme python-prometheus-client pytest-expect pytest-forked
> pytest-runner python-bleach python-mccabe python-atomicwrites
> python-attrs python-babel tap.py dbus-python python-qt4 pyqt5
> python-characteristic apipkg python-cryptography python-dateutil
> freezegun traitlets python-typing openpyxl python-tz python-et-xmlfile
> python-whoosh python-flaky wcwidth pexpect pillow python-docutils pymacs
> ropemacs python-mode enum34 sip4 configobj python-iso8601 pycairo
> pygobject-2 pygobject send2trash pygtk simplejson six unittest2
> python-mock python-psutil contextlib2 python-zipp python-traceback2
> python-debian python-apt python-linecache2 python-funcsigs
> python-concurrent.futures python-pathlib2 pickleshare testpath
> python-genty xlwt more-itertools backports.functools-lru-cache rope
> ropemode colorspacious cython pyyaml cvxopt sphinx-paramlinks
> python-pysqlite2 alabaster python-setupdocs nose mistune terminado
> python-webencodings ipython-genutils pep8 autopep8 pyxdg
> python-nose-exclude pyflakes python-greenlet xapian-bindings
>
> 2 rdflib sparql-wrapper-python
> 2 mgltools-pmv autodocktools
> 2 salutatoi sat-templates
> 2 cclib cclib-data
> 3 pastescript paste pastedeploy
> 2 sugar sugar-pippy-activity
> 13 trac-mercurial trac trac-customfieldadmin trac-graphviz
> trac-mastertickets trac-spamfilter trac-wikiprint trac-wysiwyg
> trac-xmlrpc email2trac trac-accountmanager trac-authopenid trac-bitten
> 4 hachoir-urwid hachoir-core hachoir-parser hachoir-metadata
> 4 python-pysnmp4 python-pysnmp4-mibs python-pysnmp4-apps pysmi
> 3 laditools ladish laditools # two 2Removal bugs on the same package
> 2 rpmlint rpm
> 2 crossfire crossfire-maps
> 3 python2.7 python-defaults python-stdlib-extensions
>
> (Based on recent cont...@bugs.debian.org messages; packages not listed
> are not in a cycle)
>


-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
Twitter: https://twitter.com/sandrotosi