Re: Packaging review

2014-03-22 Thread Dmitry Shachnev
Hi Ross,

I cannot upload your packages, but I had a quick look at them. They
mostly look good, but there are minor issues:

- Your copyright files don't comply to copyright format 1.0.
   - The license description should be indented with a space.
   - You shouldn't refer to symlinks like /usr/share/common-licenses/GPL.
   - For GPL license, add a longer introduction (see other packages
for example).
- Please use only one empty line to separate sections in debian/control;
- Some packages have tests, but they are not actually run during build
(like pyinsane).

--
Dmitry Shachnev

On Fri, Mar 21, 2014 at 4:40 AM, Ross Vandegrift  wrote:
> Hello,
>
> I am working on packaging a python application along with its
> dependencies.  This is my first shot at official Debian packages, so
> would appreciate any comments on my work!
>
> The modules are in the "debian" branches of:
> python-pocr https://github.com/rvandegrift/pyocr
> python-pyinsane https://github.com/rvandegrift/pyinsane
> python-nltk https://github.com/rvandegrift/nltk
> paperwork   https://github.com/rvandegrift/paperwork
>
>
> NLTK already has had some packaging work in progress - I haven't heard
> back from the latest volunteer on it's RFP, so I'm not sure if that's
> something I'd hope to submit.


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAKimPHXCm-EPyJt8rG=duyv0z1cznctah_frooja09rqdby...@mail.gmail.com



Re: Packaging review

2014-03-22 Thread Dmitry Shachnev
Also, please run lintian4python to inspect your packages. It reports
some errors, like:

e: python3-pyinsane: pyflakes-undefined-name
usr/lib/python3/dist-packages/pyinsane/rawapi.py:62: cmp
e: python3-pyinsane: pyflakes-undefined-name
usr/lib/python3/dist-packages/pyinsane/rawapi.py:425: MAX_USERNAME_LEN

--
Dmitry Shachnev

On Sat, Mar 22, 2014 at 1:36 PM, Dmitry Shachnev  wrote:
> Hi Ross,
>
> I cannot upload your packages, but I had a quick look at them. They
> mostly look good, but there are minor issues:
>
> - Your copyright files don't comply to copyright format 1.0.
>- The license description should be indented with a space.
>- You shouldn't refer to symlinks like /usr/share/common-licenses/GPL.
>- For GPL license, add a longer introduction (see other packages
> for example).
> - Please use only one empty line to separate sections in debian/control;
> - Some packages have tests, but they are not actually run during build
> (like pyinsane).
>
> --
> Dmitry Shachnev
>
> On Fri, Mar 21, 2014 at 4:40 AM, Ross Vandegrift  wrote:
>> Hello,
>>
>> I am working on packaging a python application along with its
>> dependencies.  This is my first shot at official Debian packages, so
>> would appreciate any comments on my work!
>>
>> The modules are in the "debian" branches of:
>> python-pocr https://github.com/rvandegrift/pyocr
>> python-pyinsane https://github.com/rvandegrift/pyinsane
>> python-nltk https://github.com/rvandegrift/nltk
>> paperwork   https://github.com/rvandegrift/paperwork
>>
>>
>> NLTK already has had some packaging work in progress - I haven't heard
>> back from the latest volunteer on it's RFP, so I'm not sure if that's
>> something I'd hope to submit.


-- 
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CAKimPHU6W9vufBrvg=tuyu0ogbpuyh_gkhegdskbxlarcsb...@mail.gmail.com