Re: [Debian-med-packaging] Review and sponsoring request: pymia (Python module)
* Gert Wollny , 2013-12-10, 18:22:
Vcs-Browser: http://anonscm.debian.org/?p=debian-med/pymia.git;a=summary
Vcs-Git: git://anonscm.debian.org/debian-med/pymia.git
I had a 5-seconds look at the source package:
Typo in the package description: apropriate -> appropriate
python3-mia(-dbg) should use ${python3:Depends} (NOT ${python:Depends}).
Build-dependency on pkg-config appears to be missing.
--
Jakub Wilk
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20131211134515.ga7...@jwilk.net
Re: [Debian-med-packaging] Review and sponsoring request: pymia (Python module)
Hello Jakub, thanks for having a look.
Hello Andreas, I've fixed the issues Jakub pointed out (see below), and
if the package now passes your scrutiny I'd ask for sponsoring.
best regards,
Gert
On Wed, 2013-12-11 at 14:45 +0100, Jakub Wilk wrote:
> * Gert Wollny , 2013-12-10, 18:22:
> >Vcs-Browser: http://anonscm.debian.org/?p=debian-med/pymia.git;a=summary
> >Vcs-Git: git://anonscm.debian.org/debian-med/pymia.git
>
> I had a 5-seconds look at the source package:
> Typo in the package description: apropriate -> appropriate
corrected,
> python3-mia(-dbg) should use ${python3:Depends} (NOT ${python:Depends}).
corrected,
> Build-dependency on pkg-config appears to be missing.
This dependency is pulled in via packages libmia-2.0-dev depends on (amongst
others libc6-dev).
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1386773644.23028.119.ca...@febe.die.upm.es
pybuild and not always preventing network connection in auto tests
Hi. AFAIU, pybuild prevents accesses to the network. But this can be problematic during auto_tests that will perform HTTP connections on a local HTTP server (I have such an example in rdflib's auto tests [0]). Is there a way to avoid such a protection, possibly on a selective number of tests ? Thanks in advance. Best regards, [0] https://github.com/RDFLib/rdflib/blob/master/test/test_conneg.py -- Olivier BERGER http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingenieur Recherche - Dept INF Institut Mines-Telecom, Telecom SudParis, Evry (France) -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87r49jif5j@inf-8660.int-evry.fr
Re: pybuild and not always preventing network connection in auto tests
On 11 December 2013 15:24, Olivier Berger wrote: > Hi. > > AFAIU, pybuild prevents accesses to the network. > > But this can be problematic during auto_tests that will perform HTTP > connections on a local HTTP server (I have such an example in rdflib's > auto tests [0]). > > Is there a way to avoid such a protection, possibly on a selective > number of tests ? > unexport http_proxy unexport https_proxy override_dh_auto_test: dh_auto_test --buildsystem=pybuild -- Regards, Dimitri. -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/canbhluhs_pasj6fwd1zqoaimca29vhg7wg1m4af-xtfbxq8...@mail.gmail.com
Re: pybuild and not always preventing network connection in auto tests
On 11 December 2013 15:33, Dimitri John Ledkov wrote: > On 11 December 2013 15:24, Olivier Berger > wrote: >> Hi. >> >> AFAIU, pybuild prevents accesses to the network. >> >> But this can be problematic during auto_tests that will perform HTTP >> connections on a local HTTP server (I have such an example in rdflib's >> auto tests [0]). >> >> Is there a way to avoid such a protection, possibly on a selective >> number of tests ? >> > > unexport http_proxy > unexport https_proxy > override_dh_auto_test: > dh_auto_test --buildsystem=pybuild > actually you probably need to set them to empty value; e.g. http_proxy="" https_proxy="" dh_auto_test, or export http_proxy\n export https_proxy -- Regards, Dimitri. -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CANBHLUi3hYLfjYwQ98T=iGTTjxKbwRnQsmnyfH+F-yEa=mp...@mail.gmail.com
Re: pybuild and not always preventing network connection in auto tests
On Dec 11, 2013, at 03:34 PM, Dimitri John Ledkov wrote: >actually you probably need to set them to empty value; e.g. >http_proxy="" https_proxy="" dh_auto_test, or export http_proxy\n >export https_proxy Right. That's essentially what I do. -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20131211105641.51c21...@limelight.wooz.org
Re: pybuild and not always preventing network connection in auto tests
Barry Warsaw writes: > On Dec 11, 2013, at 03:34 PM, Dimitri John Ledkov wrote: > >>actually you probably need to set them to empty value; e.g. >>http_proxy="" https_proxy="" dh_auto_test, or export http_proxy\n >>export https_proxy > > Right. That's essentially what I do. > I'm not sure I understand. Do I need an unexport http_proxy AND an http_proxy='' dh_auto_test ? I'm not sure about the behaviour of GNU make wrt env variables, so maybe that'd be obvious... Any clarification much welcome. Best regards, -- Olivier BERGER http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingenieur Recherche - Dept INF Institut Mines-Telecom, Telecom SudParis, Evry (France) -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87mwk7id37@inf-8660.int-evry.fr
Re: pybuild and not always preventing network connection in auto tests
On Dec 11, 2013, at 05:09 PM, Olivier Berger wrote: >Do I need an unexport http_proxy AND an http_proxy='' dh_auto_test ? No, all you need to do is unset http_proxy and https_proxy for the duration of the test command. >I'm not sure about the behaviour of GNU make wrt env variables, so maybe >that'd be obvious... You're just relying on the shell behavior that you can temporarily export a variable's setting by prefixing the command with environment settings. E.g. % export FOO=yes % printenv FOO yes % FOO= printenv FOO % FOO=no printenv FOO no So all you should need to do in the above is: override_dh_auto_test: http_proxy= https_proxy= dh_auto_test Of course, that means if your test hits the network outside of localhost, you may get local build successes where buildds without network access would still fail. Oh well, you'll find out soon enough. ;) Cheers, -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2013121736.4a82a...@limelight.wooz.org
Re: pybuild and not always preventing network connection in auto tests
Barry Warsaw writes: > On Dec 11, 2013, at 05:09 PM, Olivier Berger wrote: > >>Do I need an unexport http_proxy AND an http_proxy='' dh_auto_test ? > > No, all you need to do is unset http_proxy and https_proxy for the duration of > the test command. > OK, just inside the pybuild --test. That will prevent other problems related to import from pypi in other steps, etc. > > So all you should need to do in the above is: > > override_dh_auto_test: > http_proxy= https_proxy= dh_auto_test > > Of course, that means if your test hits the network outside of localhost, you > may get local build successes where buildds without network access would still > fail. Oh well, you'll find out soon enough. ;) > Yeah, well, in due time, yes ;) Thanks for the details. Best regards, -- Olivier BERGER http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8 Ingenieur Recherche - Dept INF Institut Mines-Telecom, Telecom SudParis, Evry (France) -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87iouvic5f@inf-8660.int-evry.fr
