Re: Request to Join Project Python Modules Packaging Team from Vincent Cheng (vincentc-guest)
On Sun, May 19, 2013 at 7:09 AM, Jakub Wilk wrote:
> * Vincent Cheng , 2013-05-18, 01:50:
>
>> I'm currently a DM (DDPO profile here [1]), and I'd like to join the DPMT
>> and PAPT to move some of my self-maintained packages (pygame is one of them)
>> into team maintainership. Most of my other packages are also team-maintained
>> (I'd estimate half of my packages to be in the Debian Games team, in fact).
>
>
> Welcome to the team!
Thanks! :)
> Here's my review of pygame_1.9.2~pre~r3189-2:
>
> You have "python3.2-dev (>= 3.2.3-7)" in Build-Depends. Could you put
> "python3.2-dev (<< 3.2.3-7)" in Build-Conflicts instead? That should have
> the same effect, while making it easier to remove python3.2 from the archive
> in the future.
Fixed.
> What is libjs-sphinxdoc in Depends for? The changelog says "Add depends on
> libjs-sphinxdoc and replace embedded js libraries with symlinks in
> debian/rules", but I don't see anything relevant in debian/rules. But
> anyway, should probably put ${sphinxdoc:Depends} in Depends and use
> dh_shpinxdoc instead of replacing this stuff manually.
Errr...I remember that at one point lintian complained about embedded
js libraries (jquery IIRC), but they don't seem to be present anymore
with the latest hg snapshot. I'll have to take a closer look at
this...
> I advocate against using ${python:Provides}:
> http://lists.debian.org/20110324164804.ga5...@jwilk.net
Fixed.
> It's time to drop Replaces/Conflict with python2.{3,4}-pygame.
Fixed.
> “for” loops in debian/rules lack “set -e”; see Policy §4.6.
Fixed.
> Please honour DEB_BUILD_OPTIONS=nocheck.
>
> Please run tests with all supported Python versions, not only the default
> one.
>
> Is there a reason test failures are ignored?
Some of the tests require X and a display adapter, hence me being lazy
and deciding to just skip tests altogether. I didn't know about xvfb
until just now however, so I'll definitely take another look at it.
> You might want to try run the tests under xvfb. Hopefully that should allow
> running more of them than currently.
>
> You never call "setup.py build" with python3.X, so building Python 3.X
> modules takes place only when you call "setup.py install", that is in
> binary* targets, with (pseudo)root privileges. This is something your should
> avoid.
Fixed.
> /usr/share/pyshared/pygame/docs: AFAICS this is the very same documentation
> as in /usr/share/doc/python-pygames/. Are two copies really needed?
>
> /usr/share/pyshared/examples: examples normally belong to
> /usr/share/doc/$package/examples/.
>
> Documentation and examples are quite big, and they are included in both
> binary packages. Maybe it would make sense to move them to a separate
> documentation package?
Definitely, that's on my TODO list for pygame...which has now just
grown much longer ;)
> /usr/share/pyshared/tests: do tests make sense in the binary package? I
> wouldn't install them.
>
> /usr/share/pyshared/pygame/LGPL: Lintian should have emitted
> extra-license-file.
>
> I see you overrode image-file-in-usr-lib, but "This is where distutils
> installs everything" is a poor excuse. :)
Is there any easy workaround for this? Admittedly I was being a bit
lazy here as well, but pygame's source doesn't contain that many
images and I didn't think it was worth adding more complexity to the
packaging in order to appease lintian.
> test/test_utils/unittest.py is an embedded copy of stdlib module. Please
> make sure it's not used at build time, and that it's not installed into
> binary packages.
>
> Please regenerate src/pypm.c from src/pypm.pyx at build time.
>
> docs/reST/ref/code_examples/joystick_calls.py uses "print" as method name.
> You can't do that in Python 2.X (unless you import print_function from
> __future__).
>
As for everything else, I'll fix each issue one by one when I have
some spare time. In the meantime, I've moved the packaging over from
collab-maint to the team's repository; any help would definitely be
appreciated.
Thanks for the very thorough review! :)
Regards,
Vincent
--
To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/caczd_tarllfjy2d1skmmx_r5nzm5fj7l3em22yz0usxde_3...@mail.gmail.com
Re: Request to Join Project Python Modules Packaging Team from Vincent Cheng (vincentc-guest)
On Sun, May 19, 2013 at 6:27 PM, Yaroslav Halchenko wrote: > > On Sun, 19 May 2013, Jakub Wilk wrote: >> You might want to try run the tests under xvfb. Hopefully that >> should allow running more of them than currently. > > just so it might come handy for others: to enable GLX support under > Xvfb, here is the line I have suggested to be used (upstream just > adopted it ;) ) for impressive build time testing: > > xvfb-run -s "-screen 0 640x480x24 -ac +extension GLX +render -noreset" COMMAND > > seems to work fine (besides on Ubuntu 12.10 for unknown to me yet reason). It > seems thought that you would also need build-depends on libgl1-mesa-dri to > make > it work ;) > Thanks for the tip! I'll have to read up on xvfb in my spare time; it looks to be rather useful and I kinda wish I learned about it earlier. Regards, Vincent -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caczd_tb6py36xvuq+togqdagtgco8kyoh1epgep_v7-nprg...@mail.gmail.com
Re: python3.3 status
On Fri, May 24, 2013 at 2:19 AM, Scott Kitterman wrote: > Did anyone else fix stuff? > cssutils FTBFS, needs rebuilt nosetests, then FTBFS #686340 Fixed. > python-docutils FTBFS #681723 Excellently fixed by Jakub. > pymarkups FTBFS TODO No longer FTBFS with the latest docutils. > python-flexmock FTBFS, needs rebuilt nosetests Fixed. Also committed a fix for python-pip (#692384) and submitted a fix for dep-8 tests for pandas. -- Dmitry Shachnev -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKimPHWLK+dYRkUGqnQqE_8irG=_8gfvjnghukjfh7dyxkv...@mail.gmail.com
Re: python3.3 status
Quoting Scott Kitterman (2013-05-24 00:19:06) > On Tuesday, May 07, 2013 02:01:26 PM Jakub Wilk wrote: [...] > > pytest FTBFS TODO Fixed signature.asc Description: signature
Re: python3.3 status
On May 07, 2013, at 02:01 PM, Jakub Wilk wrote: >flufl.bounce FTBFS #707086 This one is really because of the ancient version of zope.interface in sid/jessie. It's not until z.i 4.0.2 that Python 3.3 support was added, although 4.0.5 is the latest version in the Cheeseshop. CC pkg-zope-developers to get their feedback. FWIW, we have 4.0.5 in Ubuntu, so I'd be willing to help merge the Ubuntu changes back into Debian if the Zope team wants. zope.interface | 3.5.3-1 | squeeze | source zope.interface | 3.6.1-3 | wheezy | source zope.interface | 3.6.1-3 | jessie | source zope.interface | 3.6.1-3 | sid | source -Barry signature.asc Description: PGP signature
Re: python3.3 status
On Fri, May 24, 2013 at 11:24:20AM -0400, Barry Warsaw wrote: > On May 07, 2013, at 02:01 PM, Jakub Wilk wrote: > > >flufl.bounce FTBFS #707086 > > This one is really because of the ancient version of zope.interface in > sid/jessie. It's not until z.i 4.0.2 that Python 3.3 support was added, > although 4.0.5 is the latest version in the Cheeseshop. > > CC pkg-zope-developers to get their feedback. FWIW, we have 4.0.5 in Ubuntu, > so I'd be willing to help merge the Ubuntu changes back into Debian if the > Zope team wants. Please do. We recently discussed what to do now that Wheezy is out: http://lists.alioth.debian.org/pipermail/pkg-zope-developers/2013-May/008547.html The gist is that we got to a consensus on: * Merge changes from Ubuntu * add python3 support where possible * try stick to versions in http://docs.zope.org/zopetoolkit/releases/packages-2.0a1.html where possible Any help with that agenda would be appreciated :) -- Brian Sutherland -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524154805.GA69767@Brians-MacBook-Air.local
Re: PyCon 2013 -- tentative title/abstract/outline -- feedback plz
On May 19, 2013, at 12:58 AM, Jakub Wilk wrote: >* Barry Warsaw , 2012-09-28, 10:40: >>we need to get tools like pyflakes ported to Python 3. > >pyflakes >= 0.6 supports Python 3. There's no Debian package built for Python >3 yet, but that's something that can be kluged up: > >1) Install pyflakes_0.6.1-1~exp1 from experimental. >2) Put the attached script somewhere in your $PATH. >3) ... >4) PROFIT!^W^WGrumble that it doesn't work out of the box, and that you need >to resort to hacks like this instead. I'm working on updating svn to 0.7.2 and adding Python 3 support. I'll ask for a review once I get something working locally. Here's a question though, and it comes up again and again in different contexts (e.g. nosetests). I guess we should have a /usr/bin/pyflakes and /usr/bin/pyflakes3, yeah? -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524145522.19fef5f2@anarchist
pyflakes and Python 3 scripts (was Re: PyCon 2013 -- tentative title/abstract/outline -- feedback plz)
On May 24, 2013, at 02:55 PM, Barry Warsaw wrote: >I'm working on updating svn to 0.7.2 and adding Python 3 support. I'll ask >for a review once I get something working locally. r9670 >Here's a question though, and it comes up again and again in different >contexts (e.g. nosetests). I guess we should have a /usr/bin/pyflakes and >/usr/bin/pyflakes3, yeah? A few suggestions from IRC: py3flakes - What I don't like about that is that it's harder to locate(1). Replace the driver (Python) scripts with a shell script that takes a --py3 flag and invokes designated interpreter on the actual code. I rather like this, although I can see there are some complications. You probably have to sed the right interpreter(s) into a .in file and the actual entry point has to live somewhere. You probably also want a --py2 flag for consistency, and for when Python 3 is the default in Debian <0.5 wink>. You also have to strip out that argument and pass in all the others to the real driver script. What if those options collide with options the real script accepts? I kind of like the idea of such a driver shell script. Thoughts? -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524154030.1a6c8df2@anarchist
Re: pyflakes and Python 3 scripts (was Re: PyCon 2013 -- tentative title/abstract/outline -- feedback plz)
* Barry Warsaw , 2013-05-24, 15:40: Here's a question though, and it comes up again and again in different contexts (e.g. nosetests). I guess we should have a /usr/bin/pyflakes and /usr/bin/pyflakes3, yeah? My answer normally would be "ask upstream what is their preference". Although in this case the plan didn't work out: https://bugs.launchpad.net/pyflakes/+bug/1132892 Either upstream doesn't care; or they do, but they're annoyed with the discussion style. A few suggestions from IRC: py3flakes +1 - What I don't like about that is that it's harder to locate(1). Who uses that anyway? ;) Replace the driver (Python) scripts with a shell script Eww! :( -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524200215.ga9...@jwilk.net
Re: pyflakes and Python 3 scripts (was Re: PyCon 2013 -- tentative title/abstract/outline -- feedback plz)
On May 24, 2013, at 10:02 PM, Jakub Wilk wrote: >My answer normally would be "ask upstream what is their preference". Although >in this case the plan didn't work out: >https://bugs.launchpad.net/pyflakes/+bug/1132892 Either upstream doesn't >care; or they do, but they're annoyed with the discussion style. Thanks, I'd missed that bug. In any case, I started a conversation on python-dev to see if we can get some general consensus upstream. >>A few suggestions from IRC: >> >>py3flakes > >+1 > >>- What I don't like about that is that it's harder to locate(1). > >Who uses that anyway? ;) Maybe just dinosaurs? . But it also makes ls a bit more difficult. I guess I'm a -0 on the pyfoo/py3foo naming convention. >>Replace the driver (Python) scripts with a shell script > >Eww! :( Can you elaborate on what you don't like about that? I'd like to at least accurately understand your objections. Cheers, -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524161249.73709cb9@anarchist
Re: python3.3 status
On May 24, 2013, at 05:48 PM, Brian Sutherland wrote: >On Fri, May 24, 2013 at 11:24:20AM -0400, Barry Warsaw wrote: >> On May 07, 2013, at 02:01 PM, Jakub Wilk wrote: >> >> >flufl.bounce FTBFS #707086 >> >> This one is really because of the ancient version of zope.interface in >> sid/jessie. It's not until z.i 4.0.2 that Python 3.3 support was added, >> although 4.0.5 is the latest version in the Cheeseshop. >> >> CC pkg-zope-developers to get their feedback. FWIW, we have 4.0.5 in >> Ubuntu, so I'd be willing to help merge the Ubuntu changes back into Debian >> if the Zope team wants. > >Please do. We recently discussed what to do now that Wheezy is out: > > > http://lists.alioth.debian.org/pipermail/pkg-zope-developers/2013-May/008547.html > >The gist is that we got to a consensus on: >* Merge changes from Ubuntu >* add python3 support where possible >* try stick to versions in > http://docs.zope.org/zopetoolkit/releases/packages-2.0a1.html > where possible > >Any help with that agenda would be appreciated :) Looks like, at least for zope.interface, Gediminas is way ahead of me: http://lists.alioth.debian.org/pipermail/pkg-zope-developers/2013-May/008563.html Alioth's svn looks ready to go for 4.0.5-1. I only added a get-orig-source target to repack the .zip, but that's mostly unimportant for this particular issue. The last message in that thread was 15-May, so it seems like maybe zope.interface, if not more of zope.* is just waiting for uploads (something that I can't *quite* help with yet ;). -Barry -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130524182947.18309019@anarchist
Re: python3.3 status
Į will sync the rest of zope packages from ubuntu in a few days. Anyone able to upload? What is the latest snippet to add for python3 support?.. 2013.05.25 01:36, "Barry Warsaw" rašė: > On May 24, 2013, at 05:48 PM, Brian Sutherland wrote: > > >On Fri, May 24, 2013 at 11:24:20AM -0400, Barry Warsaw wrote: > >> On May 07, 2013, at 02:01 PM, Jakub Wilk wrote: > >> > >> >flufl.bounce FTBFS #707086 > >> > >> This one is really because of the ancient version of zope.interface in > >> sid/jessie. It's not until z.i 4.0.2 that Python 3.3 support was added, > >> although 4.0.5 is the latest version in the Cheeseshop. > >> > >> CC pkg-zope-developers to get their feedback. FWIW, we have 4.0.5 in > >> Ubuntu, so I'd be willing to help merge the Ubuntu changes back into > Debian > >> if the Zope team wants. > > > >Please do. We recently discussed what to do now that Wheezy is out: > > > > > http://lists.alioth.debian.org/pipermail/pkg-zope-developers/2013-May/008547.html > > > >The gist is that we got to a consensus on: > >* Merge changes from Ubuntu > >* add python3 support where possible > >* try stick to versions in > > http://docs.zope.org/zopetoolkit/releases/packages-2.0a1.html > > where possible > > > >Any help with that agenda would be appreciated :) > > Looks like, at least for zope.interface, Gediminas is way ahead of me: > > > http://lists.alioth.debian.org/pipermail/pkg-zope-developers/2013-May/008563.html > > Alioth's svn looks ready to go for 4.0.5-1. I only added a get-orig-source > target to repack the .zip, but that's mostly unimportant for this > particular > issue. > > The last message in that thread was 15-May, so it seems like maybe > zope.interface, if not more of zope.* is just waiting for uploads > (something > that I can't *quite* help with yet ;). > > -Barry >
Joining DPMT / PAPT
Hi! I'd like to join the Debian Python teams. I have two packages I'd like to package for Debian at the moment -- python-github (ITP #709682) and tratihubis (ITP not filed yet). I'm a DM and have slowly been having more time for Debian-ish stuff, so I expect that there will probably be more packages that I'd like to see in Debian as time passes. I've just submitted a request to join the Alioth DPMT group. I already asked on IRC, but if folks here have comments on my draft packaging for pygithub (with a python- and python3- split based on ScottK's python-ipaddr packaging), I'd definitely appreciate them: https://ldpreload.com/p/pygithub_1.14.2-1.dsc Thanks, -- Geoffrey Thomas http://ldpreload.com geo...@ldpreload.com -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.deb.2.00.1305241736360.15...@dr-wily.mit.edu
Re: pyflakes and Python 3 scripts (was Re: PyCon 2013 -- tentative title/abstract/outline -- feedback plz)
On 24 May 2013 20:40, Barry Warsaw wrote: > On May 24, 2013, at 02:55 PM, Barry Warsaw wrote: > > py3flakes - What I don't like about that is that it's harder to locate(1). > I like pyflakes3, but better yet I'd prefer: python3 -m flakes similar to how compileall / unittest / et al work. Regards, Dmitrijs. -- To UNSUBSCRIBE, email to debian-python-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/canbhluh-ejci6vrcxafbgrjkqvmo0+9zwd+knk+53aggbxf...@mail.gmail.com
