Re: RFS: nautilus-clamscan

2008-05-14 Thread Vincent Bernat
OoO En  ce début  de soirée du  mardi 13  mai 2008, vers  21:55, Clement
Lorteau <[EMAIL PROTECTED]> disait:

> I am looking for a sponsor for my package "nautilus-clamscan".

> * Package name: nautilus-clamscan
>   Version : 0.2.1-1
>   Upstream Author : Clement Lorteau <[EMAIL PROTECTED]>
> * URL : http://launchpad.net/nautilus-clamscan
> * License : GPLv3
>   Section : utils

Hi Clement!

Since this is a python application, you should Cc: debian-python mailing
list. They can give you some accurate advices.

In debian/changelog, say "Initial release", not "First Debian package". ;-)

In debian/control, you should move dpatch to Build-Depends: it is needed
for clean target. Why do you depend on dpatch if there is no patch?

I think that you should move test files into /usr/share/doc/XXX/examples
(with nautilus-clamscan.examples).

Remove  the fact  that debian/rules  is a  sample file.  Why do  you set
.NOTPARALLEL?
-- 
I WILL NOT FAKE RABIES
I WILL NOT FAKE RABIES
I WILL NOT FAKE RABIES
-+- Bart Simpson on chalkboard in episode 8F07


pgpPlGCzamkej.pgp
Description: PGP signature


Re: RFS: nautilus-clamscan

2008-05-14 Thread Clement Lorteau
Hi !

Thank you for the review. I followed your recommendations and uploaded
the new package to debian.mentors.net. See my comments below.

Thanks,
Clement.

-- 
Clement Lorteau
www.lorteau.fr | launchpad.net/~northern-lights


Le mercredi 14 mai 2008 à 20:18 +0200, Vincent Bernat a écrit :
> In debian/control, you should move dpatch to Build-Depends: it is needed
> for clean target. Why do you depend on dpatch if there is no patch?
Because the generic Python application Debian packaging script i make as
my understanding of packaging evolves puts it even if there's no patch
to apply :p. Fixed.
> I think that you should move test files into /usr/share/doc/XXX/examples
> (with nautilus-clamscan.examples).
Done
> Remove  the fact  that debian/rules  is a  sample file.  Why do  you set
> .NOTPARALLEL?
Done; .NOTPARALLEL was for dpatch so i removed it


signature.asc
Description: Ceci est une partie de message	numériquement signée