Re: RFS: harvestman web crawler - needs updation!

2006-08-10 Thread Piotr Ozarowski
Kumar Appaiah ([EMAIL PROTECTED]):
> Piotr Ozarowski  gmail.com> writes:
> > * You've missed binary-arch rule in debian/rules (see lintian info)
> 
> I don't think it's necessary for Arch-Indep packages, lintian doesn't complain
> on my system.

$ lintian --version
Lintian v1.23.22
$ lintian ../harvestman_1.4.6-3.dsc
E: harvestman source: debian-rules-missing-required-target binary-arch

build-arch is not optional, but since it's not needed in your package,
just add an empty rule.

> > * why are you using `find -name file | chmod 755` (and similar)? 
> >   Isn't `chmod 755 file` not good enough?
> 
> Well, since I don't know whether there are subdirectories with more files. 
> Bad,
> but doesn't hurt, does it? :-)

These lines are not needed:

 find ./doc |xargs chmod 644
 find -name 'config.xml' | xargs chmod 644

dh_fixperms will do the job

Line ("install-$(PYTHON)" rule)
 find debian/harvestman -name '*.py[co]' -exec rm -f {} \;
is also not needed, python-central will remove *.py[co] files automatically
(please don't remove the one from clean rule)

> > * no need to use sed in order to change hashbang, pycentral will take
> >   care of it
> 
> Done.

I don't know why, but dh_python didn't set hashbangs correctly (it's not
changing them at all). I will try to investigate it later, for now please use
sed again, sorry.

> Hope things are better now. See http://kumar.travisbsd.org/debpackages

* please update DH_COMPAT var. in debian/rules (you still have "4" there):
  (I recommend using debian/compat file instead, you will not have to export
  DH_COMPAT=5 in order to run dh_* manually without warnings/errors)
* remove debian/harvestman.links file and use dh_link in debian/rules
  (you have hardcoded "python2.4" there)
* dh_installchangelogs, dh_installdocs and dh_installexamples are called twice, 
see
  install-$(PYTHON) and binary-indep rules

BTW: it would be easier (at least for me ;-P) if you could provide direct link
to .dsc file in your mails (I use dget to download all necessary files)

-- 
-=[ Piotr Ozarowski ]=-
-=[ http://www.ozarowski.pl ]=-


pgpuGsAfPLjkU.pgp
Description: PGP signature


Re: Problems using python-support

2006-08-10 Thread Josselin Mouette
Le jeudi 10 août 2006 à 07:09 +0200, Andreas Tille a écrit :
> On Wed, 9 Aug 2006, Josselin Mouette wrote:
> 
> > As Gnumed doesn't ship a .pth file, the .path doesn't need to be
> > updated.
> 
> Well, I did so in 0.1 packages but was unsure whether this might be
> useful with new Python policy.  Would you advise me to continue using
> Gnumed.pth that contained
> 
>   Gnumed
>   Gnumed/pycommon

No, I think it is better without the .pth file, as it would uselessly
pollute the sys.path.
-- 
 .''`.   Josselin Mouette/\./\
: :' :   [EMAIL PROTECTED]
`. `'[EMAIL PROTECTED]
  `-  Debian GNU/Linux -- The power of freedom


signature.asc
Description: Ceci est une partie de message	numériquement signée


Re: RFS: harvestman web crawler - needs updation!

2006-08-10 Thread Kumar Appaiah
Piotr Ozarowski  gmail.com> writes:
> $ lintian --version
> Lintian v1.23.22
> $ lintian ../harvestman_1.4.6-3.dsc
> E: harvestman source: debian-rules-missing-required-target binary-arch

I have added it.

> These lines are not needed:
> 
>  find ./doc |xargs chmod 644
>  find -name 'config.xml' | xargs chmod 644
>
> dh_fixperms will do the job

Removed.

> Line ("install-$(PYTHON)" rule)
>  find debian/harvestman -name '*.py[co]' -exec rm -f {} \;
> is also not needed, python-central will remove *.py[co] files automatically
> (please don't remove the one from clean rule)

Done.

> I don't know why, but dh_python didn't set hashbangs correctly (it's not
> changing them at all). I will try to investigate it later, for now please use
> sed again, sorry.

Done.

> * please update DH_COMPAT var. in debian/rules (you still have "4" there):
>   (I recommend using debian/compat file instead, you will not have to export
>   DH_COMPAT=5 in order to run dh_* manually without warnings/errors)

Done.

> * remove debian/harvestman.links file and use dh_link in debian/rules
>   (you have hardcoded "python2.4" there)

Sorry, missed that! Set it right now.

> * dh_installchangelogs, dh_installdocs and dh_installexamples are called
twice, see
>   install-$(PYTHON) and binary-indep rules

They are now run only once.

> BTW: it would be easier (at least for me ;-P) if you could provide direct link
> to .dsc file in your mails (I use dget to download all necessary files)

Done.
http://kumar.travisbsd.org/debpackages/harvestman_1.4.6-3.dsc

And many thanks for your patient response. The rules file looks a lot better 
now!

Please get back to me for corrections.

Kumar





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]