On Tue, May 25, 2010 at 1:05 PM, Angel Guzman Maeso wrote:
> I upload again the
> package http://mentors.debian.net/debian/pool/main/t/tivion/
I'm unable to unpack it:
$ dpkg-source -x tivion_0.0.4-3.dsc
gpgv: Signature made Tue 25 May 2010 14:14:27 WST using DSA key ID 1DEEE63E
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./tivion_0.0.4-3.dsc
dpkg-source: error: File ./tivion_0.0.4.orig.tar.gz has size 469524
instead of expected 469607
After fixing the .dsc and unpacking it, here is a review:
debian/dirs shouldn't be needed since the upstream build/install
system should create them.
Please move the manual page upstream and have setup.py install it. The
comments in it can probably be removed too.
debian/rules has a lot of useless comments in it. Also the
configure/configure-stamp targets do nothing, you can remove them.
This line can be removed too: echo "* Cleaning from debian/rules".
Do you really need debian/patches/debian-changes-0.0.4-3/setup2.py?
Why not just make the upstream setup.py work?
The Homepage should be in the Source section of debian/control. It
should not point at your homepage, but the homepage of the software
http://shakaran.net/blog/tivion/. In addition it would be nice if that
were in English.
The package contains no C code, you probably meant Architecture: all
rather than any.
Why do you need debian/source/include-binaries? Normally
images/translations are part of the upstream orig.tar.gz tarball and
don't need to be included in the debian.tar.gz.
debian/docs is empty, please remove it.
debian/README.Debian contains some things you can remove (first 3
paragraphs) and the last paragraph belongs in the upstream README. So
you can remove debian/README.Debian.
Your package does not contain a watch file, please read the uscan manual page.
Upstream AUTHORS file doesn't need to be installed in the Debian
binary package since debian/copyright covers that info.
The upstream changelog and the Debian one are identical, they should
be different.
src/countries.py should be replaced by depending on and using iso-codes.
The manual page needs some things removing:
(TODO)
The programs are documented fully by The Rise and Fall of a Fooish
Bar, available via the Info system.
You install the .po files into the binary package but you should only
install the .mo files.
desktop file warning:
# desktop-file-validate debian/tivion/usr/share/applications/tivion.desktop
debian/tivion/usr/share/applications/tivion.desktop: error: value
"0.0.1" for key "Version" in group "Desktop Entry" is not a known
version
The desktop file should not use an absolute path to the icon, instead
install the icon into the icons/pixmaps directories as per the
relevant freedesktop standards and refer to it by its name without the
extension.
dpkg-gencontrol warnings:
dpkg-gencontrol: warning: Depends field of package tivion: unknown
substitution variable ${shlibs:Depends}
dpkg-gencontrol: warning: Depends field of package tivion: unknown
substitution variable ${python:Depends}
dpkg-gencontrol: warning: package tivion: unknown substitution
variable ${python:Versions}
dpkg-source warnings:
dpkg-source: warning: file tivion-0.0.4/src/countries.py has no final
newline (either original or modified version)
dpkg-source: warning: ignoring deletion of directory debian/tivion-0.0.4
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/THANKS
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/MANIFEST.in
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/setup2.py
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/setup.py
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/AUTHORS
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/LICENSE
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/TODO
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/COPYING
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/MANIFEST
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/README
dpkg-source: warning: ignoring deletion of directory debian/tivion-0.0.4/debian
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/debian/dirs
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/copyright
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/tivion.1
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/debian/rules
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/manpages
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/compat
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/control
dpkg-source: warning: ignoring deletion of file debian/tivion-0.0.4/debian/docs
dpkg-source: warning: ignoring deletion of file
debian/tivion-0.0.4/debian/README.Debian
dpkg-source: wa
