Request for review -- radiant
Hi, radiant upgrade from buster seems to have a broken symlink as reported in #985523. I tried fixing this with hints from previous scripts, and taking a look at dpkg's maintscripts manpage. However, I'm not sure if these fixes are right. Please consider to review and upload, or give me a green signal so I do so. My commits are pushed to salsa Thanks, Nilesh
Autopkgtest for Changeo
Hi, I have added autopkgtests for Changeo. Please review. 1. https://salsa.debian.org/med-team/changeo Best, Shruti ᐧ
Re: Autopkgtest for Changeo
On Fri, Mar 19, 2021 at 09:53:27PM +0530, Shruti Sridhar wrote: > Hi, > > I have added autopkgtests for Changeo. Please review. The size of the autopkgtest data is 1.3M, which is a bit too much and blows out of proportion with the size of the original package. Please embed the data instead, refer this part of med-team policy here[1] [1]: https://med-team.pages.debian.net/policy/#embedding-large-test-data Nilesh
Re: Request for review -- radiant
Hi Nilesh, Nilesh Patra, on 2021-03-19 21:15:35 +0530: > radiant upgrade from buster seems to have a broken symlink as reported > in #985523. I tried fixing this with hints from previous scripts, and > taking a look at dpkg's maintscripts manpage. > > However, I'm not sure if these fixes are right. Please consider to > review and upload, or give me a green signal so I do so. > My commits are pushed to salsa I had a look, and apparently, the bug is caused by a case mismatch between the target of the link and it's actual file name: $ ls -l ktImportMETAREP-blast ktImportMETAREP-blast -> ../share/perl5/KronaTools/scripts/ImportMETAREP-blast.pl ~ vs: $ ls ../share/perl5/KronaTools/scripts [...] ImportMETAREP-BLAST.pl ~ [...] I have not checked further to see what is causing this exactly, maybe something in the debian/install.pl if I trust grep. I hope this helps. -- Étienne Mollier Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. signature.asc Description: PGP signature
Re: Request for review -- radiant
Hi, On Fri, 19 Mar 2021 at 23:07, Étienne Mollier wrote: > Hi Nilesh, > > Nilesh Patra, on 2021-03-19 21:15:35 +0530: > > radiant upgrade from buster seems to have a broken symlink as reported > > in #985523. I tried fixing this with hints from previous scripts, and > > taking a look at dpkg's maintscripts manpage. > > > > However, I'm not sure if these fixes are right. Please consider to > > review and upload, or give me a green signal so I do so. > > My commits are pushed to salsa > > I had a look, and apparently, the bug is caused by a case > mismatch between the target of the link and it's actual file > name: > Could you confirm once if $sudo piuparts -a -d buster -d bullseye -d sid radiant --existing-chroot=/srv/chroot/buster-amd64-sbuild is the right way to reproduce the bug? This one goes OK for me. $ ls -l ktImportMETAREP-blast > ktImportMETAREP-blast -> > ../share/perl5/KronaTools/scripts/ImportMETAREP-blast.pl > >~ > vs: > $ ls ../share/perl5/KronaTools/scripts > [...] > ImportMETAREP-BLAST.pl > ~ > [...] > > I have not checked further to see what is causing this exactly, > maybe something in the debian/install.pl if I trust grep. > Alright, thanks! Probably fixing the case will fix this bug, then. Nilesh
Re: Request for review -- radiant
Nilesh Patra, on 2021-03-19 23:19:40 +0530: > On Fri, 19 Mar 2021 at 23:07, Étienne Mollier > wrote: > > Nilesh Patra, on 2021-03-19 21:15:35 +0530: > > > radiant upgrade from buster seems to have a broken symlink as reported > > > in #985523. I tried fixing this with hints from previous scripts, and > > > taking a look at dpkg's maintscripts manpage. > > > > > > However, I'm not sure if these fixes are right. Please consider to > > > review and upload, or give me a green signal so I do so. > > > My commits are pushed to salsa > > > > I had a look, and apparently, the bug is caused by a case > > mismatch between the target of the link and it's actual file > > name: > > Could you confirm once if $sudo piuparts -a -d buster -d bullseye -d sid > radiant --existing-chroot=/srv/chroot/buster-amd64-sbuild > is the right way to reproduce the bug? This one goes OK for me. Already discussed rapidly on the chat, but for people following on the mailing list: this particular test is different from the previous bug reports. The key option to reproduce this is the flag "--fail-on-broken-symlinks", which is not set by default: $ sudo piuparts \ --fail-on-broken-symlinks \ --warn-on-leftovers-after-purge \ radiant_2.7.1+dfsg-3_amd64.changes If that helps, I noticed Andreas attaches the full piuparts log to the bug reports, which includes the full piuparts command line called (which I must admit has additionally a lot of various cruft, so I agree it may not the be the easiest to read.) Cheers, :) -- Étienne Mollier Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. signature.asc Description: PGP signature
Re: Request for review -- radiant
Étienne Mollier, on 2021-03-19 19:10:08 +0100: > Already discussed rapidly on the chat, but for people following > on the mailing list: this particular test is different from the > previous bug reports. The key option to reproduce this is the > flag "--fail-on-broken-symlinks", which is not set by default: > > $ sudo piuparts \ > --fail-on-broken-symlinks \ > --warn-on-leftovers-after-purge \ --no-upgrade-test \ > radiant_2.7.1+dfsg-3_amd64.changes Quick addition before somone else looses time on it, don't forget the --no-upgrade-test for this kind of check, otherwise piuparts would choke on the previous package version's broken symlinks. Kind Regards, -- Étienne Mollier Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. signature.asc Description: PGP signature
[RFS] odin 2.0.4-2 (closes: #985508)
Greetings, I pushed a change to odin 2.0.4-2 on Salsa[1] in order to address the bug #985508). The debdiff against the previous version in Bullseye is in attachment, changes merely consist in adding a few missing dependencies to restore broken symlinks. [1] https://salsa.debian.org/med-team/odin Please consider review and sponsor or dm grants at your convenience. The package has no autopkgtest, so I will fill the required unblock request to the attention of the release team. Kind Regards, -- Étienne Mollier Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. signature.asc Description: PGP signature
Re: [RFS] odin 2.0.4-2 (closes: #985508)
On Sat, 20 Mar 2021 at 01:51, Étienne Mollier wrote: > > Please consider review and sponsor or dm grants at your > convenience. The package has no autopkgtest, so I will fill the > required unblock request to the attention of the release team. > Done. Thanks for your work on this Nilesh
