Re: [RFS] jebl2

2020-10-13 Thread Andreas Tille
Hi Pierre,

On Mon, Oct 12, 2020 at 09:34:04PM +0200, Pierre Gruet wrote:
> I have worked on jebl2 which has a new upstream version.

Ahhh, I did so yesterday evening without actually reading your mail. ;-)
 
> Would you mind either reviewing [0] or giving me DM rights?
> 
> 
> dcut dm --uid "Pierre Gruet" --allow jebl2

I did so now to enable you for the next time. ;-)
In principle I prefer making people work self standing so
I simply should become used to it that you are DM now.

Thanks a lot for your work on this
 
 Andreas.

-- 
http://fam-tille.de



Re: Bug#972004: Assembly code not working for mips64el and ppc64el (Was: Bug#972004: bowtie ftbfs on several release architectures)

2020-10-13 Thread Andreas Tille
Hi Étienne,

On Tue, Oct 13, 2020 at 12:21:40PM +0200, Étienne Mollier wrote:
> Note I ended pushing some changes to the repository after some
> more verifications yesterday.

Thanks a lot.
 
> Andreas Tille, on 2020-10-13 09:06:52 +0200:
> > H, may be I should remove third_party/cpuid.h in general?
> > Given its copyright informazion is
> > Copyright (C) 2007, 2008, 2009 Free Software Foundation, Inc.
> > that seems to be a pretty old copy of this file.
> 
> I can confirm excluding third_party/cpuid.h does the job.

OK.  Please note just mentioning it in Files-Excluded is not
sufficient.  I recreated the tarball and uploaded.  I also
opened an issue upstream[1] according to this.

 
> The diff below shows what I pushed to salsa yesterday; it is a
> bit different from my statement in my email, as I filter out
> x86_64 for setting POPCNT_CAPABILITY=0 instead of listing
> architectures that do not have this available

That's perfectly sensible - no idea why I made it that complicated.

Kind regards

 Andreas.

[1] https://github.com/BenLangmead/bowtie/issues/117

-- 
http://fam-tille.de



Re: [RFS] jebl2

2020-10-13 Thread Pierre Gruet
Hi Andreas,

Le 13/10/2020 à 09:40, Andreas Tille a écrit :
> Hi Pierre,
> 
> On Mon, Oct 12, 2020 at 09:34:04PM +0200, Pierre Gruet wrote:
>> I have worked on jebl2 which has a new upstream version.
> 
> Ahhh, I did so yesterday evening without actually reading your mail. ;-)
>

No problem, really :)

>  
>> Would you mind either reviewing [0] or giving me DM rights?
>>
>>
>> dcut dm --uid "Pierre Gruet" --allow jebl2
> 
> I did so now to enable you for the next time. ;-)
> In principle I prefer making people work self standing so
> I simply should become used to it that you are DM now.
>

Thanks for the upload and for allowing me to do further uploads. And
once again, this is not really a problem as the package got sent, which
is the essential thing!

> 
> Thanks a lot for your work on this
>  
>  Andreas.
> 

All the very best,
Pierre



Re: Bug#972004: Assembly code not working for mips64el and ppc64el (Was: Bug#972004: bowtie ftbfs on several release architectures)

2020-10-13 Thread Étienne Mollier
Hi Andreas,

Andreas Tille, on 2020-10-13 14:06:03 +0200:
> On Tue, Oct 13, 2020 at 12:21:40PM +0200, Étienne Mollier wrote:
> > I can confirm excluding third_party/cpuid.h does the job.
> 
> OK.  Please note just mentioning it in Files-Excluded is not
> sufficient.  I recreated the tarball and uploaded.  I also
> opened an issue upstream[1] according to this.

Thanks for the notice, that makes sense.  Lintian showed a big
red error about file excluded in source, I probably would have
pushed a bit further if it were not that late in the evening.
I just had a look to your commit to learn how this was done, I
see removing the file from the upstream branch does the job.
Thanks also for the forward upstream!

> > The diff below shows what I pushed to salsa yesterday; it is a
> > bit different from my statement in my email, as I filter out
> > x86_64 for setting POPCNT_CAPABILITY=0 instead of listing
> > architectures that do not have this available
> 
> That's perfectly sensible - no idea why I made it that complicated.

No problem, I believe working mainly with patches tends to skew
a bit our own way of writing code: the smaller the diff, the
better, except it may not be the simpler approach.  Anyway, glad
to have been of help.

Kind Regards,
-- 
Étienne Mollier 
Old rsa/3072: 5ab1 4edf 63bb ccff 8b54  2fa9 59da 56fe fff3 882d
New rsa/4096: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/2, please excuse my verbosity.


signature.asc
Description: PGP signature


Re: Bug#972004: Assembly code not working for mips64el and ppc64el (Was: Bug#972004: bowtie ftbfs on several release architectures)

2020-10-13 Thread Andreas Tille
Hi Étienne,

On Tue, Oct 13, 2020 at 07:22:05PM +0200, Étienne Mollier wrote:
> I just had a look to your commit to learn how this was done, I
> see removing the file from the upstream branch does the job.
> Thanks also for the forward upstream!

I think the commit does not tell the whole story.  What I really
did was

uscan --verbose --force-download
mv bowtie*dfsg.orig.tar.gz bowtie*dfsg1.orig.tar.gz
gbp import-orig --pristine-tar --no-interactive bowtie*dfsg1.orig.tar.gz
 
Kind regards

 ANdreas-

-- 
http://fam-tille.de



Re: Bug#972004: Assembly code not working for mips64el and ppc64el (Was: Bug#972004: bowtie ftbfs on several release architectures)

2020-10-13 Thread Étienne Mollier
Hi Andreas,

Andreas Tille, on 2020-10-13 21:02:11 +0200:
> On Tue, Oct 13, 2020 at 07:22:05PM +0200, Étienne Mollier wrote:
> > I just had a look to your commit to learn how this was done, I
> > see removing the file from the upstream branch does the job.
> > Thanks also for the forward upstream!
> 
> I think the commit does not tell the whole story.  What I really
> did was
> 
> uscan --verbose --force-download
> mv bowtie*dfsg.orig.tar.gz bowtie*dfsg1.orig.tar.gz
> gbp import-orig --pristine-tar --no-interactive bowtie*dfsg1.orig.tar.gz

This will be most useful for the next time a similar situation
reoccurs.  Many Thanks for pointing this out.

Kind Regards,
-- 
Étienne Mollier 
Old rsa/3072: 5ab1 4edf 63bb ccff 8b54  2fa9 59da 56fe fff3 882d
New rsa/4096: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/2, please excuse my verbosity.


signature.asc
Description: PGP signature