Re: [MoM] dwv

2015-03-15 Thread Yves
Ok, I had not checked sid! I updated the plugin so that it finds the header
on the machine or downloads it, the same way Sébastien does in his
orthanc-webviewer plugin. I removed the dependency on other Orthanc code.
This is now published in version 0.3.1 (
https://github.com/ivmartel/dwv-orthanc-plugin/releases/tag/v0.3.1).

I tried following the steps to update the code described in:
https://www.debian.org/doc/manuals/maint-guide/update.en.html#newupstream
but couldn’t succeed, uupdate failing because it did not find files. Are
these steps for already published packages? Should I try to follow them or
is a manual copy ok?

In the meantime, I modified the code manually and tried to 'debuild' it. It
builds ok but I now run into lintian errors about the javascript code:
'source is missing'! Do I need to beautify it?

Thanks!

On 14 March 2015 at 16:30, Sébastien Jodogne 
wrote:

> > Just that I can't find the OrthancCPlugin.h . The apt-file does not
> > list it in any package and after installing liborthancclient-dev it
> > is not in the /usr/include/orthanc.
>
> It is well present in the current Sid package:
> https://packages.debian.org/sid/amd64/liborthancclient-dev/filelist
>
> If you are creating a new package, you must use the Sid version of Debian.
>
> > The code also needs the OrthancException.h and Laaw (from the
> > generated resource c++ file).
>
> You should either adapt your upstream code to be independent of the
> Orthanc core, or copy the required files from Orthanc into your upstream
> code (paying attention to the d/copyright, of course).
>
> > And another question, is there a variable I can use to access package
> > include files (instead of ' /usr/include/orthanc')?
>
> You could create a Debian patch to replace your upstream code:
>
> #include 
>
> By:
>
> #include 
>
> HTH,
> Sébastien-
>
>
> --
> To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact
> listmas...@lists.debian.org
> Archive:
> https://lists.debian.org/1957157.2191552.1426347045391.javamail.r...@chu.ulg.ac.be
>
>


Re: [MoM] dwv

2015-03-15 Thread Andreas Tille
Hi Yves,

On Sun, Mar 15, 2015 at 08:02:04PM +0100, Yves wrote:
> I tried following the steps to update the code described in:
> https://www.debian.org/doc/manuals/maint-guide/update.en.html#newupstream
> but couldn’t succeed, uupdate failing because it did not find files.

What exactly failed and what error message did you got?

I did

uscan --verbose
git import-orig --pristine-tar ../dwv-orthanc-plugin_0.3.1.orig.tar.gz
git push --all
git push --tags

This went fine.

> Are
> these steps for already published packages? Should I try to follow them or
> is a manual copy ok?

What exactly have you done?  After the steps some

dch

and than edit the version manually should do the job.

> In the meantime, I modified the code manually and tried to 'debuild' it. It

While debuild is OK a pdebuild using a recent unstable chroot should be
the method of choice.  You should follow the Debian Med policy to setup
git-buildpackage to use pbuilder.

> builds ok but I now run into lintian errors about the javascript code:
> 'source is missing'! Do I need to beautify it?

In Debian minimized JavaScript files are considered as "binary without
source".  I think the orthanc package provides examples how to deal with
this.
 
Hope this helps - feel free to ask for more details

 Andreas.

-- 
http://fam-tille.de


-- 
To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150315193051.ge15...@an3as.eu



Re: [MoM] dwv

2015-03-15 Thread Yves
Thanks Andreas, I was on the wrong path! I was trying things that were not
appropriate.
I updated to your changes, updated the changelog, added a gbp.conf and a
git-pbuilder script as per Med Policy.

Now, this is what I get when I run 'git-buildpackage':

W: /home/yves/.pbuilderrc does not exist
I: using cowbuilder as pbuilder
dpkg-buildpackage: source package dwv-orthanc-plugin
dpkg-buildpackage: source version 0.3.1-1
dpkg-buildpackage: source distribution UNRELEASED
dpkg-buildpackage: source changed by Yves 
 dpkg-source -i.git -I.git --before-build dwv-orthanc-plugin
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
   dh_clean
 dpkg-source -i.git -I.git -b dwv-orthanc-plugin
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building dwv-orthanc-plugin using existing
./dwv-orthanc-plugin_0.3.1.orig.tar.gz
dpkg-source: info: building dwv-orthanc-plugin in
dwv-orthanc-plugin_0.3.1-1.debian.tar.gz
dpkg-source: info: building dwv-orthanc-plugin in
dwv-orthanc-plugin_0.3.1-1.dsc
 dpkg-genchanges -S >../dwv-orthanc-plugin_0.3.1-1_source.changes
dpkg-genchanges: including full source code in upload
 dpkg-source -i.git -I.git --after-build dwv-orthanc-plugin
dpkg-buildpackage: full upload (original source is included)
 -> Copying COW directory
  forking: rm -rf /var/cache/pbuilder/build//cow.23658
  forking: cp -al /var/cache/pbuilder/base.cow
/var/cache/pbuilder/build//cow.23658
cp: cannot stat '/var/cache/pbuilder/base.cow': No such file or directory
Failed cowcopy.
gbp:error: Couldn't run '~/bin/git-pbuilder': ~/bin/git-pbuilder returned 1

I hope I did not skip a policy again!
Best

On 15 March 2015 at 20:30, Andreas Tille  wrote:

> Hi Yves,
>
> On Sun, Mar 15, 2015 at 08:02:04PM +0100, Yves wrote:
> > I tried following the steps to update the code described in:
> >
> https://www.debian.org/doc/manuals/maint-guide/update.en.html#newupstream
> > but couldn’t succeed, uupdate failing because it did not find files.
>
> What exactly failed and what error message did you got?
>
> I did
>
> uscan --verbose
> git import-orig --pristine-tar ../dwv-orthanc-plugin_0.3.1.orig.tar.gz
> git push --all
> git push --tags
>
> This went fine.
>
> > Are
> > these steps for already published packages? Should I try to follow them
> or
> > is a manual copy ok?
>
> What exactly have you done?  After the steps some
>
> dch
>
> and than edit the version manually should do the job.
>
> > In the meantime, I modified the code manually and tried to 'debuild' it.
> It
>
> While debuild is OK a pdebuild using a recent unstable chroot should be
> the method of choice.  You should follow the Debian Med policy to setup
> git-buildpackage to use pbuilder.
>
> > builds ok but I now run into lintian errors about the javascript code:
> > 'source is missing'! Do I need to beautify it?
>
> In Debian minimized JavaScript files are considered as "binary without
> source".  I think the orthanc package provides examples how to deal with
> this.
>
> Hope this helps - feel free to ask for more details
>
>  Andreas.
>
> --
> http://fam-tille.de
>
>
> --
> To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact
> listmas...@lists.debian.org
> Archive: https://lists.debian.org/20150315193051.ge15...@an3as.eu
>
>