Re: [MoM] Debian Med MoM for February
Hi Sukhbir, thanks for working on this package. On Fri, Feb 08, 2013 at 06:27:23PM -0500, Sukhbir Singh wrote: > Hi, > > I just started packaging hunspell-en-med and the repository for the > packaging is at: > > > http://anonscm.debian.org/gitweb/?p=debian-med/hunspell-en-med.git;a=summary Looks OK so far. > When trying to build the package, I get this error: > > dpkg-source: info: local changes detected, the modified files are: > hunspell-en-med/README_en_MED.txt > hunspell-en-med/en_MED.dic > dpkg-source: info: you can integrate the local changes with dpkg-source > --commit Hmmm, the upstream files in the master branch are different from the pristine-tar files - for whatever reason. To fix this very issue I commited the files from upstream source right into master and now git-buildpackage works nicely. I have no idea why this happened but now the package works. > As a workaround, I created a `debian/install' and a `doc' file, You surely might need d/install and d/doc files - but this is totally unrelated to your problem above. > moved > the above two files (.dic and .txt) to `debian/', updated the paths, and > the problem is solved. Hmm, can not see that this was done in the Git repository (and it is not needed anyway.) > However, I think this is an incorrect way to do > it, since the files should be in the root directory and not in `debian'. > > What am I doing wrong here? What is the right way to copy (install) > these files? In any case you need to make sure that everything in master is identical to the upstream source (except the additional debian/ dir.) This is what dpkg-source is checking and it breaks if not fullfilled. The builded *.deb has some lintian warnings I did not dived into - feel free to ask if something remains unclear. Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130209174336.gc13...@an3as.eu
Re: [MoM] Debian Med MoM for February
Hi Andreas, Andreas Tille wrote: > Hmmm, the upstream files in the master branch are different from the > pristine-tar files - for whatever reason. To fix this very issue I > commited the files from upstream source right into master and now > git-buildpackage works nicely. I have no idea why this happened but > now the package works. I think we now know why this problem was there. The issue is with line endings: $ file README_en_MED.txt README_en_MED.txt: ASCII English text, with CRLF line terminators In my .gitconfig, I had `autocrlf = input', and this was changing the line terminator on commit which resulted in the committed files being different from the pristine-tar. > In any case you need to make sure that everything in master is identical > to the upstream source (except the additional debian/ dir.) This is > what dpkg-source is checking and it breaks if not fullfilled. So in the pristine-tar (and now the commit), the line endings are CRLF. I think a better idea would be to convert them to LF in the pristine-tar also and then commit. Correct? > The builded *.deb has some lintian warnings I did not dived into - feel > free to ask if something remains unclear. $ lintian hunspell-en-med_1-1_all.deb W: hunspell-en-med: new-package-should-close-itp-bug W: hunspell-en-med: wrong-bug-number-in-closes l3:# This is related to the ITP, so nothing to worry :) -- Sukhbir -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130209184150.ga4...@gmail.com
Re: [MoM] Debian Med MoM for February
Hi Sukhbir, On Sat, Feb 09, 2013 at 01:41:50PM -0500, Sukhbir Singh wrote: > I think we now know why this problem was there. The issue is with line > endings: > > $ file README_en_MED.txt > README_en_MED.txt: ASCII English text, with CRLF line terminators > > In my .gitconfig, I had `autocrlf = input', and this was changing the > line terminator on commit which resulted in the committed files being > different from the pristine-tar. Uhmm, I would think that there should be no options in .gitconfig that will potentially change some upstream files without notification. > > In any case you need to make sure that everything in master is identical > > to the upstream source (except the additional debian/ dir.) This is > > what dpkg-source is checking and it breaks if not fullfilled. > > So in the pristine-tar (and now the commit), the line endings are CRLF. I do not see any problem in this. > I think a better idea would be to convert them to LF in the pristine-tar > also and then commit. Correct? I think leaving the pristine-tar as is is the proper way to go or do you see any harm in using the upstream files as they are. > > The builded *.deb has some lintian warnings I did not dived into - feel > > free to ask if something remains unclear. > > $ lintian hunspell-en-med_1-1_all.deb > W: hunspell-en-med: new-package-should-close-itp-bug > W: hunspell-en-med: wrong-bug-number-in-closes l3:# > > This is related to the ITP, so nothing to worry :) Perhaps it is the fact that I'm using lintian from unstable, but I get some more: $ lintian hunspell-en-med_1-1_amd64.changes W: hunspell-en-med source: debhelper-but-no-misc-depends hunspell-en-med W: hunspell-en-med source: package-needs-versioned-debhelper-build-depends 8 W: hunspell-en-med source: ancient-standards-version 3.8.4 (current is 3.9.4) I: hunspell-en-med source: debian-watch-file-is-missing P: hunspell-en-med: no-upstream-changelog W: hunspell-en-med: wrong-bug-number-in-closes l3:# W: hunspell-en-med: new-package-should-close-itp-bug E: hunspell-en-med: helper-templates-in-copyright I: hunspell-en-med: extended-description-is-probably-too-short Please try: sudo apt-get -t unstable install lintian lintian -i -I hunspell-en-med_1-1_amd64.changes Kind regards Andreas. -- http://fam-tille.de -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130209214716.gb8...@an3as.eu
Re: [MoM] Debian Med MoM for February
Hi Andreas, I updated the package and made some changes. $ lintian hunspell-en-med_1-1_amd64.changes W: hunspell-en-med: wrong-bug-number-in-closes l3:# W: hunspell-en-med: new-package-should-close-itp-bug Please have a look. -- Sukhbir -- To UNSUBSCRIBE, email to debian-med-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130210063453.ga19...@gmail.com
