Re: Help needed: Bug#973070: libsis-base-java: FTBFS: Could not delete the directory targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests because: 1 exceptions: [java.io.IOException: Unable to de

2020-10-28 Thread Andreas Tille
Hi,

On Tue, Oct 27, 2020 at 10:55:43PM +0100, Markus Koschany wrote:
> This appears to be caused by the recent upgrade of Apache commons-io to
> version 2.8.0 (we had 2.6), see also #973135. In version 2.7 they
> removed a throws IOException in the method isSymlink()
> 
> https://issues.apache.org/jira/browse/IO-610
> 
> Could it be related to this change? It is probably necessary to update
> the testcase or disable it for a quick workaround.

I tried to implement this workaroung in this patch

   
https://salsa.debian.org/med-team/libsis-base-java/-/blob/master/debian/patches/skip_testGetLinkInfoSymLinkDanglingLink.patch

but unfortunately the test is executed anyway:

...
Running testTouchSymLinkAndFile
Running testGetLinkInfoSymLinkDanglingLink
Running testGetLinkInfoNonExistent
Could not delete the directory 
targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests because: 1 
exceptions: [java.io.IOException: Unable to delete file: 
targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
Could not delete the directory 
targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests in second try 
because: 1 exceptions: [java.io.IOException: Unable to delete file: 
targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
Exception in thread "main" org.apache.commons.io.IOExceptionList: 1 exceptions: 
[java.io.IOException: Unable to delete file: 
targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
...


Am I missing something?

Kind regards

   Andreas.

-- 
http://fam-tille.de



Re: [Debian-med-packaging] Bug#973070: Help needed: Bug#973070: libsis-base-java: FTBFS: Could not delete the directory targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests because: 1 exceptions:

2020-10-28 Thread olivier sallou
On Wed, 2020-10-28 at 09:05 +0100, Andreas Tille wrote:
> Hi,
> 
> On Tue, Oct 27, 2020 at 10:55:43PM +0100, Markus Koschany wrote:
> > This appears to be caused by the recent upgrade of Apache commons-
> > io to
> > version 2.8.0 (we had 2.6), see also #973135. In version 2.7 they
> > removed a throws IOException in the method isSymlink()
> > 
> > https://issues.apache.org/jira/browse/IO-610
> > 
> > Could it be related to this change? It is probably necessary to
> > update
> > the testcase or disable it for a quick workaround.
> 
> I tried to implement this workaroung in this patch
> 
>
> https://salsa.debian.org/med-team/libsis-base-java/-/blob/master/debian/patches/skip_testGetLinkInfoSymLinkDanglingLink.patch
> 
> but unfortunately the test is executed anyway:
*dumb* patch would be to simply remove those tests from code...
> 
> ...
> Running testTouchSymLinkAndFile
> Running testGetLinkInfoSymLinkDanglingLink
> Running testGetLinkInfoNonExistent
> Could not delete the directory targets/unit-test-
> wd/ch.systemsx.cisd.base.unix.UnixTests because: 1 exceptions:
> [java.io.IOException: Unable to delete file: targets/unit-test-
> wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
> Could not delete the directory targets/unit-test-
> wd/ch.systemsx.cisd.base.unix.UnixTests in second try because: 1
> exceptions: [java.io.IOException: Unable to delete file:
> targets/unit-test-
> wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
> Exception in thread "main" org.apache.commons.io.IOExceptionList: 1
> exceptions: [java.io.IOException: Unable to delete file:
> targets/unit-test-
> wd/ch.systemsx.cisd.base.unix.UnixTests/someDanglingLink]
> ...
> 
> 
> Am I missing something?
> 
> Kind regards
> 
>Andreas.
> 
-- 
Olivier Sallou
Univ Rennes, Inria, CNRS, IRISA
Irisa, Campus de Beaulieu
F-35042 RENNES - FRANCE
Tel: 02.99.84.71.95

gpg key id: 4096R/326D8438  (keyring.debian.org)
Key fingerprint = 5FB4 6F83 D3B9 5204 6335  D26D 78DC 68DB 326D 8438



Re: [Debian-med-packaging] Bug#973070: Help needed: Bug#973070: libsis-base-java: FTBFS: Could not delete the directory targets/unit-test-wd/ch.systemsx.cisd.base.unix.UnixTests because: 1 exceptions:

2020-10-28 Thread Markus Koschany


Am 28.10.20 um 16:01 schrieb olivier sallou:
[...]
> *dumb* patch would be to simply remove those tests from code...

Either this or you can keep the override for dh_auto_test-arch empty.

The test creates a broken symlink but then FileUtils.deleteDirectory
fails to delete the file, obviously because it is not a directory but
I'm not sure how it really handles symlinks within directories. See also
[1]. Probably upstream should switch to the java.nio.file API (they
still use java.io.File), test for the existence of symlinks and then try
File.delete instead of FileUtils.deleteDirectory first. Not tested, just
a guess.

Markus


[1] https://issues.apache.org/jira/browse/IO-576



signature.asc
Description: OpenPGP digital signature