Re: Tomcat 8 transition complete
On Sat, 5 Nov 2016, Emmanuel Bourg wrote: > I'm pleased to announce that the transition to Tomcat 8 is now complete. > The tomcat7 source package still exists but builds only the Servlet API > 3.0. This version of the Servlet API is no longer used in sid, but I Unfortunately, the new version of guacamole I’ve been working with Natureshadow on (with my Teckids hat worn) requires the websocket API from libtomcat7-java. I don’t know enough to comment on this (I just barely made the package compile), so I’d welcome someone from the Java team looking at both upstream code and packaging of… Vcs-Git: https://anonscm.debian.org/git/debian-edu/pkg-team/guacamole-client.git … and help us with that, so the new guacamole can hopefully land in stretch. Thanks, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Re: Tomcat 8 transition complete
Le 6/11/2016 à 23:35, Thorsten Glaser a écrit : > Unfortunately, the new version of guacamole I’ve been working > with Natureshadow on (with my Teckids hat worn) requires the > websocket API from libtomcat7-java. > > I don’t know enough to comment on this (I just barely made the > package compile), so I’d welcome someone from the Java team > looking at both upstream code and packaging of… > > Vcs-Git: > https://anonscm.debian.org/git/debian-edu/pkg-team/guacamole-client.git > > … and help us with that, so the new guacamole can hopefully land > in stretch. I got a quick look, you'll have another problem with jetty8 since it has been removed too (it relied on tomcat7). I see that there are 3 websocket implementations, for Jetty 8, Jetty 9 and Tomcat 7. Are the three absolutely needed? Is supporting only Jetty 9 a viable alternative? Emmanuel Bourg
Re: Tomcat 8 transition complete
On Mon, 7 Nov 2016, Emmanuel Bourg wrote: > I see that there are 3 websocket implementations, for Jetty 8, Jetty 9 Yes, that was confusing. > and Tomcat 7. Are the three absolutely needed? Is supporting only Jetty > 9 a viable alternative? AIUI we want to dump it into a Tomcat and be done with it, so that means Tomcat 8. Upstream said that it would work in Tomcat 8 after building it against Tomcat 7 when the Fedora packager complained about similar issues (I already fixed an API change in Jetty). So, I'm still confused. bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Re: Tomcat 8 transition complete
Le 7/11/2016 à 07:47, Thorsten Glaser a écrit :
> AIUI we want to dump it into a Tomcat and be done with it,
> so that means Tomcat 8. Upstream said that it would work
> in Tomcat 8 after building it against Tomcat 7 when the
> Fedora packager complained about similar issues (I already
> fixed an API change in Jetty).
Ok I think I get it. There are actually 4 websocket implementations:
- Jetty 8
- Jetty 9.0.x
- Tomcat 7
- JSR 356
Jetty 9.1 and Tomcat 8 support the standard JSR 356 API, so this means
you can simply ignore the Jetty 8/9 and Tomcat 7 specific code. You can
safely patch guacamole/pom.xml and modify the configuration of the
maven-compiler-plugin to ignore the
org.glyptodon.guacamole.net.basic.websocket.{jetty8,jetty9,tomcat}.*
classes. No other modification is required, the server specific
implementations are loaded dynamically in the TunnelModule class.
Alternatively you may remove the classes from the upstream tarball.
Emmanuel Bourg
