Re: gegl: FTBFS on hurd-i386

2020-02-23 Thread Andreas Henriksson
Hello Samuel,

On Mon, Dec 30, 2019 at 07:29:45PM +0100, Samuel Thibault wrote:
> Source: gegl
> Version: 0.4.18-2
> Severity: important
> Tags: patch
> User: debian-hurd@lists.debian.org
> Usertags: hurd
> 
> Hello,
> 
> gegl currently can't build on hurd-i386 because it build-depends on
> libv4l-any, which is not built on hurd-i386. Could you apply the
> attached patch to fix that?

I uploaded your patch yesterday but apparently the build still fails
(for a reason I don't quite understand) as can be seen in:
https://buildd.debian.org/status/fetch.php?pkg=gegl&arch=hurd-i386&ver=0.4.22-1&stamp=1582423475&raw=0

If I'm not mistaken this is the culprit:

[...]
Run-time dependency libv4l1 found: NO (tried pkgconfig)

meson.build:223:0: ERROR: Dependency "libv4l1" not found, tried
pkgconfig

A full log can be found at
/<>/obj-i686-gnu/meson-logs/meson-log.txt
cd obj-i686-gnu && tail -v -n \+0 meson-logs/meson-log.txt
[...]


In meson_options.txt libv4l has the default value of 'auto'
(and the option is not explicitly specified/overriden in
debian/rules invocation of dh_auto_configure).

According to the 'Features' section at
https://mesonbuild.com/Build-options.html
it is documented that:
>  auto is the same as passing required : false.

... but that doesn't seem to match what we're seeing in
the hurd build log. I'm confused. Either I'm missing something
obvious or some debugging is needed to figure this one out.

Regards,
Andreas Henriksson

PS. Is #892238 still relevant? Maybe it should just be closed now.



Re: gegl: FTBFS on hurd-i386

2020-02-23 Thread Andreas Henriksson
On Sun, Feb 23, 2020 at 10:24:17AM +0100, Andreas Henriksson wrote:
[...]
> In meson_options.txt libv4l has the default value of 'auto'
> (and the option is not explicitly specified/overriden in
> debian/rules invocation of dh_auto_configure).
[...]

The thing I was apparently missing is that debian/rules
specifies this option:
-Dauto_features=enabled
... which is apparently a way to tell meson to globally
change the behaviour of how auto is dealt with.

This was likely added to avoid surprises that could happen
with automatically detected features and mistakenly missed
build-dependencies (eg. when someone updates to a new upstream version
but forgets to bump the minimum required version of a build-dependency
and suddenly the feature is disabled without anyone noticing).

Mystery solved... I'll check something into git (without testing it)
and hopefully next upload will get further on hurd. Please feel free
to test it (and suggest additional fixes). See:
https://salsa.debian.org/gnome-team/gegl/commit/4a655fa5240d0347d16261edab0e9b0b54d2fb0a

Regards,
Andreas Henriksson



Re: gegl: FTBFS on hurd-i386

2020-02-23 Thread Samuel Thibault
Hello,

Andreas Henriksson, le dim. 23 févr. 2020 11:00:13 +0100, a ecrit:
> Mystery solved... I'll check something into git (without testing it)
> and hopefully next upload will get further on hurd. Please feel free
> to test it (and suggest additional fixes). See:
> https://salsa.debian.org/gnome-team/gegl/commit/4a655fa5240d0347d16261edab0e9b0b54d2fb0a

Yes, it fixed it, thanks!

Andreas Henriksson, le dim. 23 févr. 2020 10:24:17 +0100, a ecrit:
> PS. Is #892238 still relevant? Maybe it should just be closed now.

Apparently it is still happening.

Samuel