Bug#945943: exim4: FTBFS on hurd-i386: "operating system GNU is not supported"

2019-12-01 Thread Paul Sonnenschein
Source: exim4
Severity: important
Version: 4.93~RC5-1
User: debian-hurd@lists.debian.org
Usertags: hurd
X-Debbugs-CC: debian-hurd@lists.debian.org

Hello,

exim4 fails to build from source on hurd-i386 with the message:

> *** Sorry - operating system GNU is not supported
> *** See OS/Makefile-* for supported systems

See [1] for the complete build log.

It however builds successfully if the files OS/unsupported/*-GNU are
moved into the directory OS/.

Could you take a look?

Thanks.

[1]: 
https://buildd.debian.org/status/fetch.php?pkg=exim4&arch=hurd-i386&ver=4.93%7ERC5-1&stamp=1574915162&raw=0



Re: Bug#945943: exim4: FTBFS on hurd-i386: "operating system GNU is not supported"

2019-12-01 Thread Samuel Thibault
Paul Sonnenschein, le dim. 01 déc. 2019 13:56:26 +0100, a ecrit:
> It however builds successfully if the files OS/unsupported/*-GNU are
> moved into the directory OS/.

Mmm, but it doesn't seem to be working, I can't send mails any more with
version 4.93~RC5-1 with only that change.

Samuel



Re: Bug#945943: exim4: FTBFS on hurd-i386: "operating system GNU is not supported"

2019-12-01 Thread Samuel Thibault
Samuel Thibault, le dim. 01 déc. 2019 23:37:59 +0100, a ecrit:
> Paul Sonnenschein, le dim. 01 déc. 2019 13:56:26 +0100, a ecrit:
> > It however builds successfully if the files OS/unsupported/*-GNU are
> > moved into the directory OS/.
> 
> Mmm, but it doesn't seem to be working, I can't send mails any more with
> version 4.93~RC5-1 with only that change.

It seems that I have to disable hosts_try_fastopen

Samuel



Re: Bug#945943: exim4: FTBFS on hurd-i386: "operating system GNU is not supported"

2019-12-01 Thread Samuel Thibault
Hello,

Paul Sonnenschein, le dim. 01 déc. 2019 13:56:26 +0100, a ecrit:
> > *** Sorry - operating system GNU is not supported
> > *** See OS/Makefile-* for supported systems
> 
> See [1] for the complete build log.
> 
> It however builds successfully if the files OS/unsupported/*-GNU are
> moved into the directory OS/.
> 
> Could you take a look?

The attached patch is also required, otherwise exim4 will consider using
fastopen, but not actually do it, thus completely failing to connect.
I'll submit upstream once I get my account there confirmed.

Samuel
Index: exim4-4.93~RC5/src/ip.c
===
--- exim4-4.93~RC5.orig/src/ip.c
+++ exim4-4.93~RC5/src/ip.c
@@ -292,8 +292,7 @@ if (fastopen_blob && f.tcp_fastopen_ok)
   debug_printf("Tried TCP Fast Open but apparently not enabled by 
sysctl\n");
 goto legacy_connect;
 }
-# endif
-# ifdef EXIM_TFO_CONNECTX
+# elif defined(EXIM_TFO_CONNECTX)
   /* MacOS */
   sa_endpoints_t ends = {
 .sae_srcif = 0, .sae_srcaddr = NULL, .sae_srcaddrlen = 0,
@@ -326,12 +325,14 @@ if (fastopen_blob && f.tcp_fastopen_ok)
 else   /* assume that no data was queued; block in send */
   rc = send(sock, fastopen_blob->data, fastopen_blob->len, 0);
 }
+# else
+goto legacy_connect;
 # endif
   }
 else
 #endif /*TCP_FASTOPEN*/
   {
-#if defined(TCP_FASTOPEN) && defined(MSG_FASTOPEN)
+#if defined(TCP_FASTOPEN) && (defined(MSG_FASTOPEN) || 
!defined(EXIM_TFO_CONNECTX))
 legacy_connect:
 #endif
 


Re: Bug#945943: exim4: FTBFS on hurd-i386: "operating system GNU is not supported"

2019-12-01 Thread Samuel Thibault
Samuel Thibault, le lun. 02 déc. 2019 01:36:32 +0100, a ecrit:
> The attached patch is also required, otherwise exim4 will consider using
> fastopen, but not actually do it, thus completely failing to connect.
> I'll submit upstream once I get my account there confirmed.

This is now on 

https://bugs.exim.org/show_bug.cgi?id=2475

Samuel