Re: Bug#900718: rsyslog: FTBFS on hurd-i386

2018-11-04 Thread Samuel Thibault
Hello,

Additionally, the attached patch is needed since lsof is non available
on non-linux.

Samuel
--- debian/control.original 2018-11-04 17:45:38.0 +
+++ debian/control  2018-11-04 17:46:03.0 +
@@ -28,7 +28,7 @@
python ,
libfaketime ,
systemd [linux-any] ,
-   lsof ,
+   lsof [linux-any] ,
 Standards-Version: 4.2.1
 Rules-Requires-Root: no
 Vcs-Git: https://salsa.debian.org/debian/rsyslog.git


Re: Bug#900718: rsyslog: FTBFS on hurd-i386

2018-11-04 Thread Samuel Thibault
Hello,

Samuel Thibault, le mar. 12 juin 2018 00:35:15 +0200, a ecrit:
> Michael Biebl, le jeu. 07 juin 2018 13:40:45 +0200, a ecrit:
> > Am 07.06.2018 um 13:37 schrieb Samuel Thibault:
> > > Michael Biebl, le jeu. 07 juin 2018 13:34:48 +0200, a ecrit:
> > >> Anyway, such patches should best be sent upstream.
> > > 
> > > We don't have the manpower to chase all upstream bugtrackers and
> > > whatnot.
> > 
> > Same is true for me. I don't have the man power to keep maintaining
> > distro specific patches which belong upstream or playing bug proxy.
> 
> So, does anybody on debian-hurd have time for upstreaming?

So, can anybody on debian-hurd *please* take some time to have a look at
this?

The more people contribute to this kind of work, the less time I have
to spend on it, the more time I have to spend on more difficult issues
(llvm-toolchain, rustc, php7.3, etc.)

I have attached a refreshed patch.

Samuel
Index: rsyslog-8.34.0/runtime/modules.c
===
--- rsyslog-8.34.0.orig/runtime/modules.c
+++ rsyslog-8.34.0/runtime/modules.c
@@ -51,7 +51,7 @@
 #include 
 #include 
 
-#ifndef PATH_MAX
+#if !defined(PATH_MAX) && defined(MAXPATHLEN)
 #  define PATH_MAX MAXPATHLEN
 #endif
 
Index: rsyslog-8.34.0/plugins/imfile/imfile.c
===
--- rsyslog-8.34.0.orig/plugins/imfile/imfile.c
+++ rsyslog-8.34.0/plugins/imfile/imfile.c
@@ -66,6 +66,10 @@
 
 #include 
 
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
+
 MODULE_TYPE_INPUT
 MODULE_TYPE_NOKEEP
 MODULE_CNFNAME("imfile")


Re: Bug#900718: rsyslog: FTBFS on hurd-i386

2018-11-04 Thread Michael Biebl
Am 04.11.18 um 18:48 schrieb Samuel Thibault:

> Additionally, the attached patch is needed since lsof is non available
> on non-linux.

Is lsof not available at all or just provided by a different package?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Re: Bug#900718: rsyslog: FTBFS on hurd-i386

2018-11-04 Thread Samuel Thibault
Michael Biebl, le dim. 04 nov. 2018 21:55:58 +0100, a ecrit:
> Am 04.11.18 um 18:48 schrieb Samuel Thibault:
> 
> > Additionally, the attached patch is needed since lsof is non available
> > on non-linux.
> 
> Is lsof not available at all or just provided by a different package?

It doesn't seem to be provided by any package on Hurd and kFreeBSD.

Samuel