Re: grpc transition

2024-06-10 Thread Reinhard Tartler
On Mon, Jun 10, 2024 at 2:48 AM Shengjing Zhu  wrote:

>
> >> Though removing src:golang-github-golang-protobuf-1-3 probably will not
> be easy.
> >
> >
> > Can you please elaborate on where you see the difficulties?
> >
>
> Only pb.go files generated by protoc-gen-go-1-3 are compatible with
> gogo protobuf. That's where the protobuf transition stuck...
>

Well, I suppose that means either protoc-gen-go-1-3 or protoc-gen-gogo
(from gogoprotobuf).

Can you please point out examples of packages with "pb.go" files that are
generated with protoc-gen-go-1-3 and then used with gogo protobuf?

I'd like to compile a list to understand the scope of the issue. Maybe
those packages can be isolated in some way, like generating those files
with gogoprotobuf instead? A prominent example for instance are the
kubernetes API packages or etcd, both which still use gogoproto even in
their upstream versions. But, as my recent upload of etcd to experimental
shows [1,2], files generated with gogoprotobuf appear to work with code
that compiles with golang/protobuf@v1.5 and google/protobuf (unless I"m
missing something important again).

[1]
https://tracker.debian.org/news/1536154/accepted-etcd-3430-2-source-into-experimental/
[2]
https://buildd.debian.org/status/fetch.php?pkg=etcd&arch=amd64&ver=3.4.30-2&stamp=1717967211&raw=0

-- 
regards,
Reinhard


Re: grpc transition

2024-06-10 Thread Shengjing Zhu
On Mon, Jun 10, 2024 at 6:45 PM Reinhard Tartler  wrote:
> On Mon, Jun 10, 2024 at 2:48 AM Shengjing Zhu  wrote:
>> >> Though removing src:golang-github-golang-protobuf-1-3 probably will not 
>> >> be easy.
>> >
>> > Can you please elaborate on where you see the difficulties?
>>
>> Only pb.go files generated by protoc-gen-go-1-3 are compatible with
>> gogo protobuf. That's where the protobuf transition stuck...
>
> Well, I suppose that means either protoc-gen-go-1-3 or protoc-gen-gogo (from 
> gogoprotobuf).
>
> Can you please point out examples of packages with "pb.go" files that are 
> generated with protoc-gen-go-1-3 and then used with gogo protobuf?
>

Hmm, I thought you already saw that. You mentioned
https://github.com/containerd/ttrpc/issues/62#issuecomment-686768932
in another thread.
This is caused by using gogo protobuf (at runtime) with pb.go files
(from golang-google-genproto-dev) generated by protoc-gen-go-1-5 (or
newer).

-- 
Shengjing Zhu