Re: salsa CI golang support - golang-github-la5nta-wl2k-go
Dear Go-team, is there anyone with sufficient Salsa-CI access who can to finalize this? Regards, Faustin Lammler , 14/11/2022 – 12:18:34 (+0100): > Hi Thomas! > Did you had time to look into this? > > Faustin Lammler , > 03/11/2022 – 17:13:11 (+0100): > > > Hi Thomas! > > > > Thomas Goirand , > > 02/11/2022 – 16:46:39 (+0100): > > > > > I could, but I lack time, I'd prefer if someone else would do it. > > > > The VM should be ready now. And I took the opportunity to revalidate the > > documentation[1] and the ansible deployment[2]. > > > > > I'm a Salsa admin (and go-team admin), so yeah... I do have enough rights! > > > :) > > > > Can you follow the last steps (from "Register the runner on Salsa")[3], > > I do not have access to the go-team CI/CD settings[4]. > > > > > The instance has 16 cores and 64 GB RAM, with a system disk of 20G, plus a > > > 100 GB volume (unformated, as I didn't know if you wanted XFS or what..). > > > > Formatted with `mkfs.ext4 -m0` and mounted via /etc/fstab (UUID) in > > /srv. Reboot tested. > > > > Once done, you can probably disable the "fauuust-test" runner on salsa > > and verify that the new one is taking new builds. > > > > Don't hesitate to ping me if you need help (I am fauust on > > #debian-golang IRC). > > > > [1]: > > https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/6 > > [2]: https://salsa.debian.org/go-team/infra/provisioning/-/merge_requests/4 > > [3]: https://go-team.pages.debian.net/ci.html > > [4]: https://salsa.debian.org/groups/go-team/-/settings/ci_cd. -- Faustin GPG: F652 BCD1 1AA8 8975 F010 48A5 390A 2F27 832A 5C79 signature.asc Description: PGP signature
Re: Plans for golang-goprotobuf to unstable?
Hi, On Mon, Nov 21, 2022 at 07:33:58AM +, Peymaneh wrote: > An alternative that I consider is vendoring grpc/genproto apiv2 within > golang-github-google-cel-spec-dev so that hopefully caddy can migrate to > bookworm eventually... But that would not help other Go packages with the > facing problem > The problem is if you vendor genproto in a library (-dev package), the Go complier doesn't consume it when build the program. For example, when you build caddy, if the GOPATH has: + src/github.com/google/cel-go + src/github.com/google/cel-go/vendor/google.golang.org/genproto + src/caddyserver/caddy The Go complier doesn't look at src/github.com/google/cel-go/vendor at all. So you need + src/caddyserver/caddy/vendor/google.golang.org/genproto as well. It's bit of unfortunate, but it may work. And it looks like you only need to vendor google.golang.org/genproto/googleapis/api/expr/v1alpha1 Which only consists of 5 files. https://github.com/googleapis/go-genproto/tree/main/googleapis/api/expr/v1alpha1
Re: salsa CI golang support - golang-github-la5nta-wl2k-go
Hello. I have just sent you the registration token for the runner. In the meantime I have disabled the old runner. Cheers, Le lun. 21 nov. 2022 à 09:32, Faustin Lammler a écrit : > > Dear Go-team, > is there anyone with sufficient Salsa-CI access who can to finalize > this? > > Regards, > > Faustin Lammler , > 14/11/2022 – 12:18:34 (+0100): > > > Hi Thomas! > > Did you had time to look into this? > > > > Faustin Lammler , > > 03/11/2022 – 17:13:11 (+0100): > > > > > Hi Thomas! > > > > > > Thomas Goirand , > > > 02/11/2022 – 16:46:39 (+0100): > > > > > > > I could, but I lack time, I'd prefer if someone else would do it. > > > > > > The VM should be ready now. And I took the opportunity to revalidate the > > > documentation[1] and the ansible deployment[2]. > > > > > > > I'm a Salsa admin (and go-team admin), so yeah... I do have enough > > > > rights! > > > > :) > > > > > > Can you follow the last steps (from "Register the runner on Salsa")[3], > > > I do not have access to the go-team CI/CD settings[4]. > > > > > > > The instance has 16 cores and 64 GB RAM, with a system disk of 20G, > > > > plus a > > > > 100 GB volume (unformated, as I didn't know if you wanted XFS or > > > > what..). > > > > > > Formatted with `mkfs.ext4 -m0` and mounted via /etc/fstab (UUID) in > > > /srv. Reboot tested. > > > > > > Once done, you can probably disable the "fauuust-test" runner on salsa > > > and verify that the new one is taking new builds. > > > > > > Don't hesitate to ping me if you need help (I am fauust on > > > #debian-golang IRC). > > > > > > [1]: > > > https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/6 > > > [2]: > > > https://salsa.debian.org/go-team/infra/provisioning/-/merge_requests/4 > > > [3]: https://go-team.pages.debian.net/ci.html > > > [4]: https://salsa.debian.org/groups/go-team/-/settings/ci_cd. > -- > Faustin > GPG: F652 BCD1 1AA8 8975 F010 48A5 390A 2F27 832A 5C79
Re: salsa CI golang support - golang-github-la5nta-wl2k-go
Hi Aloïs! Aloïs Micard , 21/11/2022 – 09:40:47 (+0100): > Hello. I have just sent you the registration token for the runner. Ok, I have configured the token and named the runner "zigo-runner" Can you check that everything looks OK? If not, your keys (from GH) are on the machine: | ssh deb...@salsa-go-team-runner.debian.net > In the meantime I have disabled the old runner. Thanks! Faustin signature.asc Description: PGP signature
Re: salsa CI golang support - golang-github-la5nta-wl2k-go
Everything is OK now. Many thanks. On 21/11/2022 09:55, Faustin Lammler wrote: Hi Aloïs! Aloïs Micard , 21/11/2022 – 09:40:47 (+0100): Hello. I have just sent you the registration token for the runner. Ok, I have configured the token and named the runner "zigo-runner" Can you check that everything looks OK? If not, your keys (from GH) are on the machine: | ssh deb...@salsa-go-team-runner.debian.net I don't know why but this has not work so I have registered the runner again using a new registration token and everything is working now. Many thanks to all of you. In the meantime I have disabled the old runner. Thanks! Should I delete the old runner? Faustin Cheers, -- ⢀⣴⠾⠻⢶⣦⠀ Aloïs Micard ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ https://creekorful.org ⠈⠳⣄ DA4A A436 9BFA E299 67CD E85B F733 E871 0859 FCD2
Re: salsa CI golang support - golang-github-la5nta-wl2k-go
Aloïs Micard , 21/11/2022 – 10:19:20 (+0100): > Should I delete the old runner? Probably since I have already cleaned the VM. -- Faustin GPG: F652 BCD1 1AA8 8975 F010 48A5 390A 2F27 832A 5C79 signature.asc Description: PGP signature
Bug#1024556: ITP: golang-github-iguanesolutions-go-systemd -- Golang bindings for systemd
Package: wnpp Severity: wishlist Owner: Drew Parsons * Package name: golang-github-iguanesolutions-go-systemd Version : 5.1.0-1 Upstream Author : Iguane Solutions * URL : https://github.com/iguanesolutions/go-systemd * License : Expat Programming Lang: Go Description : Golang bindings for systemd Easily communicate with systemd when run as daemon within a service unit. . With notifier you can notify to systemd that your program is starting, stopping, reloading... . For example, if your daemon needs some time for initializing its controllers before really being considered as ready, you can specify to systemd that this is a "notify" service and send it a notification when ready. . It is safe to use it even if systemd notify support is disabled (noop call). Required by the latest version of rclone. To be maintained by the Debian Go Team.
Re: Undeclared dependencies on tzdata
El 21/11/22 a las 3:19, Shengjing Zhu escribió: On Mon, Nov 21, 2022 at 12:03:40AM +0100, Santiago Vila wrote: I've detected a bunch of Go packages which do not build from source because they use tzdata without a build-dependency. This will not happen if tzdata is installed by default, but such package is not really build-essential, so this is technically a FTBFS bug in a release architecture. tzdata's priority is required. Is this an effort to make tzdata optional? Being "priority: required", being "essential: yes", and being build-essential are all three different things. My intent is to keep stable free from FTBFS bugs, i.e. packages which do not follow this paragraph in policy: "If build-time dependencies are specified, it must be possible to build the package and produce working binaries on a system with only essential and build-essential packages installed and also those required to satisfy the build-time relationships (including any implied relationships)." As you suggest, maybe it would help if debootstrap did not install tzdata in the buildd profile (maybe I will file another bug for that), but this is completely orthogonal to my original aim, which is to have those bugs fixed in stable. That's why I asked for advice about the best way to achieve that. Can we continue on the go-pkg list? Thanks.
Re: Undeclared dependencies on tzdata
On Mon, Nov 21, 2022 at 9:07 PM Santiago Vila wrote: > > El 21/11/22 a las 3:19, Shengjing Zhu escribió: > > On Mon, Nov 21, 2022 at 12:03:40AM +0100, Santiago Vila wrote: > >> I've detected a bunch of Go packages which do not build from source because > >> they use tzdata without a build-dependency. > >> > >> This will not happen if tzdata is installed by default, but such package is > >> not really build-essential, so this is technically a FTBFS bug in a release > >> architecture. > > > > tzdata's priority is required. Is this an effort to make tzdata optional? > > Being "priority: required", being "essential: yes", and being > build-essential are all three different things. > > My intent is to keep stable free from FTBFS bugs, i.e. packages which do > not follow this paragraph in policy: > > "If build-time dependencies are specified, it must be possible to build > the package and produce working binaries on a system with only essential > and build-essential packages installed and also those required to > satisfy the build-time relationships (including any implied relationships)." > So I think we have different interpretations for the policy. > As you suggest, maybe it would help if debootstrap did not install > tzdata in the buildd profile (maybe I will file another bug for that), > but this is completely orthogonal to my original aim, which is to have > those bugs fixed in stable. That's why I asked for advice about the best > way to achieve that. Can we continue on the go-pkg list? > I think it should be on debian-devel. And if the consensus is that required packages should be explicit set at build-depends. We should ensure buildd doesn't include them. Otherwise we can only fix the packages you have listed today. More packages may miss it tomorrow. -- Shengjing Zhu
Bug#1024569: ITP: golang-github-rclone-ftp -- FTP client package for Go
Package: wnpp Severity: wishlist Owner: Drew Parsons * Package name: golang-github-rclone-ftp Version : 1.0.0-210902h-1 Upstream Author : Julien Laffaye * URL : https://github.com/rclone/ftp * License : ISC Programming Lang: Go Description : FTP client package for Go A FTP client package for Go Required by the latest version of rclone. To be maintained by the Debian Go Team (alongside rclone)
Re: salsa CI golang support - golang-github-la5nta-wl2k-go
On 11/21/22 10:19, Aloïs Micard wrote: Everything is OK now. Many thanks. On 21/11/2022 09:55, Faustin Lammler wrote: Hi Aloïs! Aloïs Micard , 21/11/2022 – 09:40:47 (+0100): Hello. I have just sent you the registration token for the runner. Ok, I have configured the token and named the runner "zigo-runner" Can you check that everything looks OK? If not, your keys (from GH) are on the machine: | ssh deb...@salsa-go-team-runner.debian.net I don't know why but this has not work so I have registered the runner again using a new registration token and everything is working now. Many thanks to all of you. Thanks for doing the work, and sorry that I didn't have the time to do it myself. I hope this VM will be useful. Cheers, Thomas Goirand (zigo)
Bug#1024572: ITP: golang-github-dop251-scsu -- A Standard Compression Scheme for Unicode implementation in Go
Package: wnpp Severity: wishlist Owner: Drew Parsons * Package name: golang-github-dop251-scsu Version : 0.0~git20220106.84ac880-1 Upstream Author : Dmitry Panov * URL : https://github.com/dop251/scsu * License : Expat Programming Lang: Go Description : A Standard Compression Scheme for Unicode implementation in Go A Standard Compression Scheme for Unicode implementation in Go. . This in an implementation of SCSU as described in (https://www.unicode.org/reports/tr6/tr6-4.html) . Although UTF-8 is now the most commonly used and recommended encoding, in some cases the use of SCSU can be beneficial. For example when storing or transmitting short alphabetical texts (Arabic, Hebrew, Russian, etc.) where general-purpose compression algorithms are inefficient, but SCSU provides nearly 50% compression ratio over UTF-8. . The code is based on the sample Java implementation found at (ftp://ftp.unicode.org/Public/PROGRAMS/SCSU/) however the encoding algorithm has been slightly modified as the implementation above contains a few bugs. . The code has been fuzz-tested using go-fuzz to ensure that random input neither crashes the Encoder nor the Decoder, and if it happens to be a valid UTF-8, an Encode/Decode cycle produces identical output. Required by latest version of rclone. To be maintained by the Debian Go Team.
Bug#1024583: ITP: golang-github-casbin-casbin -- Authorization library that supports access control models like ACL, RBAC, ABAC
Package: wnpp Severity: wishlist Owner: Mathias Gibbens X-Debbugs-CC: debian-de...@lists.debian.org, debian-go@lists.debian.org * Package name: golang-github-casbin-casbin Version : 2.57.0-1 Upstream Author : Casbin * URL : https://github.com/casbin/casbin * License : Apache-2.0 Programming Lang: Go Description : Authorization library that supports access control models like ACL, RBAC, ABAC Casbin is a powerful and efficient open-source access control library for Golang projects. It provides support for enforcing authorization based on various access control models. This is a dependency of updating golang-github-go-kit-kit and will be team-maintained within the Go Packaging Team. signature.asc Description: This is a digitally signed message part
Bug#1024584: ITP: golang-github-vividcortex-gohistogram -- Streaming approximate histograms in Go
Package: wnpp Severity: wishlist Owner: Mathias Gibbens X-Debbugs-CC: debian-de...@lists.debian.org, debian-go@lists.debian.org * Package name: golang-github-vividcortex-gohistogram Version : 1.0.0-1 Upstream Author : VividCortex * URL : https://github.com/VividCortex/gohistogram * License : Expat Programming Lang: Go Description : Streaming approximate histograms in Go This package provides Streaming Approximate Histograms for efficient quantile approximations. . The histograms in this package are based on the algorithms found in Ben-Haim & Yom-Tov's "A Streaming Parallel Decision Tree Algorithm". Histogram bins do not have a preset size. As values stream into the histogram, bins are dynamically added and merged. This is a dependency of updating golang-github-go-kit-kit and will be team-maintained within the Go Packaging Team. signature.asc Description: This is a digitally signed message part
Bug#1024585: ITP: golang-github-performancecopilot-speed -- Implementation of the PCP instrumentation API
Package: wnpp Severity: wishlist Owner: Mathias Gibbens X-Debbugs-CC: debian-de...@lists.debian.org, debian-go@lists.debian.org * Package name: golang-github-performancecopilot-speed Version : 4.0.0-1 Upstream Author : Performance Co-Pilot * URL : https://github.com/performancecopilot/speed * License : Expat Programming Lang: Go Description : Implementation of the PCP instrumentation API Golang implementation of the Performance Co-Pilot (PCP) instrumentation API. . There are 3 main components defined in the library, a Client, a Registry and a Metric. A client is created using an application name, and the same name is used to create a memory mapped file in PCP_TMP_DIR. Each client contains a registry of metrics that it holds, and will publish on being activated. This is a dependency of updating golang-github-go-kit-kit and will be team-maintained within the Go Packaging Team. signature.asc Description: This is a digitally signed message part
Bug#1024586: ITP: golang-github-knetic-govaluate -- Arbitrary expression evaluation for golang
Package: wnpp Severity: wishlist Owner: Mathias Gibbens X-Debbugs-CC: debian-de...@lists.debian.org, debian-go@lists.debian.org * Package name: golang-github-knetic-govaluate Version : 3.0.0-1 Upstream Author : George Lester * URL : https://github.com/Knetic/govaluate * License : Expat Programming Lang: Go Description : Arbitrary expression evaluation for golang Provides support for evaluating arbitrary C-like artithmetic/string expressions. . Sometimes, you can't know ahead-of-time what an expression will look like, or you want those expressions to be configurable. Perhaps you've got a set of data running through your application, and you want to allow your users to specify some validations to run on it before committing it to a database. Or maybe you've written a monitoring framework which is capable of gathering a bunch of metrics, when evaluating a few expressions to see if any metrics should be alerted upon, but the conditions for alerting are different for each monitor. . A lot of people wind up writing their own half-baked style of evaluation language that fits their needs, but isn't complete. Or they wind up baking the expression into the actual executable, even if they know it's subject to change. These strategies may work, but they take time to implement, time for users to learn, and induce technical debt as requirements change. This library is meant to cover all the normal C-like expressions, so that you don't have to reinvent one of the oldest wheels on a computer. This is a dependency of golang-github-casbin-casbin (ITP#1024583) and will be team-maintained within the Go Packaging Team. signature.asc Description: This is a digitally signed message part
Re: Bug#1010648: marked as pending in golang-github-pierrec-lz4.v4
Control: retitle -1 RFP: golang-github-pierrec-lz4.v4 -- LZ4 compression and decompression in pure Go (v4) Control: noowner -1 TLDR: this missing package is blocking updates for syncthing as well as golang-github-gocql-gocql. It will be more challenging to maintain syncthing (backported fixes for CVEs) in bookworm if we get stuck with 1.19.2, from 05 April 2022 rather than 1.22.x or 1.23.x. Hi Eric, Aloïs, Alexandre, and Go Team, There is no longer a package waiting for review in NEW. I missed a few Gutenberg headers in my review; however, strictly speaking, this might be what FTP Masters are objecting to (without saying so), because there is less precedent for implicit Gutenberg license to 3-clause-BSD has than public domain to 3-clause-BSD. Upstream would need to exercise his public domain right to remove the Gutenberg headers, and some FTP Masters appear to also be angling for an explicit upstream public_domain to 3-clause-BSD record, even though this isn't required. Yet there is precedent in the GCC package (and golang package) for how this isn't a real problem...In these two places, the copyright information appears to have been strategically omitted from the copyright file. This is 100% valid in places that recognise public domain works (eg: works that have no copyright, not even moral rights), but I fail to see how it's acceptable for world-wide scope for some packages but not others. It's fastest to just remove all the tests. If the newest src:syncthing 1.19.2 tests for correct operation of lz4.v4 compression on buildds and DebCI than this may not be as horrifying at it seems. It may also be sufficient to remove the fuzz and testdata from the single binary package, but I feel like that depends on which FTP Master reviews the package. We're running out of time to fix this for bookworm, so I leave this to someone else. Here's the remote: g...@salsa.debian.org:go-team/packages/golang-github-pierrec-lz4.v4.git Regards, Nicholas signature.asc Description: PGP signature
