Re: dpkg-source --commit fails to find local changes

2014-08-17 Thread Bernhard R. Link
* Guillem Jover  [140815 17:50]:
> On Fri, 2014-08-15 at 15:34:09 +0100, Neil Williams wrote:
> > I'm unable to get dpkg-source to see that I have changed files in a
> > python source package format 3.0 (quilt):
> > 
> > dpkg-source: info: there are no local changes to record
> > 
> > No matter what I seem to do inside the json-schema-validator package,
> > dpkg refuses to spot the change, even renaming the package in setup.py
> > or changing the .py files. I get no warning on building and I have to
> > create the patch manually.
> > 
> > Is this a regression or is there something different about the
> > json-schema-validator and versiontools packages?
> > 
> > This happened with 1.17.11 and 1.17.12.
> 
> This looks like it might be a regression yes, I'm checking the obvious
> culprits now.

This also effects the normal dpkg-source --build run:
It silently ignores unrecorded changes and just creates a source package
without them.


Bernhard R. Link
-- 
F8AC 04D5 0B9B 064B 3383  C3DA AFFC 96D1 151D FFDC


-- 
To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140817112230.ga3...@client.brlink.eu



Re: dpkg-source --commit fails to find local changes

2014-08-17 Thread Sebastian Ramacher
Package: dpkg-dev
Version: 1.17.11
Severity: important
Control: submitter -1 Neil Williams 

Hi Guillem

On 2014-08-15 17:49:53, Guillem Jover wrote:
> On Fri, 2014-08-15 at 15:34:09 +0100, Neil Williams wrote:
> > I'm unable to get dpkg-source to see that I have changed files in a
> > python source package format 3.0 (quilt):
> > 
> > dpkg-source: info: there are no local changes to record
> > 
> > No matter what I seem to do inside the json-schema-validator package,
> > dpkg refuses to spot the change, even renaming the package in setup.py
> > or changing the .py files. I get no warning on building and I have to
> > create the patch manually.
> > 
> > Is this a regression or is there something different about the
> > json-schema-validator and versiontools packages?
> > 
> > This happened with 1.17.11 and 1.17.12.
> 
> This looks like it might be a regression yes, I'm checking the obvious
> culprits now.

I'm turning this into a bug report. Today I've encountered the same bug
and wondered what's wrongs since there is nothing in the BTS.

I've bisected the commits between 1.17.10 and 1.17.12 and it seems that
changes detection is broken since
543ac69d2470e39f6b95a59b82fee116bc1b90d7.

Cheers
-- 
Sebastian Ramacher


signature.asc
Description: Digital signature


Re: dpkg-source --commit fails to find local changes

2014-08-17 Thread Guillem Jover
Hi!

On Sun, 2014-08-17 at 14:43:47 +0200, Sebastian Ramacher wrote:
> Package: dpkg-dev
> Version: 1.17.11
> Severity: important
> Control: submitter -1 Neil Williams 

> On 2014-08-15 17:49:53, Guillem Jover wrote:
> > On Fri, 2014-08-15 at 15:34:09 +0100, Neil Williams wrote:
> > > I'm unable to get dpkg-source to see that I have changed files in a
> > > python source package format 3.0 (quilt):
> > > 
> > > dpkg-source: info: there are no local changes to record
> > > 
> > > No matter what I seem to do inside the json-schema-validator package,
> > > dpkg refuses to spot the change, even renaming the package in setup.py
> > > or changing the .py files. I get no warning on building and I have to
> > > create the patch manually.
> > > 
> > > Is this a regression or is there something different about the
> > > json-schema-validator and versiontools packages?
> > > 
> > > This happened with 1.17.11 and 1.17.12.
> > 
> > This looks like it might be a regression yes, I'm checking the obvious
> > culprits now.
> 
> I'm turning this into a bug report. Today I've encountered the same bug
> and wondered what's wrongs since there is nothing in the BTS.
> 
> I've bisected the commits between 1.17.10 and 1.17.12 and it seems that
> changes detection is broken since
> 543ac69d2470e39f6b95a59b82fee116bc1b90d7.

Yeah, thanks, had already fixed this yesterday, but when I got time to
prepare the release was quite late and I was too tired to operate
correctly. :) Will be uploading now.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140817131123.ga5...@gaara.hadrons.org



Re: dpkg-source --commit fails to find local changes

2014-08-17 Thread Guillem Jover
On Sun, 2014-08-17 at 15:11:23 +0200, Guillem Jover wrote:
> Yeah, thanks, had already fixed this yesterday, but when I got time to
> prepare the release was quite late and I was too tired to operate
> correctly. :) Will be uploading now.

Actually, later today, as I've to run out now. And was didn't have
time to test everything properly.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140817143155.ga24...@gaara.hadrons.org