Question about PTS web interface
Hello, Some days ago I uploaded a new version of wmaker (0.95.4-1) package [1] to experimental. The PTS web interface shows this package in the "patch-tracker" box, but the "todo" box show info about the unstable version (0.95.3-2): 8< Lintian reports 3 warnings about this package. You should make the package lintian clean getting rid of them. A new upstream version is available: 0.95.4, you should consider packaging it. 8< is that correct? The lintian info for 0.95.4 is available, so IMO the PTS should consider the experimental version too. Best regards, kix [1] http://packages.qa.debian.org/w/wmaker.html -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5103bf62.60...@kix.es
Re: Question about PTS web interface
The PTS has a lot of unstable-isms, patches welcome though. Outside the freeze, experimental probably isn't particularly important to inform people about though. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6eddlr0-p8taunsgn4ud5tch0yc4-lyxmvcnb6pds5...@mail.gmail.com
Re: problematic shlibs entry in substvars file
> I guess that #s-sharedlibs-symbols on that page should be referenced by > deb-symbols(5), dpkg-shlibdeps(1) and dpkg-gensymbols(1), could you file a > bug/patch about that on dpkg-dev? Done in #698999. -- Charles Plessy Tsurumi, Kanagawa, Japan -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130126125520.ga4...@falafel.plessy.net
Suggestion about minor improvements to default bashrc
Hello, this is my first minor contribution to Debian, but as it's my Linux distribution of choise and the only one I chose to work with I have found minor improvements that perhaps can be of use. The first one I will mail about is so minor it might be uninteresting but as I spend so much time on new VPS and Debain installations on the net I tend to use the: $ clear Command more often than not. However, to save time I've begun to use an .bashrc alias for it, as such: alias cl='clear' If you personally havn't tried it, do it. It's insanely addictive. I have further ideas for improvements, but I am unaware of the criteria for Debian scripts. Is it okay to use external sites for information inside shell scripts? Perhaps there's somekind of guildeline for Debian developers I can view before I write more material! // Slimbo -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130126171902.ga19...@wuut.se
Re: Suggestion about minor improvements to default bashrc
On Sat, Jan 26, 2013 at 06:19:02PM +0100, Simon Johnsson wrote: > Hello, this is my first minor contribution to Debian, but as it's my > Linux distribution of choise and the only one I chose to work with I > have found minor improvements that perhaps can be of use. > > The first one I will mail about is so minor it might be uninteresting > but as I spend so much time on new VPS and Debain installations on > the net I tend to use the: > > $ clear > > Command more often than not. However, to save time I've begun to use > an .bashrc alias for it, as such: > > alias cl='clear' > > If you personally havn't tried it, do it. It's insanely addictive. Did you try Ctrl-L? > I have further ideas for improvements, but I am unaware of the > criteria for Debian scripts. Is it okay to use external sites for > information inside shell scripts? What do you mean? > Perhaps there's somekind of guildeline for Debian developers I can view > before I write more material! Guideline regarding what? -- WBR, wRAR signature.asc Description: Digital signature
screen says "Bad tty" if /dev/console is a symlink
Before filling a bug, I need a review :-)
The patch fo screen.cc [1] introduces the function CheckTtyname():
int
CheckTtyname (tty)
char *tty;
{
struct stat st;
if (lstat(tty, &st) || !S_ISCHR(st.st_mode) ||
(st.st_nlink > 1 && strncmp(tty, "/dev/", 5)))
return -1;
return 0;
}
When I run screen on a "real" console, screen says "Bad tty '/dev/console'"
I guess this is due to:
1. /dev/console is a symlink (don't ask ;-):
# ls -lh /dev/console
lrwxrwxrwx 1 root root 30 May 13 2012 /dev/console ->
../devices/pseudo/cn@0:console
2. lstat() stats a symlink itself, and it is obviosly not a character device.
Does it make sense to replace lstat() with stat()?
[1]
http://anonscm.debian.org/gitweb/?p=collab-maint/screen.git;a=blob;f=debian/patches/47screen-cc.patch;h=a8f58e6c0c61fab6250e952e2707af0ff98b8452;hb=HEAD
--
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CALL-Q8wdgX83y2dvT2PxPkb9uqt_4EnJFgGBYX0ip5=petl...@mail.gmail.com
Re: screen says "Bad tty" if /dev/console is a symlink
On Sat, 2013-01-26 at 22:57:59 +0400, Игорь Пашев wrote:
> The patch fo screen.cc [1] introduces the function CheckTtyname():
>
> int
> CheckTtyname (tty)
> char *tty;
> {
>struct stat st;
>
>if (lstat(tty, &st) || !S_ISCHR(st.st_mode) ||
> (st.st_nlink > 1 && strncmp(tty, "/dev/", 5)))
> return -1;
>return 0;
> }
> Does it make sense to replace lstat() with stat()?
Yes, that makes sense, but reading into the intention of the function
that would defeat the check on the actual name, so for that latter
check to also make sense you'd have to dereference the path before
doing the strncmp(), at which point using lstat() on the dereferenced
path would be fine again.
Regards,
Guillem
--
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130126193939.ga10...@gaara.hadrons.org
Re: screen says "Bad tty" if /dev/console is a symlink
Did I break anything?
Too paranoid?
Index: screen/tty.sh
===
--- screen.orig/tty.sh 2013-01-26 07:55:33.092171499 +
+++ screen/tty.sh 2013-01-26 08:56:34.254462991 +
@@ -1505,12 +1505,29 @@
CheckTtyname (tty)
char *tty;
{
+ char real[MAX_PATH];
struct stat st;
-
- if (lstat(tty, &st) || !S_ISCHR(st.st_mode) ||
- (st.st_nlink > 1 && strncmp(tty, "/dev/", 5)))
-return -1;
- return 0;
+ if (0 == lstat(tty, &st)) {
+if (S_ISCHR(st.st_mode)) {
+ if ((1 == st.st_nlink) || (0 == strncmp(tty, "/dev/", 5)))
+ return 0;
+} else if (S_ISLNK(st.st_mode)) {
+ if (0 == stat(tty, &st) && S_ISCHR(st.st_mode)) {
+if (1 == st.st_nlink) {
+ return 0;
+} else if (realpath(tty, real)) {
+#if defined(__sun__)
+if (!strncmp(real, "/devices/", 9))
+ return 0;
+#else
+if (!strncmp(real, "/dev/", 5))
+ return 0;
+#endif
+}
+ }
+}
+ }
+ return -1;
}
--
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CALL-Q8y8W8dPX45cXFEhLHrNVtNvuTv=v1ka2zjzyhlytfn...@mail.gmail.com
Re: screen says "Bad tty" if /dev/console is a symlink
I'd rather drop checking for path at all. -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CALL-Q8zSrj=fgggfqeva4k4iuqngbb6u12to8_fz1vp4uqo...@mail.gmail.com
Re: Suggestion about minor improvements to default bashrc
Le Sat, Jan 26, 2013 at 06:19:02PM +0100, Simon Johnsson a écrit : > Hello, this is my first minor contribution to Debian, but as it's my > Linux distribution of choise and the only one I chose to work with I > have found minor improvements that perhaps can be of use. Dear Simon, thank you for trying to improve Debian. The .bashrc file in fresh user accounts is derived from /etc/skel/.bashrc, which is created by the base-files package. To make your suggestion, you would therefore report a bug with a severity wishlist against this package. This said, be prepared to be disappointed by the answer. On a distribution that targets a broad range of users, /etc/skel/.bashrc, can only be minimal. Imagine that your alias pleases 90 % of the users and annoys the 10 % remaining. With a bunch of aliases that have non-overlapping user bases, we would quickly grow towards a very high probablity of annoying any of our users by default... But there are countless other ways where you can help Debian. You can have a look at http://www.debian.org/intro/help for a start. Have a nice Sunday, -- Charles Plessy Debian Med packaging team, http://www.debian.org/devel/debian-med Tsurumi, Kanagawa, Japan -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130127065329.ga28...@falafel.plessy.net
