Bug#870448: hw-detect - stop using modprobe -l
On Wed, Aug 02, 2017 at 07:58:05PM +0100, Ben Hutchings wrote:
> On Wed, 2017-08-02 at 12:26 +1000, Vincent McIntyre wrote:
> > Package: hw-detect
> > Version: 1.124
> > Severity: normal
> > Tags: patch
> >
> > I keep seeing this in installer logs, back to jessie.
> >
> > Aug 2 01:52:11 main-menu[193]: (process:224): modprobe: invalid option --
> > 'l'
> >
> >
> > I rated this normal rather than minor because the way it is working
> > now the is_available() function always returns 1 (failure)
> >
> > My suggestion is to use modinfo instead.
> > This will return multiline output inside the quotes but
> > a couple of tests suggests that is ok.
> > It does fail with some modules (nvidia), not sure if we care.
> >
> > diff --git a/hw-detect.sh b/hw-detect.sh
> > index 7977814..d8196c1 100755
> > --- a/hw-detect.sh
> > +++ b/hw-detect.sh
> > @@ -43,7 +43,7 @@ is_not_loaded() {
> > }
> >
> > is_available () {
> > - [ "$(modprobe -l $1)" ] || return 1
> > + [ "$(modinfo $1)" ] || return 1
> > }
>
> But this still prints error messages for missing modules. I think the
> function should be implemented as:
>
> is_available () {
> modprobe -qn "$1"
> }
>
That seems much better, can someone please apply Ben's version?
Thanks for tickling this Holger.
Cheers
Vince
Bug#592834: grub-pc: File descriptor leaked on lvs invocation
Hello there, I still see the same on my installation: Ubuntu 16.04: Examining /etc/kernel/postrm.d . run-parts: executing /etc/kernel/postrm.d/initramfs-tools 4.4.0-140-generic /boot/vmlinuz-4.4.0-140-generic update-initramfs: Deleting /boot/initrd.img-4.4.0-140-generic run-parts: executing /etc/kernel/postrm.d/zz-update-grub 4.4.0-140-generic /boot/vmlinuz-4.4.0-140-generic Generating grub configuration file ... File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12417: grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12417: grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12484: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12484: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12503: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12503: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12522: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12522: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12542: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12542: /usr/sbin/grub-probe Warning: Setting GRUB_TIMEOUT to a non-zero value when GRUB_HIDDEN_TIMEOUT is set is no longer supported. File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12637: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12637: /usr/sbin/grub-probe Found linux image: /boot/vmlinuz-4.15.0-43-generic Found initrd image: /boot/initrd.img-4.15.0-43-generic File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12771: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12771: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12791: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12791: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12811: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12811: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12831: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 12831: /usr/sbin/grub-probe Found linux image: /boot/vmlinuz-4.15.0-42-generic Found initrd image: /boot/initrd.img-4.15.0-42-generic Found linux image: /boot/vmlinuz-4.4.0-141-generic Found initrd image: /boot/initrd.img-4.4.0-141-generic File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 13390: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on vgs invocation. Parent PID 13390: /usr/sbin/grub-probe File descriptor 11 (/var/lib/dpkg/triggers/linux-update-4.15.0-39-generic (deleted)) leaked on lvs invocation. Parent PID 13546: /bin/sh Adding boot menu entry for EFI firmware configuration If, as commented above: > [...] It's just overly-verbose debug from "vgs" [...] Then, is this tracked in the "vgs" program / fixed somehow? Ντέντος Σταύρος
Bug#851189: keyboard-configuration: ALT+Cursor-Left switches consoles instead of working on app in focus
Hi again. In short I kind of just copied that post blindly and only now looked into things further. > Mmm, do you mean that this postinst script ends up calling setupcon > --force --save in a living Ubuntu system, not the installer of Ubuntu? > The script checks for the presence of the /lib/debian-installer.d > directory, does that directory really exist in an installed Ubuntu > system? If so, that's the problem, that directory shouldn't exist on an > installed system. >> To reproduce: >> sudo apt install --reinstall keyboard-configuration > That doesn't trigger the issue on an installed Debian system (which > doesn't have /lib/debian-installer.d). I did just try this myself and you're right, this didn't trigger it. Which got me to think more of what could have and I did recently build wine in an ubuntu chroot which is a plausible cause, I think?
Bug#851189: keyboard-configuration: ALT+Cursor-Left switches consoles instead of working on app in focus
Mike McGuire, le lun. 07 janv. 2019 18:57:18 +, a ecrit: > I did just try this myself and you're right, this didn't trigger it. Which > got me to think more of what could have and I did recently build wine in an > ubuntu chroot which is a plausible cause, I think? That could have triggered running the keyboard-configuration indeed. Which version of ubuntu is this? I only have a 16.04 version under my hand, and that does not contain the check for /lib/debian-installer.d that the Debian package has since 2010, so it seems ubuntu dropped it for some reason without taking enough care. The script does check for $DISPLAY, but that won't work when running inside unattended-upgrade, which runs out of X. Samuel
Bug#851189: keyboard-configuration: ALT+Cursor-Left switches consoles instead of working on app in focus
It's a xenial chroot and it indeed doesn't have that test in keyboard-configuration.postinst. Perhaps just an ubuntu issue then, sorry for the noise. ;-)
control file: Priority for udeb packages
Hi,
the Debian Policy is not strict there under
https://www.debian.org/doc/debian-policy/ch-controlfields.html#priority
so I better ask:
Is there any sense in adding a Priority field for udeb packages?
For example like this for cdebconf:
snip---
Source: cdebconf
Section: utils
Priority: optional
[...]
Package: cdebconf
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf, dpkg (>= 1.15.4)
Provides: debconf-2.0
Suggests: cdebconf-gtk
Priority: optional
[...]
Package: cdebconf-udeb
Architecture: any
Section: debian-installer
Priority: standard
Depends: ${shlibs:Depends}, ${misc:Depends}
Provides: debconf-2.0
Package-Type: udeb
[...]
--snap-
Source package has optional, also has the 'cdebconf' binary package, and the
udeb has standard.
I this somehow intended? Has is some effect?
udebs are 'micro binary packages' by definition, so they don't need the
Priority field themselves, they inherit the value from Source package, right?
Any other intention, especially why the udeb has standard, while source has
optional?
Holger
--
Holger Wansing
PGP-Finterprint: 496A C6E8 1442 4B34 8508 3529 59F1 87CA 156E B076
Bug#706643: Block ios PlayStation Xbox one and family members third parties and business uninstall all on other devices retrieve my data and business uninstall all on other devices retrieve my data an
Block
Bug#918659: Debootstrap started to fail with Busybox
Package: debootstrap Version: 1.0.113 Debootstrap started to fail with busybox since version 1.0.113. Previously it worked flawlessly with busybox. It fails silently, but debootstrap.log contains the following error: date: invalid date 'Tue, 15 Jan 2019 02:23:06 UTC' The reason is commit: 75cd76ca821bfe92434b26503b1716ca6b99fd0c, which parses Valid-Until using `date -d` command. Busybox's date command does not parse RFC 2822 dates. Please do not use `date -d` command for parsing Valid-Until field. Or, at least, shortcut with NO_CHECK_VALID_UNTIL **before** `date -d` command is called (so one will use --no-check-valid-until on Busybox to prevent debootstrap from silent fail).
