Re: [PATCH] Cope with more unset/disabled root password options
On Fri, Jul 07, 2017 at 04:20:10PM +0100, Steve McIntyre wrote:
> Recognise and cope with a different *disabled* root password ("!*") in
> /etc/shadow as well as the normal unset one ("*"). Closes: #866206,
> fixing a major bug in the live installer.
Looks good to me, though at this point it might be worth refactoring
that conditional a bit to assign the grep output to a local variable to
avoid the repeated subprocess invocations.
--
Colin Watson [cjwat...@debian.org]
Processing of rescue_1.65_source.changes
rescue_1.65_source.changes uploaded successfully to localhost along with the files: rescue_1.65.dsc rescue_1.65.tar.xz rescue_1.65_source.buildinfo Greetings, Your Debian queue daemon (running on host usper.debian.org)
Bug#867564: marked as done (rescue: Call to search-path fails as it is not in $CHROOT_PATH)
Your message dated Sun, 09 Jul 2017 15:19:06 + with message-id and subject line Bug#867564: fixed in rescue 1.65 has caused the Debian Bug report #867564, regarding rescue: Call to search-path fails as it is not in $CHROOT_PATH to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 867564: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867564 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: rescue Version: 1.64 Tags: patch Severity: important Dear Maintainer, * What led up to the situation? Trying to recover a debian machine using rescue, after mounting the target disk, trying to open a shell in the target * What was the outcome of this action? Informed no shell could be found (or dropped to a shell, but not bash) * What outcome did you expect instead? Correctlly end up in a shell with bash In the chroot_has function, the PATH variable is set to $CHROOT_PATH which does not contain the script search-path (as this only exists in the installer env). Therefore this call fails. Changing this to the absolute path resolves the issue -- System Information: Debian Release: buster/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) patch Description: Binary data --- End Message --- --- Begin Message --- Source: rescue Source-Version: 1.65 We believe that the bug you reported is fixed in the latest version of rescue, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 867...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Colin Watson (supplier of updated rescue package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Sun, 09 Jul 2017 14:58:51 +0100 Source: rescue Binary: rescue-check rescue-mode Architecture: source Version: 1.65 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team Changed-By: Colin Watson Description: rescue-check - enter d-i rescue mode if requested (udeb) rescue-mode - mount requested partition and start a rescue shell (udeb) Closes: 867564 Changes: rescue (1.65) unstable; urgency=medium . * Invoke search-path by absolute path in chroot_has (thanks, Tom Hanson; closes: #867564). Checksums-Sha1: 27b66f577c4eb2e79c90f6cc960d86bd0c7e8e2a 1677 rescue_1.65.dsc 4dfd2b8942672e9a17d9baf0f97c3df7c796529d 138216 rescue_1.65.tar.xz b789d496ea988afa8b9d37aeb024d36322fca89b 6107 rescue_1.65_source.buildinfo Checksums-Sha256: 3432d0f9ab199a51564ebf70159f6e5716178ace044b55a0db8f8343b84a057e 1677 rescue_1.65.dsc 8d113e656aa10dcaf1de7154a9b917206b810908833ada13097aca55d51693cf 138216 rescue_1.65.tar.xz 0df87e81a52e3a15f023d6862efd4b79d045fc35cb558906797d385acebac5ae 6107 rescue_1.65_source.buildinfo Files: fa98890ca16fa5a6a33515ec85d625df 1677 debian-installer optional rescue_1.65.dsc 320e647532420d77eba404b684cc5433 138216 debian-installer optional rescue_1.65.tar.xz 12cc072faecfc32c2fcd8568fbb7e63c 6107 debian-installer optional rescue_1.65_source.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAlliNs4ACgkQOTWH2X2G UAtirxAAtT6WTJ2ZKsb5cZS2Avx72Ob3sHJ392ysviagOFVTLCJoOVi8ZYjaJQaj wauSVwyZukd76nT19JHl9LJ6KX/QhBVgDnO7+MLN0TynzMxCkVzdgmiks2Hej30o XCE/b60sbAy9yxrHspIQrI1vJoMDU3407NfyS2BC881BTLWDP8zYWFT5clqNwaMo 8im5a8OjPBEaLhYmXEOr8K42tkw+Mew7jLpEuzYo963bzkoN8ZGoRGuckWKWIz9b pfpp7DPL44f7c4XWuSVGkuQyhh2q4abmEJYfxFDBT9cBGpvSICy2U9g7rVcCtvuZ iKVIdqPWgEJfx2qW094/UYc7yjGJORHjJwiN1H6QrzEJeh0GLOWaUU9F0W84Gay9 6Sb5ie/b9Hruz3oOSMQVjMcZmoiyvxfRrNMKxRinKb7KwKRZxr7VZt2opQTKRgw/ gjSQJVtuU1P8GZ+mM+GGmiIUvJXR05NhbaVRjr9SxCFP/JT60y6eqjOavmwgw8bi vUBJGJvsN+vcSOYRtC3vKSKpZd204epb9C2ktrhUGI8hZrPfpDLKZaY/HWEKK0hT hoRHc/rwnT8LSPY/lSGve81VMdgKq+0/eDV3sMEQNB7tJg6YwekWJ1Lk1wBNRqsn C8rFC2jlPxLCtEl0yvOHXUZJ5K8+cBzA14NhSmWiQAFfv9vxn+8= =YrwO -END PGP SIGNATURE End Message ---
rescue_1.65_source.changes ACCEPTED into unstable
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Format: 1.8 Date: Sun, 09 Jul 2017 14:58:51 +0100 Source: rescue Binary: rescue-check rescue-mode Architecture: source Version: 1.65 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team Changed-By: Colin Watson Description: rescue-check - enter d-i rescue mode if requested (udeb) rescue-mode - mount requested partition and start a rescue shell (udeb) Closes: 867564 Changes: rescue (1.65) unstable; urgency=medium . * Invoke search-path by absolute path in chroot_has (thanks, Tom Hanson; closes: #867564). Checksums-Sha1: 27b66f577c4eb2e79c90f6cc960d86bd0c7e8e2a 1677 rescue_1.65.dsc 4dfd2b8942672e9a17d9baf0f97c3df7c796529d 138216 rescue_1.65.tar.xz b789d496ea988afa8b9d37aeb024d36322fca89b 6107 rescue_1.65_source.buildinfo Checksums-Sha256: 3432d0f9ab199a51564ebf70159f6e5716178ace044b55a0db8f8343b84a057e 1677 rescue_1.65.dsc 8d113e656aa10dcaf1de7154a9b917206b810908833ada13097aca55d51693cf 138216 rescue_1.65.tar.xz 0df87e81a52e3a15f023d6862efd4b79d045fc35cb558906797d385acebac5ae 6107 rescue_1.65_source.buildinfo Files: fa98890ca16fa5a6a33515ec85d625df 1677 debian-installer optional rescue_1.65.dsc 320e647532420d77eba404b684cc5433 138216 debian-installer optional rescue_1.65.tar.xz 12cc072faecfc32c2fcd8568fbb7e63c 6107 debian-installer optional rescue_1.65_source.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAlliNs4ACgkQOTWH2X2G UAtirxAAtT6WTJ2ZKsb5cZS2Avx72Ob3sHJ392ysviagOFVTLCJoOVi8ZYjaJQaj wauSVwyZukd76nT19JHl9LJ6KX/QhBVgDnO7+MLN0TynzMxCkVzdgmiks2Hej30o XCE/b60sbAy9yxrHspIQrI1vJoMDU3407NfyS2BC881BTLWDP8zYWFT5clqNwaMo 8im5a8OjPBEaLhYmXEOr8K42tkw+Mew7jLpEuzYo963bzkoN8ZGoRGuckWKWIz9b pfpp7DPL44f7c4XWuSVGkuQyhh2q4abmEJYfxFDBT9cBGpvSICy2U9g7rVcCtvuZ iKVIdqPWgEJfx2qW094/UYc7yjGJORHjJwiN1H6QrzEJeh0GLOWaUU9F0W84Gay9 6Sb5ie/b9Hruz3oOSMQVjMcZmoiyvxfRrNMKxRinKb7KwKRZxr7VZt2opQTKRgw/ gjSQJVtuU1P8GZ+mM+GGmiIUvJXR05NhbaVRjr9SxCFP/JT60y6eqjOavmwgw8bi vUBJGJvsN+vcSOYRtC3vKSKpZd204epb9C2ktrhUGI8hZrPfpDLKZaY/HWEKK0hT hoRHc/rwnT8LSPY/lSGve81VMdgKq+0/eDV3sMEQNB7tJg6YwekWJ1Lk1wBNRqsn C8rFC2jlPxLCtEl0yvOHXUZJ5K8+cBzA14NhSmWiQAFfv9vxn+8= =YrwO -END PGP SIGNATURE- Thank you for your contribution to Debian.
Processed: closing 867125
Processing commands for cont...@bugs.debian.org: > # Submitter confirmed that system really does use LVM2 > close 867125 Bug #867125 [installation-reports] installation-reports: (initrd) 4.9 kernel boot fails because package lvm2 not installed Marked Bug as done > thanks Stopping processing here. Please contact me if you need assistance. -- 867125: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=867125 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Upcoming oldstable point release (8.9)
Hi, The next point release for "jessie" (8.9) is scheduled for Saturday, July 22nd. Processing of new uploads into jessie-proposed-updates will be frozen during the preceding weekend. Regards, Adam
Upcoming stable point release (9.1)
Hi, The first point release for "stretch" (9.1) is scheduled for Saturday, July 22nd. Processing of new uploads into stretch-proposed-updates will be frozen during the preceding weekend. Regards, Adam
Re: [PATCH] Cope with more unset/disabled root password options
On Sun, Jul 09, 2017 at 02:52:14PM +0100, Colin Watson wrote:
>On Fri, Jul 07, 2017 at 04:20:10PM +0100, Steve McIntyre wrote:
>> Recognise and cope with a different *disabled* root password ("!*") in
>> /etc/shadow as well as the normal unset one ("*"). Closes: #866206,
>> fixing a major bug in the live installer.
>
>Looks good to me, though at this point it might be worth refactoring
>that conditional a bit to assign the grep output to a local variable to
>avoid the repeated subprocess invocations.
Nod. I pondered that, but for this patch thought I'd keep the core
code the same to make reviewing easier.
--
Steve McIntyre, Cambridge, UK.st...@einval.com
Welcome my son, welcome to the machine.
Re: [PATCH] Cope with more unset/disabled root password options
Colin Watson writes:
> On Fri, Jul 07, 2017 at 04:20:10PM +0100, Steve McIntyre wrote:
>> Recognise and cope with a different *disabled* root password ("!*") in
>> /etc/shadow as well as the normal unset one ("*"). Closes: #866206,
>> fixing a major bug in the live installer.
>
> Looks good to me, though at this point it might be worth refactoring
> that conditional a bit to assign the grep output to a local variable to
> avoid the repeated subprocess invocations.
I susupect that this does the same thing as all the greps:
sed -n '/^root:\(\*\|!\|\):/q1' $ROOT/etc/shadow
so that should look like:
if [ -e $ROOT/etc/shadow ] && \
sed -n '/^root:\(\*\|!\|\):/q1' $ROOT/etc/shadow; then
return 0
fi
Which works by throwing an error (the q1 bit) if the pattern matches,
where the pattern should match the three cases we don't want (*, ! and
empty).
... but I've not yet checked that it really works in d-i's busybox -
should have time for that in the morning.
Cheers, Phil.
--
|)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd.
|-| http://www.hands.com/http://ftp.uk.debian.org/
|(| Hugo-Klemm-Strasse 34, 21075 Hamburg,GERMANY
signature.asc
Description: PGP signature
Bug#819867: marked as done (installation-report: USB-boot fails with Stretch, no GRUB-installation with BTRFS-partition)
Your message dated Mon, 10 Jul 2017 08:28:32 +0200 with message-id <20170710082832.7574146d@a68n.lokal> and subject line done - usb-boot is now workable in the stretch-release has caused the Debian Bug report #819867, regarding installation-report: USB-boot fails with Stretch, no GRUB-installation with BTRFS-partition to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 819867: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819867 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Package: installation-reports Version: 2.62 Severity: minor Dear Maintainer, *** Reporter, please consider answering these questions, where appropriate *** * What led up to the situation? * What exactly did you do (or not do) that was effective (or ineffective)? * What was the outcome of this action? * What outcome did you expect instead? *** End of the template - remove these template lines *** - -- Package-specific info: Boot method: local netinstall-image Image version: 2016-03-28, http://cdimage.debian.org/cdimage/weekly-builds/amd64/iso-cd/debian-testing-amd64-netinst.iso Date: 2016-04-02, about 12.00 h Machine: KVM with vm-manager Partitions: Filesystem Type 1K-blocks Used Available Use% Mounted on udev devtmpfs500856 0500856 0% /dev tmpfs tmpfs 102076 1732100344 2% /run /dev/vda1 btrfs 6835200 933704 5263640 16% / tmpfs tmpfs 510376 0510376 0% /dev/shm tmpfs tmpfs 5120 0 5120 0% /run/lock tmpfs tmpfs 510376 0510376 0% /sys/fs/cgroup tmpfs tmpfs 102076 0102076 0% /run/user/0 Base System Installation Checklist: [O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it Initial boot: [o] Detect network card:[o] Configure network: [o] Detect CD: [o] Load installer modules: [o] Clock/timezone setup: [o] User/password setup:[o] Detect hard drives: [o] Partition hard drives: [o] Install base system:[o] Install tasks: [o] Install boot loader:[E] Overall install:[E] Comments/Problems: This problem was discussed already at the debian-boot mailing-list in this thread: https://lists.debian.org/debian-boot/2016/03/msg00340.html Today I told myself, it would be a good way of officially opening a ticket for this, to report the installation inside KVM/virt-manager, now here it is. Steve McIntire suggested, I debug this myself, but I think, that really the D-I team needs to do something to fix this for everyone, so I include the verbose output of lsinitramfs [initramfs.txt.gz] and dmesg [dmesg.txt.gz], more info to come, maybe. I did another Stretch installation on a different device on Compact-Flash card in the meantime, that also worked with BTRFS-root, it's actually for trying out LXC1.1 - -- Please make sure that the hardware-summary log file, and any other installation logs that you think would be useful are attached to this report. Please compress large files using gzip. Once you have filled out this report, mail it to sub...@bugs.debian.org. == Installer lsb-release: == DISTRIB_ID=Debian DISTRIB_DESCRIPTION="Debian GNU/Linux installer" DISTRIB_RELEASE="9 (stretch) - installer build 20160328-00:05" X_INSTALLATION_MEDIUM=cdrom == Installer hardware-summary: == uname -a: Linux str-tst 4.4.0-1-amd64 #1 SMP Debian 4.4.6-1 (2016-03-17) x86_64 GNU/Linux lspci -knn: 00:00.0 Host bridge [0600]: Intel Corporation 440FX - 82441FX PMC [Natoma] [8086:1237] (rev 02) lspci -knn:Subsystem: Red Hat, Inc Device [1af4:1100] lspci -knn: 00:01.0 ISA bridge [0601]: Intel Corporation 82371SB PIIX3 ISA [Natoma/Triton II] [8086:7000] lspci -knn: Subsystem: Red Hat, Inc Device [1af4:1100] lspci -knn: 00:01.1 IDE interface [0101]: Intel Corporation 82371SB PIIX3 IDE [Natoma/Triton II] [8086:7010] lspci -knn: Subsystem: Red Hat, Inc Device [1af4:1100] lspci -knn: Kernel driver in use: ata_piix lspci -knn: Kernel modules: ata_piix, ata_generic lspci -knn: 00:01.3 Bridge [0680]: Intel Corporation 82371AB/EB/MB PIIX4 ACPI [8086:7113] (rev 03) lspci -knn:Subsystem: Red Hat, Inc Device [1af4:1100] lspci -knn: 00:02.0 VGA compatible controller [0300]: Red Hat, Inc. QXL paravirtual graphic card [1b36:0
