[darktable-dev] Feature #12145

2018-04-30 Thread Sam
Hi, I'd like to have a go at implementing Dr. Henry Dietz's fix for the
banding issue on Sony cameras as is mentioned in Feature #12145
<https://redmine.darktable.org/issues/12145> on the bug tracker. I've
emailed Dr. Henry Dietz for the source (which he says he will provide on
request) and to ask for his blessing to implement it in darktable.

I haven't worked on any projects this big before and it's been a while
since I've done any programming at all so I might be a bit slow getting it
done and I'd appreciate any suggestions.

Thanks,
Sam

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Collect images module

2018-11-05 Thread Sam
Is it not the semicolon in "An expression in the form [from*;*to] selects a
range of values." that you are referring to?

On Mon, 5 Nov 2018 at 19:50, Bruce Williams  wrote:

> Hey guys,
> I had a viewer ask me about the use of the semicolon when it comes to
> using the [Date] modifier in the Collect Images module.
>
> Section 2.3.2.1 of the manual contains the following paragraph:
> "Attributes with numerical values as well as date and time attributes can
> be used in combi-
> nation with comparative and range operators. Write <, <=, >, >=, <>, and =
> to select images
> with attributes less, less or equal, greater, greater or equal, not equal,
> or equal to the a
> given value, respectively. An expression in the form [from;to] selects a
> range of values."
>
> Which makes no reference to the semicolon as a modifier, at all. Yet, when
> you set the drop down menu to [Date], and mouse over the text field, the
> tooltip which pops up shows the semicolon as another modifier. Is this some
> left over code that needs to be removed? Or is there another use case here
> which is not documented in the manual?
>
> Cheers,
> Bruce Williams
> --
> Mobile:  +61 41 250 6349
>
> audio2u.com
> brucewilliamsphotography.com
> shuttersincpodcast.com
> sinelanguagepodcast.com
>
> e-mail  | Twitter  |
> LinkedIn  | Facebook
>  | Soundcloud
>  | Quora
> 
> --
>
>
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Collect images module

2018-11-05 Thread Sam
I took that quote from your original email, which you say is from the
manual. The [from;to] that it mentions is the same as the [;] in the
tooltip, which I assume is the semicolon that you are talking about.

On Mon, 5 Nov 2018 at 20:59, Bruce Williams  wrote:

> I don't know! Maybe. The user manual certainly makes no mention of that.
> I'll try it when I get home tonight.
> Cheers,
> Bruce Williams.
>
> On Tue., 6 Nov. 2018, 07:26 Sam 
>> Is it not the semicolon in "An expression in the form [from*;*to]
>> selects a range of values." that you are referring to?
>>
>> On Mon, 5 Nov 2018 at 19:50, Bruce Williams  wrote:
>>
>>> Hey guys,
>>> I had a viewer ask me about the use of the semicolon when it comes to
>>> using the [Date] modifier in the Collect Images module.
>>>
>>> Section 2.3.2.1 of the manual contains the following paragraph:
>>> "Attributes with numerical values as well as date and time attributes
>>> can be used in combi-
>>> nation with comparative and range operators. Write <, <=, >, >=, <>, and
>>> = to select images
>>> with attributes less, less or equal, greater, greater or equal, not
>>> equal, or equal to the a
>>> given value, respectively. An expression in the form [from;to] selects a
>>> range of values."
>>>
>>> Which makes no reference to the semicolon as a modifier, at all. Yet,
>>> when you set the drop down menu to [Date], and mouse over the text field,
>>> the tooltip which pops up shows the semicolon as another modifier. Is this
>>> some left over code that needs to be removed? Or is there another use case
>>> here which is not documented in the manual?
>>>
>>> Cheers,
>>> Bruce Williams
>>> --
>>> Mobile:  +61 41 250 6349
>>>
>>> audio2u.com
>>> brucewilliamsphotography.com
>>> shuttersincpodcast.com
>>> sinelanguagepodcast.com
>>>
>>> e-mail  | Twitter <http://twitter.com/@audio2u> |
>>> LinkedIn <http://au.linkedin.com/pub/bruce-williams/1/318/489> |
>>> Facebook <http://www.facebook.com/audio2u> | Soundcloud
>>> <http://www.soundcloud.com/audio2u> | Quora
>>> <https://www.quora.com/profile/Bruce-Williams-5>
>>> --
>>>
>>>
>>>
>>> ___
>>> darktable developer mailing list to unsubscribe send a mail to
>>> darktable-dev+unsubscr...@lists.darktable.org
>>>
>>
>> ___
>> darktable developer mailing list to unsubscribe send a mail to
>> darktable-dev+unsubscr...@lists.darktable.org
>>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Possible bug in master: Missing buttons in lighttable

2018-12-02 Thread Sam
Clicking the little white triangle at the top of the screen will show/hide
those options.

On Sun, 2 Dec 2018 at 09:13, Matej Martinovic 
wrote:

> Well, solved. Deleting darktablerc solved the problem. I have a
> feeling that it had something to do with my locale settings (I was
> messing around with them a few days ago), as darktable started with a
> different language after deleting darktablerc.
>
> BR
> Matej
> Am Sa., 1. Dez. 2018 um 22:39 Uhr schrieb Patrick Shanahan <
> p...@opensuse.org>:
> >
> > * Matej Martinovic  [12-01-18 15:11]:
> > > Hello,
> > >
> > > am I the only one missing some buttons in lighttable mode with the
> > > current master?
> > > There's no settings button, no grouping and no selection of rating...
> > >
> > > I'm using master (d25c659) through darix's package on fedora 29 with
> KDE.
> >
> > perhaps, openSUSE Tumbleweed kde/plasma5
> >   http://wahoo.no-ip.org/~paka/Screenshot_20181201_163115.png
> >
> > --
> > (paka)Patrick Shanahan   Plainfield, Indiana, USA
> @ptilopteri
> > http://en.opensuse.orgopenSUSE Community Member
> facebook/ptilopteri
> > Registered Linux User #207535@
> http://linuxcounter.net
> > Photos: http://wahoo.no-ip.org/piwigo   paka @ IRCnet
> freenode
> >
> ___
> > darktable developer mailing list
> > to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
> >
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

[darktable-dev] Full metadata editor

2019-07-22 Thread Sam
Hi,

I'd like to start working on a more complete metadata editing interface.
I've come up with two possible ways of doing this:

1) A pop up window - this gives a lot of space and flexibility to
eventually add as many different metadata-editing features as we could
possibly want.

2) Expand the current metadata editor module  - I think I could squeeze
quite a lot into there by splitting the fields up into different categories
but it could quite easily become unwieldy and hard to use.

My preference is for the first option, but it also doesn't really seem like
the darktable way of doing things so I'm interested to hear some other
people's opinions (I'm also open to any other suggestions, or opinions
about if people actually want this feature added).

Thanks,
Sam

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Full metadata editor

2019-07-24 Thread Sam
> I would advocate for a separate view for that, let's call it "digital
assets management" view.

I like this idea, but I think only having the film band makes it somewhat
awkward for selecting a bunch of images. Perhaps if it maintained the
collect images module it would be ok.

On Wed, 24 Jul 2019 at 12:02, Aurélien Pierre 
wrote:

> Hi,
>
> I have mixed feelings about the classical module approach for an EXIF
> editor. See how the tagging module already behaves… not great.
>
> Modules are good when you only have a couple of consistent options (mostly
> sliders and drop-down boxes) used to do one thing. But given that the
> sidebars can't be resized dynamically in width, and every user will have a
> different available screen height / DPI, modules are limited, and fixed
> heights are a burden.
>
> I would advocate for a separate view for that, let's call it "digital
> assets management" view. Use a film band, at the bottom of screen to sort
> and select the pictures to edit (same as the darkroom one), and take a
> full screen to put all text fields in a comfortable way. What you are
> trying to do is a text editor, mostly. You could expand the EXIF metadata
> editing with hierarchical tagging views, GPS/date overwriting, ratings and
> maybe source file path edition (for orphan pictures in the database).
>
> Let's think bigger, for this kind of feature, than just squizzing "yet
> another module" inside the already crowded lighttable.
>
> Photojournalists for news agencies/papers/stock archives only rely on the
> metadata of the pictures to get proper credits and salary, because that's
> how agencies manage their stock. Thus the tagging/metadata edition is a
> critical part of photography now (at least, for professionals), which is
> holding back a lot of guys on Lightroom, and should not be rushed into the
> easiest/fastest way the code the thing. Let's think about efficient ways to
> batch-edit metadata for large sets of pictures.
>
> Aurélien.
> Le 22/07/2019 à 18:42, philippe.weyl...@libertysurf.fr a écrit :
>
> Great !
>
>
> it should be kept within the module, as this better fits the usual 
> metadata-editing workflow.
>
> +1
>
>
> The unwieldiness might be countered by letting the user specify what set of 
> metadata keys should appear for editing.
>
> +1
> The user keys selection could be done / udapted in a pop window. To every key 
> the user should be able to select the corresponding metadata tag family 
> (exif, xmp, ...), at least the most common. But this can bring some 
> complexity too (language, ...).
>
> Philippe
>
> - Mail original -
> De: "Maurizio Paglia"  
> À: "August Schwerdfeger"  
> Cc: "darktable"  
> 
> Envoyé: Lundi 22 Juillet 2019 12:05:38
> Objet: Re: [darktable-dev] Full metadata editor
>
>
>
> Hi,
> this is very interesting!
> Sometimes I find dt panels a little restricting (i.e. the fixed dimensions do 
> not fit good for all the modules).
> Maybe the request of having panels with different dimensions could help.
> But is is possible to have each module expanded while clicking on its title?
> I mean expanded in a window exceeding the dimension of the side panel where 
> you can see ALL controls.
>
>
> To come back quickly to the original question I will prefere standard 
> behaviour instead of popup too.
>
>
> Thanks,
> Maurizio
>
>
>
> Il giorno lun 22 lug 2019 alle ore 16:56 August Schwerdfeger < 
> aug...@schwerdfeger.name > ha scritto:
>
>
>
>
> I am in favor of an expanded metadata editor, but I think it should be kept 
> within the module, as this better fits the usual metadata-editing workflow. 
> The unwieldiness might be countered by letting the user specify what set of 
> metadata keys should appear for editing.
>
>
>
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Full metadata editor

2019-07-28 Thread Sam
I've posted a draft pull request on the github page (see
https://github.com/darktable-org/darktable/pull/2819) with my hastily put
together mock up. I'd very much appreciate any input on the design/UX side,
or if you want to help me implement it let me know.

Thanks

On Wed, 24 Jul 2019 at 18:18, Pascal Obry  wrote:

> Le mercredi 24 juillet 2019 à 13:02 +0200, Aurélien Pierre a écrit :
> > I would advocate for a separate view for that, let's call it "digital
> > assets management" view. Use a film band, at the bottom of screen to
> > sort and select the pictures to edit (same as the darkroom one), and
> > take a full screen to put all text fields in a comfortable way.
>
> Why not! Looks like a good idea after all. Maybe some screen mockups
> would help design this properly.
>
> --
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable 2.6.2 - problem reading exif camera settings from dng file

2019-10-27 Thread Sam
Hi, I tried a DNG from my own phone (Google Pixel) in a dev build and it
worked fine, can you send a file so I can test one of yours.

Thanks

On Mon, 28 Oct 2019 at 14:05, Donald Walton  wrote:

> Hello,
>
> I am using darktable 2.6.2 on Linux Mint 19.2 and Windows 10. The Linux
> and Windows version of darktable are both exhibiting the same behavior.
>
> When I load the dng file from a Huawei P30 Pro, the exif camera settings
> are not displayed correctly.  The aperture shows 0.0, exposure shows
> 1/inf, and the focal length is truncated from 2.3 to 2.  Jpg files from
> the same camera are displayed correctly.
>
> Thank you for all your hard work,
>
> Don Walton
>
>
> --
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] darktable 2.6.2 - problem reading exif camera settings from dng file

2019-10-28 Thread Sam
Hi, I tried the image and had the same problem. I can see the info with
exiftool but not with exiv2 (https://github.com/Exiv2/exiv2), which is what
darktable uses to get the data so I think it's an issue on their end so
you'll probably need to report it to them.

On Mon, 28 Oct 2019 at 14:31, D Walton  wrote:

> Sam,
>
> Let's see if this works.  I am attaching it to this email.
>
> Don
>  IMG_20191027_104130.dng
> <https://drive.google.com/file/d/1LzDLyToAeiyl_r3buZrn9pMKVTIYHXug/view?usp=drive_web>
>
>
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
>  Virus-free.
> www.avast.com
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link>
> <#m_935884280021711373_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
> On Mon, Oct 28, 2019 at 1:21 PM Sam  wrote:
>
>> Hi, I tried a DNG from my own phone (Google Pixel) in a dev build and it
>> worked fine, can you send a file so I can test one of yours.
>>
>> Thanks
>>
>> On Mon, 28 Oct 2019 at 14:05, Donald Walton  wrote:
>>
>>> Hello,
>>>
>>> I am using darktable 2.6.2 on Linux Mint 19.2 and Windows 10. The Linux
>>> and Windows version of darktable are both exhibiting the same behavior.
>>>
>>> When I load the dng file from a Huawei P30 Pro, the exif camera settings
>>> are not displayed correctly.  The aperture shows 0.0, exposure shows
>>> 1/inf, and the focal length is truncated from 2.3 to 2.  Jpg files from
>>> the same camera are displayed correctly.
>>>
>>> Thank you for all your hard work,
>>>
>>> Don Walton
>>>
>>>
>>> --
>>> This email has been checked for viruses by Avast antivirus software.
>>> https://www.avast.com/antivirus
>>>
>>>
>>> ___
>>> darktable developer mailing list
>>> to unsubscribe send a mail to
>>> darktable-dev+unsubscr...@lists.darktable.org
>>>
>>>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] darktable 2.6.2 - problem reading exif camera settings from dng file

2019-10-28 Thread Sam
I thought there might be a way to export the data with exiftool and
re-import it with exiv2 but I haven't found a way to do that. I haven't
dealt with the exiv2 team so I don't know how likely you are to get help
from them, and I don't know anything about different dng standards sorry.

Also I realised I replied that large file into the mailing list, I'm not
sure if it's going to fill up people's inboxes because I think it's just a
drive link but I'm sorry if I caused any problems guys.

On Mon, 28 Oct 2019 at 15:11, Donald Walton  wrote:

> Sam,
>
> As an additional data point, Adobe Lightroom doesn't have a problem
> reading the exif data from the Huawei dng files.  That would lead me to
> believe that Huawei implemented their version of the dng file so that it
> is compatible with Adobe's dng standard.  Do you have any thoughts on this?
>
> Thanks,
> Don
>
> On 10/28/2019 14:01, Sam wrote:
> > Hi, I tried the image and had the same problem. I can see the info with
> > exiftool but not with exiv2 (https://github.com/Exiv2/exiv2), which is
> what
> > darktable uses to get the data so I think it's an issue on their end so
> > you'll probably need to report it to them.
> >
> > On Mon, 28 Oct 2019 at 14:31, D Walton  wrote:
> >
> >> Sam,
> >>
> >> Let's see if this works.  I am attaching it to this email.
> >>
> >> Don
> >>   IMG_20191027_104130.dng
> >> <
> https://drive.google.com/file/d/1LzDLyToAeiyl_r3buZrn9pMKVTIYHXug/view?usp=drive_web
> >
> >>
> >>
> >> <
> https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon>
> Virus-free.
> >> www.avast.com
> >> <
> https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
> >
> >> <#m_935884280021711373_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> >>
> >> On Mon, Oct 28, 2019 at 1:21 PM Sam  wrote:
> >>
> >>> Hi, I tried a DNG from my own phone (Google Pixel) in a dev build and
> it
> >>> worked fine, can you send a file so I can test one of yours.
> >>>
> >>> Thanks
> >>>
> >>> On Mon, 28 Oct 2019 at 14:05, Donald Walton 
> wrote:
> >>>
> >>>> Hello,
> >>>>
> >>>> I am using darktable 2.6.2 on Linux Mint 19.2 and Windows 10. The
> Linux
> >>>> and Windows version of darktable are both exhibiting the same
> behavior.
> >>>>
> >>>> When I load the dng file from a Huawei P30 Pro, the exif camera
> settings
> >>>> are not displayed correctly.  The aperture shows 0.0, exposure shows
> >>>> 1/inf, and the focal length is truncated from 2.3 to 2.  Jpg files
> from
> >>>> the same camera are displayed correctly.
> >>>>
> >>>> Thank you for all your hard work,
> >>>>
> >>>> Don Walton
> >>>>
> >>>>
> >>>> --
> >>>> This email has been checked for viruses by Avast antivirus software.
> >>>> https://www.avast.com/antivirus
> >>>>
> >>>>
> >>>>
> ___
> >>>> darktable developer mailing list
> >>>> to unsubscribe send a mail to
> >>>> darktable-dev+unsubscr...@lists.darktable.org
> >>>>
> >>>>
>
>
> --
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] UI glitches → Buttons and stuff

2019-11-06 Thread Sam
I've added fixes to a couple of these to my pull request here.


On Thu, 7 Nov 2019 at 14:36, Timur Irikovich Davletshin <
timur.davlets...@gmail.com> wrote:

> Good morning developers!
>
> There are number of glitches I noticed in UI:
>
> 1. Tethering shooting (width1.png) → Camera settings is too narrow,
> doesn't take all available space.
> 2. Number of button issues (buttons1.png) like non full-width closing
> button in lighttable → select. Hovering buttons in lighttable →
> tagging, lighttable → metadata editor changes button's width, while it
> works fine in other places.
> 3. Reverse vs. straight button order (buttons2.png and buttons3.png).
> Looks like we're more gnome stuff and use reverse button order, so
> "edit metadata exportation" window should be fixed.
>
> Thanks in advance,
>
> Timur.
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] UI glitches → Buttons and stuff

2019-11-10 Thread Sam
Hey Timur, I opened an issue on github for this
<https://github.com/darktable-org/darktable/issues/3359>, but it seems like
it's just you and I that see this so I was wondering what OS and maybe DE
you're using?

Thanks

On Fri, 8 Nov 2019 at 02:49, Timur Irikovich Davletshin <
timur.davlets...@gmail.com> wrote:

> Buttons in following darkroom modules require fixing too:
>
> vignetting, rgb levels, levels, color mapping, basic adjustments.
>
> Timur.
>
> On Thu, 2019-11-07 at 15:09 +0800, Sam wrote:
> > I've added fixes to a couple of these to my pull request here.
> >
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org