Re: [PATCH] Implement sigtimedwait (revised)
Hi Mark, On Dec 14 17:05, Mark Geisert wrote: > Abstract out common code from sigwait/sigwaitinfo/sigtimedwait to implement > the latter. > --- > winsup/cygwin/common.din | 1 + > winsup/cygwin/include/cygwin/version.h | 3 ++- > winsup/cygwin/signal.cc| 36 > -- > winsup/cygwin/thread.cc| 2 +- > winsup/doc/posix.xml | 2 +- > 5 files changed, 39 insertions(+), 5 deletions(-) as I wrote on Friday, the patch looks good to me. I just need a contributors license agreement from you per the "Before you get started" section on https://cygwin.com/contrib.html Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature
Re: [PATCH] Implement sigtimedwait (revised)
On Mon, 18 Dec 2017, Corinna Vinschen wrote: Hi Mark, [...] as I wrote on Friday, the patch looks good to me. I just need a contributors license agreement from you per the "Before you get started" section on https://cygwin.com/contrib.html Hi Corinna, Y'all should have one from me on file already. Back in Feb/Mar 2016 I did some work on the gmon profiler and documentation for same. I can re-send the agreement if needed. ..mark
Re: [PATCH] Implement sigtimedwait (revised)
On Dec 18 01:34, Mark Geisert wrote: > On Mon, 18 Dec 2017, Corinna Vinschen wrote: > > Hi Mark, > [...] > > as I wrote on Friday, the patch looks good to me. I just need a > > contributors license agreement from you per the "Before you get started" > > section on https://cygwin.com/contrib.html > > Hi Corinna, > Y'all should have one from me on file already. Back in Feb/Mar 2016 I did > some work on the gmon profiler and documentation for same. I can't find it, neither on cygwin-developers nor on cygwin-patches. AFAICS, I missed to ask you for one back in 2016. > I can re-send the agreement if needed. Yes, please. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature
Re: [PATCH] Implement sigtimedwait (revised)
On 2017-12-18 04:48, Corinna Vinschen wrote: > On Dec 18 01:34, Mark Geisert wrote: >> On Mon, 18 Dec 2017, Corinna Vinschen wrote: >>> Hi Mark, >> [...] >>> as I wrote on Friday, the patch looks good to me. I just need a >>> contributors license agreement from you per the "Before you get started" >>> section on https://cygwin.com/contrib.html >> >> Hi Corinna, >> Y'all should have one from me on file already. Back in Feb/Mar 2016 I did >> some work on the gmon profiler and documentation for same. > > I can't find it, neither on cygwin-developers nor on cygwin-patches. > AFAICS, I missed to ask you for one back in 2016. It was sent through the old process in February 2016. -- Yaakov signature.asc Description: OpenPGP digital signature
Re: [PATCH] Implement sigtimedwait (revised)
On Dec 18 11:07, Yaakov Selkowitz wrote: > On 2017-12-18 04:48, Corinna Vinschen wrote: > > On Dec 18 01:34, Mark Geisert wrote: > >> On Mon, 18 Dec 2017, Corinna Vinschen wrote: > >>> Hi Mark, > >> [...] > >>> as I wrote on Friday, the patch looks good to me. I just need a > >>> contributors license agreement from you per the "Before you get started" > >>> section on https://cygwin.com/contrib.html > >> > >> Hi Corinna, > >> Y'all should have one from me on file already. Back in Feb/Mar 2016 I did > >> some work on the gmon profiler and documentation for same. > > > > I can't find it, neither on cygwin-developers nor on cygwin-patches. > > AFAICS, I missed to ask you for one back in 2016. > > It was sent through the old process in February 2016. I didn't expect that, duh. Thanks for pulling this fact from history. I patched the CONTRIBUTORS file accordingly. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature
Re: [PATCH] Implement sigtimedwait (revised)
On Dec 14 17:05, Mark Geisert wrote: > Abstract out common code from sigwait/sigwaitinfo/sigtimedwait to implement > the latter. > --- > winsup/cygwin/common.din | 1 + > winsup/cygwin/include/cygwin/version.h | 3 ++- > winsup/cygwin/signal.cc| 36 > -- > winsup/cygwin/thread.cc| 2 +- > winsup/doc/posix.xml | 2 +- > 5 files changed, 39 insertions(+), 5 deletions(-) Patch pushed. I added a small change on top, converting sigwait_common to an inline function. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature
