Re: cvs commit: ports/devel/pcsc-lite Makefile

2012-06-15 Thread Tilman Keskinöz
* Sunpoet Po-Chuan Hsieh [Fri, 15 Jun 2012 00:30:53 +0800]:

> On Fri, Jun 08, 2012 at 03:28:50PM +, Tilman Keskinoz wrote:
>> arved   2012-06-08 15:28:50 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>> devel/pcsc-lite  Makefile 
>>   Log:
>>   Convert WITH_ style option to optionsng
>>   
>>   Revision  ChangesPath
>>   1.61  +10 -12ports/devel/pcsc-lite/Makefile
> 
> Hi,
> 
> The transition to new options framework is incorrect.
> OPTIONS* was processed by bsd.options.mk.
> Therefore OPTIONS* should be defined before the inclusion of bsd.port.pre.mk.
> 

Since OSVERSION is defined in bsd.port.pre.mk it is not possible to just
move the OPTIONS before bsd.port.pre.mk.

Do you have a suggestion how this can be done? Or should the commit
reverted?

regards
arved
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: [ports] cvs commit: ports/devel/rubygem-daemons Makefile distinfo

2012-01-27 Thread Tilman Keskinöz
* Philip M. Gollucci [Tue, 20 Dec 2011 05:11:02 + (UTC)]:
> pgollucci2011-12-20 05:10:43 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
> devel/rubygem-daemons Makefile distinfo 
>   Log:
>   - Update to 1.1.5
>   
>   With Hat:   ruby@
>   Sponsored by:   RideCharge Inc. / TaxiMagic

Is there a reason, that this port installs so many world-writable
files?

===>   Registering installation for rubygem-daemons-1.1.5
===> SECURITY REPORT:
  This port has installed the following world-writable
files/directories.
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/LICENSE
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/TODO
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_keep_pid_files.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/application.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_monitor.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_crash.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pidmem.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/cmdline.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pid.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/change_privilege.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/call/call.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/etc_extension.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/setup.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc_simple.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/monitor.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_exit.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pidfile.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/README
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/call/call_monitor.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/Releases
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/daemonize/daemonize.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/application_group.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_hanging.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_crashing.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_exec.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/daemonize.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_optionparser.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_ontop.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/controller.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_hanging.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc_multiple.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_exiting.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_multiple.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_normal.rb
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/Rakefile
/usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/exceptions.rb



___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: [ports] cvs commit: ports/devel/rubygem-daemons Makefile distinfo

2012-01-27 Thread Tilman Keskinöz
If there is no reason, the port should be either fixed, or the commit backed 
out!

On Jan 27, 2012, at 18:39 , Philip M. Gollucci wrote:

> You'd have to ask the gem author.  Nothing is jumping out at me in the code.
> 
> 
> 
> On 01/27/12 15:35, Tilman Keskinöz wrote:
>> * Philip M. Gollucci [Tue, 20 Dec 2011 05:11:02 + (UTC)]:
>>> pgollucci2011-12-20 05:10:43 UTC
>>> 
>>>  FreeBSD ports repository
>>> 
>>>  Modified files:
>>>devel/rubygem-daemons Makefile distinfo 
>>>  Log:
>>>  - Update to 1.1.5
>>> 
>>>  With Hat:   ruby@
>>>  Sponsored by:   RideCharge Inc. / TaxiMagic
>> 
>> Is there a reason, that this port installs so many world-writable
>> files?
>> 
>> ===>   Registering installation for rubygem-daemons-1.1.5
>> ===> SECURITY REPORT:
>>  This port has installed the following world-writable
>> files/directories.
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/LICENSE
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/TODO
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_keep_pid_files.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/application.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_monitor.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_crash.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pidmem.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/cmdline.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pid.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/change_privilege.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/call/call.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/etc_extension.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/setup.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc_simple.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/monitor.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_exit.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/pidfile.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/README
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/call/call_monitor.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/Releases
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/daemonize/daemonize.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/application_group.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_hanging.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_crashing.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_exec.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/daemonize.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_optionparser.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_ontop.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/controller.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_hanging.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_proc_multiple.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/myserver_exiting.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_multiple.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/examples/run/ctrl_normal.rb
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/Rakefile
>> /usr/local/lib/ruby/gems/1.8/gems/daemons-1.1.5/lib/daemons/exceptions.rb
>> 
> 
> 
> -- 
> 
> 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
> Philip M. Gollucci (pgollu...@p6m7g8.com) c: 703.336.9354
> Member,   Apache Software Foundation
> Committer,FreeBSD Foundation
> Consultant,   P6M7G8 Inc.
> Director Operations,  Ridecharge Inc.
> 
> Work like you don't need the money,
> love like you'll never get hurt,
> and dance like nobody's watching.
> 

___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: [ports] cvs commit: ports/devel/rubygem-daemons Makefile distinfo

2012-01-29 Thread Tilman Keskinöz

On Jan 28, 2012, at 20:22 , Philip M. Gollucci wrote:

> On 1/28/12 1:52 AM, Tilman Keskinöz wrote:
>> If there is no reason, the port should be either fixed, or the commit backed 
>> out!
> This is not a unique problem among gems.  Lots of them screw up umasks on 
> install.  Some too restrictive, some overly lax.

The committer committing the patch is responsible for testing the port for 
screw ups.

No port should install world-writable scripts or executables. This is a 
security issue. Again i ask you to fix the port or backout your commit.

In the old days, Kris processed the pointyhat logs for these issues[1]. Maybe 
someone with access to the pointyhat logs can do this again?

Also how about introducing a Makefile variable "WORLDWRITABLE_FILES" for the 
highscore files and aborting the install if a file is not mentioned in this 
variable.

[1] e.g. 
http://lists.freebsd.org/pipermail/freebsd-ports/2006-September/035115.html___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: cvs commit: ports/korean/a2ps Makefile ports/japanese/ack Makefile ports/games/anagramarama Makefile ports/korean/bitchx Makefile ports/net/callgen323 Makefile ports/japanese/chimera Makefile port

2011-06-18 Thread Tilman Keskinöz

On Jun 17, 2011, at 20:22 , Philip M. Gollucci wrote:

> On 06/17/11 13:09, Baptiste Daroussin wrote:
>>mail/cvsmail Makefile 
> Doesn't every committer use this ?

People with FreeBSD.org account can use dfilter, which is using less resources,
but all other contributers can use cvsmail.

It definitely should not be 
deleted.___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: [ports] cvs commit: ports/x11-wm/icewm Makefile

2011-07-18 Thread Tilman Keskinöz
Have you been in contact with Eitan, the old maintainer?

In ports/158949 he is still trying to fix the problem.

On 07/18/2011 06:25 PM, Cy Schubert wrote:
> cy  2011-07-18 16:25:20 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
> x11-wm/icewm Makefile 
>   Log:
>   Mark BROKEN when GNOMEDESKTOP is selected.
>   
>   Assume maintainership.
>   
>   Revision  ChangesPath
>   1.151 +2 -1  ports/x11-wm/icewm/Makefile
> ___
> cvs-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
> 
> 
> Index: ports/x11-wm/icewm/Makefile
> diff -u ports/x11-wm/icewm/Makefile:1.150 ports/x11-wm/icewm/Makefile:1.151
> --- ports/x11-wm/icewm/Makefile:1.150 Mon Apr 25 19:48:41 2011
> +++ ports/x11-wm/icewm/Makefile   Mon Jul 18 16:25:20 2011
> @@ -11,7 +11,7 @@
>  CATEGORIES=  x11-wm
>  MASTER_SITES=
> SF/${PORTNAME}/${PORTNAME}-${PORTVERSION:R}/${PORTVERSION}/
>  
> -MAINTAINER=  po...@eitanadler.com
> +MAINTAINER=  c...@eitanadler.com
>  COMMENT= Window Manager designed for speed, usability and consistency
>  
>  WANT_GNOME=  yes
> @@ -42,6 +42,7 @@
>  .include 
>  
>  .if defined(WITH_GNOMEDESKTOP)
> +BROKEN=  fails to install
>  USE_GNOME+=  gnomedesktop
>  CONFIGURE_ARGS+=--enable-menus-gnome2
>  INSTALL_TARGET=  install install-gnome

___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"


Re: cvs commit: ports/textproc Makefile ports/textproc/ack Makefile distinfo pkg-descr pkg-plist

2011-08-09 Thread Tilman Keskinöz
On 08/09/2011 03:53 PM, Matthew D. Fuller wrote:
>>   Added files:
>> textproc/ack Makefile distinfo pkg-descr pkg-plist 
> 
> What's the difference from textproc/p5-ack?

This is the second time someone tries to add it (the other one was
sysutils/ack
http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/ack/Attic/ ),

Maybe this is a hint that the name p5-ack is not where people expect to
find it and we should move p5-ack to ack
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"