cvs commit: src/sbin/mount_msdosfs mount_msdosfs.c

2005-11-23 Thread Tai-hwa Liang
avatar  2005-11-23 19:52:14 UTC

  FreeBSD src repository

  Modified files:
sbin/mount_msdosfs   mount_msdosfs.c 
  Log:
  - Adding the missing 'W' option back which was accidentally removed
in rev1.37.
  - Fixing a core dump inside build_iovec_argf by providing a !NULL format
string to vsnprintf(3).
  
  Reviewed by:rodrigc
  
  Revision  ChangesPath
  1.39  +2 -2  src/sbin/mount_msdosfs/mount_msdosfs.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sbin/mount mount.c

2005-11-24 Thread Tai-hwa Liang
avatar  2005-11-24 17:35:05 UTC

  FreeBSD src repository

  Modified files:
sbin/mount   mount.c 
  Log:
  Fixing a regression introduced in rev1.72 by connecting cd9660 to the
  external mounting program list as well; otherwise, entry like the following
  in /etc/fstab wouldn't work:
  
  /dev/acd0   /mnt/cdrom  cd9660  ro,-C=big5  0   0
  
  Reviewed by:rodrigc
  
  Revision  ChangesPath
  1.76  +1 -1  src/sbin/mount/mount.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sbin/mount_cd9660 mount_cd9660.c

2005-11-25 Thread Tai-hwa Liang
avatar  2005-11-25 19:48:53 UTC

  FreeBSD src repository

  Modified files:
sbin/mount_cd9660mount_cd9660.c 
  Log:
  It turns out that set_charset() invokes build_iovec() which modifies
  iov address internally through realloc(3).  However, since the function
  parameter wasn't designed to allow the modified iov being passed back to
  the caller, we end up feeding iov with several corrupted entries(depends on
  how many arguments were pushed into iovec before set_charset()) to nmount(2).
  
  This commit fixes this regression introduced in rev1.31 such that
  mount_cd9660(8) with code page conversion option(-C) enabled works again.
  
  Reviewed by:rodrigc
  
  Revision  ChangesPath
  1.32  +5 -5  src/sbin/mount_cd9660/mount_cd9660.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sbin/mount_msdosfs mount_msdosfs.c

2005-11-25 Thread Tai-hwa Liang
avatar  2005-11-25 19:55:14 UTC

  FreeBSD src repository

  Modified files:
sbin/mount_msdosfs   mount_msdosfs.c 
  Log:
  It turns out that set_charset() invokes build_iovec_argf() which modifies
  iov address internally through realloc(3).  However, since the function
  parameter wasn't designed to allow the modified iov being passed back to
  the caller, we ended up feeding iov with several corrupted entries(this
  depends on how many arguments were pushed into iovec before set_charset())
  to nmount(2).
  
  This commit fixes this regression introduced in rev1.37 such that
  mount_msdosfs(8) with code page conversion option(-W,-D) enabled works again.
  
  Reviewed by:rodrigc
  
  Revision  ChangesPath
  1.40  +6 -6  src/sbin/mount_msdosfs/mount_msdosfs.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sbin/mount_msdosfs mount_msdosfs.c

2005-11-30 Thread Tai-hwa Liang
avatar  2005-12-01 00:18:48 UTC

  FreeBSD src repository

  Modified files:
sbin/mount_msdosfs   mount_msdosfs.c 
  Log:
  Fixing yet another regression introduced in rev1.37 by preserving cs_local
  pointer such that local to DOS code page conversion with combined option
  '-L,-D' works again.
  
  Reviewed by:rodrigc
  
  Revision  ChangesPath
  1.41  +1 -0  src/sbin/mount_msdosfs/mount_msdosfs.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/fs/smbfs smbfs_vfsops.c

2005-12-05 Thread Tai-hwa Liang
avatar  2005-12-05 19:05:06 UTC

  FreeBSD src repository

  Modified files:
sys/fs/smbfs smbfs_vfsops.c 
  Log:
  Recent nmount(2) adoption in mount_smbfs(8) did not flag the "long" option
  since mount_smbfs(8) assumed long name mounting by default unless "-n long"
  was explicitly specified.
  
  Rather than supplying a "long" option in mount_smbfs(8), this commit brings
  back the original behaviour by associating SMBFS_MOUNT_NO_LONG with the
  "nolong" option.  This should fix the broken long file names on smbfs people
  observed recently.
  
  Reported by:Vladimir Grebenschikov 
  Reviewed by:phk
  Tested by:  Slawa Olhovchenkov 
  
  Revision  ChangesPath
  1.38  +1 -3  src/sys/fs/smbfs/smbfs_vfsops.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sbin/mount_cd9660 mount_cd9660.c

2005-12-18 Thread Tai-hwa Liang
avatar  2005-12-19 05:52:38 UTC

  FreeBSD src repository

  Modified files:
sbin/mount_cd9660mount_cd9660.c 
  Log:
  Fixing multi-session disc mount by passing the correct "ssector" option
  to the kernel.
  
  Submitted by:   Enache Adrian 
  
  Revision  ChangesPath
  1.33  +1 -1  src/sbin/mount_cd9660/mount_cd9660.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/cardbus cardbus_cis.c

2005-12-30 Thread Tai-hwa Liang
avatar  2005-12-31 01:45:40 UTC

  FreeBSD src repository

  Modified files:
sys/dev/cardbus  cardbus_cis.c 
  Log:
  Fixing build bustage.
  
  Revision  ChangesPath
  1.56  +1 -1  src/sys/dev/cardbus/cardbus_cis.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/tools/regression/msdosfs msdosfstest-6.sh

2005-12-31 Thread Tai-hwa Liang
avatar  2006-01-01 01:28:32 UTC

  FreeBSD src repository

  Added files:
tools/regression/msdosfs msdosfstest-6.sh 
  Log:
  Adding another multi-byte characters related regression test for recent
  nmount(2) adoption.
  
  Revision  ChangesPath
  1.1   +22 -0 src/tools/regression/msdosfs/msdosfstest-6.sh (new)
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/kern kern_mutex.c

2006-01-06 Thread Tai-hwa Liang
avatar  2006-01-07 02:07:08 UTC

  FreeBSD src repository

  Modified files:
sys/kern kern_mutex.c 
  Log:
  Trying to fix compilation bustage introduced in rev1.160 by converting
  a missing lo_class to LO_CLASSINDEX().
  
  Revision  ChangesPath
  1.161 +1 -1  src/sys/kern/kern_mutex.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/modules/if_gif Makefile

2006-01-28 Thread Tai-hwa Liang
avatar  2006-01-29 07:46:27 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_5)
sys/modules/if_gif   Makefile 
  Log:
  MFC: (1.4, 1.5) Allow the gif module to be built without IPv6 support when
  NOINET6 is defined.
  
  Revision  ChangesPath
  1.3.8.1   +6 -1  src/sys/modules/if_gif/Makefile
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-02-04 Thread Tai-hwa Liang
avatar  2006-02-04 08:07:00 UTC

  FreeBSD src repository

  Modified files:
.ObsoleteFiles.inc 
  Log:
  s/bin/sbin/ for mount_nwfs, mount_portalfs and mount_smbfs.  They never
  lived in bin since 1994.
  Whilst here, also document the removal time of aforementioned utilities
  as well.
  
  MFC after:  1 week
  
  Revision  ChangesPath
  1.27  +4 -3  src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-02-15 Thread Tai-hwa Liang
avatar  2006-02-16 07:25:23 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
.ObsoleteFiles.inc 
  Log:
  MFC: (1.27) s/bin/sbin/ for mount_nwfs, mount_portalfs and mount_smbfs.
  Also document the removal time of these utilities.
  
  Approved by:re (scottl)
  
  Revision  ChangesPath
  1.25.2.3  +4 -3  src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/compat/linux linux_misc.c

2006-03-27 Thread Tai-hwa Liang
avatar  2006-03-27 23:27:11 UTC

  FreeBSD src repository

  Modified files:
sys/compat/linux linux_misc.c 
  Log:
  Unbreaking build by removing a now unused variable.
  
  Revision  ChangesPath
  1.177 +0 -1  src/sys/compat/linux/linux_misc.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/modules/if_gif Makefile

2006-05-15 Thread Tai-hwa Liang
avatar  2006-05-15 23:27:01 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_4)
sys/modules/if_gif   Makefile 
  Log:
  MFC: (1.4, 1.5) Allow the gif module to be built without IPv6 support when
  NOINET6 is defined.
  
  Revision  ChangesPath
  1.1.2.2   +6 -1  src/sys/modules/if_gif/Makefile
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/wi if_wi.c

2006-06-05 Thread Tai-hwa Liang
avatar  2006-06-05 22:59:14 UTC

  FreeBSD src repository

  Modified files:
sys/dev/wi   if_wi.c 
  Log:
  Fixing a typo in rev1.196.
  
  Revision  ChangesPath
  1.197 +1 -1  src/sys/dev/wi/if_wi.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/wi if_wi.c

2006-06-05 Thread Tai-hwa Liang
avatar  2006-06-05 23:06:03 UTC

  FreeBSD src repository

  Modified files:
sys/dev/wi   if_wi.c 
  Log:
  Really fix the typo this time: it should be sc->sc_drvbpf to be verified,
  not ic->ic_drvbpf.
  
  Revision  ChangesPath
  1.198 +1 -1  src/sys/dev/wi/if_wi.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-08-21 Thread Tai-hwa Liang
avatar  2006-08-21 14:42:58 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
.ObsoleteFiles.inc 
  Log:
  MFC (1.40, 1.41): Adding more antiques came from the RELENG_4(or prior) era:
  sbin/nfsd, sbin/mount_portal and sbin/kget.
  
  Revision  ChangesPath
  1.25.2.5  +8 -0  src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/etc/rc.d ppp

2006-10-25 Thread Tai-hwa Liang
avatar  2006-10-26 00:29:43 UTC

  FreeBSD src repository

  Modified files:
etc/rc.d ppp 
  Log:
  Re-sync'ing pf rules in post command as we already did for ipfilter.
  
  With this patch, pf rules with dynamically created devices such like tun0
  works without further intervention.
  
  Reviewed by:mlaier
  MFC after:  3 days
  
  Revision  ChangesPath
  1.12  +2 -1  src/etc/rc.d/ppp
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/etc/rc.d ppp

2006-10-30 Thread Tai-hwa Liang
avatar  2006-10-31 03:29:27 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
etc/rc.d ppp 
  Log:
  MFC (1.12): Re-sync'ing pf rules in post command as we already did for
  ipfilter.
  
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.11.2.2  +2 -1  src/etc/rc.d/ppp
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-07-07 Thread Tai-hwa Liang
avatar  2006-07-08 03:18:41 UTC

  FreeBSD src repository

  Modified files:
.ObsoleteFiles.inc 
  Log:
  Adding more antiques came from the RELENG_4(or prior) era: sbin/nfsd,
  sbin/mount_portal and sbin/kget.
  
  MFC after:  1 month
  
  Revision  ChangesPath
  1.40  +9 -0  src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-07-07 Thread Tai-hwa Liang
avatar  2006-07-08 03:22:44 UTC

  FreeBSD src repository

  Modified files:
.ObsoleteFiles.inc 
  Log:
  Oops, it is sbin/nfsd that was removed, not the man page.
  
  MFC after:  1 month
  
  Revision  ChangesPath
  1.41  +0 -1  src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/net if_ethersubr.c if_gif.c

2006-07-26 Thread Tai-hwa Liang
avatar  2006-07-27 03:50:38 UTC

  FreeBSD src repository

  Modified files:
sys/net  if_ethersubr.c if_gif.c 
  Log:
  Fixing compilation bustage: net/if_bridgevar.h depends on net/bridgestp.h.
  
  Revision  ChangesPath
  1.216 +1 -0  src/sys/net/if_ethersubr.c
  1.63  +1 -0  src/sys/net/if_gif.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/netgraph ng_ether.c

2006-07-26 Thread Tai-hwa Liang
avatar  2006-07-27 06:15:37 UTC

  FreeBSD src repository

  Modified files:
sys/netgraph ng_ether.c 
  Log:
  Fixing compilation bustage: net/if_bridgevar.h depends on net/bridgestp.h.
  
  Revision  ChangesPath
  1.59  +1 -0  src/sys/netgraph/ng_ether.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/wi if_wi.c

2006-08-01 Thread Tai-hwa Liang
avatar  2006-08-01 07:37:22 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
sys/dev/wi   if_wi.c 
  Log:
  MFC: (1.191) Fix "taskqueue_drain with the following non-sleepable locks
  held" witness(9) warning on detach.
  
  Ok'ed by:   ru
  Tested on:  6-STABLE
  
  Revision   ChangesPath
  1.180.2.8  +1 -1  src/sys/dev/wi/if_wi.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/nlm nlm_prot_impl.c

2008-06-27 Thread Tai-hwa Liang
avatar  2008-06-27 15:29:48 UTC

  FreeBSD src repository

  Modified files:
sys/nlm  nlm_prot_impl.c 
  Log:
  SVN rev 180069 on 2008-06-27 15:29:48Z by avatar
  
  Fixing NO_INET6 build.
  
  Revision  ChangesPath
  1.11  +4 -1  src/sys/nlm/nlm_prot_impl.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/netinet in_pcb.c in_pcb.h

2008-07-21 Thread Tai-hwa Liang
avatar  2008-07-22 04:23:57 UTC

  FreeBSD src repository

  Modified files:
sys/netinet  in_pcb.c in_pcb.h 
  Log:
  SVN rev 180683 on 2008-07-22 04:23:57Z by avatar
  
  Trying to fix compilation bustage:
  - removing 'const' qualifier from an input parameter to conform to the type
required by rw_assert();
  - using in_addr->s_addr to retrive 32 bits address value.
  
  Observed by:tinderbox
  
  Revision  ChangesPath
  1.214 +3 -3  src/sys/netinet/in_pcb.c
  1.113 +1 -1  src/sys/netinet/in_pcb.h
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c

2007-09-10 Thread Tai-hwa Liang
avatar  2007-09-10 12:53:34 UTC

  FreeBSD src repository

  Modified files:
sys/dev/an   if_an.c 
  Log:
  Fixing invalid channel display in ifconfig(8) by implementing required
  ioctl().
  
  Note that other information provided by ifconfig(8) such like "list chan"
  or "list ap" are still not available at this moment.
  
  Before an(4) is connected to wlan(4), users are encouraged to use
  ancontrol(8) to retrieve aforementioned information.
  
  Reported by:dhw 
(http://lists.freebsd.org/pipermail/freebsd-current/2007-July/074848.html)
  Reviewed by:ambrisko
  Tested by:  dhw
  Approved by:re (bmah)
  
  Revision  ChangesPath
  1.84  +17 -0 src/sys/dev/an/if_an.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c if_anreg.h

2007-11-16 Thread Tai-hwa Liang
avatar  2007-11-16 11:22:18 UTC

  FreeBSD src repository

  Modified files:
sys/dev/an   if_an.c if_anreg.h 
  Log:
  MFP4(128855, 129015):
  - Trying to eliminate another racing by replacing the timeout(9) with
callout APIs.  In addition to that, the callout_drain() in an_detach()
help us to avoid a possible panic-on-free due to the callout API tries
to lock a destroyed mutex.
  - In an_stats_update(), check the return value of an_read_record(). This
should reduce the chance of device removal(PCCARD) panic [2].
  - Adding a comment to state the fact that an_stats_update() is now called
via callout(9) with a lock held [2].
  
  Submitted by:   jhb [1], ambrisko [2]
  Reviewed by:jhb, ambrisko
  Reported by:dhw
  Tested by:  dhw
  MFC after:  3 days
  
  Revision  ChangesPath
  1.85  +17 -10src/sys/dev/an/if_an.c
  1.24  +1 -1  src/sys/dev/an/if_anreg.h
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c if_anreg.h

2007-11-20 Thread Tai-hwa Liang
avatar  2007-11-21 06:37:40 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_7)
sys/dev/an   if_an.c if_anreg.h 
  Log:
  MFC(if_an.c:1.85, if_anreg.h:1.24): Trying to eliminate a racing as well as
  reducing the chance of device removal(PCCARD) panic by replacing the
  timeout(9) with callout(9) APIs.
  
  Tested by:  dhw
  Approved by:re (kensmith)
  MFC after:  3 days
  
  Revision   ChangesPath
  1.84.2.1   +17 -10src/sys/dev/an/if_an.c
  1.23.10.1  +1 -1  src/sys/dev/an/if_anreg.h
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/usr.bin/tail read.c

2007-11-21 Thread Tai-hwa Liang
avatar  2007-11-22 01:51:46 UTC

  FreeBSD src repository

  Modified files:
usr.bin/tail read.c 
  Log:
  Nuking the temporary pointer once it is properly tracked in local storage.
  This should fix the double free() bug where there's no tailing newline(\n)
  character:
  
  current# echo -n test | tail
  testAssertion failed: (run->magic == ARENA_RUN_MAGIC), function
  arena_dalloc, file /usr/src/lib/libc/stdlib/malloc.c, line 2448.
  Abort (core dumped)
  
  Reviewed by:kib
  MFC after:  3 days
  
  Revision  ChangesPath
  1.14  +1 -0  src/usr.bin/tail/read.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c if_anreg.h

2007-11-27 Thread Tai-hwa Liang
avatar  2007-11-27 08:11:13 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
sys/dev/an   if_an.c if_anreg.h 
  Log:
  MFC(if_an.c:1.85, if_anreg.h:1.24): Trying to eliminate a racing as well as
  reducing the chance of device removal(PCCARD) panic by replacing the
  timeout(9) with callout(9) APIs.
  
  Tested by:  dhw
  Approved by:re (gnn)
  
  Revision  ChangesPath
  1.67.2.3  +13 -10src/sys/dev/an/if_an.c
  1.23.2.1  +1 -1  src/sys/dev/an/if_anreg.h
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c if_anreg.h

2007-11-27 Thread Tai-hwa Liang
avatar  2007-11-27 08:22:37 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6_3)
sys/dev/an   if_an.c if_anreg.h 
  Log:
  MFC(if_an.c:1.85, if_anreg.h:1.24): Trying to eliminate a racing as well as
  reducing the chance of device removal(PCCARD) panic by replacing the
  timeout(9) with callout(9) APIs.
  
  Approved by:re (gnn)
  
  Revision  ChangesPath
  1.67.2.2.8.1  +13 -10src/sys/dev/an/if_an.c
  1.23.12.1 +1 -1  src/sys/dev/an/if_anreg.h
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c

2007-11-27 Thread Tai-hwa Liang
avatar  2007-11-27 08:29:24 UTC

  FreeBSD src repository

  Modified files:
sys/dev/an   if_an.c 
  Log:
  MFP4(129048): Eliminating an unnecessary check on an_gone inside
  an_stats_update() since a properly locked callout_stop(9) does do the
  right thing.
  
  Reviewed by:ambrisko, jhb
  MFC after:  3 days
  
  Revision  ChangesPath
  1.86  +0 -4  src/sys/dev/an/if_an.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/usr.bin/tail read.c

2007-11-28 Thread Tai-hwa Liang
avatar  2007-11-29 03:50:55 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_7)
usr.bin/tail read.c 
  Log:
  MFC(1.14): Fixing a double free bug which will cause tail to dump core when
  there's no tailing newline(\n) character.
  
  PR: bin/118267
  Reviewed by:kib
  Approved by:re (kensmith)
  
  Revision   ChangesPath
  1.11.10.2  +1 -0  src/usr.bin/tail/read.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/usr.bin/tail read.c

2007-11-28 Thread Tai-hwa Liang
avatar  2007-11-29 03:53:40 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
usr.bin/tail read.c 
  Log:
  MFC(1.14): Fixing a double free bug which will cause tail to dump core when
  there's no tailing newline(\n) character.
  
  PR: bin/118267
  Reviewed by:kib
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.11.2.2  +1 -0  src/usr.bin/tail/read.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/usr.bin/tail read.c

2007-11-28 Thread Tai-hwa Liang
avatar  2007-11-29 03:54:56 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6_3)
usr.bin/tail read.c 
  Log:
  MFC(1.14): Fixing a double free bug which will cause tail to dump core when
  there's no tailing newline(\n) character.
  
  PR: bin/118267
  Reviewed by:kib
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.11.2.1.2.1  +1 -0  src/usr.bin/tail/read.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c

2007-11-30 Thread Tai-hwa Liang
avatar  2007-12-01 07:01:46 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_7)
sys/dev/an   if_an.c 
  Log:
  MFC(1.86): Eliminating an unnecessary check on an_gone inside
  an_stats_update() since a properly locked callout_stop(9) does do the
  right thing.
  
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.84.2.2  +0 -4  src/sys/dev/an/if_an.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/net80211 ieee80211_crypto_tkip.c

2008-08-29 Thread Tai-hwa Liang
avatar  2008-08-29 08:44:51 UTC

  FreeBSD src repository

  Modified files:
sys/net80211 ieee80211_crypto_tkip.c 
  Log:
  SVN rev 182437 on 2008-08-29 08:44:51Z by avatar
  
  Fixing INVARIANTS build by adding 'z' format prefix for size_t typed
  variable.
  
  Reminded by:tinderbox
  
  Revision  ChangesPath
  1.17  +1 -1  src/sys/net80211/ieee80211_crypto_tkip.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/conf files

2007-07-03 Thread Tai-hwa Liang
avatar  2007-07-03 07:20:21 UTC

  FreeBSD src repository

  Modified files:
sys/conf files 
  Log:
  Fixing !INET6 + FAST_IPSEC builds.
  
  Reviewed by:gnn
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.1228+1 -1  src/sys/conf/files
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/conf files

2007-07-03 Thread Tai-hwa Liang
avatar  2007-07-04 03:44:57 UTC

  FreeBSD src repository

  Modified files:
sys/conf files 
  Log:
  Reintroducing !INET6 + IPSEC building fix which was accidentally reverted
  in rev. 1.1229.
  
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.1232+1 -1  src/sys/conf/files
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/ipw if_ipw.c

2007-07-05 Thread Tai-hwa Liang
avatar  2007-07-05 15:06:49 UTC

  FreeBSD src repository

  Modified files:
sys/dev/ipw  if_ipw.c 
  Log:
  MFp4: Fixing IPW_DEBUG enabled builds by converting the last piece of
  ic->ic_des_essid to ic->ic_des_ssid[0].
  
  Reviewed by:sam
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.29  +2 -1  src/sys/dev/ipw/if_ipw.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/netsmb smb_dev.c

2007-07-10 Thread Tai-hwa Liang
avatar  2007-07-10 09:23:11 UTC

  FreeBSD src repository

  Modified files:
sys/netsmb   smb_dev.c 
  Log:
  Fixing the mount_smbfs(8) hanging by utilising the destroy_dev_sched() KPI.
  
  Relevant threads:
  
http://lists.freebsd.org/pipermail/freebsd-current/2007-June/074329.html
  
  Reviewed by:kib, bp (slightly different version)
  Tested by:  Yuri Pankov ,
  Jiawei Ye 
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.33  +3 -1  src/sys/netsmb/smb_dev.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c

2007-08-01 Thread Tai-hwa Liang
avatar  2007-08-02 02:20:19 UTC

  FreeBSD src repository

  Modified files:
sys/dev/an   if_an.c 
  Log:
  MFP4(123686): Fixing various ancontrol(8) related panics by dropping locks
  around copyin()/copyout().
  
  Reviewed by:sam, thompsa
  Tested by:  dhw
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.82  +60 -12src/sys/dev/an/if_an.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/an if_an.c

2007-08-07 Thread Tai-hwa Liang
avatar  2007-08-07 12:26:19 UTC

  FreeBSD src repository

  Modified files:
sys/dev/an   if_an.c 
  Log:
  MFP4(123687): Closing another LOR by dropping the driver lock around calls
  to if_input().
  
  Reviewed by:ambrisko
  Tested by:  dhw
  Approved by:re (kensmith)
  
  Revision  ChangesPath
  1.83  +3 -1  src/sys/dev/an/if_an.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/dev/wi if_wi.c

2007-08-09 Thread Tai-hwa Liang
avatar  2007-08-09 13:29:27 UTC

  FreeBSD src repository

  Modified files:
sys/dev/wi   if_wi.c 
  Log:
  MFP4(123963): Fixing a possible NULL pointer dereference by making
  the actual assignment after the NULL check.
  
  Found by:   Coverity Prevent(tm)
  CID:2303 (run 4156)
  Reviewed by:sam
  Approved by:re (bmah)
  
  Revision  ChangesPath
  1.212 +1 -1  src/sys/dev/wi/if_wi.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


Re: cvs commit: src/sys/kern kern_conf.c

2006-11-14 Thread Tai-hwa Liang

On Thu, 19 Oct 2006, Giorgos Keramidas wrote:

FWIW, reverting revision 1.199 of kern_conf.c locally fixes the
unkillable xterms, stuck in "devdrn", problem.


  With rev 1.199, modules that do destroy_dev() in their d_close() will
hang in "devdrn" state upon device closing.  For example, netsmb and snp:

# mount_smbfs -I server //server/share /mnt
Password:
[hang]

# watch
Snoop started.
Enter device name []:^C
[hang]

  It turns out that devfs_close() does a dev_refthread() before invoking
device specific d_close(), which makes subsequent destroy_dev() being
blocked in the "devdrn" loop.

  Before someone teaches these drivers not doing destroy_dev() in their 
d_close(), following bandaid can workaround this hanging problem:


Index: sys/netsmb/smb_dev.c
===
RCS file: /home/ncvs/src/sys/netsmb/smb_dev.c,v
retrieving revision 1.29
diff -u -p -u -r1.29 smb_dev.c
--- sys/netsmb/smb_dev.c22 Nov 2005 02:15:46 -  1.29
+++ sys/netsmb/smb_dev.c14 Nov 2006 13:49:37 -
@@ -175,6 +175,7 @@ nsmb_dev_close(struct cdev *dev, int fla
 */
dev->si_drv1 = NULL;
free(sdp, M_NSMBDEV);
+   dev_relthread(dev); /* XXX dealing with si_threadcount */
destroy_dev(dev);
splx(s);
return 0;
Index: sys/dev/snp/snp.c
===
RCS file: /home/ncvs/src/sys/dev/snp/snp.c,v
retrieving revision 1.102
diff -u -p -u -r1.102 snp.c
--- sys/dev/snp/snp.c   19 Sep 2005 13:48:45 -  1.102
+++ sys/dev/snp/snp.c   14 Nov 2006 13:49:37 -
@@ -489,6 +489,7 @@ snpclose(dev, flags, fmt, td)
free(snp->snp_buf, M_SNP);
snp->snp_flags &= ~SNOOP_OPEN;
dev->si_drv1 = NULL;
+   dev_relthread(dev); /* XXX dealing with si_threadcount */
destroy_dev(dev);

return (snp_detach(snp));

  On the other hand, si_threadcount could be negative with aforementioned
patch... :(


On 2006-10-19 02:49, Giorgos Keramidas <[EMAIL PROTECTED]> wrote:


Maybe it's not related, but all xterm's seem unkillable and blocked
forever in "devdrn" here, in a build from 2006.10.18.15.56.11.

An earlier sync from 2006.10.13.12.45.54 didn't exhibit this behavior,
so I guess there's something mildly buggy with this change?

On 2006-10-15 09:15, Martin Blapp <[EMAIL PROTECTED]> wrote:


Cool, thank you !

Martin

Martin Blapp, <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
--
ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH
Phone: +41 61 826 93 00 Fax: +41 61 826 93 01
PGP: 
PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E
--

On Fri, 13 Oct 2006, Tor Egge wrote:


tegge   2006-10-13 20:49:24 UTC

FreeBSD src repository

Modified files:
  sys/kern kern_conf.c
Log:
Wait for thread count to reach zero in destroy_devl() even when no purge
method is defined, to avoid memory being modified after free.

Temporarily increase refcount in destroy_devl() to avoid a double free
if dev_rel() is called while waiting for thread count to reach zero.

Revision  ChangesPath
1.199 +6 -0  src/sys/kern/kern_conf.c


--
Cheers,

Tai-hwa Liang
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2006-12-06 Thread Tai-hwa Liang
avatar  2006-12-07 01:24:38 UTC

  FreeBSD src repository

  Modified files:
.ObsoleteFiles.inc 
  Log:
  Completing the process of UUCP migration to ports.
  
  MFC after:  1 month
  
  Revision  ChangesPath
  1.67  +27 -0 src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src ObsoleteFiles.inc

2007-01-06 Thread Tai-hwa Liang
avatar  2007-01-07 02:40:38 UTC

  FreeBSD src repository

  Modified files:(Branch: RELENG_6)
.ObsoleteFiles.inc 
  Log:
  MFC (1.67): Completing the process of UUCP migration to ports.
  
  Revision   ChangesPath
  1.25.2.11  +27 -1 src/ObsoleteFiles.inc
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/fs/msdosfs msdosfs_vfsops.c msdosfs_vnops.c

2007-01-30 Thread Tai-hwa Liang
avatar  2007-01-30 08:05:04 UTC

  FreeBSD src repository

  Modified files:
sys/fs/msdosfs   msdosfs_vfsops.c msdosfs_vnops.c 
  Log:
  Fixing compilation bustage by removing references to opt_msdosfs.h.
  
  This auto-generated header file no longer exists since the removal of
  MSDOSFS_LARGE in sys/conf/options:1.574.
  
  Revision  ChangesPath
  1.158 +0 -2  src/sys/fs/msdosfs/msdosfs_vfsops.c
  1.168 +0 -2  src/sys/fs/msdosfs/msdosfs_vnops.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/modules/msdosfs Makefile

2007-01-31 Thread Tai-hwa Liang
avatar  2007-02-01 04:21:03 UTC

  FreeBSD src repository

  Modified files:
sys/modules/msdosfs  Makefile 
  Log:
  Reflecting the removal of MSDOSFS_LARGE found in sys/conf/files:1.1173.
  This should fix the run time bustage observed on recent -CURRENT whilst
  mounting a MSDOS filesystem with non-default locale/code page:
  
  link_elf: symbol msdosfs_fileno_free undefined
  KLD msdosfs_iconv.ko: depends on msdosfs - not available
  
  Revision  ChangesPath
  1.24  +2 -2  src/sys/modules/msdosfs/Makefile
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/netsmb smb_dev.c

2007-02-08 Thread Tai-hwa Liang
avatar  2007-02-09 02:54:13 UTC

  FreeBSD src repository

  Modified files:
sys/netsmb   smb_dev.c 
  Log:
  It turns out that devfs_close() does a dev_refthread() before invoking
  device specific d_close(), which makes subsequent destroy_dev() being
  blocked in the "devdrn" loop.
  
  This bandaid should fix the smbfs hang/crashing observed on -CURRENT since
  the introduction of sys/kern/kern_conf.c:1.199:
  
  # mount_smbfs -I server //server/share /mnt
  Password:
  [hang]
  
  Reviewed by:bp
  See also:   
http://lists.freebsd.org/pipermail/cvs-src/2006-November/071379.html
  
  Revision  ChangesPath
  1.30  +1 -0  src/sys/netsmb/smb_dev.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/sys/netsmb smb_dev.c

2007-02-09 Thread Tai-hwa Liang
avatar  2007-02-09 17:22:11 UTC

  FreeBSD src repository

  Modified files:
sys/netsmb   smb_dev.c 
  Log:
  Backing out the wrong fix which could possibly trash the memory if devfs
  tries to drop the reference count after our close routine returns.
  
  A more correct fix is to defer the destroy_dev() to a taskqueue(either
  in devfs or locally).
  
  Reminded by:jhb
  
  Revision  ChangesPath
  1.31  +0 -1  src/sys/netsmb/smb_dev.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"


cvs commit: src/usr.bin/netstat mcast.c

2007-03-01 Thread Tai-hwa Liang
avatar  2007-03-02 05:23:39 UTC

  FreeBSD src repository

  Modified files:
usr.bin/netstat  mcast.c 
  Log:
  Fixing NO_INET6 build as addr2ascii() has been nuked in previous commit.
  
  Revision  ChangesPath
  1.7   +2 -0  src/usr.bin/netstat/mcast.c
___
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"