Re: cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch
On 17.12.2010 16:15, Doug Barton wrote: In no particular order, new rc.d scripts should not be added with the .sh extension. I've attached a patch to the current version, but when the final result is committed it should be minidlna.in. Thanks for the diff, Doug. Regarding the .sh extension, there is a problem... This port has NO_WRKSUBDIR, and its main executable itself is called minidlna. If I don't use the .sh extension, the script overwrites the binary in WRKDIR (which is the same as WRKSRC in this case). The explicit PID-file removal was necessary, because I patched the software to drop root-privileges after creating the PID-file and opening its log (under /var/log). If the PID file is not removed before a subsequent start, the program will not overwrite it -- unlike rc.subr, it has no smarts to figure out, the PID-file is stale. Now, in my defense, FWIW, I used the net/mediatomb's rc.d script as a working (and accepted) example... Sorry, didn't realize the significance of the KEYWORD comment... And I remind, again, that I asked publicly -- on ports@ -- for help in creating the start-up script six months ago. No one has volunteered and I figured, it is better to have a port with imperfect start-up script, than no port at all... Yours, -mi ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
Re: cvs commit: ports/www/websh Makefile
On 22.02.2011 11:54, Erwin Lansing wrote: Just reinstating it to PORTREVISON+1 should be good enough. There's no need to get the, few, people that may have upgraded during the time to upgrade again to +2. PKGVERSION needs to be the same or higher, it just cannot go down. Since the package remains exactly the same in this case, it does not even matter, does it? Some time later, when/if the PORTREVISION needs to be bumped for real, it can be bumped to +2 for those (if any), who may have updated during the between-commits window yesterday. But for the time being both they and all the rest don't need to do anything... -mi ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
Re: cvs commit: ports/www/websh Makefile
On 22.02.2011 11:08, Greg Larkin wrote: What's the proper fix at this point - rebump to current PORTREVISION+2, or is a PORTEPOCH bump required? Since the pointyhat had not started then, I don't think, there is anything to be fixed at all now... -mi ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
Re: cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch
On 14.12.2010 02:27, Alexey Dokuchaev wrote: On Tue, Dec 14, 2010 at 06:11:04AM +, Mikhail Teterin wrote: mi 2010-12-14 06:11:04 UTC Added files: net/minidlna Makefile distinfo pkg-descr pkg-plist net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline patch-minidlna.c patch-upnphttp pkg-message.in scandir-patch Log: Add the port of minidlna -- the DLNA-speaking service. (Took me 6 months to come up with the etc/rc.d/ script...) It's sad that during these 6 months you did not find few minutes to ask dougb@ to review it. Why is dougb@ to be burdened reviewing these particular things? Having done the actual heavy-lifting of porting this Linux-only piece of software back in June, I published the port's shar and asked -- on ports@ -- for somebody else to contribute the start-up script. For 6 months no one has and now, finally, got around to learning, how to do this myself. Revision ChangesPath 1.1 +11 -0 ports/net/minidlna/files/patch-aa (new) 1.1 +9 -0 ports/net/minidlna/files/patch-ab (new) Apart from number of style bugs in the Makefile, can you explain why did Portlint's only complaint is the single MASTER_SITE... Feel free to submit patches. you go with `patch-xy' files, which is against current naming policy? Because I felt like this color was matching this bike shed the best... Because several naming styles exist currently and this particular one reminds the audience of the good old times, when new ports -- especially those, which provide unique and hitherto unavailable functionality -- were welcomed, rather than scolded for imaginary transgressions... You are welcome. -mi ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
Re: cvs commit: src/usr.bin/tar write.c
Kris Kennaway wrote: On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: Rong-en Fan wrote: On 3/15/07, Colin Percival <[EMAIL PROTECTED]> wrote: Modified files: usr.bin/tar write.c Log: Don't consider an lstat(2) failure to be an error (in the sense of affecting the return value from bsdtar) [...] This commit makes 'make package' successfully even if the plist is wrong, i.e. it contains ``ghost'' files. Basically, $ tar zcvf a.tgz /aaa tar: /aaa: Cannot stat: No such file or directory It returns 0, so make package will be considered successful. I've fixed this in revision 1.62. Colin Percival Thanks, I think mi@ ran into this recently too. So, this is fixed now? I guess, the fears, that fixing it would require fixing multitude of ports, were somewhat ungrounded. -mi ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
