cvs commit: ports/games/py-mnemosyne Makefile ports/games/py-mnemosyne/files patch-setup.py
beech 2008-09-12 07:16:11 UTC FreeBSD ports repository Modified files: games/py-mnemosyne Makefile games/py-mnemosyne/files patch-setup.py Log: - Patch setup.py to not install files during build - Unbreak Reported by:pointyhat via pav Approved by:portmgr (erwin) Revision ChangesPath 1.9 +2 -4 ports/games/py-mnemosyne/Makefile 1.2 +4 -5 ports/games/py-mnemosyne/files/patch-setup.py ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/audio/last.fm Makefile ports/audio/last.fm/files patch-src_mp3transcode_mp3transcode.cpp
miwi2008-09-12 08:48:58 UTC FreeBSD ports repository Modified files: audio/last.fmMakefile Added files: audio/last.fm/files patch-src_mp3transcode_mp3transcode.cpp Log: - Fix build on amd64 PR: 127223 Submitted by: "Andrius Morkūnas" <[EMAIL PROTECTED]> Approved by:portmgr (erwin) Revision ChangesPath 1.19 +1 -1 ports/audio/last.fm/Makefile 1.1 +11 -0 ports/audio/last.fm/files/patch-src_mp3transcode_mp3transcode.cpp (new) ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/math/py-scientific Makefile
miwi2008-09-12 08:50:42 UTC FreeBSD ports repository Modified files: math/py-scientific Makefile Log: - Respect NOPORTDOCS Approved by:portmgr (erwin) Revision ChangesPath 1.23 +1 -1 ports/math/py-scientific/Makefile ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/security/rid Makefile pkg-plist ports/security/sslwrap Makefile pkg-plist ports/news/p5-Gateway Makefile pkg-plist
miwi2008-09-12 08:51:36 UTC FreeBSD ports repository Modified files: security/rid Makefile pkg-plist security/sslwrap Makefile pkg-plist news/p5-Gateway Makefile pkg-plist Log: - Respect NOPORTDOCS/NOPORTEXAMPLES Approved by:portmgr (erwin) Revision ChangesPath 1.15 +3 -3 ports/news/p5-Gateway/Makefile 1.8 +11 -10ports/news/p5-Gateway/pkg-plist 1.14 +6 -4 ports/security/rid/Makefile 1.4 +4 -4 ports/security/rid/pkg-plist 1.17 +4 -3 ports/security/sslwrap/Makefile 1.2 +3 -3 ports/security/sslwrap/pkg-plist ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/security/vuxml vuln.xml
miwi2008-09-12 09:12:18 UTC FreeBSD ports repository Modified files: security/vuxml vuln.xml Log: - Document neon -- NULL pointer dereference in Digest domain support Approved by:portmgr (secteam blanked) Revision ChangesPath 1.1685+32 -1 ports/security/vuxml/vuln.xml ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/i386 sys_machdep.c
kib 2008-09-12 09:49:01 UTC FreeBSD src repository Modified files: sys/i386/i386sys_machdep.c Log: SVN rev 182959 on 2008-09-12 09:49:01Z by kib Remove warning about static LDT segment allocation. Applications continue using it after ~7 years since warning was introduced, and there is no reason to discourage them. MFC after: 1 week Revision ChangesPath 1.115 +0 -9 src/sys/i386/i386/sys_machdep.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/i386 sys_machdep.c vm_machdep.c src/sys/i386/include proc.h
kib 2008-09-12 09:53:29 UTC FreeBSD src repository Modified files: sys/i386/i386sys_machdep.c vm_machdep.c sys/i386/include proc.h Log: SVN rev 182961 on 2008-09-12 09:53:29Z by kib When doing rfork(0), i.e. separating curproc VM from any other user of the same vmspace, decrement the reference count of the shared LDT instead of a newly-made copy. Code factually removed LDT from the process that did rfork(0). Introduce user_ldt_deref() function that does decrement of refcount for the struct proc_ldt, and call it in the rfork(0) case on the shared LDT. Reviewed by:jhb MFC after: 1 week Revision ChangesPath 1.117 +8 -0 src/sys/i386/i386/sys_machdep.c 1.291 +5 -5 src/sys/i386/i386/vm_machdep.c 1.28 +1 -0 src/sys/i386/include/proc.h ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/i386 sys_machdep.c
kib 2008-09-12 09:51:11 UTC FreeBSD src repository Modified files: sys/i386/i386sys_machdep.c Log: SVN rev 182960 on 2008-09-12 09:51:11Z by kib The user_ldt_alloc() function shall return with dt_lock locked. The user_ldt_free() function shall return with dt_lock unlocked. Error handling code in both functions do not handle this, fix it by doing necessary lock/unlock. While there, fix minor style nits. MFC after: 1 week Revision ChangesPath 1.116 +9 -5 src/sys/i386/i386/sys_machdep.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: doc/en_US.ISO8859-1/articles/portbuild article.sgml
erwin 2008-09-12 11:36:27 UTC FreeBSD doc repository (ports committer) Modified files: en_US.ISO8859-1/articles/portbuild article.sgml Log: Add missing buildid to the mandatory arguments to makeworld. Revision ChangesPath 1.34 +1 -1 doc/en_US.ISO8859-1/articles/portbuild/article.sgml ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cvs commit: ports/security/pkcs11-helper Makefile
Hi, The build which triggered this email is done under tinderbox-2.4.3, on 7-STABLE on amd64, with tinderd_flags="-nullfs -plistcheck -onceonly" and ccache support, with the "official" up-to-date Ports Tree, with the following vars set: NOPORTDOCS=yes, NOPORTEXAMPLES=yes, NOPORTDATA=yes, FORCE_PACKAGE=yes. Excerpt from http://T64.TecNik93.com/logs/7-STABLE-FTP/pkcs11-helper-1.06.log : building pkcs11-helper-1.06 in directory /var/tinderbox/7-STABLE-FTP maintained by: [EMAIL PROTECTED] building for: 7.0-STABLE amd64 port directory: /usr/ports/security/pkcs11-helper Makefile ident: $FreeBSD: ports/security/pkcs11-helper/Makefile,v 1.8 2008/09/12 12:32:34 ale Exp $ prefixes: LOCALBASE=usr/local X11BASE=usr/local NO* env vars: NOPORTDOCS=yes NOPORTEXAMPLES=yes NOPORTDATA=yes build started at Fri Sep 12 12:33:53 UTC 2008 ... - add LIBDIR to the `LD_RUN_PATH' environment variable during linking - use the `-Wl,--rpath -Wl,LIBDIR' linker flag See any operating system documentation about shared libraries for more information, such as the ld(1) and ld.so(8) manual pages. -- test -z "" || .././install-sh -c -d "" test -z "/usr/local/libdata/pkgconfig" || .././install-sh -c -d "/usr/local/libdata/pkgconfig" install -o root -g wheel -m 444 'libpkcs11-helper-1.pc' '/usr/local/libdata/pkgconfig/libpkcs11-helper-1.pc' Making install in m4dir test -z "/usr/local/share/aclocal" || .././install-sh -c -d "/usr/local/share/aclocal" install -o root -g wheel -m 444 'pkcs11-helper-1.m4' '/usr/local/share/aclocal/pkcs11-helper-1.m4' Making install in doc Making install in api test -z "/usr/local/share/doc/pkcs11-helper/api" || ../.././install-sh -c -d "/usr/local/share/doc/pkcs11-helper/api" Making install in distro Making install in rpm Making install in debian make install-am Making install in tests ===> Compressing manual pages for pkcs11-helper-1.06 ===> Running ldconfig /sbin/ldconfig -m /usr/local/lib ===> Registering installation for pkcs11-helper-1.06 ===> Building package for pkcs11-helper-1.06 Creating package /tmp/packages/All/pkcs11-helper-1.06.tbz Registering depends: pkg-config-0.23_1. Creating bzip'd tar ball in '/tmp/packages/All/pkcs11-helper-1.06.tbz' Deleting pkcs11-helper-1.06 === Checking filesystem state list of extra files and directories in / (not present before this port was installed but present after it was deinstalled) 93740694 drwxr-xr-x3 root wheel 512 Sep 12 12:34 usr/local/share/doc/pkcs11-helper 93747094 drwxr-xr-x2 root wheel 512 Sep 12 12:34 usr/local/share/doc/pkcs11-helper/api build of /usr/ports/security/pkcs11-helper ended at Fri Sep 12 12:34:15 UTC 2008 A description of the testing process can be found here: http://T32.TecNik93.com/FreeBSD/QA-Tindy/testing_process.txt Thanks for your work on making FreeBSD better, -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> [EMAIL PROTECTED], PGP Key ID 057E9F8B493A297B ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/security/pkcs11-helper Makefile
ale 2008-09-12 12:32:34 UTC FreeBSD ports repository Modified files: security/pkcs11-helper Makefile Log: Fix typo for NOPORTDOCS. Approved by:portmgr (erwin) Revision ChangesPath 1.8 +1 -1 ports/security/pkcs11-helper/Makefile ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/security/pkcs11-helper Makefile
ale 2008-09-12 12:52:18 UTC FreeBSD ports repository Modified files: security/pkcs11-helper Makefile Log: Really fix pkg-plist. Approved by:portmgr (implicit) Revision ChangesPath 1.9 +4 -0 ports/security/pkcs11-helper/Makefile ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/share/man/man9 bus_dma.9
kib 2008-09-12 13:04:39 UTC FreeBSD src repository Modified files: share/man/man9 bus_dma.9 Log: SVN rev 182962 on 2008-09-12 13:04:39Z by kib Remove unneeded comma. Noted by: kensmith Revision ChangesPath 1.43 +1 -1 src/share/man/man9/bus_dma.9 ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/share/man/man9 bus_dma.9
kib 2008-09-12 13:08:12 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) share/man/man9 bus_dma.9 Log: SVN rev 182963 on 2008-09-12 13:08:12Z by kib MFC r182816: Document BUS_DMA_NOCACHE. MFC r182962: Remove unneeded comma. Approved by:re (kensmith) Revision ChangesPath 1.40.2.1 +7 -0 src/share/man/man9/bus_dma.9 ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/tx if_tx.c
jhb 2008-09-12 14:41:53 UTC FreeBSD src repository Modified files: sys/dev/tx if_tx.c Log: SVN rev 182964 on 2008-09-12 14:41:53Z by jhb Use the parent device's DMA tag when creating our own DMA tags. This fixes a panic on sparc64. Reviewed by:Florian Smeets flo kasimir.com Revision ChangesPath 1.99 +10 -9 src/sys/dev/tx/if_tx.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cvs commit: src/sys/i386/i386 sys_machdep.c
On Friday 12 September 2008 05:51:11 am Konstantin Belousov wrote: > kib 2008-09-12 09:51:11 UTC > > FreeBSD src repository > > Modified files: > sys/i386/i386sys_machdep.c > Log: > SVN rev 182960 on 2008-09-12 09:51:11Z by kib > > The user_ldt_alloc() function shall return with dt_lock locked. > The user_ldt_free() function shall return with dt_lock unlocked. > Error handling code in both functions do not handle this, fix it by > doing necessary lock/unlock. > > While there, fix minor style nits. Hmm, I had actually thought it was intentional for user_ldt_alloc() to only return with the lock held on success and depend on a later call to another method to drop the lock in the success case (so the locking isn't visible to consumers of the API in theory). For example, i386_ldt_grow() depended on this feature and is now broken (it leaks a lock on failure). I missed this when looking at this yesterday. Other notes: - Since user_ldt_free() handles the case of there not being an LDT, the code in exec_setregs() on i386 can be simplified to just always call user_ldt_free(). - cpu_exit() could possibly do the same. I wonder if exec_setregs() needs the same fixup to %gs that cpu_exit() does. If so, that could possibly be moved into user_ldt_free(). Ah, exec_setregs() does it unconditionally. I think you could make cpu_exit() just do it unconditionally as well before calling user_ldt_free(). -- John Baldwin ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cvs commit: src/sys/i386/i386 sys_machdep.c
On Fri, Sep 12, 2008 at 10:22:35AM -0400, John Baldwin wrote: > On Friday 12 September 2008 05:51:11 am Konstantin Belousov wrote: > > kib 2008-09-12 09:51:11 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/i386sys_machdep.c > > Log: > > SVN rev 182960 on 2008-09-12 09:51:11Z by kib > > > > The user_ldt_alloc() function shall return with dt_lock locked. > > The user_ldt_free() function shall return with dt_lock unlocked. > > Error handling code in both functions do not handle this, fix it by > > doing necessary lock/unlock. > > > > While there, fix minor style nits. > > Hmm, I had actually thought it was intentional for user_ldt_alloc() to only > return with the lock held on success and depend on a later call to another > method to drop the lock in the success case (so the locking isn't visible to > consumers of the API in theory). For example, i386_ldt_grow() depended on > this feature and is now broken (it leaks a lock on failure). I missed this > when looking at this yesterday. I probably miss something there. On failure of user_ldt_alloc(), i386_ldt_grow() does return (ENOMEM), without changing lock state for dt_lock. There are three call locations for the i386_ldt_grow(), all of them in i386_set_ldt(). On failure, each call location does mtx_unlock_spin(&dt_lock) immediately after call. So I assumed that protocol for i386_ldt_grow() is to always return with dt_lock locked. Two other callers of the user_ldt_alloc() in cpu_fork() do panic() immediately after the failed call to user_ldt_alloc(). Could you, please, point me to exact place where the lock would leak ? > > Other notes: > > - Since user_ldt_free() handles the case of there not being an LDT, the code > in exec_setregs() on i386 can be simplified to just always call > user_ldt_free(). > - cpu_exit() could possibly do the same. I wonder if exec_setregs() needs the > same fixup to %gs that cpu_exit() does. If so, that could possibly be moved > into user_ldt_free(). Ah, exec_setregs() does it unconditionally. I think > you could make cpu_exit() just do it unconditionally as well before calling > user_ldt_free(). > > -- > John Baldwin pgppaUXGzbhRf.pgp Description: PGP signature
cvs commit: src/sys/dev/mlx mlx.c src/usr.sbin/mlxcontrol command.c interface.c
sepotvin2008-09-12 17:40:17 UTC FreeBSD src repository Modified files: sys/dev/mlx mlx.c usr.sbin/mlxcontrol command.c interface.c Log: SVN rev 182965 on 2008-09-12 17:40:17Z by sepotvin Make mlxcontrol work with more than one system drive: - When searching for the next system drive, return the next one instead of always returning the first one. - Plug fd lead and make sure that the MLX_NEXT_CHILD ioctl is called on the controller fd, not the disk's one. While there, fix a cut-n-pase error in a warning. Reviewed by:jhb Approved by:kan (mentor) MFC after: 1 month Revision ChangesPath 1.55 +1 -1 src/sys/dev/mlx/mlx.c 1.3 +2 -2 src/usr.sbin/mlxcontrol/command.c 1.3 +6 -4 src/usr.sbin/mlxcontrol/interface.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.bin/top machine.c
sepotvin2008-09-12 17:54:50 UTC FreeBSD src repository Modified files: usr.bin/top machine.c Log: SVN rev 182966 on 2008-09-12 17:54:50Z by sepotvin Display the sum of the runtime of all the threads in a process when it's multithreaded instead of picking the time of the first thread found. Reviewed by:jhb Approved by:kan (mentor) MFC after: 1 month Revision ChangesPath 1.90 +1 -0 src/usr.bin/top/machine.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/aac aac_pci.c
emaste 2008-09-12 18:15:12 UTC FreeBSD src repository Modified files: sys/dev/aac aac_pci.c Log: SVN rev 182967 on 2008-09-12 18:15:12Z by emaste Whitespace cleanup. Revision ChangesPath 1.69 +5 -5 src/sys/dev/aac/aac_pci.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/k8temp k8temp.c
rpaulo 2008-09-12 18:26:09 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/dev/k8temp k8temp.c Log: SVN rev 182968 on 2008-09-12 18:26:09Z by rpaulo MFC r182722: Fix the sysctl function parameters. We were only querying Sensor 0. Noticed by: des Approved by:re Revision ChangesPath 1.7.2.2 +2 -2 src/sys/dev/k8temp/k8temp.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/sound/pci/hda hdac.c
remko 2008-09-12 18:37:52 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/dev/sound/pci/hda hdac.c Log: SVN rev 182969 on 2008-09-12 18:37:52Z by remko MFC r182854 Fix deactivation of speakers while plugging in headphones on Fujitsu U1010, Lenovo 3k N200 and Acer Aspire 4715Z. Reviewed by:attilio PR: 126216, 126244, 127034 Submitted by: Anton E. Kartashev <[EMAIL PROTECTED]>, Ganael Laplanche <[EMAIL PROTECTED]>, Dennis Generaloff <[EMAIL PROTECTED]> Requested by: joel Approved by:re (kib, via joel), imp (mentor, implicit) Obtained from: joel Revision ChangesPath 1.44.2.7 +9 -0 src/sys/dev/sound/pci/hda/hdac.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/netinet tcp_input.c
bz 2008-09-12 19:28:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/netinet tcp_input.c Log: SVN rev 182970 on 2008-09-12 19:28:57Z by bz MFC: svn r182885, cvs rev. 1.381 tcp_input.c Work around an integer division resulting in 0 and thus the congestion window not being incremented, if cwnd > maxseg^2. As suggested in RFC2581 increment the cwnd by 1 in this case. See http://caia.swin.edu.au/reports/080829A/CAIA-TR-080829A.pdf for more details. Submitted by: Alana Huebner, Lawrence Stewart, Grenville Armitage (caia.swin.edu.au) Reviewed by:dwmalone, gnn, rpaulo, silby Approved by:re (gnn) Revision ChangesPath 1.370.2.5 +3 -1 src/sys/netinet/tcp_input.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/netinet tcp_input.c
bz 2008-09-12 19:36:37 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netinet tcp_input.c Log: SVN rev 182971 on 2008-09-12 19:36:37Z by bz MFC: svn r182885, cvs rev. 1.381 tcp_input.c Work around an integer division resulting in 0 and thus the congestion window not being incremented, if cwnd > maxseg^2. As suggested in RFC2581 increment the cwnd by 1 in this case. See http://caia.swin.edu.au/reports/080829A/CAIA-TR-080829A.pdf for more details. Submitted by: Alana Huebner, Lawrence Stewart, Grenville Armitage (caia.swin.edu.au) Reviewed by:dwmalone, gnn, rpaulo, silby Approved by:re (gnn) RevisionChangesPath 1.281.2.14 +3 -1 src/sys/netinet/tcp_input.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/conf PAE
jhb 2008-09-12 20:09:05 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/i386/confPAE Log: SVN rev 182972 on 2008-09-12 20:09:05Z by jhb MFC: Don't disable USB in the PAE kernel config. Approved by:re (kib) Revision ChangesPath 1.25.2.4 +0 -29 src/sys/i386/conf/PAE ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cvs commit: src/sys/i386/i386 sys_machdep.c
On Friday 12 September 2008 11:36:19 am Kostik Belousov wrote: > On Fri, Sep 12, 2008 at 10:22:35AM -0400, John Baldwin wrote: > > On Friday 12 September 2008 05:51:11 am Konstantin Belousov wrote: > > > kib 2008-09-12 09:51:11 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/i386/i386sys_machdep.c > > > Log: > > > SVN rev 182960 on 2008-09-12 09:51:11Z by kib > > > > > > The user_ldt_alloc() function shall return with dt_lock locked. > > > The user_ldt_free() function shall return with dt_lock unlocked. > > > Error handling code in both functions do not handle this, fix it by > > > doing necessary lock/unlock. > > > > > > While there, fix minor style nits. > > > > Hmm, I had actually thought it was intentional for user_ldt_alloc() to only > > return with the lock held on success and depend on a later call to another > > method to drop the lock in the success case (so the locking isn't visible to > > consumers of the API in theory). For example, i386_ldt_grow() depended on > > this feature and is now broken (it leaks a lock on failure). I missed this > > when looking at this yesterday. > > I probably miss something there. > > On failure of user_ldt_alloc(), i386_ldt_grow() does return (ENOMEM), > without changing lock state for dt_lock. > > There are three call locations for the i386_ldt_grow(), all of > them in i386_set_ldt(). On failure, each call location does > mtx_unlock_spin(&dt_lock) immediately after call. So I assumed that > protocol for i386_ldt_grow() is to always return with dt_lock locked. > > Two other callers of the user_ldt_alloc() in cpu_fork() do panic() > immediately after the failed call to user_ldt_alloc(). > > Could you, please, point me to exact place where the lock would leak ? Gah, sorry, I had missed the callers of i386_ldt_grow(). I had recalled it being purposeful at one point that user_ldt_alloc() had this behavior. -- John Baldwin ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/conf PAE
jhb 2008-09-12 20:28:13 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/i386/confPAE Log: SVN rev 182973 on 2008-09-12 20:28:13Z by jhb MFC: Don't disable USB in the PAE kernel config. Approved by:re (kib) Revision ChangesPath 1.16.2.6 +0 -19 src/sys/i386/conf/PAE ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/usb ufoma.c
takawata2008-09-12 20:34:12 UTC FreeBSD src repository Modified files: sys/dev/usb ufoma.c Log: SVN rev 182974 on 2008-09-12 20:34:12Z by takawata Don't issue CDC request before negotiate the interface role. Revision ChangesPath 1.14 +107 -58 src/sys/dev/usb/ufoma.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/fs/tmpfs tmpfs.h tmpfs_fifoops.c tmpfs_fifoops.h tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c tmpfs_vnops.h
delphij 2008-09-12 20:35:17 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/fs/tmpfs tmpfs.h tmpfs_fifoops.c tmpfs_fifoops.h tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c tmpfs_vnops.h Log: SVN rev 182975 on 2008-09-12 20:35:17Z by delphij MFC r182739: license change from NetBSD. Approved by:re (kib) Revision ChangesPath 1.11.2.3 +1 -8 src/sys/fs/tmpfs/tmpfs.h 1.3.2.1 +1 -8 src/sys/fs/tmpfs/tmpfs_fifoops.c 1.3.2.1 +1 -8 src/sys/fs/tmpfs/tmpfs_fifoops.h 1.12.2.3 +1 -8 src/sys/fs/tmpfs/tmpfs_subr.c 1.11.2.5 +1 -8 src/sys/fs/tmpfs/tmpfs_vfsops.c 1.11.2.4 +1 -8 src/sys/fs/tmpfs/tmpfs_vnops.c 1.2.2.1 +1 -8 src/sys/fs/tmpfs/tmpfs_vnops.h ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/security/tripwire12 Makefile ports/security/tripwire12/files patch-aux_Makefile
gahr2008-09-12 21:00:07 UTC FreeBSD ports repository Modified files: security/tripwire12 Makefile Added files: security/tripwire12/files patch-aux_Makefile Log: - Unbreak on 64-bit, little-endian machines (read: amd64) Approved by:portmgr (marcus) Revision ChangesPath 1.22 +2 -0 ports/security/tripwire12/Makefile 1.1 +12 -0 ports/security/tripwire12/files/patch-aux_Makefile (new) ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/kern kern_condvar.c kern_sig.c kern_sx.c kern_synch.c kern_thread.c subr_sleepqueue.c src/sys/sys proc.h sleepqueue.h src/sys/vm vm_glue.c
jhb 2008-09-12 21:00:11 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern kern_condvar.c kern_sig.c kern_sx.c kern_synch.c kern_thread.c subr_sleepqueue.c sys/sys proc.h sleepqueue.h sys/vm vm_glue.c Log: SVN rev 182976 on 2008-09-12 21:00:11Z by jhb MFC: Fix a spin lock LOR when waking up a thread from a process that is swapped out by deferring the wakeup of the swapper kernel process until after releasing sleepq chain locks. Approved by:re (kib) RevisionChangesPath 1.62.2.1+10 -2 src/sys/kern/kern_condvar.c 1.349.2.7 +10 -2 src/sys/kern/kern_sig.c 1.55.2.1+17 -6 src/sys/kern/kern_sx.c 1.302.2.4 +17 -15src/sys/kern/kern_synch.c 1.255.2.8 +36 -13src/sys/kern/kern_thread.c 1.39.2.4+49 -18src/sys/kern/subr_sleepqueue.c 1.491.2.10 +2 -2 src/sys/sys/proc.h 1.12.2.1+3 -3 src/sys/sys/sleepqueue.h 1.225.2.3 +14 -37src/sys/vm/vm_glue.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
Re: cvs commit: ports/security/tripwire12 Makefile ports/security/tripwire12/files patch-aux_Makefile
Hi, The build which triggered this email is done under tinderbox-2.4.3, on 7-STABLE on amd64, with tinderd_flags="-nullfs -plistcheck -onceonly" and ccache support, with the "official" up-to-date Ports Tree, with the following vars set: NOPORTDOCS=yes, NOPORTEXAMPLES=yes, NOPORTDATA=yes, FORCE_PACKAGE=yes. Excerpt from http://T64.TecNik93.com/logs/7-STABLE-FTP/tripwire-1.2.log : building tripwire-1.2 in directory /var/tinderbox/7-STABLE-FTP maintained by: [EMAIL PROTECTED] building for: 7.0-STABLE amd64 port directory: /usr/ports/security/tripwire12 Makefile ident: $FreeBSD: ports/security/tripwire12/Makefile,v 1.22 2008/09/12 21:00:06 gahr Exp $ prefixes: LOCALBASE=usr/local X11BASE=usr/local NO* env vars: NOPORTDOCS=yes NOPORTEXAMPLES=yes NOPORTDATA=yes build started at Fri Sep 12 21:01:13 UTC 2008 ... add_pkg ===> Installing for tripwire-1.2 ===> Generating temporary packing list ===> Checking if security/tripwire12 already installed (cd aux; make CC=cc CFLAGS="-O2 -fno-strict-aliasing -pipe " LDFLAGS="-static" CPP="cc -E" SHELL=/bin/sh all) (cd src; make CC=cc CFLAGS="-O2 -fno-strict-aliasing -pipe " LIBS="" LDFLAGS="-static" CPP="cc -E" SHELL=/bin/sh YACC="yacc" LEX="lex" all) (cd src; make INSTALL=/usr/bin/install DESTDIR=/usr/local/bin install) /usr/bin/install tripwire /usr/local/bin /usr/bin/install siggen /usr/local/bin (cd man; make INSTALL=/usr/bin/install MANDIR=/usr/local/man install) cp siggen.8 /usr/local/man/man8 cp tripwire.8 /usr/local/man/man8 cp tw.config.5 /usr/local/man/man5 chmod 644 /usr/local/man/man8/siggen.8 chmod 644 /usr/local/man/man8/tripwire.8 chmod 644 /usr/local/man/man5/tw.config.5 # Creating tripwire database ### Warning:creating ./databases directory! ### ### Phase 1: Reading configuration file ### Phase 2: Generating file list tripwire: /.rhosts: No such file or directory tripwire: /.login: No such file or directory tripwire: /.exrc: No such file or directory tripwire: /.logout: No such file or directory tripwire: /.forward: No such file or directory tripwire: /home: No such file or directory tripwire: /lkm: No such file or directory tripwire: /modules: No such file or directory tripwire: /root/.history: No such file or directory tripwire: /stand: No such file or directory ### Phase 3: Creating file information database Segmentation fault (core dumped) *** Error code 139 Stop in /a/ports/security/tripwire12. build of /usr/ports/security/tripwire12 ended at Fri Sep 12 21:01:51 UTC 2008 A description of the testing process can be found here: http://T32.TecNik93.com/FreeBSD/QA-Tindy/testing_process.txt Thanks for your work on making FreeBSD better, -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> [EMAIL PROTECTED], PGP Key ID 057E9F8B493A297B ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/kern subr_smp.c
jhb 2008-09-12 21:07:22 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern subr_smp.c Log: SVN rev 182977 on 2008-09-12 21:07:22Z by jhb MFC: Only count the number of CPUs in the rendezvous map once, use CPU_ABSENT(), and count up to mp_maxid. Approved by:re (kib) Revision ChangesPath 1.201.2.5 +8 -14 src/sys/kern/subr_smp.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/ipmi ipmi_kcs.c
jhb 2008-09-12 21:37:37 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/dev/ipmi ipmi_kcs.c Log: SVN rev 182981 on 2008-09-12 21:37:37Z by jhb MFC: Fix two places that used && instead of & to test if OBF was set. Approved by:re (kib) Revision ChangesPath 1.1.2.2 +3 -3 src/sys/dev/ipmi/ipmi_kcs.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.sbin Makefile src/usr.sbin/crashinfo Makefile crashinfo.8 crashinfo.sh
jhb 2008-09-12 21:30:54 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.sbin Makefile Added files: (Branch: RELENG_7) usr.sbin/crashinfo Makefile crashinfo.8 crashinfo.sh Log: SVN rev 182978 on 2008-09-12 21:30:54Z by jhb MFC: Add a script to perform simple analysis of a crash dump. Approved by:re (kib) Revision ChangesPath 1.375.2.5 +1 -0 src/usr.sbin/Makefile 1.1.2.1+6 -0 src/usr.sbin/crashinfo/Makefile (new) 1.1.2.1+109 -0src/usr.sbin/crashinfo/crashinfo.8 (new) 1.1.2.1+306 -0src/usr.sbin/crashinfo/crashinfo.sh (new) ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/amd64/amd64 local_apic.c src/sys/i386/i386 local_apic.c
jhb 2008-09-12 21:40:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/amd64/amd64 local_apic.c sys/i386/i386local_apic.c Log: SVN rev 182982 on 2008-09-12 21:40:57Z by jhb MFC: Adjust the handling of the various timer frequencies when using the lapic timer to use dynamic divisors and try to keep stathz around 128. Approved by:re (kib) Revision ChangesPath 1.42.2.4 +17 -10src/sys/amd64/amd64/local_apic.c 1.44.2.3 +17 -10src/sys/i386/i386/local_apic.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/ipmi ipmi.c ipmivars.h
jhb 2008-09-12 21:44:31 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/dev/ipmi ipmi.c ipmivars.h Log: SVN rev 182985 on 2008-09-12 21:44:31Z by jhb MFC: Remove the never-enabled attempt at using device cloning to provide per-file descriptor storage and replace it with cdevpriv (and enable it) instead. Approved by:re (kib) Revision ChangesPath 1.10.2.1 +34 -121 src/sys/dev/ipmi/ipmi.c 1.2.2.1 +3 -13 src/sys/dev/ipmi/ipmivars.h ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/amd64/amd64 local_apic.c src/sys/i386/i386 local_apic.c
jhb 2008-09-12 21:41:21 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/amd64/amd64 local_apic.c sys/i386/i386local_apic.c Log: SVN rev 182983 on 2008-09-12 21:41:21Z by jhb MFC: Adjust the handling of the various timer frequencies when using the lapic timer to use dynamic divisors and try to keep stathz around 128. Approved by:re (kib) Revision ChangesPath 1.17.2.16 +17 -10src/sys/amd64/amd64/local_apic.c 1.17.2.15 +17 -10src/sys/i386/i386/local_apic.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/kern subr_witness.c
attilio 2008-09-12 21:44:01 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c Log: SVN rev 182984 on 2008-09-12 21:44:01Z by attilio - For any lock list we hold the head in order to reduce allocation from the free list and in this way avoid contention on the w_mtx. In order to make the code simple, we rely on the rule that when the head has not a child it also doesn't have other subsequent entries. Actually this assertion is broken because we can free all the head children and quit witness_unlock() with the head still allocated, with no children and subsequent entries present. Fix this by shifting the head if other entries are present and still freeing the object, but leaving always an head. - Fix witness_thread_has_locks() in order to report, correctly, if the lock list linked to a specific thread has children or not based on the above explained rule. - Fix a printout into DDB's "show alllocks" command in order to show, correctly, the process name that is really what we want. - Fix style(9) for a comment. Tested by: Giovanni Trematerra Reported by:Marko Kiiskila Sponsored by: Nokia Revision ChangesPath 1.255 +18 -5 src/sys/kern/subr_witness.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/cpufreq powernow.c smist.c
jhb 2008-09-12 21:46:23 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/i386/cpufreq powernow.c smist.c Log: SVN rev 182986 on 2008-09-12 21:46:23Z by jhb MFC: Fail detach if cpufreq_unregister() fails. Approved by:re (kensmith) Revision ChangesPath 1.4.2.2 +1 -2 src/sys/i386/cpufreq/powernow.c 1.2.2.2 +2 -2 src/sys/i386/cpufreq/smist.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/i386/cpufreq powernow.c smist.c
jhb 2008-09-12 21:46:59 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/i386/cpufreq powernow.c smist.c Log: SVN rev 182987 on 2008-09-12 21:46:59Z by jhb MFC: Fail detach if cpufreq_unregister() fails. Approved by:re (kensmith) Revision ChangesPath 1.2.2.2 +1 -2 src/sys/i386/cpufreq/powernow.c 1.1.2.2 +2 -2 src/sys/i386/cpufreq/smist.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.sbin Makefile src/usr.sbin/crashinfo Makefile crashinfo.8 crashinfo.sh
jhb 2008-09-12 21:33:29 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.sbin Makefile Added files: (Branch: RELENG_6) usr.sbin/crashinfo Makefile crashinfo.8 crashinfo.sh Log: SVN rev 182979 on 2008-09-12 21:33:29Z by jhb MFC: Add a script to perform simple analysis of a crash dump. Approved by:re (kib) RevisionChangesPath 1.332.2.14 +1 -0 src/usr.sbin/Makefile 1.1.4.1 +6 -0 src/usr.sbin/crashinfo/Makefile (new) 1.1.4.1 +109 -0src/usr.sbin/crashinfo/crashinfo.8 (new) 1.1.4.1 +306 -0src/usr.sbin/crashinfo/crashinfo.sh (new) ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.bin/vmstat vmstat.c src/usr.sbin/iostat iostat.c
jhb 2008-09-12 21:50:42 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.bin/vmstat vmstat.c usr.sbin/iostat iostat.c Log: SVN rev 182988 on 2008-09-12 21:50:42Z by jhb MFC: Use kvm_getcptime() to fetch the equivalent of the kern.cp_time sysctl from a crash dump. Approved by:re (kib) Revision ChangesPath 1.98.2.2 +14 -15src/usr.bin/vmstat/vmstat.c 1.36.2.2 +15 -9 src/usr.sbin/iostat/iostat.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/dev/ipmi ipmi_kcs.c
jhb 2008-09-12 21:36:48 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/dev/ipmi ipmi_kcs.c Log: SVN rev 182980 on 2008-09-12 21:36:48Z by jhb MFC: Fix two places that used && instead of & to test if OBF was set. Approved by:re (kib) Revision ChangesPath 1.1.4.1 +3 -3 src/sys/dev/ipmi/ipmi_kcs.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.sbin/ntp config.h
roberto 2008-09-12 22:15:43 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) usr.sbin/ntp config.h Log: SVN rev 182989 on 2008-09-12 22:15:43Z by roberto MFH r182944: Makefile.inc already defines OPENSSL if crypto is available/wanted. PR: bin/127296 Submitted by: olivier Approved by:re (gnn) Revision ChangesPath 1.13.10.2 +1 -1 src/usr.sbin/ntp/config.h ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/contrib/ntp/libparse clk_rawdcf.c
roberto 2008-09-12 22:18:35 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) contrib/ntp/libparse clk_rawdcf.c Log: SVN rev 182990 on 2008-09-12 22:18:35Z by roberto MFH r182857: Apply updated patch from bin/92839 to avoid two possible buffer overflows. PR: bin/92839 Submitted by: Helge Oldach <[EMAIL PROTECTED]> Approved by:re (gnn) Revision ChangesPath 1.1.1.3.24.2 +2 -2 src/contrib/ntp/libparse/clk_rawdcf.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/usr.sbin/ntp config.h
roberto 2008-09-12 22:20:24 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) usr.sbin/ntp config.h Log: SVN rev 182991 on 2008-09-12 22:20:24Z by roberto MFH r182944: Makefile.inc already defines OPENSSL if crypto is available/wanted. PR: bin/127296 Submitted by: olivier Approved by:re (gnn) Revision ChangesPath 1.13.2.2 +1 -1 src/usr.sbin/ntp/config.h ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/contrib/ntp/libparse clk_rawdcf.c
roberto 2008-09-12 22:22:31 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) contrib/ntp/libparse clk_rawdcf.c Log: SVN rev 182992 on 2008-09-12 22:22:31Z by roberto MFH r182857: Apply updated patch from bin/92839 to avoid two possible buffer overflows. PR: bin/92839 Submitted by: Helge Oldach <[EMAIL PROTECTED]> Approved by: re (gnn) Revision ChangesPath 1.1.1.3.14.2 +2 -2 src/contrib/ntp/libparse/clk_rawdcf.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: src/sys/kern uipc_usrreq.c
rwatson 2008-09-13 00:16:20 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern uipc_usrreq.c Log: SVN rev 182993 on 2008-09-13 00:16:20Z by rwatson Extend global UNIX domain socket rwlock coverage to include incrementing and decrementing unp_rights, which may otherwise be corrupted. Be slightly more conversative in where we read unp_rights. This relates to one of the symptoms reported in the noted PR, but may not correct the actual high system time problem. The reporter has confirmed stability but not that the problem is eliminated. However, this is a useful fix to a clear locking bug. Note that this is not an MFC as the UNIX domain socket garbage collector has been replaced in 8.x. PR: 127024 Reported by:Anton Yuzhaninov Reviewed by:kib Approved by:re (kib) Revision ChangesPath 1.206.2.4 +6 -2 src/sys/kern/uipc_usrreq.c ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
cvs commit: ports/java/eclipse Makefile ports/java/eclipse-devel Makefile
glewis 2008-09-13 04:06:44 UTC FreeBSD ports repository Modified files: java/eclipse Makefile java/eclipse-devel Makefile Log: . Fix the build when WITHOUT_MOZILLA is defined by removing the manual inclusion of an (obsolete) copy of bsd.gecko.mk (its included when appropriate by the port setting USE_GECKO). Submitted by: ale Approved by:portmgr (pav) Revision ChangesPath 1.20 +0 -1 ports/java/eclipse-devel/Makefile 1.60 +0 -1 ports/java/eclipse/Makefile ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
