RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

2022-11-09 Thread pandaapo 
The cache named `signerToCodeSource` is never used now.

-

Commit messages:
 - Make signerToCodeSource cache work.

Changes: https://git.openjdk.org/jdk/pull/11072/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8296734
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11072.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11072/head:pull/11072

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v6]

2022-11-20 Thread pandaapo 
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.

pandaapo has updated the pull request incrementally with one additional commit 
since the last revision:

  Modify as review and update copyright.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/11072/files
  - new: https://git.openjdk.org/jdk/pull/11072/files/a8fb419c..fb933804

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=04-05

  Stats: 92 lines in 3 files changed: 0 ins; 90 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11072.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11072/head:pull/11072

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

2022-11-20 Thread pandaapo 
On Sun, 20 Nov 2022 15:37:24 GMT, Weijun Wang  wrote:

> `codomain`, `VerifierCodeSource`, `isSigningRelated`, and `getUnsignedCS` 
> also used nowhere.

Thanks. I think your `codomain` must mean `csdomain`.

-

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

2022-11-21 Thread pandaapo 
> The cache named `signerToCodeSource` in `JarVerifier` is never used now.

pandaapo has updated the pull request incrementally with one additional commit 
since the last revision:

  Modify as reviews.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/11072/files
  - new: https://git.openjdk.org/jdk/pull/11072/files/fb933804..1aa65b2b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=05-06

  Stats: 10 lines in 1 file changed: 4 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11072.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11072/head:pull/11072

PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

2022-11-21 Thread pandaapo 
On Tue, 22 Nov 2022 01:44:29 GMT, Weijun Wang  wrote:

> Everything looks fine now. Thanks so much for the cleanup. It's always nice 
> to see unused lines removed.

Thank you for your review.

-

PR: https://git.openjdk.org/jdk/pull/11072

Integrated: 8297301: Cleanup unused methods in JavaUtilJarAccess

2022-11-21 Thread pandaapo 
On Thu, 10 Nov 2022 01:02:00 GMT, pandaapo  wrote:

> The cache named `signerToCodeSource` in `JarVerifier` is never used now.

This pull request has now been integrated.

Changeset: f0e99c63
Author:    pandaapo <1052156...@qq.com>
Committer: Weijun Wang 
URL:   
https://git.openjdk.org/jdk/commit/f0e99c634693fafc0c5d1103184e73c6669629db
Stats: 652 lines in 4 files changed: 3 ins; 636 del; 13 mod

8297301: Cleanup unused methods in JavaUtilJarAccess

Reviewed-by: weijun

-

PR: https://git.openjdk.org/jdk/pull/11072