Re: [PR] Refactored duplicate code in TopicPublishInfo [rocketmq]
DivyanshIITB commented on PR #9257: URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2744949363 @RongtongJin I have resolved and replied to your review. Let me know if any further changes are required ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix: Added missing NameServer parameter for RocketMQ Dashboard deployment [rocketmq-site]
DivyanshIITB commented on PR #720: URL: https://github.com/apache/rocketmq-site/pull/720#issuecomment-2744951543 @RongtongJin Gentle Reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Optimize processResponseCommand in NettyRemotingAbstract by Removing Redundant Operations [rocketmq]
DivyanshIITB opened a new pull request, #9268: URL: https://github.com/apache/rocketmq/pull/9268 Key Changes: - Removed duplicate operation: responseFuture.setResponseCommand(cmd); was being called outside and inside the if condition. It is now moved inside the conditional block where getInvokeCallback() != null. - Enhanced maintainability: Eliminates unnecessary code while preserving the intended behavior. - No functional impact: The change ensures that setResponseCommand(cmd); is executed only when required. Why This Change? - The previous implementation resulted in an unnecessary function call in cases where getInvokeCallback() was null. - This minor optimization improves performance by avoiding redundant method execution. Testing & Verification: - Unit tests were run to verify that the behavior remains consistent. - The RocketMQ remoting module continues to function as expected. Fixes #2578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Upgrade the version in quickstart to the latest [rocketmq-site]
yx9o opened a new pull request, #721: URL: https://github.com/apache/rocketmq-site/pull/721 Upgrade quickstart version 5.3.1 to 5.3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize processResponseCommand in NettyRemotingAbstract by Removing Redundant Operations [rocketmq]
codecov-commenter commented on PR #9268: URL: https://github.com/apache/rocketmq/pull/9268#issuecomment-2745083434 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `20.0%` with `4 lines` in your changes missing coverage. Please review. > Project coverage is 48.00%. Comparing base [(`34c32d8`)](https://app.codecov.io/gh/apache/rocketmq/commit/34c32d8c8081f09f7c87cbd79534162eb0a08a0f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`bac1227`)](https://app.codecov.io/gh/apache/rocketmq/commit/bac12272f93f538bf34c326826650d11c4467901?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9268?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://app.codecov.io/gh/apache/rocketmq/pull/9268?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FNettyRemotingAbstract.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9268 +/- ## = - Coverage 48.16% 48.00% -0.16% + Complexity 1212412091 -33 = Files 1322 1322 Lines 9312693128 +2 Branches 1194011940 = - Hits 4485044704 -146 - Misses 4273842884 +146 - Partials5538 5540 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9268?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(Dockerfile): Unable to build docker image [rocketmq-dashboard]
cndoit18 closed pull request #134: fix(Dockerfile): Unable to build docker image URL: https://github.com/apache/rocketmq-dashboard/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactored duplicate code in TopicPublishInfo [rocketmq]
DivyanshIITB commented on PR #9257: URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2742785857 Just a gentle reminder @RongtongJin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DivyanshIITB (triggered by DivyanshIITB). Head commit for run: bac12272f93f538bf34c326826650d11c4467901 / Divyansh Refactored processResponseCommand to remove redundant operations Report URL: https://github.com/apache/rocketmq/actions/runs/14005935833 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DivyanshIITB (triggered by github-actions[bot]). Head commit for run: bac12272f93f538bf34c326826650d11c4467901 / Divyansh Refactored processResponseCommand to remove redundant operations Report URL: https://github.com/apache/rocketmq/actions/runs/14005935833 With regards, GitHub Actions via GitBox
