[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12746011412 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12746029243 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: cf4151ffc218ad8744dd82f29c654e4f3b206947 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12744132983 With regards, GitHub Actions via GitBox
[I] [Bug] Ack may cause NPE when grpc client change proxy [rocketmq]
qianye1001 opened a new issue, #9128: URL: https://github.com/apache/rocketmq/issues/9128 ### Before Creating the Bug Report - [x] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [x] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [x] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment any ### RocketMQ version develop branch ### JDK Version any ### Describe the Bug When a client changes its proxy, the client's heartbeat might arrive later than other requests, causing a NullPointerException (NPE) when executing getHandleString during acknowledgment (ack). ### Steps to Reproduce 1. receive some messages from proxy1 2. Shutdown proxy1 3. ack messages ### What Did You Expect to See? ack successfully ### What Did You See Instead? npe ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 36bf4d6ac883a46f6cadc5e0c6abd58662a08b54 / qianye Merge branch 'develop' into issue8895 Report URL: https://github.com/apache/rocketmq/actions/runs/12760034558 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941953 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 36bf4d6ac883a46f6cadc5e0c6abd58662a08b54 / qianye Merge branch 'develop' into issue8895 Report URL: https://github.com/apache/rocketmq/actions/runs/12760034558 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941953 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 36bf4d6ac883a46f6cadc5e0c6abd58662a08b54 / qianye Merge branch 'develop' into issue8895 Report URL: https://github.com/apache/rocketmq/actions/runs/12760034558 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941953 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9111] Support export broker RocksDB Config to json file [rocketmq]
lollipopjin merged PR #9114: URL: https://github.com/apache/rocketmq/pull/9114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #9111] Support export broker RocksDB Config to json file (#9114)
This is an automated email from the ASF dual-hosted git repository.
lollipop pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new b30afe8184 [ISSUE #9111] Support export broker RocksDB Config to json
file (#9114)
b30afe8184 is described below
commit b30afe81840a0aacac730556432ebcdb276bbe85
Author: qianye
AuthorDate: Tue Jan 14 10:29:40 2025 +0800
[ISSUE #9111] Support export broker RocksDB Config to json file (#9114)
* [ISSUE #9111] Broker Support export RocksDB Config to json file and
enhance admin tools
---
.../config/v1/RocksDBConsumerOffsetManager.java| 13 +-
.../config/v1/RocksDBSubscriptionGroupManager.java | 7 +-
.../config/v1/RocksDBTopicConfigManager.java | 7 +-
.../broker/processor/AdminBrokerProcessor.java | 54 -
.../rocketmq/client/impl/MQClientAPIImpl.java | 16 ++
.../rocketmq/remoting/protocol/RequestCode.java| 1 +
.../ExportRocksDBConfigToJsonRequestHeader.java| 100 +
...ExportRocksDBConfigToJsonRequestHeaderTest.java | 51 +
.../rocketmq/tools/admin/DefaultMQAdminExt.java| 8 +
.../tools/admin/DefaultMQAdminExtImpl.java | 8 +
.../apache/rocketmq/tools/admin/MQAdminExt.java| 5 +
.../export/ExportMetadataInRocksDBCommand.java | 11 +-
.../metadata/RocksDBConfigToJsonCommand.java | 224 ++---
13 files changed, 463 insertions(+), 42 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConsumerOffsetManager.java
b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConsumerOffsetManager.java
index 824fc0fee3..963c5046f2 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConsumerOffsetManager.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConsumerOffsetManager.java
@@ -38,7 +38,7 @@ public class RocksDBConsumerOffsetManager extends
ConsumerOffsetManager {
protected static final Logger log =
LoggerFactory.getLogger(LoggerName.BROKER_LOGGER_NAME);
-protected RocksDBConfigManager rocksDBConfigManager;
+protected transient RocksDBConfigManager rocksDBConfigManager;
public RocksDBConsumerOffsetManager(BrokerController brokerController) {
super(brokerController);
@@ -100,7 +100,7 @@ public class RocksDBConsumerOffsetManager extends
ConsumerOffsetManager {
byte[] keyBytes =
topicAtGroup.getBytes(DataConverter.CHARSET_UTF8);
this.rocksDBConfigManager.delete(keyBytes);
} catch (Exception e) {
-LOG.error("kv remove consumerOffset Failed, {}", topicAtGroup);
+log.error("kv remove consumerOffset Failed, {}", topicAtGroup);
}
}
@@ -109,7 +109,7 @@ public class RocksDBConsumerOffsetManager extends
ConsumerOffsetManager {
RocksDBOffsetSerializeWrapper wrapper = JSON.parseObject(body,
RocksDBOffsetSerializeWrapper.class);
this.offsetTable.put(topicAtGroup, wrapper.getOffsetTable());
-LOG.info("load exist local offset, {}, {}", topicAtGroup,
wrapper.getOffsetTable());
+log.info("load exist local offset, {}, {}", topicAtGroup,
wrapper.getOffsetTable());
}
public String rocksdbConfigFilePath() {
@@ -132,12 +132,17 @@ public class RocksDBConsumerOffsetManager extends
ConsumerOffsetManager {
this.rocksDBConfigManager.batchPutWithWal(writeBatch);
this.rocksDBConfigManager.flushWAL();
} catch (Exception e) {
-LOG.error("consumer offset persist Failed", e);
+log.error("consumer offset persist Failed", e);
} finally {
writeBatch.close();
}
}
+public synchronized void exportToJson() {
+log.info("RocksDBConsumerOffsetManager export consumer offset to json
file");
+super.persist();
+}
+
private void putWriteBatch(final WriteBatch writeBatch, final String
topicGroupName, final ConcurrentMap offsetMap) throws Exception {
byte[] keyBytes = topicGroupName.getBytes(DataConverter.CHARSET_UTF8);
RocksDBOffsetSerializeWrapper wrapper = new
RocksDBOffsetSerializeWrapper();
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBSubscriptionGroupManager.java
b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBSubscriptionGroupManager.java
index 8fc7a4d6ed..ff47152569 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBSubscriptionGroupManager.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBSubscriptionGroupManager.java
@@ -37,7 +37,7 @@ import org.rocksdb.RocksIterator;
public class RocksDBSubscriptionGroupManager extends SubscriptionGroupManager {
-protected RocksDBConfigManager rocksDBConfigManager;
+protected transient RocksDBConfigManager rocksDBConfigMa
Re: [I] [Enhancement] Support export json consumer offset to file when using RocksDB consumer offset manage [rocketmq]
lollipopjin closed issue #9111: [Enhancement] Support export json consumer offset to file when using RocksDB consumer offset manage URL: https://github.com/apache/rocketmq/issues/9111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #235]Add podAnnotations field to CRDs and types for Broker, Controller, and NameService [rocketmq-operator]
drivebyer commented on code in PR #236: URL: https://github.com/apache/rocketmq-operator/pull/236#discussion_r1914179178 ## pkg/controller/nameservice/nameservice_controller.go: ## @@ -20,14 +20,15 @@ package nameservice import ( "context" - "github.com/google/uuid" "os/exec" "reflect" "sort" "strconv" "strings" "time" + "github.com/google/uuid" Review Comment: It's formated by goimport tool :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 36bf4d6ac883a46f6cadc5e0c6abd58662a08b54 / qianye Merge branch 'develop' into issue8895 Report URL: https://github.com/apache/rocketmq/actions/runs/12760034555 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12760164998 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941967 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #235]Add podAnnotations field to CRDs and types for Broker, Controller, and NameService [rocketmq-operator]
drivebyer commented on code in PR #236: URL: https://github.com/apache/rocketmq-operator/pull/236#discussion_r1914179178 ## pkg/controller/nameservice/nameservice_controller.go: ## @@ -20,14 +20,15 @@ package nameservice import ( "context" - "github.com/google/uuid" "os/exec" "reflect" "sort" "strconv" "strings" "time" + "github.com/google/uuid" Review Comment: It's format by goimport tool :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941950 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: b30afe81840a0aacac730556432ebcdb276bbe85 / qianye [ISSUE #9111] Support export broker RocksDB Config to json file (#9114) * [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12759941950 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9115] Optimize the broker's reverse notification for consumerId change [rocketmq]
yx9o commented on PR #9116: URL: https://github.com/apache/rocketmq/pull/9116#issuecomment-2586493754 > 1. task1 has already done notification > 2. task2 try interrupt task1 and update map > 3. task1 remove group in map > > if so, task2 will never be interrupted, but it is better than now Hi, thank you for your review. I added the atomic check here. Please help review it again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12743239387 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 51b4fb52af8b03d18f8893cc821d036118e62e1d / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12743206427 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 51b4fb52af8b03d18f8893cc821d036118e62e1d / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12743206427 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 51b4fb52af8b03d18f8893cc821d036118e62e1d / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12743206427 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401824 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401824 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401824 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by github-actions[bot]). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12742009785 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12743433395 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 51b4fb52af8b03d18f8893cc821d036118e62e1d / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12743206442 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401835 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user Kris20030907 (triggered by lizhimins). Head commit for run: 7d1b21369e2e01a0788f699311c84b7851c3f88a / kris20030907 <3185633...@qq.com> fix(comment): correct typos in ConsumeQueueExt class. Report URL: https://github.com/apache/rocketmq/actions/runs/12723349116 With regards, GitHub Actions via GitBox
[I] [Bug] Remove dependency on `rocketmq-slf4j-api` [rocketmq]
ppkarwasz opened a new issue, #9127: URL: https://github.com/apache/rocketmq/issues/9127 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment All ### RocketMQ version branch: develop ### JDK Version _No response_ ### Describe the Bug Many RocketMQ artifacts depend on repackaged versions of SLF4J and Logback: - [`io.github.aliyunmq:rocketmq-slf4j-api`](https://github.com/aliyunmq/rocketmq-slf4j-api-bridge) - [`io.github.aliyunmq:rocketmq-logback-classic`](https://github.com/aliyunmq/rocketmq-logging) This is IMHO a very bad idea, since: - It introduces yet another logging API that users need to forward to their logging implementation. - Naïve implementations of bridges between logging APIs have a tendency to lose location information (class, method and line number). [`io.github.aliyunmq:rocketmq-slf4j-api-bridge`](https://github.com/aliyunmq/rocketmq-slf4j-api-bridge) is **not** an exception and loses location information. - Using those dependencies introduces an additional entity to the RocketMQ supply chain: the [aliyun.mq project](https://github.com/aliyunmq). I am aware of the fact the `aliyun.mq` is mostly composed by members of the RocketMQ PMC, but it is still an independent project and is not covered by the ASF rules and Apache Security Team. This will cause a problem with CRA and similar regulations. - The `rocketmq-logback-classic` artifact is basically subject to the same vulnerabilities as `logback-classic`, but I don't see any CVE being issued against that artifact (Logback published 7 CVEs in 2023 and 2024). ### Steps to Reproduce You can see the problem by searching the `pom.xml` files for the artifacts mentioned above. ### What Did You Expect to See? I would expect: - All the RocketMQ artifacts to depend on `org.slf4j:slf4j-api` or another established logging API. (Note that the [openrewrite/rewrite-logging-frameworks](https://github.com/openrewrite/rewrite-logging-frameworks) project contains rules to rewrite SLF4J to any other logging API, so the choice of logging API is not really binding). - Additionally the [`rocketmq-distribution`](https://github.com/apache/rocketmq/blob/develop/distribution/pom.xml) artifact should have a `runtime` dependency on `ch.qos.logback:logback-classic`. - No other RocketMQ artifact should have a `runtime` dependency on Logback (see #5347). If Logback is used by the tests, it should be in the `test` scope. ### What Did You See Instead? All RocketMQ artifacts depend on the custom `io.github.aliyunmq:rocketmq-slf4j-api` logging API. Some of them depend on `io.github.aliyunmq:rocketmq-logback-classic` or `io.github.aliyunmq:rocketmq-slf4j-api-bridge`. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 7c46333ff0471b48fbea9e6b90d8a1efb42ff97f / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745973437 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 03436fa75c714f64f8c93586303589b24992 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745991895 With regards, GitHub Actions via GitBox
Re: [I] build docker image [rocketmq]
HattoriHenzo commented on issue #4704: URL: https://github.com/apache/rocketmq/issues/4704#issuecomment-2588429530 [late answer] I was able to configure my setup and here a the different steps. The `rockermq ` project has all the required files and the documents to help you configure your IDE, but you have to do some changes and adapt some part to match your local configuration: 1. My OS: **Window 11 Pro** 2. Read and configure your IDE according to the [CONTRIBUTION GUIDE](https://eventmesh.apache.org/community/contribute/contribute/) 3. Create a folder, lets say `rocketmq` where you will clone 3 different projects: - [rocketmq](https://github.com/apache/rocketmq) - [rocketmq-docker](https://github.com/apache/rocketmq-docker) - [rocketmq-dashboard](https://github.com/apache/rocketmq-dashboard) 4. In the `rocketmq-docker` project you will find a folder named `scripts` in the following path: `rocketmq-docker/scripts`. Copy this folder in your root folder `rocketmq`. This folder contains the scripts to start `rocketmq ` component (proxy, nameserver and broker) At this point I have created custom `compose.yaml`, `Dockerfiles ` and a build file to run `rocketmq ` in docker compose. The compose file in mostly inspired by the one provided in the [documentation](https://rocketmq.apache.org/docs/quickStart/03quickstartWithDockercompose). The important modification in the compose file are: - the use of custom docker images of `rocketmq ` components build locally - the integration of the image of the dashboard built locally 5. To activate the debugging mode, you have to uncomment line **67** in the `rocketmq\scripts\runbroker-customize.sh` file. This mean you should configure your IDE to communicate with the same port in container 6. The same thing is applied for the `rocketmq-dashboard` project with a different port already configured in the `compose.yaml` file ## Warning 1: because of some issue with the `proxy ` component, I had to use the image available on the docker hub ## Warning 2: a common error that will appear is the following **connect to failed** with the dashboard container. You will the find some solutions in the **Troubleshoopting.md** file in the rocketmq repository.  7. You will find the content of the files I am using to build my local project. You can bring any modification, I will be happy have you point of vue. **compose.yaml** ``` version: '3.8' services: namesrv: image: hattorihenzo/rocketmq-broker-dev:latest container_name: rmqnamesrv ports: - 9876:9876 networks: - rocketmq command: sh mqnamesrv broker: image: hattorihenzo/rocketmq-broker-dev:latest container_name: rmqbroker ports: - 9555:9555 - 10909:10909 - 10911:10911 - 10912:10912 environment: - NAMESRV_ADDR=rmqnamesrv:9876 depends_on: - namesrv networks: - rocketmq command: sh mqbroker proxy: image: apache/rocketmq:5.3.1 container_name: rmqproxy networks: - rocketmq depends_on: - broker - namesrv ports: - 8080:8080 - 8081:8081 restart: on-failure environment: - NAMESRV_ADDR=rmqnamesrv:9876 command: sh mqproxy dashboard: image: hattorihenzo/rocketmq-dashboard-dev:latest container_name: rmqdashboard networks: - rocketmq ports: - 9090:8282 - 5005:5005 environment: - JAVA_OPTS=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005 -Drocketmq.namesrv.addr=rmqnamesrv:9876 - NAMESRV_ADDR=rmqnamesrv:9876 networks: rocketmq: driver: bridge ``` **Dockerfile.broker** ``` # # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional information regarding copyright ownership. # The ASF licenses this file to You under the Apache License, Version 2.0 # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # # Build stage 1 `builder`:
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: cf4151ffc218ad8744dd82f29c654e4f3b206947 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12744132983 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: cf4151ffc218ad8744dd82f29c654e4f3b206947 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12744132984 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401827 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user ppkarwasz (triggered by github-actions[bot]). Head commit for run: 10cfe28cc2db04ed4c57553bf5cc94775b34ad56 / Piotr P. Karwasz Add a RocketMQ BOM artifact Add a `rocketmq-bom` artifact that only manages RocketMQ dependency versions. The previous `rocketmq-all` artifact is reparented to `rocketmq-bom`. Report URL: https://github.com/apache/rocketmq/actions/runs/12745368965 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user ppkarwasz (triggered by github-actions[bot]). Head commit for run: 10cfe28cc2db04ed4c57553bf5cc94775b34ad56 / Piotr P. Karwasz Add a RocketMQ BOM artifact Add a `rocketmq-bom` artifact that only manages RocketMQ dependency versions. The previous `rocketmq-all` artifact is reparented to `rocketmq-bom`. Report URL: https://github.com/apache/rocketmq/actions/runs/12745368965 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 65779b2b1051a587ac12b24d7f22555702795bea / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12743401827 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: cf4151ffc218ad8744dd82f29c654e4f3b206947 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12744132991 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12744174182 With regards, GitHub Actions via GitBox
Re: [PR] [Issue #7730] Add a RocketMQ BOM artifact [rocketmq]
codecov-commenter commented on PR #7732: URL: https://github.com/apache/rocketmq/pull/7732#issuecomment-2586804633 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7732?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.97%. Comparing base [(`f6249e5`)](https://app.codecov.io/gh/apache/rocketmq/commit/f6249e5b3a171be1cd0051732be77fd55ee4eb97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`10cfe28`)](https://app.codecov.io/gh/apache/rocketmq/commit/10cfe28cc2db04ed4c57553bf5cc94775b34ad56?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7732 +/- ## = - Coverage 48.02% 47.97% -0.05% + Complexity 1205012048 -2 = Files 1320 1320 Lines 9284692846 Branches 1189811898 = - Hits 4458844545 -43 - Misses 4274842789 +41 - Partials5510 5512 +2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7732?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 7c46333ff0471b48fbea9e6b90d8a1efb42ff97f / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745973450 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 03436fa75c714f64f8c93586303589b24992 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745991896 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 7c46333ff0471b48fbea9e6b90d8a1efb42ff97f / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745973450 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 03436fa75c714f64f8c93586303589b24992 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745991896 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 7c46333ff0471b48fbea9e6b90d8a1efb42ff97f / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745973450 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 03436fa75c714f64f8c93586303589b24992 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12745991896 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user ppkarwasz (triggered by ppkarwasz). Head commit for run: 10cfe28cc2db04ed4c57553bf5cc94775b34ad56 / Piotr P. Karwasz Add a RocketMQ BOM artifact Add a `rocketmq-bom` artifact that only manages RocketMQ dependency versions. The previous `rocketmq-all` artifact is reparented to `rocketmq-bom`. Report URL: https://github.com/apache/rocketmq/actions/runs/12745368965 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: cf4151ffc218ad8744dd82f29c654e4f3b206947 / qianye [ISSUE #9111] Broker Support export RocksDB Config to json file and enhance admin tools Report URL: https://github.com/apache/rocketmq/actions/runs/12744132983 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user ppkarwasz (triggered by ppkarwasz). Head commit for run: f6249e5b3a171be1cd0051732be77fd55ee4eb97 / Aurora Twinkle [ISSEU #6426] Fix slave broker SubscriptionGroupConfig and MessageRequestMode updating atomically (#8983) * fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically * add unit test * fix ut - Co-authored-by: duanlinlin Report URL: https://github.com/apache/rocketmq/actions/runs/12745451851 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8895] Fix NPE when broker shutdown and optimize the log [rocketmq]
lollipopjin merged PR #9094: URL: https://github.com/apache/rocketmq/pull/9094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly [rocketmq]
lollipopjin closed issue #8895: [Enhancement] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly URL: https://github.com/apache/rocketmq/issues/8895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094
This is an automated email from the ASF dual-hosted git repository.
lollipop pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 94d9185f2c [ISSUE #8895] Fix NPE when broker shutdown and optimize the
log #9094
94d9185f2c is described below
commit 94d9185f2c80bcfb9ffca03a65080f48060f0a39
Author: qianye
AuthorDate: Tue Jan 14 14:50:56 2025 +0800
[ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094
---
.../common/config/AbstractRocksDBStorage.java| 20 ++--
.../apache/rocketmq/store/DefaultMessageStore.java | 4 +---
.../store/queue/RocksDBConsumeQueueOffsetTable.java | 2 +-
3 files changed, 12 insertions(+), 14 deletions(-)
diff --git
a/common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java
b/common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java
index 347d92304d..6c0bce5929 100644
---
a/common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java
+++
b/common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java
@@ -18,7 +18,16 @@ package org.apache.rocketmq.common.config;
import com.google.common.collect.Maps;
import io.netty.buffer.PooledByteBufAllocator;
+import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.Semaphore;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
import org.apache.rocketmq.common.ThreadFactoryImpl;
import org.apache.rocketmq.common.constant.LoggerName;
import org.apache.rocketmq.common.utils.ThreadUtils;
@@ -43,16 +52,6 @@ import org.rocksdb.Status;
import org.rocksdb.WriteBatch;
import org.rocksdb.WriteOptions;
-import java.nio.ByteBuffer;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.ArrayBlockingQueue;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.Semaphore;
-import java.util.concurrent.ThreadPoolExecutor;
-import java.util.concurrent.TimeUnit;
-
public abstract class AbstractRocksDBStorage {
protected static final Logger LOGGER =
LoggerFactory.getLogger(LoggerName.ROCKSDB_LOGGER_NAME);
@@ -381,6 +380,7 @@ public abstract class AbstractRocksDBStorage {
public synchronized boolean shutdown() {
try {
if (!this.loaded) {
+LOGGER.info("RocksDBStorage is not loaded, shutdown OK.
dbPath={}, readOnly={}", this.dbPath, this.readOnly);
return true;
}
diff --git
a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
index 9d3c46a438..187a0729e8 100644
--- a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
+++ b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
@@ -517,11 +517,9 @@ public class DefaultMessageStore implements MessageStore {
if (this.compactionService != null) {
this.compactionService.shutdown();
}
-
-if (messageStoreConfig.isRocksdbCQDoubleWriteEnable()) {
+if (messageStoreConfig.isRocksdbCQDoubleWriteEnable() &&
this.rocksDBMessageStore != null) {
this.rocksDBMessageStore.consumeQueueStore.shutdown();
}
-
this.flushConsumeQueueService.shutdown();
this.allocateMappedFileService.shutdown();
this.storeCheckpoint.flush();
diff --git
a/store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueOffsetTable.java
b/store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueOffsetTable.java
index a91ae5e244..cb989852fb 100644
---
a/store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueOffsetTable.java
+++
b/store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueOffsetTable.java
@@ -144,7 +144,7 @@ public class RocksDBConsumeQueueOffsetTable {
Function predicate = entry -> entry.type ==
OffsetEntryType.MAXIMUM;
Consumer fn = entry -> {
topicQueueMaxCqOffset.putIfAbsent(entry.topic + "-" +
entry.queueId, entry.offset);
-ROCKSDB_LOG.info("Max {}:{} --> {}|{}", entry.topic,
entry.queueId, entry.offset, entry.commitLogOffset);
+log.info("LoadMaxConsumeQueueOffsets Max {}:{} --> {}|{}",
entry.topic, entry.queueId, entry.offset, entry.commitLogOffset);
};
try {
forEach(predicate, fn);
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549130 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549130 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #5068] Fix return types in ByteBuffer to Support JAVA9+ [rocketmq]
HattoriHenzo commented on PR #7033: URL: https://github.com/apache/rocketmq/pull/7033#issuecomment-2589024468 [late answer] To solve this issue I had to recompile the jar with the `JAVA_HOME `set to `Java 8 or 1.8` because the maven settings for the version of Java are set like this: ``` 1.8 1.8 ``` If you are using docker, use the **eclipse-temurin:8-jdk-alpine** image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #9128] Fix NPE when gRPC client ack message immediately after changing proxy [rocketmq]
qianye1001 opened a new pull request, #9129: URL: https://github.com/apache/rocketmq/pull/9129 …changing proxy ### Which Issue(s) This PR Fixes Fixes #9128 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 11bd64062aa09fd0fba0809aeae67bc28fce4051 / qianye [ISSUE #9128] Fix NPE when grpc client ack message immediately after changing proxy Report URL: https://github.com/apache/rocketmq/actions/runs/12762660428 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 11bd64062aa09fd0fba0809aeae67bc28fce4051 / qianye [ISSUE #9128] Fix NPE when grpc client ack message immediately after changing proxy Report URL: https://github.com/apache/rocketmq/actions/runs/12762660428 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549122 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by github-actions[bot]). Head commit for run: 11bd64062aa09fd0fba0809aeae67bc28fce4051 / qianye [ISSUE #9128] Fix NPE when grpc client ack message immediately after changing proxy Report URL: https://github.com/apache/rocketmq/actions/runs/12762660428 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762689493 With regards, GitHub Actions via GitBox
[I] ProducerImpl batch send message [rocketmq-clients]
xiaobao16 opened a new issue, #911: URL: https://github.com/apache/rocketmq-clients/issues/911 ### Programming Language of the Client Java ### Is Your Feature Request Related to a Problem? 1.ProducerImpl中有消息的批量发送方法，但是都是private的，对外暴露的消息发送方法都是只能发送单条消息的，为什么不增加批量发送消息对外暴露。2.还有个问题，可以构造的方法中增加入口可以添加ssl证书吗 ### Describe the Solution You'd Like 1.新增批量发送消息的方法对外暴露，2.还有个问题，可以构造的方法中增加入口可以添加ssl证书吗 ### Describe Alternatives You've Considered 1.新增批量发送消息的方法对外暴露，2.还有个问题，可以构造的方法中增加入口可以添加ssl证书吗 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-operator) branch master updated: Add podAnnotations field to CRDs and types for Broker, Controller, and NameService (#236)
This is an automated email from the ASF dual-hosted git repository. caigy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-operator.git The following commit(s) were added to refs/heads/master by this push: new 03741c8 Add podAnnotations field to CRDs and types for Broker, Controller, and NameService (#236) 03741c8 is described below commit 03741c8521a8d5063a1d5c1d1d704f1072e9d767 Author: yangw AuthorDate: Tue Jan 14 13:56:29 2025 +0800 Add podAnnotations field to CRDs and types for Broker, Controller, and NameService (#236) This commit introduces a new field, podAnnotations, to the CRDs and corresponding types for Broker, Controller, and NameService. This allows users to specify annotations for the pods created by these resources, enhancing customization and configuration options for deployments. Signed-off-by: yangw --- .../crds/rocketmq.apache.org_brokers.yaml | 5 .../crds/rocketmq.apache.org_controllers.yaml | 5 .../crds/rocketmq.apache.org_nameservices.yaml | 5 deploy/crds/rocketmq.apache.org_brokers.yaml | 5 deploy/crds/rocketmq.apache.org_controllers.yaml | 5 deploy/crds/rocketmq.apache.org_nameservices.yaml | 5 pkg/apis/rocketmq/v1alpha1/broker_types.go | 2 ++ pkg/apis/rocketmq/v1alpha1/controller_types.go | 2 ++ pkg/apis/rocketmq/v1alpha1/nameservice_types.go| 2 ++ .../rocketmq/v1alpha1/zz_generated.deepcopy.go | 28 ++ pkg/controller/broker/broker_controller.go | 3 ++- pkg/controller/console/console_controller.go | 8 --- pkg/controller/controller/dledger_controller.go| 3 ++- .../nameservice/nameservice_controller.go | 6 +++-- 14 files changed, 77 insertions(+), 7 deletions(-) diff --git a/charts/rocketmq-operator/crds/rocketmq.apache.org_brokers.yaml b/charts/rocketmq-operator/crds/rocketmq.apache.org_brokers.yaml index ffc0ad1..3d71b64 100644 --- a/charts/rocketmq-operator/crds/rocketmq.apache.org_brokers.yaml +++ b/charts/rocketmq-operator/crds/rocketmq.apache.org_brokers.yaml @@ -1171,6 +1171,11 @@ spec: description: NodeSelector is a selector which must be true for the pod to fit on a node type: object + podAnnotations: +additionalProperties: + type: string +description: Pod Annotations +type: object priorityClassName: description: PriorityClassName indicates the pod's priority type: string diff --git a/charts/rocketmq-operator/crds/rocketmq.apache.org_controllers.yaml b/charts/rocketmq-operator/crds/rocketmq.apache.org_controllers.yaml index 4f98506..7993880 100644 --- a/charts/rocketmq-operator/crds/rocketmq.apache.org_controllers.yaml +++ b/charts/rocketmq-operator/crds/rocketmq.apache.org_controllers.yaml @@ -1149,6 +1149,11 @@ spec: description: NodeSelector is a selector which must be true for the pod to fit on a node type: object + podAnnotations: +additionalProperties: + type: string +description: Pod Annotations +type: object priorityClassName: description: PriorityClassName indicates the pod's priority type: string diff --git a/charts/rocketmq-operator/crds/rocketmq.apache.org_nameservices.yaml b/charts/rocketmq-operator/crds/rocketmq.apache.org_nameservices.yaml index 49317b0..3f6676d 100644 --- a/charts/rocketmq-operator/crds/rocketmq.apache.org_nameservices.yaml +++ b/charts/rocketmq-operator/crds/rocketmq.apache.org_nameservices.yaml @@ -1158,6 +1158,11 @@ spec: description: NodeSelector is a selector which must be true for the pod to fit on a node type: object + podAnnotations: +additionalProperties: + type: string +description: Pod Annotations +type: object priorityClassName: description: PriorityClassName indicates the pod's priority type: string diff --git a/deploy/crds/rocketmq.apache.org_brokers.yaml b/deploy/crds/rocketmq.apache.org_brokers.yaml index ffc0ad1..3d71b64 100644 --- a/deploy/crds/rocketmq.apache.org_brokers.yaml +++ b/deploy/crds/rocketmq.apache.org_brokers.yaml @@ -1171,6 +1171,11 @@ spec: description: NodeSelector is a selector which must be true for the pod to fit on a node type: object + podAnnotations: +additionalProperties: + type: string +description: Pod Annotations +type: object priorityClassName: description: Priority
Re: [I] Add podAnnotations field to CRDs and types for Broker, Controller, and NameService [rocketmq-operator]
caigy closed issue #235: Add podAnnotations field to CRDs and types for Broker, Controller, and NameService URL: https://github.com/apache/rocketmq-operator/issues/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #235]Add podAnnotations field to CRDs and types for Broker, Controller, and NameService [rocketmq-operator]
caigy merged PR #236: URL: https://github.com/apache/rocketmq-operator/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549134 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 11bd64062aa09fd0fba0809aeae67bc28fce4051 / qianye [ISSUE #9128] Fix NPE when grpc client ack message immediately after changing proxy Report URL: https://github.com/apache/rocketmq/actions/runs/12762660430 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by github-actions[bot]). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549130 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9128] Fix NPE when gRPC client ack message immediately after changing proxy [rocketmq]
codecov-commenter commented on PR #9129: URL: https://github.com/apache/rocketmq/pull/9129#issuecomment-2589209716 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9129?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `20.0%` with `4 lines` in your changes missing coverage. Please review. > Project coverage is 47.93%. Comparing base [(`f6249e5`)](https://app.codecov.io/gh/apache/rocketmq/commit/f6249e5b3a171be1cd0051732be77fd55ee4eb97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`11bd640`)](https://app.codecov.io/gh/apache/rocketmq/commit/11bd64062aa09fd0fba0809aeae67bc28fce4051?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on develop. | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9129?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...tmq/proxy/grpc/v2/consumer/AckMessageActivity.java](https://app.codecov.io/gh/apache/rocketmq/pull/9129?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2Fv2%2Fconsumer%2FAckMessageActivity.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY29uc3VtZXIvQWNrTWVzc2FnZUFjdGl2aXR5LmphdmE=) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9129 +/- ## = - Coverage 48.02% 47.93% -0.09% - Complexity 1205012055 +5 = Files 1320 1321 +1 Lines 9284693024 +178 Branches 1189811926 +28 = + Hits 4458844594 +6 - Misses 4274842922 +174 + Partials5510 5508 -2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9129?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 94d9185f2c80bcfb9ffca03a65080f48060f0a39 / qianye [ISSUE #8895] Fix NPE when broker shutdown and optimize the log #9094 Report URL: https://github.com/apache/rocketmq/actions/runs/12762549134 With regards, GitHub Actions via GitBox
