[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user DongyuanPan (triggered by github-actions[bot]). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620674 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lollipopjin). Head commit for run: 1e37b25e00b2b15b7b2997b1b31e9f0fb1fdf6d3 / Li Zhanhui fix: Shallow clone of Session MUST include settings and telemetry-command-tx Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620065867 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
lizhimins merged PR #9107: URL: https://github.com/apache/rocketmq/pull/9107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Retries of revive process are not executed in backoff pattern as expected [rocketmq]
lizhimins closed issue #9106: [Bug] Retries of revive process are not executed in backoff pattern as expected URL: https://github.com/apache/rocketmq/issues/9106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 2538c3414d [ISSUE #9106] Fix revive backoff retry not effective in Pop
Consumption based on rocksdb (#9107)
2538c3414d is described below
commit 2538c3414d17604b930bcd52dba15edf210c4ab8
Author: Liu Shengzhong
AuthorDate: Mon Jan 6 10:03:34 2025 +0800
[ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption
based on rocksdb (#9107)
---
.../rocketmq/broker/pop/PopConsumerService.java| 11 ---
.../broker/pop/PopConsumerServiceTest.java | 36 ++
2 files changed, 43 insertions(+), 4 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
b/broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
index fb371dce05..647e3d6ff7 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/pop/PopConsumerService.java
@@ -496,10 +496,13 @@ public class PopConsumerService extends ServiceThread {
if (record.getAttemptTimes() <
brokerConfig.getPopReviveMaxAttemptTimes()) {
long backoffInterval = 1000L *
REWRITE_INTERVALS_IN_SECONDS[
Math.min(REWRITE_INTERVALS_IN_SECONDS.length,
record.getAttemptTimes())];
-record.setInvisibleTime(record.getInvisibleTime() +
backoffInterval);
-record.setAttemptTimes(record.getAttemptTimes() + 1);
-failureList.add(record);
-log.warn("PopConsumerService revive backoff retry,
record={}", record);
+long nextInvisibleTime = record.getInvisibleTime() +
backoffInterval;
+PopConsumerRecord retryRecord = new
PopConsumerRecord(record.getPopTime(), record.getGroupId(),
+record.getTopicId(), record.getQueueId(),
record.getRetryFlag(), nextInvisibleTime,
+record.getOffset(), record.getAttemptId());
+retryRecord.setAttemptTimes(record.getAttemptTimes() +
1);
+failureList.add(retryRecord);
+log.warn("PopConsumerService revive backoff retry,
record={}", retryRecord);
} else {
log.error("PopConsumerService drop record, message may
be lost, record={}", record);
}
diff --git
a/broker/src/test/java/org/apache/rocketmq/broker/pop/PopConsumerServiceTest.java
b/broker/src/test/java/org/apache/rocketmq/broker/pop/PopConsumerServiceTest.java
index 5e73adb1ea..b77c170c8c 100644
---
a/broker/src/test/java/org/apache/rocketmq/broker/pop/PopConsumerServiceTest.java
+++
b/broker/src/test/java/org/apache/rocketmq/broker/pop/PopConsumerServiceTest.java
@@ -385,6 +385,42 @@ public class PopConsumerServiceTest {
consumerService.shutdown();
}
+@Test
+public void reviveBackoffRetryTest() {
+
Mockito.when(brokerController.getEscapeBridge()).thenReturn(Mockito.mock(EscapeBridge.class));
+PopConsumerService consumerServiceSpy = Mockito.spy(consumerService);
+
+consumerService.getPopConsumerStore().start();
+
+long popTime = 10L;
+long invisibleTime = 60 * 1000L;
+PopConsumerRecord record = new PopConsumerRecord();
+record.setPopTime(popTime);
+record.setInvisibleTime(invisibleTime);
+record.setTopicId("topic");
+record.setGroupId("group");
+record.setQueueId(0);
+record.setOffset(0);
+
consumerService.getPopConsumerStore().writeRecords(Collections.singletonList(record));
+
+
Mockito.doReturn(CompletableFuture.completedFuture(Triple.of(Mockito.mock(MessageExt.class),
"", false)))
+
.when(consumerServiceSpy).getMessageAsync(any(PopConsumerRecord.class));
+
Mockito.when(brokerController.getEscapeBridge().putMessageToSpecificQueue(any(MessageExtBrokerInner.class))).thenReturn(
+new PutMessageResult(PutMessageStatus.UNKNOWN_ERROR, new
AppendMessageResult(AppendMessageStatus.UNKNOWN_ERROR))
+);
+
+long visibleTimestamp = popTime + invisibleTime;
+
+// revive fails
+Assert.assertEquals(1, consumerServiceSpy.revive(visibleTimestamp, 1));
+// should be invisible now
+Assert.assertEquals(0,
consumerService.getPopConsumerStore().scanExpiredRecords(visibleTimestamp,
1).size());
+// will be visible again in 10 seconds
+Assert.assertEquals(1,
consumerService.getPopConsumerStore().scanExpiredRecords(visibleTimestamp + 10
* 1000, 1).size());
+
+consumerService.shutdown();
+}
+
@Test
public void tr
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625164826 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by github-actions[bot]). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625164826 With regards, GitHub Actions via GitBox
Re: [I] [Bug] In RocketMQ, when the client producer is using a proxy proxy, the message will be sent with an exception error [rocketmq]
github-actions[bot] commented on issue #7718: URL: https://github.com/apache/rocketmq/issues/7718#issuecomment-2571804455 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Optimize RebalanceImpl#rebalanceByTopic method [rocketmq]
github-actions[bot] commented on issue #6442: URL: https://github.com/apache/rocketmq/issues/6442#issuecomment-2571804469 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] In RocketMQ, when the client producer is using a proxy proxy, the message will be sent with an exception error [rocketmq]
github-actions[bot] closed issue #7718: [Bug] In RocketMQ, when the client producer is using a proxy proxy, the message will be sent with an exception error URL: https://github.com/apache/rocketmq/issues/7718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add transaction message retry attempt for C# client Producer [rocketmq-clients]
github-actions[bot] commented on issue #876: URL: https://github.com/apache/rocketmq-clients/issues/876#issuecomment-2571812991 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add transaction message retry attempt for C# client Producer [rocketmq-clients]
github-actions[bot] closed issue #876: [Enhancement] Add transaction message retry attempt for C# client Producer URL: https://github.com/apache/rocketmq-clients/issues/876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by github-actions[bot]). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625164826 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user OneCodeMonkey (triggered by github-actions[bot]). Head commit for run: e33e096295397038bcf78bb914d1e160c8e0e08b / OneCodeMonkey <1460018...@qq.com> fix: Docker usage may occur error in volume mapping params, simple fix Report URL: https://github.com/apache/rocketmq/actions/runs/12579836920 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8895] CreateFlushConsumeQueueService for loadAndStartConsumerServiceOnly [rocketmq]
lizhimins commented on code in PR #9094:
URL: https://github.com/apache/rocketmq/pull/9094#discussion_r1903466939
##
common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java:
##
@@ -381,6 +381,7 @@ public synchronized boolean start() {
public synchronized boolean shutdown() {
try {
if (!this.loaded) {
+LOGGER.info("shutdown OK. {} is not loaded", this.dbPath);
Review Comment:
The log content should be more specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user OneCodeMonkey (triggered by lizhimins). Head commit for run: e33e096295397038bcf78bb914d1e160c8e0e08b / OneCodeMonkey <1460018...@qq.com> fix: Docker usage may occur error in volume mapping params, simple fix Report URL: https://github.com/apache/rocketmq/actions/runs/12579836920 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8998] No retry is required when the remaining time reaches zero [rocketmq]
lizhimins merged PR #8999: URL: https://github.com/apache/rocketmq/pull/8999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8998] No retry is required when the remaining time reaches zero (#8999)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 0548593b30 [ISSUE #8998] No retry is required when the remaining time
reaches zero (#8999)
0548593b30 is described below
commit 0548593b30466e527f0591e757e6efa204ab793d
Author: hqbfz <125714719+3424672...@users.noreply.github.com>
AuthorDate: Mon Jan 6 10:23:47 2025 +0800
[ISSUE #8998] No retry is required when the remaining time reaches zero
(#8999)
---
.../src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
index c462dd1241..7d4b51cfc5 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java
@@ -776,7 +776,7 @@ public class MQClientAPIImpl implements
NameServerUpdateCallback, StartAndShutdo
final DefaultMQProducerImpl producer
) {
int tmp = curTimes.incrementAndGet();
-if (needRetry && tmp <= timesTotal) {
+if (needRetry && tmp <= timesTotal && timeoutMillis > 0) {
String retryBrokerName = brokerName;//by default, it will send to
the same broker
if (topicPublishInfo != null) { //select one message queue
accordingly, in order to determine which broker to send
MessageQueue mqChosen =
producer.selectOneMessageQueue(topicPublishInfo, brokerName, false);
Re: [I] [Enhancement] no retry is required when time=0 [rocketmq]
lizhimins closed issue #8998: [Enhancement] no retry is required when time=0 URL: https://github.com/apache/rocketmq/issues/8998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user OneCodeMonkey (triggered by OneCodeMonkey). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625219740 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625164822 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 0548593b30466e527f0591e757e6efa204ab793d / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8998] No retry is required when the remaining time reaches zero (#8999) Report URL: https://github.com/apache/rocketmq/actions/runs/12625347306 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #4570] fix: Docker usage may occur error in volume mapping params, simple fix [rocketmq]
codecov-commenter commented on PR #9096: URL: https://github.com/apache/rocketmq/pull/9096#issuecomment-2572126215 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9096?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 48.00%. Comparing base [(`f32fe78`)](https://app.codecov.io/gh/apache/rocketmq/commit/f32fe78ca039fc2fec3341323dc61e8a9e486368?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e33e096`)](https://app.codecov.io/gh/apache/rocketmq/commit/e33e096295397038bcf78bb914d1e160c8e0e08b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 3 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9096 +/- ## = - Coverage 48.13% 48.00% -0.14% + Complexity 1208312045 -38 = Files 1320 1320 Lines 9278292782 Branches 1189711897 = - Hits 4466544538 -127 - Misses 4262542735 +110 - Partials5492 5509 +17 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9096?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user OneCodeMonkey (triggered by lizhimins). Head commit for run: e33e096295397038bcf78bb914d1e160c8e0e08b / OneCodeMonkey <1460018...@qq.com> fix: Docker usage may occur error in volume mapping params, simple fix Report URL: https://github.com/apache/rocketmq/actions/runs/12579836933 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9105] Fix the issue of duplicate consumption in LMQ [rocketmq]
DongyuanPan merged PR #9101: URL: https://github.com/apache/rocketmq/pull/9101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Messages are duplicated when using LMQ for pop consumption [rocketmq]
DongyuanPan closed issue #9105: [Bug] Messages are duplicated when using LMQ for pop consumption URL: https://github.com/apache/rocketmq/issues/9105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101)
This is an automated email from the ASF dual-hosted git repository.
dongyuanpan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 9ce83452a6 [ISSUE #9105] Fix the issue of duplicate consumption in LMQ
(#9101)
9ce83452a6 is described below
commit 9ce83452a62f3fb910454bab92c092c83d561bdb
Author: rongtong
AuthorDate: Mon Jan 6 10:51:58 2025 +0800
[ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101)
* Fix the issue of duplicate consumption in LMQ
* Pass the checkstyle
* Pass the UTs
* Pass the check style
---
.../broker/longpolling/PopLongPollingService.java | 17 -
.../broker/offset/ConsumerOrderInfoManager.java| 2 +-
.../broker/processor/AdminBrokerProcessor.java | 6 ++--
.../broker/processor/PopBufferMergeService.java| 6 ++--
.../longpolling/PopLongPollingServiceTest.java | 42 +++---
.../offset/ConsumerOrderInfoManagerTest.java | 6 +---
6 files changed, 39 insertions(+), 40 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java
b/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java
index 91185fbe94..e87a8e803f 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/longpolling/PopLongPollingService.java
@@ -52,7 +52,7 @@ public class PopLongPollingService extends ServiceThread {
LoggerFactory.getLogger(LoggerName.ROCKETMQ_POP_LOGGER_NAME);
private final BrokerController brokerController;
private final NettyRequestProcessor processor;
-private final ConcurrentHashMap>
topicCidMap;
+private final ConcurrentLinkedHashMap> topicCidMap;
private final ConcurrentLinkedHashMap> pollingMap;
private long lastCleanTime = 0;
@@ -63,7 +63,8 @@ public class PopLongPollingService extends ServiceThread {
this.brokerController = brokerController;
this.processor = processor;
// 10 topic default, 10 lru topic + cid + qid
-this.topicCidMap = new
ConcurrentHashMap<>(brokerController.getBrokerConfig().getPopPollingMapSize());
+this.topicCidMap = new ConcurrentLinkedHashMap.Builder>()
+
.maximumWeightedCapacity(this.brokerController.getBrokerConfig().getPopPollingMapSize()
* 2L).build();
this.pollingMap = new ConcurrentLinkedHashMap.Builder>()
.maximumWeightedCapacity(this.brokerController.getBrokerConfig().getPopPollingMapSize()).build();
this.notifyLast = notifyLast;
@@ -350,7 +351,7 @@ public class PopLongPollingService extends ServiceThread {
Map.Entry> entry =
topicCidMapIter.next();
String topic = entry.getKey();
if
(brokerController.getTopicConfigManager().selectTopicConfig(topic) == null) {
-POP_LOGGER.info("remove not exit topic {} in
topicCidMap!", topic);
+POP_LOGGER.info("remove nonexistent topic {} in
topicCidMap!", topic);
topicCidMapIter.remove();
continue;
}
@@ -358,8 +359,8 @@ public class PopLongPollingService extends ServiceThread {
while (cidMapIter.hasNext()) {
Map.Entry cidEntry = cidMapIter.next();
String cid = cidEntry.getKey();
-if
(!brokerController.getSubscriptionGroupManager().getSubscriptionGroupTable().containsKey(cid))
{
-POP_LOGGER.info("remove not exit sub {} of topic
{} in topicCidMap!", cid, topic);
+if
(!brokerController.getSubscriptionGroupManager().containsSubscriptionGroup(cid))
{
+POP_LOGGER.info("remove nonexistent subscription
group {} of topic {} in topicCidMap!", cid, topic);
cidMapIter.remove();
}
}
@@ -380,12 +381,12 @@ public class PopLongPollingService extends ServiceThread {
String topic = keyArray[0];
String cid = keyArray[1];
if
(brokerController.getTopicConfigManager().selectTopicConfig(topic) == null) {
-POP_LOGGER.info("remove not exit topic {} in
pollingMap!", topic);
+POP_LOGGER.info("remove nonexistent topic {} in
pollingMap!", topic);
pollingMapIter.remove();
continue;
}
-if
(!brokerController.getSubscriptionGroupManager().getSubscriptionGroupTable().containsKey(cid))
{
-POP_LOGGER.info("remove not exit sub {} of topic {} in
pollingMap!", cid,
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620682 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 2538c3414d17604b930bcd52dba15edf210c4ab8 / Liu Shengzhong [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb (#9107) Report URL: https://github.com/apache/rocketmq/actions/runs/12625164821 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by github-actions[bot]). Head commit for run: 0548593b30466e527f0591e757e6efa204ab793d / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8998] No retry is required when the remaining time reaches zero (#8999) Report URL: https://github.com/apache/rocketmq/actions/runs/12625347306 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by github-actions[bot]). Head commit for run: 0548593b30466e527f0591e757e6efa204ab793d / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8998] No retry is required when the remaining time reaches zero (#8999) Report URL: https://github.com/apache/rocketmq/actions/runs/12625347306 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by github-actions[bot]). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620682 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 0548593b30466e527f0591e757e6efa204ab793d / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8998] No retry is required when the remaining time reaches zero (#8999) Report URL: https://github.com/apache/rocketmq/actions/runs/12625347309 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by github-actions[bot]). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620682 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lollipopjin). Head commit for run: 1e37b25e00b2b15b7b2997b1b31e9f0fb1fdf6d3 / Li Zhanhui fix: Shallow clone of Session MUST include settings and telemetry-command-tx Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620065867 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620681 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620672 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: 9ce83452a62f3fb910454bab92c092c83d561bdb / rongtong [ISSUE #9105] Fix the issue of duplicate consumption in LMQ (#9101) * Fix the issue of duplicate consumption in LMQ * Pass the checkstyle * Pass the UTs * Pass the check style Report URL: https://github.com/apache/rocketmq/actions/runs/12625620674 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user OneCodeMonkey (triggered by github-actions[bot]). Head commit for run: e33e096295397038bcf78bb914d1e160c8e0e08b / OneCodeMonkey <1460018...@qq.com> fix: Docker usage may occur error in volume mapping params, simple fix Report URL: https://github.com/apache/rocketmq/actions/runs/12579836933 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
ChineseTony commented on PR #8880: URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2572443112 ok,thanks ,but isFieldNullable function can use temp variable to save and reture the value ,Don't need search key twice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f / lizhimins <707364...@qq.com> [ISSUE #9025] [RIP-73] Modify Pop Consumption rocksdb init config (#9100) Report URL: https://github.com/apache/rocketmq/actions/runs/12620225488 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 20cacec88baf9a74a293e91359ff2b86ffcceccb / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620034439 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: c9c6f43240b672733c56da994bd9defb40e62c54 / yx9o [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo Report URL: https://github.com/apache/rocketmq/actions/runs/12620027644 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by github-actions[bot]). Head commit for run: 6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8 / redlsz fix revive backoff retry Report URL: https://github.com/apache/rocketmq/actions/runs/12619802534 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 8dc2f4ee1f7e561c5fcf45c6c976158357e5940a / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620210737 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 20cacec88baf9a74a293e91359ff2b86ffcceccb / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620034439 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 8dc2f4ee1f7e561c5fcf45c6c976158357e5940a / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620210737 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: c9c6f43240b672733c56da994bd9defb40e62c54 / yx9o [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo Report URL: https://github.com/apache/rocketmq/actions/runs/12620027644 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 8dc2f4ee1f7e561c5fcf45c6c976158357e5940a / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620210737 With regards, GitHub Actions via GitBox
Re: [I] 使用rocketmq-spring-boot-starter导致异步打印日志失效 [rocketmq-spring]
OPbjO closed issue #700: 使用rocketmq-spring-boot-starter导致异步打印日志失效 URL: https://github.com/apache/rocketmq-spring/issues/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 使用rocketmq-spring-boot-starter导致异步打印日志失效 [rocketmq-spring]
OPbjO commented on issue #700: URL: https://github.com/apache/rocketmq-spring/issues/700#issuecomment-2571540333 异步日志需要在JVM启动时添加参数 -DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Retries of revive process are not executed in backoff pattern as expected [rocketmq]
redlsz opened a new issue, #9106:
URL: https://github.com/apache/rocketmq/issues/9106
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [X] I have searched the [GitHub
Issues](https://github.com/apache/rocketmq/issues) and [GitHub
Discussions](https://github.com/apache/rocketmq/discussions) of this
repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not
other repositories of RocketMQ.
### Runtime platform environment
macos/centos
### RocketMQ version
develop
### JDK Version
1.8
### Describe the Bug
When pop consumption based on rocksdb is enabled, retries of revive process
are not executed in backoff pattern as expected.
### Steps to Reproduce
org.apache.rocketmq.broker.pop.PopConsumerServiceTest
```
@Test
public void test() {
Mockito.when(brokerController.getEscapeBridge()).thenReturn(Mockito.mock(EscapeBridge.class));
PopConsumerService consumerServiceSpy = Mockito.spy(consumerService);
consumerService.getPopConsumerStore().start();
long popTime = 10L;
long invisibleTime = 60 * 1000L;
PopConsumerRecord record = new PopConsumerRecord();
record.setPopTime(popTime);
record.setInvisibleTime(invisibleTime);
record.setTopicId("topic");
record.setGroupId("group");
record.setQueueId(0);
record.setOffset(0);
consumerService.getPopConsumerStore().writeRecords(Collections.singletonList(record));
Mockito.doReturn(CompletableFuture.completedFuture(Triple.of(Mockito.mock(MessageExt.class),
"", false)))
.when(consumerServiceSpy).getMessageAsync(any(PopConsumerRecord.class));
Mockito.when(brokerController.getEscapeBridge().putMessageToSpecificQueue(any(MessageExtBrokerInner.class))).thenReturn(
new PutMessageResult(PutMessageStatus.UNKNOWN_ERROR, new
AppendMessageResult(AppendMessageStatus.UNKNOWN_ERROR))
);
long visibleTimestamp = popTime + invisibleTime;
// revive fails
Assert.assertEquals(1, consumerServiceSpy.revive(visibleTimestamp, 1));
// should be invisible now
Assert.assertEquals(0,
consumerService.getPopConsumerStore().scanExpiredRecords(visibleTimestamp,
1).size());
// will be visible again in 10 seconds
Assert.assertEquals(1,
consumerService.getPopConsumerStore().scanExpiredRecords(visibleTimestamp + 10
* 1000, 1).size());
consumerService.shutdown();
}
```
### What Did You Expect to See?
Retry in backoff pattern.
### What Did You See Instead?
Retry immediately.
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Enhancement] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo [rocketmq]
yx9o opened a new issue, #9108: URL: https://github.com/apache/rocketmq/issues/9108 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Use fastjson2 to replace fastjson1 ### Motivation Use fastjson2 to replace fastjson1 ### Describe the Solution You'd Like Use fastjson2 to replace fastjson1 ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: reset telemetry bidirectional stream on heartbeat timeout [rocketmq-clients]
lizhanhui opened a new pull request, #906: URL: https://github.com/apache/rocketmq-clients/pull/906 ### Which Issue(s) This PR Fixes Fixes #903 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 232725a6c4df7aa55c14cba1dea2e2e67bffa834 / Li Zhanhui fix: reset telemetry bidirectional stream on heartbeat timeout Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12619973127 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
codecov-commenter commented on PR #9107: URL: https://github.com/apache/rocketmq/pull/9107#issuecomment-2571629414 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9107?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.97%. Comparing base [(`a3afb05`)](https://app.codecov.io/gh/apache/rocketmq/commit/a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6c37a81`)](https://app.codecov.io/gh/apache/rocketmq/commit/6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9107 +/- ## = - Coverage 48.04% 47.97% -0.08% + Complexity 1206412039 -25 = Files 1320 1320 Lines 9282492827 +3 Branches 1189711897 = - Hits 4459644530 -66 - Misses 4273442782 +48 - Partials5494 5515 +21 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9107?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo [rocketmq]
yx9o opened a new pull request, #9109: URL: https://github.com/apache/rocketmq/pull/9109 Fixes #9108 , use fastjson2 to replace fastjson1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: c9c6f43240b672733c56da994bd9defb40e62c54 / yx9o [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo Report URL: https://github.com/apache/rocketmq/actions/runs/12620027643 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: c9c6f43240b672733c56da994bd9defb40e62c54 / yx9o [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo Report URL: https://github.com/apache/rocketmq/actions/runs/12620027643 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 61c9031209e5d70f7b77b17b467d7a791efd6998 / Li Zhanhui chore: format code Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620044926 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 232725a6c4df7aa55c14cba1dea2e2e67bffa834 / Li Zhanhui fix: reset telemetry bidirectional stream on heartbeat timeout Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12619973141 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 20cacec88baf9a74a293e91359ff2b86ffcceccb / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620034442 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 1e37b25e00b2b15b7b2997b1b31e9f0fb1fdf6d3 / Li Zhanhui fix: Shallow clone of Session MUST include settings and telemetry-command-tx Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620065874 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f / lizhimins <707364...@qq.com> [ISSUE #9025] [RIP-73] Modify Pop Consumption rocksdb init config (#9100) Report URL: https://github.com/apache/rocketmq/actions/runs/12620038968 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 61c9031209e5d70f7b77b17b467d7a791efd6998 / Li Zhanhui chore: format code Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620044929 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 1e37b25e00b2b15b7b2997b1b31e9f0fb1fdf6d3 / Li Zhanhui fix: Shallow clone of Session MUST include settings and telemetry-command-tx Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12620065867 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: c9c6f43240b672733c56da994bd9defb40e62c54 / yx9o [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo Report URL: https://github.com/apache/rocketmq/actions/runs/12620027643 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8 / redlsz fix revive backoff retry Report URL: https://github.com/apache/rocketmq/actions/runs/12619802534 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f / lizhimins <707364...@qq.com> [ISSUE #9025] [RIP-73] Modify Pop Consumption rocksdb init config (#9100) Report URL: https://github.com/apache/rocketmq/actions/runs/12620044713 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #9102] Fix bazel-compile (ubuntu-latest) ci run failure [rocketmq]
codecov-commenter commented on PR #9103: URL: https://github.com/apache/rocketmq/pull/9103#issuecomment-2571638969 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9103?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 47.94%. Comparing base [(`a3afb05`)](https://app.codecov.io/gh/apache/rocketmq/commit/a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`20cacec`)](https://app.codecov.io/gh/apache/rocketmq/commit/20cacec88baf9a74a293e91359ff2b86ffcceccb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9103?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...c/main/java/org/apache/rocketmq/common/MixAll.java](https://app.codecov.io/gh/apache/rocketmq/pull/9103?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fcommon%2FMixAll.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vTWl4QWxsLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9103 +/- ## = - Coverage 48.04% 47.94% -0.10% + Complexity 1206412037 -27 = Files 1320 1320 Lines 9282492825 +1 Branches 1189711897 = - Hits 4459644505 -91 - Misses 4273442809 +75 - Partials5494 5511 +17 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9103?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #9108] Refactor ColdDataCgCtrService#getColdDataFlowCtrInfo [rocketmq]
codecov-commenter commented on PR #9109: URL: https://github.com/apache/rocketmq/pull/9109#issuecomment-2571638568 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9109?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 47.97%. Comparing base [(`a3afb05`)](https://app.codecov.io/gh/apache/rocketmq/commit/a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c9c6f43`)](https://app.codecov.io/gh/apache/rocketmq/commit/c9c6f43240b672733c56da994bd9defb40e62c54?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#9109 +/- ## = - Coverage 48.04% 47.97% -0.08% + Complexity 1206412041 -23 = Files 1320 1320 Lines 9282492824 Branches 1189711897 = - Hits 4459644529 -67 - Misses 4273442783 +49 - Partials5494 5512 +18 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9109?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 8dc2f4ee1f7e561c5fcf45c6c976158357e5940a / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620210741 With regards, GitHub Actions via GitBox
[PR] [ISSUE #9106] Fix revive backoff retry not effective in Pop Consumption based on rocksdb [rocketmq]
redlsz opened a new pull request, #9107: URL: https://github.com/apache/rocketmq/pull/9107 ### Which Issue(s) This PR Fixes Fixes #9106 ### Brief Description When revive is needed to be retried, the original PopConsumerRecord object and the retry one should be independent of each other. ### How Did You Test This Change? Unit Test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by github-actions[bot]). Head commit for run: 6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8 / redlsz fix revive backoff retry Report URL: https://github.com/apache/rocketmq/actions/runs/12619802557 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8 / redlsz fix revive backoff retry Report URL: https://github.com/apache/rocketmq/actions/runs/12619802557 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by github-actions[bot]). Head commit for run: 6c37a8146f161ecb3b6e7fd9b6fd33cf55796db8 / redlsz fix revive backoff retry Report URL: https://github.com/apache/rocketmq/actions/runs/12619802557 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: a3afb05cb32f6c63fe8af5aef7a86ad1a4d5797f / lizhimins <707364...@qq.com> [ISSUE #9025] [RIP-73] Modify Pop Consumption rocksdb init config (#9100) Report URL: https://github.com/apache/rocketmq/actions/runs/12619822215 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by github-actions[bot]). Head commit for run: 20cacec88baf9a74a293e91359ff2b86ffcceccb / yx9o Update Report URL: https://github.com/apache/rocketmq/actions/runs/12620034439 With regards, GitHub Actions via GitBox
