[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user wangshaojie4039 (triggered by wangshaojie4039).

Head commit for run:
b675339dc15c38dc7f5062dd5ef643b8c787f898 / wangshaojie4039 <15001782...@163.com>
fix tiered store ConstructIndexFile ConcurrentModificationException,add  test

Report URL: https://github.com/apache/rocketmq/actions/runs/12480838454

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user wangshaojie4039 (triggered by github-actions[bot]).

Head commit for run:
b675339dc15c38dc7f5062dd5ef643b8c787f898 / wangshaojie4039 <15001782...@163.com>
fix tiered store ConstructIndexFile ConcurrentModificationException,add  test

Report URL: https://github.com/apache/rocketmq/actions/runs/12480838454

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user wangshaojie4039 (triggered by github-actions[bot]).

Head commit for run:
b675339dc15c38dc7f5062dd5ef643b8c787f898 / wangshaojie4039 <15001782...@163.com>
fix tiered store ConstructIndexFile ConcurrentModificationException,add  test

Report URL: https://github.com/apache/rocketmq/actions/runs/12480838454

With regards,
GitHub Actions via GitBox



Re: [I] 初始化Producer时需要设置通信配置以及预绑定的Topic报错 [rocketmq]

2024-12-24 Thread via GitHub


qianye1001 commented on issue #9031:
URL: https://github.com/apache/rocketmq/issues/9031#issuecomment-2561002907

   i guess you do use namesrv endpoint instead of proxy endpoint, rmq grpc 
client need to connect to proxy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user wangshaojie4039 (triggered by wangshaojie4039).

Head commit for run:
35a6426ea9cca0e9606eac396f30f57cf44412b5 / lizhimins <707364...@qq.com>
[ISSUE #9025] [RIP-73] Pop Consumption Improvement Based on RocksDB (#9048)

Report URL: https://github.com/apache/rocketmq/actions/runs/12480864636

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #9069] Fix the IndexFile ConcurrentModificationException in tiered storage [rocketmq]

2024-12-24 Thread via GitHub


wangshaojie4039 commented on code in PR #9071:
URL: https://github.com/apache/rocketmq/pull/9071#discussion_r1896601388


##
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreDispatcherImpl.java:
##
@@ -153,10 +160,22 @@ public CompletableFuture 
doScheduleDispatch(FlatFileInterface flatFile,
 
 // If the previous commit fails, attempt to trigger a commit 
directly.
 if (commitOffset < currentOffset) {
-this.commitAsync(flatFile);
+this.commitAsync(flatFile).whenComplete((result, throwable) -> 
{
+if (throwable != null) {
+log.error("topic: {}, queueId: {} flat file flush 
cache failed more than twice.", topic, queueId, throwable);

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Bug] In the same ConsumerGroup, the Consumer instances have different Topics subscribed to do not work on the 5.2.0 SDK [rocketmq]

2024-12-24 Thread via GitHub


ljw1264654273 opened a new issue, #9078:
URL: https://github.com/apache/rocketmq/issues/9078

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   OS:openEuler22.03(LTS-SP3)
   
   ### RocketMQ version
   
   version:rocketmq-all-5.3.1
   
   ### JDK Version
   
   Run:openjdk 1.8.0_432
   
   ### Describe the Bug
   
   In the same ConsumerGroup, the Consumer instances have different Topics 
subscribed to do not work on the 5.2.0 SDK.
   
   ### Steps to Reproduce
   
   I started two consumer instances with the same consumer group configuration, 
subscribing to different topics separately. However, the subscription 
relationship was inconsistent, resulting in chaotic and lost consumer messages. 
As described in the official documentation, the 5. x version SDK does not 
support consumer instances under the same consumer group subscribing to 
different topics.
   
   ### What Did You Expect to See?
   
   The 5.x version of the SDK supports Consumer instances in the same 
ConsumerGroup subscribing to different topics.
   
   ### What Did You See Instead?
   
   
![image](https://github.com/user-attachments/assets/22380261-84ba-4224-a5f4-293f5f387063)
   
![image](https://github.com/user-attachments/assets/0c7aee5b-d7ef-4fe7-946d-a307ca0266e6)
   
![image](https://github.com/user-attachments/assets/a2935463-a154-471c-a31f-185b2707527f)
   
   ### Additional Context
   
   I developed in the springboot environment, version 2.7.18,and the version of 
rocketmq-spring-boot-starter is 2.3.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Bug] Bug title rocketmq5.3版本,开启proxy后。remoting发送消息,不支持ipv6;grpc发送是正常的 [rocketmq]

2024-12-24 Thread via GitHub


jaylu163 opened a new issue, #9077:
URL: https://github.com/apache/rocketmq/issues/9077

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   centos,
   容器环境使用
   
   
   ### RocketMQ version
   
   5.3.0
   
   
   ### JDK Version
   
   1.8.0_412
   
   
   ### Describe the Bug
   
   使用 remoting方式发送消息,发送失败。客户端提示 
   UNAVAILABLE: Network closed for unknown reason
   
   ### Steps to Reproduce
   
   在k8s中开启 proxy,使用cluster模式部署
   
   然后使用remoting发送消息
   
   ### What Did You Expect to See?
   
   希望能使用remoting的ipv6可以发送消息
   
   ### What Did You See Instead?
   
   客户端日志报错如下图:
   
![image](https://github.com/user-attachments/assets/e5f58e07-57e5-4665-a5f2-05214908bb78)
   
   服务端的日志:remoting日志如下图
   
   
![image](https://github.com/user-attachments/assets/14858aaa-de4b-495d-b265-65d434d52b09)
   
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user wangshaojie4039 (triggered by wangshaojie4039).

Head commit for run:
b675339dc15c38dc7f5062dd5ef643b8c787f898 / wangshaojie4039 <15001782...@163.com>
fix tiered store ConstructIndexFile ConcurrentModificationException,add  test

Report URL: https://github.com/apache/rocketmq/actions/runs/12480838460

With regards,
GitHub Actions via GitBox



[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build" on rocketmq-clients.git has failed.
Run started by GitHub user herywang (triggered by lollipopjin).

Head commit for run:
90bf4fa4ec5ec1286b6a293ceae415ff04cca841 / wangheng <673602...@qq.com>
[ISSUE #889] Python Example: start a simple consumer in background thread (#889)

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12312478185

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user wangshaojie4039 (triggered by github-actions[bot]).

Head commit for run:
b675339dc15c38dc7f5062dd5ef643b8c787f898 / wangshaojie4039 <15001782...@163.com>
fix tiered store ConstructIndexFile ConcurrentModificationException,add  test

Report URL: https://github.com/apache/rocketmq/actions/runs/12480838460

With regards,
GitHub Actions via GitBox



Re: [I] [Bug] In the same ConsumerGroup, the Consumer instances have different Topics subscribed to do not work on the 5.2.0 SDK [rocketmq]

2024-12-24 Thread via GitHub


ljw1264654273 commented on issue #9078:
URL: https://github.com/apache/rocketmq/issues/9078#issuecomment-2561556919

   The official documentation states that version 5. x of the SDK now supports 
subscribing to different topics for Consumer instances under the same 
ConsumerGroup.
   
![image](https://github.com/user-attachments/assets/1cef8619-2ff4-4142-8a3c-f6f8b8bcf4d7)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490334243

With regards,
GitHub Actions via GitBox



[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build" on rocketmq-clients.git has failed.
Run started by GitHub user qianye1001 (triggered by lollipopjin).

Head commit for run:
9d27ebaa24b0c3aaf03d225e207d2e9ab3d8b661 / qianye 

fix

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12490576491

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by github-actions[bot]).

Head commit for run:
186f38f68d7ba3a107f2e98a9d8a08fe6bc0a390 / dingshuangxi888 

Avoid message type validate in message sync scenario.

Report URL: https://github.com/apache/rocketmq/actions/runs/12490750427

With regards,
GitHub Actions via GitBox



[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build" on rocketmq-clients.git has failed.
Run started by GitHub user qianye1001 (triggered by qianye1001).

Head commit for run:
9d27ebaa24b0c3aaf03d225e207d2e9ab3d8b661 / qianye 

fix

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12490576491

With regards,
GitHub Actions via GitBox



[I] [Enhancement] Make Client prefer to use endpoints in config when pick endpoints to QueryAssignments [rocketmq-clients]

2024-12-24 Thread via GitHub


qianye1001 opened a new issue, #894:
URL: https://github.com/apache/rocketmq-clients/issues/894

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Programming Language of the Client
   
   Not related to the specified programming language
   
   ### Summary
   
   Make Client prefer to use endpoints in config when pick endpoints to 
QueryAssignments
   
   ### Motivation
   
   Make Client prefer to use endpoints in config when pick endpoints to 
QueryAssignments
   
   ### Describe the Solution You'd Like
   
   Make Client prefer to use endpoints in config when pick endpoints to 
QueryAssignments
   
   ### Describe Alternatives You've Considered
   
   null
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by github-actions[bot]).

Head commit for run:
186f38f68d7ba3a107f2e98a9d8a08fe6bc0a390 / dingshuangxi888 

Avoid message type validate in message sync scenario.

Report URL: https://github.com/apache/rocketmq/actions/runs/12490750427

With regards,
GitHub Actions via GitBox



[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build" on rocketmq-clients.git has failed.
Run started by GitHub user qianye1001 (triggered by lollipopjin).

Head commit for run:
9d27ebaa24b0c3aaf03d225e207d2e9ab3d8b661 / qianye 

fix

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12490576491

With regards,
GitHub Actions via GitBox



Re: [PR] fix[slave]:Make SubscriptionGroupConfig and MessageRequestMode updating atomically [rocketmq]

2024-12-24 Thread via GitHub


AuroraTwinkle commented on PR #8983:
URL: https://github.com/apache/rocketmq/pull/8983#issuecomment-2561694148

   @Jason918 @lizhimins Would you please merge this PR?Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [ISSUE #894] Make Client prefer to use endpoints in config when pick endpoints to QueryAssignments [rocketmq-clients]

2024-12-24 Thread via GitHub


qianye1001 opened a new pull request, #895:
URL: https://github.com/apache/rocketmq-clients/pull/895

   
   
   ### Which Issue(s) This PR Fixes
   
   
   
   Fixes #894 
   
   ### Brief Description
   
   
   
   ### How Did You Test This Change?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490334254

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
186f38f68d7ba3a107f2e98a9d8a08fe6bc0a390 / dingshuangxi888 

Avoid message type validate in message sync scenario.

Report URL: https://github.com/apache/rocketmq/actions/runs/12490750427

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490770121

With regards,
GitHub Actions via GitBox



[I] [Feature] 能不能给php swoole做一个长连接的sdk,或者使用grpc双向流的sdk [rocketmq-clients]

2024-12-24 Thread via GitHub


wisonlau opened a new issue, #893:
URL: https://github.com/apache/rocketmq-clients/issues/893

   ### Programming Language of the Client
   
   PHP
   
   ### Is Your Feature Request Related to a Problem?
   
   能不能给php swoole做一个长连接的sdk,或者使用grpc双向流的sdk,这样能提高消息的发送效率和接收效率
   
   ### Describe the Solution You'd Like
   
   sdk
   
   ### Describe Alternatives You've Considered
   
   无
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #8957] Remove excess traffic and fix cache inconsistencies [rocketmq]

2024-12-24 Thread via GitHub


qianye1001 commented on PR #8958:
URL: https://github.com/apache/rocketmq/pull/8958#issuecomment-2561654198

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

2024-12-24 Thread lizhimin
This is an automated email from the ASF dual-hosted git repository.

lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new d63373a152 [ISSUE #8957] Remove excess traffic and fix cache 
inconsistencies (#8958)
d63373a152 is described below

commit d63373a152ebd395cdce6a2e04e01b62e54c76af
Author: hqbfz <125714719+3424672...@users.noreply.github.com>
AuthorDate: Wed Dec 25 14:38:57 2024 +0800

[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)
---
 .../client/impl/consumer/RebalanceImpl.java| 53 +-
 1 file changed, 1 insertion(+), 52 deletions(-)

diff --git 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
index d1f0d116e0..b6f1d99b1c 100644
--- 
a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
+++ 
b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/RebalanceImpl.java
@@ -36,7 +36,6 @@ import org.apache.rocketmq.common.MixAll;
 import org.apache.rocketmq.common.message.MessageQueue;
 import org.apache.rocketmq.common.message.MessageQueueAssignment;
 import org.apache.rocketmq.common.message.MessageRequestMode;
-import org.apache.rocketmq.remoting.exception.RemotingTimeoutException;
 import org.apache.rocketmq.remoting.protocol.body.LockBatchRequestBody;
 import org.apache.rocketmq.remoting.protocol.body.UnlockBatchRequestBody;
 import org.apache.rocketmq.remoting.protocol.filter.FilterAPI;
@@ -60,12 +59,8 @@ public abstract class RebalanceImpl {
 protected MessageModel messageModel;
 protected AllocateMessageQueueStrategy allocateMessageQueueStrategy;
 protected MQClientInstance mQClientFactory;
-private static final int TIMEOUT_CHECK_TIMES = 3;
 private static final int QUERY_ASSIGNMENT_TIMEOUT = 3000;
 
-private Map topicBrokerRebalance = new 
ConcurrentHashMap<>();
-private Map topicClientRebalance = new 
ConcurrentHashMap<>();
-
 public RebalanceImpl(String consumerGroup, MessageModel messageModel,
 AllocateMessageQueueStrategy allocateMessageQueueStrategy,
 MQClientInstance mQClientFactory) {
@@ -241,7 +236,7 @@ public abstract class RebalanceImpl {
 for (final Map.Entry entry : 
subTable.entrySet()) {
 final String topic = entry.getKey();
 try {
-if (!clientRebalance(topic) && tryQueryAssignment(topic)) {
+if (!clientRebalance(topic)) {
 boolean result = 
this.getRebalanceResultFromBroker(topic, isOrder);
 if (!result) {
 balanced = false;
@@ -266,38 +261,6 @@ public abstract class RebalanceImpl {
 return balanced;
 }
 
-private boolean tryQueryAssignment(String topic) {
-if (topicClientRebalance.containsKey(topic)) {
-return false;
-}
-
-if (topicBrokerRebalance.containsKey(topic)) {
-return true;
-}
-String strategyName = allocateMessageQueueStrategy != null ? 
allocateMessageQueueStrategy.getName() : null;
-int retryTimes = 0;
-while (retryTimes++ < TIMEOUT_CHECK_TIMES) {
-try {
-Set resultSet = 
mQClientFactory.queryAssignment(topic, consumerGroup,
-strategyName, messageModel, QUERY_ASSIGNMENT_TIMEOUT / 
TIMEOUT_CHECK_TIMES * retryTimes);
-topicBrokerRebalance.put(topic, topic);
-return true;
-} catch (Throwable t) {
-if (!(t instanceof RemotingTimeoutException)) {
-log.error("tryQueryAssignment error.", t);
-topicClientRebalance.put(topic, topic);
-return false;
-}
-}
-}
-if (retryTimes >= TIMEOUT_CHECK_TIMES) {
-// if never success before and timeout exceed TIMEOUT_CHECK_TIMES, 
force client rebalance
-topicClientRebalance.put(topic, topic);
-return false;
-}
-return true;
-}
-
 public ConcurrentMap getSubscriptionInner() {
 return subscriptionInner;
 }
@@ -460,20 +423,6 @@ public abstract class RebalanceImpl {
 }
 }
 }
-
-Iterator> clientIter = 
topicClientRebalance.entrySet().iterator();
-while (clientIter.hasNext()) {
-if (!subTable.containsKey(clientIter.next().getKey())) {
-clientIter.remove();
-}
-}
-
-Iterator> brokerIter = 
topicBrokerRebalance.entrySet().iterator();
-while (brokerIter.hasNext()) {
-if (!subTable.containsKey(brokerIter.next().getKey())) {
-brokerIter.remove();
-}
-}
 }
 
 privat

Re: [I] [Bug] Network jitter encountered while rebalancing results in repeated consumption or errors in pop mode [rocketmq]

2024-12-24 Thread via GitHub


lizhimins closed issue #8686: [Bug] Network jitter encountered while 
rebalancing results in repeated consumption or errors in pop mode
URL: https://github.com/apache/rocketmq/issues/8686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Enhancement] Avoid unnecessary network communication when rebalance in POP [rocketmq]

2024-12-24 Thread via GitHub


lizhimins closed issue #8957: [Enhancement] Avoid unnecessary network 
communication when rebalance in POP
URL: https://github.com/apache/rocketmq/issues/8957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #8957] Remove excess traffic and fix cache inconsistencies [rocketmq]

2024-12-24 Thread via GitHub


lizhimins merged PR #8958:
URL: https://github.com/apache/rocketmq/pull/8958


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490334244

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user lizhimins (triggered by github-actions[bot]).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490334244

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-24 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user lizhimins (triggered by github-actions[bot]).

Head commit for run:
d63373a152ebd395cdce6a2e04e01b62e54c76af / hqbfz 
<125714719+3424672...@users.noreply.github.com>
[ISSUE #8957] Remove excess traffic and fix cache inconsistencies (#8958)

Report URL: https://github.com/apache/rocketmq/actions/runs/12490334244

With regards,
GitHub Actions via GitBox