Re: [PR] new python sdk [rocketmq-clients]

2024-12-18 Thread via GitHub


feipengzhao commented on PR #864:
URL: https://github.com/apache/rocketmq-clients/pull/864#issuecomment-2550665467

   **RocketMQ 5.0** 的**监控报警**功能,在**消费者 在线/掉线** 
都会进行**消息堆积**的数据收集以及报警吗,比较关注监控报警功能,还有**消息延迟时间**的报警


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Enhancement] 5.x client cant support broadcasting mode? [rocketmq-clients]

2024-12-18 Thread via GitHub


qianye1001 commented on issue #888:
URL: 
https://github.com/apache/rocketmq-clients/issues/888#issuecomment-2550762906

   grpc client uses pop instead of pull, it can not support broadcast. maybe 
you need to use remoting client


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Enhancement] Optimize the way to determine whether RMQ_SYS_TRANS-HALFTOPIC is in RMQ_SSYS_TRANS-OP_ALF_TOPIC in transaction messages [rocketmq]

2024-12-18 Thread via GitHub


LilMosey opened a new issue, #9064:
URL: https://github.com/apache/rocketmq/issues/9064

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   
org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl#check
   
   https://github.com/user-attachments/assets/8d43851a-2fdb-49b1-9c18-9b4e39c628df";
 />
   
   
   ### Motivation
   
   if ((removedOpOffset = removeMap.remove(i)) != null){
   log.debug("Half offset {} has been committed/rolled 
back", i);
   opMsgMap.get(removedOpOffset).remove(i);
   if (opMsgMap.get(removedOpOffset).size() == 0) {
   opMsgMap.remove(removedOpOffset);
   doneOpOffset.add(removedOpOffset);
   }
   }
   
   ### Describe the Solution You'd Like
   
   if ((removedOpOffset = removeMap.remove(i)) != null){
   log.debug("Half offset {} has been committed/rolled 
back", i);
   opMsgMap.get(removedOpOffset).remove(i);
   if (opMsgMap.get(removedOpOffset).size() == 0) {
   opMsgMap.remove(removedOpOffset);
   doneOpOffset.add(removedOpOffset);
   }
   }
   
   ### Describe Alternatives You've Considered
   
   事务消息, 回查判断RMQ_SYS_TRANS_HALF_TOPIC消息是否在RMQ_SYS_TRANS_OP_HALF_TOPIC 
中,优化判断方式。之前代码是先判断Map.containsKey,然后进行removeKey,新的方式是直接removeKey != 
null。之前如果Map.containsKey为真,还需要进行额外的一步removeKey操作,新的方式removeKey!= 
null,即判断了Map是否存在key,又移出了对应的key,提升了一点点性能。
   经过多轮测试,在Map.containsKey 
为true为false概率各为50%的情况,第二种方案明显优于第一种方案。而实际生产环境中,事务回查状态为Unknown的场景应该小于50%,在高并发大数据量场景下,个人认为这个小改动对性能还是有一些提升。
   
   Transactional messages: The process involves checking whether messages in 
RMQ_SYS_TRANS_HALF_TOPIC exist in RMQ_SYS_TRANS_OP_HALF_TOPIC, with an 
optimized approach for verification. Previously, the code first used 
Map.containsKey to check existence and then performed removeKey. The new 
approach directly uses removeKey != null.
   
   In the previous method, if Map.containsKey returned true, an additional 
removeKey operation was required. In contrast, the new approach both checks if 
the key exists in the Map and removes the corresponding key in one step, 
offering a slight performance improvement.
   
   After multiple rounds of testing, when the probabilities of Map.containsKey 
being true or false are both 50%, the second approach consistently outperforms 
the first. In actual production environments, the probability of transactional 
checks being in an “Unknown” state should be less than 50%. Therefore, I 
believe this small adjustment provides a minor but meaningful performance 
improvement.
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature] Producer send message do not support batch send [rocketmq-clients]

2024-12-18 Thread via GitHub


lizhimins commented on issue #886:
URL: 
https://github.com/apache/rocketmq-clients/issues/886#issuecomment-2552659363

   protocol not support now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature] Producer send message do not support batch send [rocketmq-clients]

2024-12-18 Thread via GitHub


lizhimins closed issue #886: [Feature] Producer send message do not support  
batch send
URL: https://github.com/apache/rocketmq-clients/issues/886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #9002]when bytebuffer is not enough, do not throw exception [rocketmq]

2024-12-18 Thread via GitHub


RongtongJin merged PR #9003:
URL: https://github.com/apache/rocketmq/pull/9003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] In the master-slave replication scenario, since the replication is based on bytes, the slave data will often be temporarily incomplete. [rocketmq]

2024-12-18 Thread via GitHub


RongtongJin closed issue #9002: [Bug] In the master-slave replication scenario, 
since the replication is based on bytes, the slave data will often be 
temporarily incomplete.
URL: https://github.com/apache/rocketmq/issues/9002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

2024-12-18 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 16b6e53263 [ISSUE #9002] when bytebuffer is not enough, do not throw 
exception (#9003)
16b6e53263 is described below

commit 16b6e53263477794125a49d9f31a994a510970b7
Author: Lei Zhiyuan 
AuthorDate: Thu Dec 19 11:44:32 2024 +0800

[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of 
throw exception

* fix: when bytebuffer is not enough,we should wait for next instead of 
throw exception
---
 store/src/main/java/org/apache/rocketmq/store/CommitLog.java | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java 
b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
index d30691908b..ff96bf1066 100644
--- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
+++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
@@ -432,8 +432,14 @@ public class CommitLog implements Swappable {
 public DispatchRequest checkMessageAndReturnSize(java.nio.ByteBuffer 
byteBuffer, final boolean checkCRC,
 final boolean checkDupInfo, final boolean readBody) {
 try {
+if (byteBuffer.remaining() <= 4) {
+return new DispatchRequest(-1, false /* fail */);
+}
 // 1 TOTAL SIZE
 int totalSize = byteBuffer.getInt();
+if (byteBuffer.remaining() < totalSize - 4) {
+return new DispatchRequest(-1, false /* fail */);
+}
 
 // 2 MAGIC CODE
 int magicCode = byteBuffer.getInt();
@@ -628,6 +634,7 @@ public class CommitLog implements Swappable {
 
 return dispatchRequest;
 } catch (Exception e) {
+log.error("checkMessageAndReturnSize failed, may can not 
dispatch", e);
 }
 
 return new DispatchRequest(-1, false /* success */);



Re: [PR] [ISSUE #9059] Support reset offset for lite pull consumer [rocketmq]

2024-12-18 Thread via GitHub


RongtongJin commented on PR #9060:
URL: https://github.com/apache/rocketmq/pull/9060#issuecomment-2552713452

   CI needs to be passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user LilMosey (triggered by RongtongJin).

Head commit for run:
f13c93e8dae7605c056d4dbaac3d0d605dfe0199 / TangJie 
事务消息, 回查判断OP_HALF_QUEUE 消息是否在HALF_QUEUE中,优化判断方式。
Transaction message, check back to determine if the OP-HALF-QUEUE message is in 
HALF-QUEUE, optimize the judgment method

Report URL: https://github.com/apache/rocketmq/actions/runs/12391870520

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user LilMosey (triggered by github-actions[bot]).

Head commit for run:
f13c93e8dae7605c056d4dbaac3d0d605dfe0199 / TangJie 
事务消息, 回查判断OP_HALF_QUEUE 消息是否在HALF_QUEUE中,优化判断方式。
Transaction message, check back to determine if the OP-HALF-QUEUE message is in 
HALF-QUEUE, optimize the judgment method

Report URL: https://github.com/apache/rocketmq/actions/runs/12391870520

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849218

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by github-actions[bot]).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849218

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by github-actions[bot]).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849218

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849226

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!

2024-12-18 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has 
succeeded.
Run started by GitHub user LilMosey (triggered by LilMosey).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405872417

With regards,
GitHub Actions via GitBox



Re: [I] [Feature] 5.x Client can support 4.x rocketmq server? [rocketmq-clients]

2024-12-18 Thread via GitHub


lizhimins closed issue #887: [Feature] 5.x Client can support  4.x rocketmq 
server?
URL: https://github.com/apache/rocketmq-clients/issues/887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature] 5.x Client can support 4.x rocketmq server? [rocketmq-clients]

2024-12-18 Thread via GitHub


lizhimins commented on issue #887:
URL: 
https://github.com/apache/rocketmq-clients/issues/887#issuecomment-2552665577

   5.x client based on gRPC protocol,client connect to proxy rather than ns or 
broker


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849221

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-12-18 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user LilMosey (triggered by RongtongJin).

Head commit for run:
f13c93e8dae7605c056d4dbaac3d0d605dfe0199 / TangJie 
事务消息, 回查判断OP_HALF_QUEUE 消息是否在HALF_QUEUE中,优化判断方式。
Transaction message, check back to determine if the OP-HALF-QUEUE message is in 
HALF-QUEUE, optimize the judgment method

Report URL: https://github.com/apache/rocketmq/actions/runs/12391870495

With regards,
GitHub Actions via GitBox



Re: [I] [Feature] 5.x Client can support 4.x rocketmq server? [rocketmq-clients]

2024-12-18 Thread via GitHub


qianye1001 commented on issue #887:
URL: 
https://github.com/apache/rocketmq-clients/issues/887#issuecomment-2552649534

   5.x Client need 5.x proxy, can not connect namesrv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature] Producer send message do not support batch send [rocketmq-clients]

2024-12-18 Thread via GitHub


qianye1001 commented on issue #886:
URL: 
https://github.com/apache/rocketmq-clients/issues/886#issuecomment-2552650708

   5.x client need 5.x proxy, proxy do not support batch send now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] How does rocketmq return the message to the specified queue when the message is retried? [rocketmq]

2024-12-18 Thread via GitHub


ZShUn opened a new issue, #9066:
URL: https://github.com/apache/rocketmq/issues/9066

   ### Search before creation
   
   - [X] I had searched in the 
[issues](https://github.com/apache/rocketmq/issues) and found no similar issues.
   
   
   ### Documentation Related
   
   When I used queue to implement traffic isolation, I found that the message 
retry queue was single and could not return to the consumption queue.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq-clients): Workflow run "go_modules in /golang for golang.org/x/net - Update #935108635" failed!

2024-12-18 Thread GitBox


The GitHub Actions job "go_modules in /golang for golang.org/x/net - Update 
#935108635" on rocketmq-clients.git has failed.
Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]).

Head commit for run:
d2f95889b4852251ba5c526ef790ea8735b42100 / imzs 
[ISSUE #878] The java implementation of recalling API (#879)

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/12402791356

With regards,
GitHub Actions via GitBox



[I] [Bug] Bug title rocketmq 跑了三个月物理内存占用远超实际jvm设置堆内存 [rocketmq]

2024-12-18 Thread via GitHub


527054314 opened a new issue, #9065:
URL: https://github.com/apache/rocketmq/issues/9065

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   jvm参数:
   /usr/local/java/jdk1.8.0_401/bin/java -server -Xms10g -Xmx10g -XX:+UseG1GC 
-XX:G1HeapRegionSize=16m -XX:G1ReservePercent=25 
-XX:InitiatingHeapOccupancyPercent=30 -XX:SoftRefLRUPolicyMSPerMB=0 -verbose:gc 
-Xloggc:/dev/shm/rmq_srv_gc_%p_%t.log -XX:+PrintGCDetails 
-XX:+PrintGCDateStamps -XX:+PrintGCApplicationStoppedTime 
-XX:+PrintAdaptiveSizePolicy -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 
-XX:GCLogFileSize=30m -XX:-OmitStackTraceInFastThrow -XX:+AlwaysPreTouch 
-XX:MaxDirectMemorySize=15g -XX:-UseLargePages -XX:-UseBiasedLocking -cp 
.:/opt/rocketmq/bin/../conf:/opt/rocketmq/bin/../lib/*:.:/usr/local/java/jdk1.8.0_401/lib
 -Drmq.logback.configurationFile=/opt/rocketmq/conf/rmq.broker.logback.xml 
org.apache.rocketmq.broker.BrokerStartup -c /opt/rocketmq/conf/esb/broker-a.conf
   
   
   实际三个月过后发现broker内存实际占用80g
   https://github.com/user-attachments/assets/25840116-1457-4d3a-b8e4-6c4e886915e4";
 />
   
   
   
   ### RocketMQ version
   
   5.1.4
   
   ### JDK Version
   
   java version "1.8.0_401"
   
   ### Describe the Bug
   
   运行三个月后内存实际占用远超设置,jmap查看堆内存为正常
   
   ### Steps to Reproduce
   
   1
   
   ### What Did You Expect to See?
   
   1
   
   ### What Did You See Instead?
   
   1
   
   ### Additional Context
   
   1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] debezium-mysql connector无法连接nameserver [rocketmq-connect]

2024-12-18 Thread via GitHub


shusley244 closed issue #545: debezium-mysql connector无法连接nameserver
URL: https://github.com/apache/rocketmq-connect/issues/545


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Coverage" is working again!

2024-12-18 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has succeeded.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
16b6e53263477794125a49d9f31a994a510970b7 / Lei Zhiyuan 
[ISSUE #9002] when bytebuffer is not enough, do not throw exception (#9003)

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

* fix: when bytebuffer is not enough,we should wait for next instead of throw 
exception

Report URL: https://github.com/apache/rocketmq/actions/runs/12405849219

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #9064]Optimize the way to determine whether RMQ_SYS_TRANS-HALFTOPIC is in RMQ_SSYS_TRANS-OP_ALF_TOPIC in transaction messages [rocketmq]

2024-12-18 Thread via GitHub


codecov-commenter commented on PR #9062:
URL: https://github.com/apache/rocketmq/pull/9062#issuecomment-2552735476

   ## 
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `0%` with `2 lines` in your changes missing 
coverage. Please review.
   > Project coverage is 47.85%. Comparing base 
[(`93e2689`)](https://app.codecov.io/gh/apache/rocketmq/commit/93e268909cb92dd6d4033a4a36e1daab40025a75?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`f13c93e`)](https://app.codecov.io/gh/apache/rocketmq/commit/f13c93e8dae7605c056d4dbaac3d0d605dfe0199?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 1 commits behind head on develop.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...saction/queue/TransactionalMessageServiceImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/9062?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Ftransaction%2Fqueue%2FTransactionalMessageServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdHJhbnNhY3Rpb24vcXVldWUvVHJhbnNhY3Rpb25hbE1lc3NhZ2VTZXJ2aWNlSW1wbC5qYXZh)
 | 0.00% | [1 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/9062?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#9062  +/-   ##
   =
   - Coverage  47.97%   47.85%   -0.13% 
   + Complexity 1190411869  -35 
   =
 Files   1312 1312  
 Lines  9173591733   -2 
 Branches   1175111751  
   =
   - Hits   4401443898 -116 
   - Misses 4231242414 +102 
   - Partials5409 5421  +12 
   ```
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9062?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org