Re: [I] Does the project not verify the AccessKey at startup? [rocketmq]
github-actions[bot] commented on issue #7529: URL: https://github.com/apache/rocketmq/issues/7529#issuecomment-2461053803 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6570] Optimizing the process of putting messages to improve performance [rocketmq]
github-actions[bot] commented on PR #6571: URL: https://github.com/apache/rocketmq/pull/6571#issuecomment-2461053858 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6570] Optimizing the process of putting messages to improve performance [rocketmq]
github-actions[bot] closed pull request #6571: [ISSUE #6570] Optimizing the process of putting messages to improve performance URL: https://github.com/apache/rocketmq/pull/6571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Does the project not verify the AccessKey at startup? [rocketmq]
github-actions[bot] closed issue #7529: Does the project not verify the AccessKey at startup? URL: https://github.com/apache/rocketmq/issues/7529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #XXX] Set benchmark isSuffixEnable variable default false [rocketmq]
codecov-commenter commented on PR #2370: URL: https://github.com/apache/rocketmq/pull/2370#issuecomment-2461061865 ## Welcome to [Codecov](https://codecov.io?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :tada: Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered :open_umbrella: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "License Checker" is working again!
The GitHub Actions job "License Checker" on rocketmq-clients.git has succeeded. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: be5e39c6902845e43b4beedbdfc75c50243948a8 / zhouli license for test.py Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11699577056 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/1170267 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544669 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544669 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "License Checker" failed!
The GitHub Actions job "License Checker" on rocketmq-clients.git has failed. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: 3d5fd82a9e4a7b9812ad359fb7268151dd2236a6 / zhouli license for pb.py Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11699520137 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: 3d5fd82a9e4a7b9812ad359fb7268151dd2236a6 / zhouli license for pb.py Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11699520115 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" is working again!
The GitHub Actions job "Build" on rocketmq-clients.git has succeeded. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: 0e61b28712bb993ac2261e8106c0cd218a75db26 / zhouli code style Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11704662395 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: bedff2855de032597eccc4b16b57e6bdeccfe5ff / zhouli code style Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11702900455 With regards, GitHub Actions via GitBox
[PR] [#8859] Fix duplicate mapped file in mutil commitlog store path mode. [rocketmq]
hexueyuan opened a new pull request, #8897: URL: https://github.com/apache/rocketmq/pull/8897 ### Which Issue(s) This PR Fixes Fixes #8859 ### Brief Description I changed the key of the requestTable in the AllocateMappedFileService class from the FilePath to the FileName(this must be the only one), and then added a getCachedMappedFilePath method to provide to the MultiPathMappedFileQueue to check whether the MappedFile of a specified offset MappedFile create request has been submitted, and if so, obtain the cached FilePath, otherwise a new path is generated based on the previous rules. ### How Did You Test This Change? I make a unit test to recurrence this case in testUniqueNextNextMappedFile(). In the previous implementation, the results obtained were as shown in the picture below, the MappedFile 1024 repeatedly appear in directory a and directory b.  This problem was solved in the new implementation and the result is as follows:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11702672199 With regards, GitHub Actions via GitBox
Re: [I] [Bug] jdk21 Unrecognized VM option 'UseBiasedLocking' [rocketmq]
lizhimins closed issue #8808: [Bug] jdk21 Unrecognized VM option 'UseBiasedLocking' URL: https://github.com/apache/rocketmq/issues/8808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544669 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11702672207 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by github-actions[bot]). Head commit for run: 6896cf6f99eb08672553e7e31f343cb0deebf17b / redlsz Fix query compaction topic offset Report URL: https://github.com/apache/rocketmq/actions/runs/11698503196 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: be5e39c6902845e43b4beedbdfc75c50243948a8 / zhouli license for test.py Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11699577047 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544683 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user zhouli11 (triggered by lollipopjin). Head commit for run: 86d1d157fcffce6a1bdae6468154250b2ae8abb8 / zhouli commit new python code Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11701596467 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" is working again!
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11702672213 With regards, GitHub Actions via GitBox
[PR] new python sdk [rocketmq-clients]
zhouli11 opened a new pull request, #864: URL: https://github.com/apache/rocketmq-clients/pull/864 This PR completely refactors the existing Python SDK, including the following content: 1. It hides the implementation details of coroutines. Users do not need to understand asyncio API, It is simpler to use. 2. It provides asynchronous methods for sending, receiving, and acknowledging message. 3. It implements thread safety for using multiple producers and consumers in a multithreaded environment, the existing version can’t work under a multi-threaded environment. 4. It implements metrics based on OpenTelemetry. 5. It fixes some bugs, such as multiple connections for the same endpoints、 heartbeat failures and so on 6. It fixes the incorrect package dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544683 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 43f3c2b61bf5dbdb174c4664121677d66542277c / rongtong [ISSUE #8885] Resolve the issue of inaccurate CK number statistics (#8886) Report URL: https://github.com/apache/rocketmq/actions/runs/11702581081 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544686 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user zaaksam (triggered by RongtongJin). Head commit for run: 3c3ac5bfd38c55c87c9833c90cb205bda9befd57 / Zaaksam golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11586687530 With regards, GitHub Actions via GitBox
Re: [PR] new python client version [rocketmq-clients]
zhouli11 commented on PR #862: URL: https://github.com/apache/rocketmq-clients/pull/862#issuecomment-2459074793 reput after some code style check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] new python client version [rocketmq-clients]
zhouli11 closed pull request #862: new python client version URL: https://github.com/apache/rocketmq-clients/pull/862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 [rocketmq]
lizhimins merged PR #8809: URL: https://github.com/apache/rocketmq/pull/8809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8882]Change the compare method for acl signature to improve the security. [rocketmq]
caigy commented on PR #8883: URL: https://github.com/apache/rocketmq/pull/8883#issuecomment-2461150677 Spotbugs check failed, pls fix it > [INFO] Total bugs: 1 Error: High: Found reliance on default encoding in org.apache.rocketmq.acl.plain.PlainPermissionManager.validate(PlainAccessResource): String.getBytes() [org.apache.rocketmq.acl.plain.PlainPermissionManager] At PlainPermissionManager.java:[line 623] DM_DEFAULT_ENCODING -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 198f997ed42a1f9f53b915f0ee9671883c624c48 / Zaaksam golang: Add ClientFunc option for simple consumer (#863) * golang: Add ClientFunc option for simple consumer * golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11716062545 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "CPP Coverage" failed!
The GitHub Actions job "CPP Coverage" on rocketmq-clients.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 198f997ed42a1f9f53b915f0ee9671883c624c48 / Zaaksam golang: Add ClientFunc option for simple consumer (#863) * golang: Add ClientFunc option for simple consumer * golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11716062521 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: bbf240d08421a4b9d6bd91de51b1b394f594c8fd / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715772782 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: bbf240d08421a4b9d6bd91de51b1b394f594c8fd / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715772782 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: bbf240d08421a4b9d6bd91de51b1b394f594c8fd / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715772776 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Run Integration Tests" failed!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 7a17cd1ca10b9fbefce6900dedf8b17e9d00651c / dingshuangxi888 Change the compare method for acl signature to improve the security. Report URL: https://github.com/apache/rocketmq/actions/runs/11715635389 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: a9ea2c905447aaf874ece5defdbcf2f3f90d99d7 / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715426997 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Run Integration Tests" is working again!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: bbf240d08421a4b9d6bd91de51b1b394f594c8fd / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715772780 With regards, GitHub Actions via GitBox
(rocketmq-clients) branch master updated (4f05fb7d -> 198f997e)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git from 4f05fb7d Update golang_build.yml (#861) add 198f997e golang: Add ClientFunc option for simple consumer (#863) No new revisions were added by this update. Summary of changes: golang/simple_consumer_options.go | 8 1 file changed, 8 insertions(+)
Re: [PR] Override recoverOffsetTable for kvCq store [rocketmq]
lollipopjin commented on code in PR #8896:
URL: https://github.com/apache/rocketmq/pull/8896#discussion_r1832083197
##
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##
@@ -343,7 +344,24 @@ public ByteBuffer get(final String topic, final int
queueId, final long cqOffset
*/
@Override
public void recoverOffsetTable(long minPhyOffset) {
-
+try {
+ConcurrentMap cqOffsetTable = new
ConcurrentHashMap<>(1024);
+ConcurrentMap configs =
this.messageStore.getTopicConfigs();
+for (TopicConfig topicConfig : configs.values()) {
+for (int queueId = 0; queueId <
topicConfig.getWriteQueueNums(); queueId++) {
+String key = topicConfig.getTopicName() + "-" + queueId;
+Long maxOffset =
this.rocksDBConsumeQueueOffsetTable.getMaxCqOffset(topicConfig.getTopicName(),
queueId);
+if (maxOffset != null) {
+long maxOffsetInQueue = maxOffset + 1;
Review Comment:
Here means the begin offset for the new arrived message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(rocketmq-apis) branch main updated (37bcee2 -> bab0523)
This is an automated email from the ASF dual-hosted git repository. lollipop pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/rocketmq-apis.git from 37bcee2 Merge pull request #86 from qianye1001/qianye-main add 1845bd4 add api definition of recalling message add 935edb3 update status code document for code: MESSAGE_BODY_EMPTY new bab0523 Merge pull request #87 from imzs/main The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: StatusCode.md| 1 + apache/rocketmq/v2/service.proto | 19 +++ 2 files changed, 20 insertions(+)
(rocketmq-apis) 01/01: Merge pull request #87 from imzs/main
This is an automated email from the ASF dual-hosted git repository. lollipop pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/rocketmq-apis.git commit bab0523b8a9341ad5c867c1893560190a17f4d99 Merge: 37bcee2 935edb3 Author: Jixiang Jin AuthorDate: Thu Nov 7 15:54:30 2024 +0800 Merge pull request #87 from imzs/main Add api definition of recalling message StatusCode.md| 1 + apache/rocketmq/v2/service.proto | 19 +++ 2 files changed, 20 insertions(+)
Re: [PR] Add api definition of recalling message [rocketmq-apis]
lollipopjin merged PR #87: URL: https://github.com/apache/rocketmq-apis/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] golang: Add ClientFunc option for simple consumer [rocketmq-clients]
RongtongJin merged PR #863: URL: https://github.com/apache/rocketmq-clients/pull/863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Golang Coverage" failed!
The GitHub Actions job "Golang Coverage" on rocketmq-clients.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 198f997ed42a1f9f53b915f0ee9671883c624c48 / Zaaksam golang: Add ClientFunc option for simple consumer (#863) * golang: Add ClientFunc option for simple consumer * golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11716062524 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 198f997ed42a1f9f53b915f0ee9671883c624c48 / Zaaksam golang: Add ClientFunc option for simple consumer (#863) * golang: Add ClientFunc option for simple consumer * golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11716062537 With regards, GitHub Actions via GitBox
Re: [PR] Override recoverOffsetTable for kvCq store [rocketmq]
lizhimins commented on code in PR #8896:
URL: https://github.com/apache/rocketmq/pull/8896#discussion_r1831981821
##
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##
@@ -343,7 +344,24 @@ public ByteBuffer get(final String topic, final int
queueId, final long cqOffset
*/
@Override
public void recoverOffsetTable(long minPhyOffset) {
-
+try {
+ConcurrentMap cqOffsetTable = new
ConcurrentHashMap<>(1024);
+ConcurrentMap configs =
this.messageStore.getTopicConfigs();
+for (TopicConfig topicConfig : configs.values()) {
+for (int queueId = 0; queueId <=
topicConfig.getWriteQueueNums(); queueId++) {
Review Comment:
<= ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Java Coverage" failed!
The GitHub Actions job "Java Coverage" on rocketmq-clients.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 198f997ed42a1f9f53b915f0ee9671883c624c48 / Zaaksam golang: Add ClientFunc option for simple consumer (#863) * golang: Add ClientFunc option for simple consumer * golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11716062530 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: bbf240d08421a4b9d6bd91de51b1b394f594c8fd / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715772776 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11715794962 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8882]Change the compare method for acl signature to improve the security. [rocketmq]
codecov-commenter commented on PR #8883: URL: https://github.com/apache/rocketmq/pull/8883#issuecomment-2461230781 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `60.0%` with `2 lines` in your changes missing coverage. Please review. > Project coverage is 47.51%. Comparing base [(`5600684`)](https://app.codecov.io/gh/apache/rocketmq/commit/5600684eb437dd5a4aeb9c658e24200bcb74909b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7a17cd1`)](https://app.codecov.io/gh/apache/rocketmq/commit/7a17cd1ca10b9fbefce6900dedf8b17e9d00651c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 3 commits behind head on develop. | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8883?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...che/rocketmq/acl/plain/PlainPermissionManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/8883?src=pr&el=tree&filepath=acl%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Facl%2Fplain%2FPlainPermissionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUGxhaW5QZXJtaXNzaW9uTWFuYWdlci5qYXZh) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...entication/chain/DefaultAuthenticationHandler.java](https://app.codecov.io/gh/apache/rocketmq/pull/8883?src=pr&el=tree&filepath=auth%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fauth%2Fauthentication%2Fchain%2FDefaultAuthenticationHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvYXV0aC9hdXRoZW50aWNhdGlvbi9jaGFpbi9EZWZhdWx0QXV0aGVudGljYXRpb25IYW5kbGVyLmphdmE=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8883 +/- ## = - Coverage 47.71% 47.51% -0.20% + Complexity 1176311730 -33 = Files 1304 1304 Lines 9105191054 +3 Branches 1167511677 +2 = - Hits 4344843268 -180 - Misses 4227442436 +162 - Partials5329 5350 +21 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8883?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Override recoverOffsetTable for kvCq store [rocketmq]
LetLetMe commented on code in PR #8896:
URL: https://github.com/apache/rocketmq/pull/8896#discussion_r1832098971
##
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##
@@ -343,7 +344,24 @@ public ByteBuffer get(final String topic, final int
queueId, final long cqOffset
*/
@Override
public void recoverOffsetTable(long minPhyOffset) {
-
+try {
+ConcurrentMap cqOffsetTable = new
ConcurrentHashMap<>(1024);
+ConcurrentMap configs =
this.messageStore.getTopicConfigs();
+for (TopicConfig topicConfig : configs.values()) {
+for (int queueId = 0; queueId <
topicConfig.getWriteQueueNums(); queueId++) {
+String key = topicConfig.getTopicName() + "-" + queueId;
+Long maxOffset =
this.rocksDBConsumeQueueOffsetTable.getMaxCqOffset(topicConfig.getTopicName(),
queueId);
+if (maxOffset != null) {
+long maxOffsetInQueue = maxOffset + 1;
Review Comment:
getMaxCqOffset -> The highest queueOffset that has been persisted
getMaxOffsetInQueue -> The next available queueOffset after the latest
message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11717812121 With regards, GitHub Actions via GitBox
Re: [I] connect to null failed [rocketmq-dashboard]
HuXiaoge1 closed issue #255: connect to null failed URL: https://github.com/apache/rocketmq-dashboard/issues/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] connect to null failed [rocketmq-dashboard]
HuXiaoge1 opened a new issue, #255: URL: https://github.com/apache/rocketmq-dashboard/issues/255 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/). **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? - What did you expect to see? - What did you see instead? 2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8549] Ipv6 enabled in broker, pickupStoreTimestamp size should be 20 [rocketmq]
jaylu163 commented on PR #8567: URL: https://github.com/apache/rocketmq/pull/8567#issuecomment-2461515110 5.2版本还有问题。有修改这个版本吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add api definition of recalling message [rocketmq-apis]
imzs opened a new pull request, #87: URL: https://github.com/apache/rocketmq-apis/pull/87 1. add api definition of recalling message 2. update status code document for code: MESSAGE_BODY_EMPTY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 2af82a55ab0b307f504cc966a4da24027e6611bb / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11702544683 With regards, GitHub Actions via GitBox
[PR] Override recoverOffsetTable for kvCq store [rocketmq]
LetLetMe opened a new pull request, #8896: URL: https://github.com/apache/rocketmq/pull/8896 ### Which Issue(s) This PR Fixes Fixes #8895 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by caigy). Head commit for run: c90978b0b993142d7719e7339b55066a63e8e79e / Li Zhanhui fix: add deps to Bazel Signed-off-by: Li Zhanhui Report URL: https://github.com/apache/rocketmq/actions/runs/11685643747 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: a9ea2c905447aaf874ece5defdbcf2f3f90d99d7 / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715427003 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Benchmark java17 version exception [rocketmq]
hakusai22 commented on issue #8898:
URL: https://github.com/apache/rocketmq/issues/8898#issuecomment-2461184825
> You can manually modify benchmark’s startup script benchmark/runclass.sh.
>
> In your case, you should change '-XX:PermSize=128m -XX:MaxPermSize=320m'
to '-XX:MetaspaceSize=128m -XX:MaxMetaspaceSize=320m'.
>
> The PermSize option was used in Java 7 and earlier to set the initial size
of the permanent generation space. However, starting from Java 8, this option
was replaced by Metaspace.
yes, After I modified the jvm parameters, it ran successfully
```
JAVA_OPT="${JAVA_OPT} -server -Xms1g -Xmx1g -Xmn256m "
JAVA_OPT="${JAVA_OPT} -XX:+UseG1GC -XX:MaxGCPauseMillis=200
-XX:G1ReservePercent=20 -XX:InitiatingHeapOccupancyPercent=70"
JAVA_OPT="${JAVA_OPT} -verbose:gc
-Xlog:gc*:file=${GC_LOG_DIR}/rmq_run_class_gc_%p_%t.log:time,uptime,level,tags
-XX:+PrintGCDetails"
JAVA_OPT="${JAVA_OPT} -XX:+UnlockExperimentalVMOptions
-XX:+UseContainerSupport -XX:+PerfDisableSharedMem"
JAVA_OPT="${JAVA_OPT} -cp ${CLASSPATH}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414783 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414787 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11715425013 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414790 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Benchmark java17 version exception [rocketmq]
hexueyuan commented on issue #8898: URL: https://github.com/apache/rocketmq/issues/8898#issuecomment-2461183174 You can manually modify benchmark’s startup script benchmark/runclass.sh. In your case, you should change '-XX:PermSize=128m -XX:MaxPermSize=320m' to '-XX:MetaspaceSize=128m -XX:MaxMetaspaceSize=320m'. The PermSize option was used in Java 7 and earlier to set the initial size of the permanent generation space. However, starting from Java 8, this option was replaced by Metaspace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Run Integration Tests" failed!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414793 With regards, GitHub Actions via GitBox
[I] [Bug] Bug title [rocketmq]
hakusai22 opened a new issue, #8898: URL: https://github.com/apache/rocketmq/issues/8898 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment linux ### RocketMQ version rocketmq-all-5.2.0-bin-release/benchmark ### JDK Version java version "17.0.11" 2024-04-16 LTS Java(TM) SE Runtime Environment (build 17.0.11+7-LTS-207) Java HotSpot(TM) 64-Bit Server VM (build 17.0.11+7-LTS-207, mixed mode, sharing) ### Describe the Bug - The jvm parameters in the stress test runclass.sh are outdated. I use the java17 version and an exception occurs ```bash benchmark]# Unrecognized VM option 'PermSize=128m' Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` ### Steps to Reproduce sh producer.sh -h ### What Did You Expect to See? success ### What Did You See Instead? error ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414794 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: a9ea2c905447aaf874ece5defdbcf2f3f90d99d7 / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715427001 With regards, GitHub Actions via GitBox
[I] [Doc] Override recoverOffsetTable for kvCq store [rocketmq]
LetLetMe opened a new issue, #8895: URL: https://github.com/apache/rocketmq/issues/8895 ### Search before creation - [X] I had searched in the [issues](https://github.com/apache/rocketmq/issues) and found no similar issues. ### Documentation Related When performing dual write switching during active message transmission and reception, we observed queue offset rollback issues. This occurs because the kvCq store uses a lazy loading approach to obtain the max offset. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new e281697b8e [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM
Option for JDK21 (#8809)
e281697b8e is described below
commit e281697b8e07cfe77eb26ffa46ac76ba3eca75de
Author: Thomas Lee
AuthorDate: Wed Nov 6 19:30:18 2024 +0800
[ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21
(#8809)
---
distribution/bin/runbroker.cmd | 4 ++--
distribution/bin/runbroker.sh | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/distribution/bin/runbroker.cmd b/distribution/bin/runbroker.cmd
index fefaab3013..f9a710985a 100644
--- a/distribution/bin/runbroker.cmd
+++ b/distribution/bin/runbroker.cmd
@@ -53,8 +53,8 @@ if %JAVA_MAJOR_VERSION% lss 17 (
set "JAVA_OPT=%JAVA_OPT% -XX:-OmitStackTraceInFastThrow"
set "JAVA_OPT=%JAVA_OPT% -XX:+AlwaysPreTouch"
set "JAVA_OPT=%JAVA_OPT% -XX:MaxDirectMemorySize=15g"
- set "JAVA_OPT=%JAVA_OPT% -XX:-UseLargePages -XX:-UseBiasedLocking"
+ set "JAVA_OPT=%JAVA_OPT% -XX:-UseLargePages -XX:-UseBiasedLocking
-XX:+IgnoreUnrecognizedVMOptions"
set "JAVA_OPT=%JAVA_OPT% %JAVA_OPT_EXT% -cp "%CLASSPATH%""
)
-"%JAVA%" %JAVA_OPT% %*
\ No newline at end of file
+"%JAVA%" %JAVA_OPT% %*
diff --git a/distribution/bin/runbroker.sh b/distribution/bin/runbroker.sh
index e6e2132aba..e701e6c320 100644
--- a/distribution/bin/runbroker.sh
+++ b/distribution/bin/runbroker.sh
@@ -105,7 +105,7 @@ choose_gc_options
JAVA_OPT="${JAVA_OPT} -XX:-OmitStackTraceInFastThrow"
JAVA_OPT="${JAVA_OPT} -XX:+AlwaysPreTouch"
JAVA_OPT="${JAVA_OPT} -XX:MaxDirectMemorySize=15g"
-JAVA_OPT="${JAVA_OPT} -XX:-UseLargePages -XX:-UseBiasedLocking"
+JAVA_OPT="${JAVA_OPT} -XX:-UseLargePages -XX:-UseBiasedLocking
-XX:+IgnoreUnrecognizedVMOptions"
#JAVA_OPT="${JAVA_OPT} -Xdebug
-Xrunjdwp:transport=dt_socket,address=9555,server=y,suspend=n"
JAVA_OPT="${JAVA_OPT} ${JAVA_OPT_EXT}"
JAVA_OPT="${JAVA_OPT} -cp ${CLASSPATH}"
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11715450236 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414794 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Benchmark java17 version exception [rocketmq]
hakusai22 commented on issue #8898: URL: https://github.com/apache/rocketmq/issues/8898#issuecomment-2461198836 Is it possible to select appropriate parameters according to the java version? Java8 as the dividing line or abandon the original jvm parameters? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] new python sdk [rocketmq-clients]
beiwei30 commented on PR #864: URL: https://github.com/apache/rocketmq-clients/pull/864#issuecomment-2461198157 LGTM. This is a feature the community has been looking forward to, good job :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Run Integration Tests" is working again!
The GitHub Actions job "Run Integration Tests" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: a9ea2c905447aaf874ece5defdbcf2f3f90d99d7 / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715426993 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by github-actions[bot]). Head commit for run: 5900529f7012a63de7f9ea1f3c729d32a8b8383f / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715414794 With regards, GitHub Actions via GitBox
Re: [PR] Override recoverOffsetTable for kvCq store [rocketmq]
codecov-commenter commented on PR #8896: URL: https://github.com/apache/rocketmq/pull/8896#issuecomment-2461207475 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8896?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `86.7%` with `2 lines` in your changes missing coverage. Please review. > Project coverage is 47.76%. Comparing base [(`dd62ed0`)](https://app.codecov.io/gh/apache/rocketmq/commit/dd62ed0f3b16919adec5d5eece21a1050dc9c5a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a9ea2c9`)](https://app.codecov.io/gh/apache/rocketmq/commit/a9ea2c905447aaf874ece5defdbcf2f3f90d99d7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 6 commits behind head on develop. | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8896?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rocketmq/store/queue/RocksDBConsumeQueueStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/8896?src=pr&el=tree&filepath=store%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fstore%2Fqueue%2FRocksDBConsumeQueueStore.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL1JvY2tzREJDb25zdW1lUXVldWVTdG9yZS5qYXZh) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8896?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8896 +/- ## = + Coverage 47.61% 47.76% +0.14% - Complexity 1175211811 +59 = Files 1304 1304 Lines 9104391476 +433 Branches 1167511832 +157 = + Hits 4335443692 +338 - Misses 4235242416 +64 - Partials5337 5368 +31 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8896?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: a9ea2c905447aaf874ece5defdbcf2f3f90d99d7 / LetLetMe Override recoverOffsetTable for kvCq store Report URL: https://github.com/apache/rocketmq/actions/runs/11715427037 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Golang Coverage" failed!
The GitHub Actions job "Golang Coverage" on rocketmq-clients.git has failed. Run started by GitHub user zaaksam (triggered by RongtongJin). Head commit for run: 1d9c3abb4014569cb90965b27815f638a4f313fd / Zaaksam golang: Add ClientFunc option for simple consumer Report URL: https://github.com/apache/rocketmq-clients/actions/runs/11698989770 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: e281697b8e07cfe77eb26ffa46ac76ba3eca75de / Thomas Lee [ISSUE #8808] Resolve unsupported 'UseBiasedLocking' VM Option for JDK21 (#8809) Report URL: https://github.com/apache/rocketmq/actions/runs/11715656470 With regards, GitHub Actions via GitBox
Re: [PR] Override recoverOffsetTable for kvCq store [rocketmq]
lizhimins commented on code in PR #8896:
URL: https://github.com/apache/rocketmq/pull/8896#discussion_r1831981821
##
store/src/main/java/org/apache/rocketmq/store/queue/RocksDBConsumeQueueStore.java:
##
@@ -343,7 +344,24 @@ public ByteBuffer get(final String topic, final int
queueId, final long cqOffset
*/
@Override
public void recoverOffsetTable(long minPhyOffset) {
-
+try {
+ConcurrentMap cqOffsetTable = new
ConcurrentHashMap<>(1024);
+ConcurrentMap configs =
this.messageStore.getTopicConfigs();
+for (TopicConfig topicConfig : configs.values()) {
+for (int queueId = 0; queueId <=
topicConfig.getWriteQueueNums(); queueId++) {
Review Comment:
<= ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
