[PR] [ISSUE #8599] Throw exception when receiving GO_AWAY twice to close channel. [rocketmq]
qianye1001 opened a new pull request, #8862: URL: https://github.com/apache/rocketmq/pull/8862 ### Which Issue(s) This PR Fixes Fixes #8599 ### Brief Description 1. Throw exception when receiving GO_AWAY twice to close channel. 2. Throw exception when receiving GO_AWAY and nor enableReconnectForGoAway ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8829] feat: provide ConfigManagerV2 to make best uses of RocksDB [rocketmq]
lizhanhui commented on PR #8856: URL: https://github.com/apache/rocketmq/pull/8856#issuecomment-2437085299 > Hi, @lizhanhui , we have been using version v1 in the production environment, and it's likely that some community users are doing the same. From a code perspective, a compatibility upgrade from v1 to v2 is not feasible. Given the need for compatibility upgrade, I think it's essential to add support for persisting lmq consumer offsets in version v1. Let's do this in the next pull request. This pull request has been kind of too large. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] 请教，消费方式用法 [rocketmq-client-go]
eddatt opened a new issue, #1176:
URL: https://github.com/apache/rocketmq-client-go/issues/1176
您好，我有以下使用场景：
多实例拉取消费，每条消息全局仅消费一次，并且顺序消费
比如有10条消息，ID：0-9，当前两个实例，希望每个实例能每次拉取都获得下一个全局未消费的消息，理想情况下，id 02468被一个实例消费，id
13579 被另一个实例消费
我按照文档尝试：
1.poll 方法：两个实例情况下，一直只会有一个实例在消费，另一个实例完全拿不到消息
2.pull 方法：两个实例情况下，一个实例会重复获取同一条消息，不知道怎么ack
3.pullfrom
方法：rmq配置3broker，每个broker两个queue情况下，生产的消息只会打到6个中的一个（很奇怪），然后我pullfrom
会调用6次，每次设置1s超时（这个遍历一遍的成本很高），两个实例情况下，这两个实例都能拿到全部消息，然后我用redis去重，保证每个消息只消费一次
目前只有pullfrom 6次+redis方法跑通了要求，但是额外耗时太高了，我觉得是不是哪里没有用对，小白求教，十分感谢
这里是创建consumer代码：
`nameServer, err := primitive.NewNamesrvAddr(NameServerAddr)
if err != nil {}
newPullConsumer, err := rocketmq.NewPullConsumer(
consumer.WithGroupName(GroupName),
consumer.WithNameServer(nameServer),
consumer.WithAutoCommit(true),
consumer.WithConsumerModel(consumer.Clustering),
consumer.WithMaxReconsumeTimes(1),
)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [#8822]Double write cq, reduce unnecessary switches [rocketmq]
lollipopjin commented on code in PR #8823:
URL: https://github.com/apache/rocketmq/pull/8823#discussion_r1814160072
##
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##
@@ -3418,6 +3375,103 @@ private boolean validateBlackListConfigExist(Properties
properties) {
return false;
}
+private CheckRocksdbCqWriteResult
doCheckRocksdbCqWriteProgress(ChannelHandlerContext ctx, RemotingCommand
request) throws RemotingCommandException {
+CheckRocksdbCqWriteProgressRequestHeader requestHeader =
request.decodeCommandCustomHeader(CheckRocksdbCqWriteProgressRequestHeader.class);
+String requestTopic = requestHeader.getTopic();
+MessageStore messageStore = brokerController.getMessageStore();
+DefaultMessageStore defaultMessageStore;
+if (messageStore instanceof AbstractPluginMessageStore) {
+defaultMessageStore = (DefaultMessageStore)
((AbstractPluginMessageStore) messageStore).getNext();
+} else {
+defaultMessageStore = (DefaultMessageStore) messageStore;
+}
+RocksDBMessageStore rocksDBMessageStore =
defaultMessageStore.getRocksDBMessageStore();
+CheckRocksdbCqWriteResult result = new CheckRocksdbCqWriteResult();
+
+if
(defaultMessageStore.getMessageStoreConfig().getStoreType().equals(StoreType.DEFAULT_ROCKSDB.getStoreType()))
{
+result.setCheckResult("storeType is DEFAULT_ROCKSDB, no need
check");
+
result.setCheckStatus(CheckRocksdbCqWriteResult.CheckStatus.CHECK_OK.getValue());
+return result;
+}
+
+if
(!defaultMessageStore.getMessageStoreConfig().isRocksdbCQDoubleWriteEnable()) {
+result.setCheckResult("rocksdbCQWriteEnable is false,
checkRocksdbCqWriteProgressCommand is invalid");
+
result.setCheckStatus(CheckRocksdbCqWriteResult.CheckStatus.CHECK_NOT_OK.getValue());
+return result;
+}
+
+ConcurrentMap>
cqTable = defaultMessageStore.getConsumeQueueTable();
+StringBuilder diffResult = new StringBuilder();
+try {
+if (StringUtils.isNotBlank(requestTopic)) {
+boolean checkResult =
processConsumeQueuesForTopic(cqTable.get(requestTopic), requestTopic,
rocksDBMessageStore, diffResult, false, requestHeader.getCheckStoreTime());
+result.setCheckResult(diffResult.toString());
+result.setCheckStatus(checkResult ?
CheckRocksdbCqWriteResult.CheckStatus.CHECK_OK.getValue() :
CheckRocksdbCqWriteResult.CheckStatus.CHECK_NOT_OK.getValue());
+return result;
+}
+boolean checkResult = true;
+for (Map.Entry> topicEntry : cqTable.entrySet()) {
+String topic = topicEntry.getKey();
+checkResult =
processConsumeQueuesForTopic(topicEntry.getValue(), topic, rocksDBMessageStore,
diffResult, true, requestHeader.getCheckStoreTime());
+if (!checkResult) {
+break;
+}
+}
+diffResult.append("check all topic successful,
size:").append(cqTable.size());
+result.setCheckResult(diffResult.toString());
+result.setCheckStatus(checkResult ?
CheckRocksdbCqWriteResult.CheckStatus.CHECK_OK.getValue() :
CheckRocksdbCqWriteResult.CheckStatus.CHECK_NOT_OK.getValue());
+} catch (Exception e) {
+LOGGER.error("CheckRocksdbCqWriteProgressCommand error", e);
+result.setCheckResult(e.getMessage() +
Arrays.toString(e.getStackTrace()));
+
result.setCheckStatus(CheckRocksdbCqWriteResult.CheckStatus.CHECK_ERROR.getValue());
+}
+return result;
+}
+
+private boolean processConsumeQueuesForTopic(ConcurrentMap queueMap, String topic, RocksDBMessageStore
rocksDBMessageStore, StringBuilder diffResult, boolean checkAll, long
checkStoreTime) {
Review Comment:
How about change checkStoreTime to checkpointByStoreTime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: c6ddccfffb74dc7e8ba42ad20d0d755fd69c6110 / yx9o Merge branch 'refs/heads/develop' into dev-8852 Report URL: https://github.com/apache/rocketmq/actions/runs/11500623694 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user qianye1001 (triggered by qianye1001). Head commit for run: 95b88ff8fcfecbd1942e1a35460f7417ee620673 / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8442][RIP-70-3] Extract adaptive lock mechanism (#8663) * extract the adaptive lock * extract the adaptive lock * feat(): perfect the adaptive lock * feat(): perfect the adaptive lock * Optimized code type * Optimized code type * Optimized code type * fix fail test * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * feat:Adaptive locking mechanism adjustment * feat:Adaptive locking mechanism adjustment * feat:Adaptive locking mechanism adjustment * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Updated the locking mechanism name * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * delete unused import * Optimize the logic of switching to spin locks * Revert "Optimize the logic of switching to spin locks" This reverts commit 1d7bac5c2fea0531af01d4c57c843084ba4fea61. * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimized locking logic * Optimized locking logic * Optimized locking logic * fix test * fix test * fix test * fix test * Optimize code style * Optimize code style * fix test * fix test * optimize client rebalancing logic - Co-authored-by: wanghuaiyuan Report URL: https://github.com/apache/rocketmq/actions/runs/11514291792 With regards, GitHub Actions via GitBox
Re: [PR] [OSPP2024]feat: support aliyun OSS Sink Connector [rocketmq-connect]
2011shenlin commented on code in PR #540:
URL: https://github.com/apache/rocketmq-connect/pull/540#discussion_r1816199090
##
connectors/aliyun/rocketmq-connect-oss/README.md:
##
@@ -0,0 +1,50 @@
+# rocketmq-connect-oss
+* **rocketmq-connect-oss** 说明
+```
+Be responsible for consuming messages from producer and writing data to oss.
+```
+
+## rocketmq-connect-oss 打包
+```
+mvn clean install -Dmaven.test.skip=true
+```
+
+## rocketmq-connect-oss 启动
+
+* **rocketmq-connect-oss** 启动
+
+```
+http://${runtime-ip}:${runtime-port}/connectors/${rocketmq-oss-sink-connector-name}
+?config={"source-rocketmq":"${runtime-ip}:${runtime-port}","source-cluster":"${broker-cluster}","connector-class":"org.apache.rocketmq.connect.oss.sink.OssSinkConnector","connect-topicname":"${connect-topicname}","accessKeyId":"${accessKeyId}","accessKeySecret":"${accessKeySecret}","accountEndpoint":"${accountEndpoint}","bucketName":"${bucketName}","fileUrlPrefix":"${fileUrlPrefix}","objectName":"${objectName}","region":"${region}","partitionMethod":"${partitionMethod}"}
+```
+
+例子
+```
+http://localhost:8081/connectors/ossConnectorSink?config={"source-rocketmq":"localhost:9876","source-cluster":"DefaultCluster";,
+"connector-class":"org.apache.rocketmq.connect.oss.sink.OssSinkConnector","connect-topicname":"oss-topic","accountEndpoint":"","accessKeyId":"","accessKeySecret":"",
+"bucketName":"","objectName":"","region":"","partitionMethod":"","fileUrlPrefix":""}
+```
+
+>**注：** `rocketmq-oss-connect`
的启动依赖于`rocketmq-connect-runtime`项目的启动，需将打好的所有`jar`包放置到`runtime`项目中`pluginPaths`配置的路径后再执行上面的启动请求,该值配置在`runtime`项目下的`connect.conf`文件中
+
+## rocketmq-connect-oss 停止
+
+```
+http://${runtime-ip}:${runtime-port}/connectors/${rocketmq-oss-connector-name}/stop
+```
+
+## rocketmq-connect-oss 参数说明
+* **oss-sink-connector 参数说明**
+
+| KEY | TYPE | Must be filled | Description|
Example
+|-|||||
+| accountEndpoint | String | YES| OSS endpoint |
oss-cn-beijing.aliyuncs.com |
+| accessKeyId | String | YES| 阿里云授信账号的AK |
|
+| accessKeySecret | String | YES| 阿里云授信账号的SK |
xxx|
+| bucketName | String | YES| OSS bucketName |
test_bucket|
+| objectName | String | YES| 上传目的object名字 |
test.txt |
+| region | String | YES| OSS region |
cn-beijing |
+| partitionMethod | String | YES| 分区模式，Normal表示不分区，Time表示按时间分区 |
Time |
+| fileUrlPrefix | String | YES| 到object的URL前缀 |
file1/ |
+| enableBatchPut | String | NO | 是否开启批处理模式 |
true |
Review Comment:
什么场景下enableBatchPut会设置为false？如果不存在这样的场景，可以移除这个参数。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [OSPP2024]feat: support aliyun OSS Sink Connector [rocketmq-connect]
2011shenlin commented on code in PR #540:
URL: https://github.com/apache/rocketmq-connect/pull/540#discussion_r1816199090
##
connectors/aliyun/rocketmq-connect-oss/README.md:
##
@@ -0,0 +1,50 @@
+# rocketmq-connect-oss
+* **rocketmq-connect-oss** 说明
+```
+Be responsible for consuming messages from producer and writing data to oss.
+```
+
+## rocketmq-connect-oss 打包
+```
+mvn clean install -Dmaven.test.skip=true
+```
+
+## rocketmq-connect-oss 启动
+
+* **rocketmq-connect-oss** 启动
+
+```
+http://${runtime-ip}:${runtime-port}/connectors/${rocketmq-oss-sink-connector-name}
+?config={"source-rocketmq":"${runtime-ip}:${runtime-port}","source-cluster":"${broker-cluster}","connector-class":"org.apache.rocketmq.connect.oss.sink.OssSinkConnector","connect-topicname":"${connect-topicname}","accessKeyId":"${accessKeyId}","accessKeySecret":"${accessKeySecret}","accountEndpoint":"${accountEndpoint}","bucketName":"${bucketName}","fileUrlPrefix":"${fileUrlPrefix}","objectName":"${objectName}","region":"${region}","partitionMethod":"${partitionMethod}"}
+```
+
+例子
+```
+http://localhost:8081/connectors/ossConnectorSink?config={"source-rocketmq":"localhost:9876","source-cluster":"DefaultCluster";,
+"connector-class":"org.apache.rocketmq.connect.oss.sink.OssSinkConnector","connect-topicname":"oss-topic","accountEndpoint":"","accessKeyId":"","accessKeySecret":"",
+"bucketName":"","objectName":"","region":"","partitionMethod":"","fileUrlPrefix":""}
+```
+
+>**注：** `rocketmq-oss-connect`
的启动依赖于`rocketmq-connect-runtime`项目的启动，需将打好的所有`jar`包放置到`runtime`项目中`pluginPaths`配置的路径后再执行上面的启动请求,该值配置在`runtime`项目下的`connect.conf`文件中
+
+## rocketmq-connect-oss 停止
+
+```
+http://${runtime-ip}:${runtime-port}/connectors/${rocketmq-oss-connector-name}/stop
+```
+
+## rocketmq-connect-oss 参数说明
+* **oss-sink-connector 参数说明**
+
+| KEY | TYPE | Must be filled | Description|
Example
+|-|||||
+| accountEndpoint | String | YES| OSS endpoint |
oss-cn-beijing.aliyuncs.com |
+| accessKeyId | String | YES| 阿里云授信账号的AK |
|
+| accessKeySecret | String | YES| 阿里云授信账号的SK |
xxx|
+| bucketName | String | YES| OSS bucketName |
test_bucket|
+| objectName | String | YES| 上传目的object名字 |
test.txt |
+| region | String | YES| OSS region |
cn-beijing |
+| partitionMethod | String | YES| 分区模式，Normal表示不分区，Time表示按时间分区 |
Time |
+| fileUrlPrefix | String | YES| 到object的URL前缀 |
file1/ |
+| enableBatchPut | String | NO | 是否开启批处理模式 |
true |
Review Comment:
Under what circumstances will enableBatchPut be set to false? If such a
scenario does not exist, this parameter can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Zyh_ict_pr [rocketmq]
ShannonDing commented on PR #8795: URL: https://github.com/apache/rocketmq/pull/8795#issuecomment-2437371570 这个PR太大了，建议按照模块分别创建issue和PR，把优化的地方做个介绍，方便社区review。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [golang] Fixed go client MessageQueues not filtering slave broker [rocketmq-clients]
lixiang365 opened a new pull request, #852: URL: https://github.com/apache/rocketmq-clients/pull/852 ### Which Issue(s) This PR Fixes Fixes ### Brief Description Occasional errors CODE: INTERNAL_SERVER_ERROR, MESSAGE: org.apache.rocketmq.proxy.common.ProxyException: service not available now. It may be caused by one of the following reasons: the broker's disk is full [CL: 0.11 CQ: 0.11 INDEX: 0.11], messages are put to the slave, message store has been shut down, etc. Check the local disk space, there is still a lot of space. So it's possible that data was written to the slave node -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 生产者没有Python客户端代码示例 [rocketmq-clients]
github-actions[bot] closed issue #838: 生产者没有Python客户端代码示例 URL: https://github.com/apache/rocketmq-clients/issues/838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 生产者没有Python客户端代码示例 [rocketmq-clients]
github-actions[bot] commented on issue #838: URL: https://github.com/apache/rocketmq-clients/issues/838#issuecomment-2439077354 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 14688a417af119e854613233b3e7ffc13d885895 / LetLetMe Reduce unnecessary switches Report URL: https://github.com/apache/rocketmq/actions/runs/11494246158 With regards, GitHub Actions via GitBox
[I] How to set rocketmq-proxy access through k8s host nodeport [rocketmq]
liuxin638507 opened a new issue, #8864: URL: https://github.com/apache/rocketmq/issues/8864 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment ubuntu20.04 ### RocketMQ version version: 5.3.1 ### JDK Version docker pull apache/rocketmq:5.3.1 ### Describe the Bug rocketmq-proxy deployed in k8s: port 8080 is mapped through the host nodeport, and the rocketmq-proxy container ip and port are returned when the program accesses the nodeport port. How do I set the return to the connected host ip+nodeport port Client. Exception. MQBrokerException: CODE: 15 DESC: Request doesn 't have the field bnane BROKER: 10.42.19.4:8080  ### Steps to Reproduce rocketmq-proxy deployed in k8s: port 8080 is mapped through the host nodeport, and the rocketmq-proxy container ip and port are returned when the program accesses the nodeport port. How do I set the return to the connected host ip+nodeport port Client. Exception. MQBrokerException: CODE: 15 DESC: Request doesn 't have the field bnane BROKER: 10.42.19.4:8080  ### What Did You Expect to See? How to set rocketmq-proxy access through k8s host nodeport ### What Did You See Instead? How to set rmq-proxy parameter or variable? rmq-proxy returns the ip and port of the host when it can be accessed through nodeport ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #542] Fix connect runtime stats oom [rocketmq-connect]
VictoryAnn opened a new pull request, #543: URL: https://github.com/apache/rocketmq-connect/pull/543 ## What is the purpose of the change fix connect runtime stats bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8599] Throw exception when receiving GO_AWAY twice to close channel. [rocketmq]
codecov-commenter commented on PR #8862: URL: https://github.com/apache/rocketmq/pull/8862#issuecomment-2437209260 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8862?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `4.34783%` with `22 lines` in your changes missing coverage. Please review. > Project coverage is 47.35%. Comparing base [(`95b88ff`)](https://app.codecov.io/gh/apache/rocketmq/commit/95b88ff8fcfecbd1942e1a35460f7417ee620673?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`50b2387`)](https://app.codecov.io/gh/apache/rocketmq/commit/50b23878092042863fc8853cd7582df358e2809a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/8862?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FNettyRemotingClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | 6.66% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/rocketmq/remoting/common/RemotingHelper.java](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fcommon%2FRemotingHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL2NvbW1vbi9SZW1vdGluZ0hlbHBlci5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rocketmq/remoting/netty/NettyRemotingAbstract.java](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&filepath=remoting%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fremoting%2Fnetty%2FNettyRemotingAbstract.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdBYnN0cmFjdC5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8862 +/- ## = - Coverage 47.41% 47.35% -0.07% + Complexity 1165711641 -16 = Files 1294 1294 Lines 9042490412 -12 Branches 1162711622 -5 = - Hits 4287942814 -65 - Misses 4227442313 +39 - Partials5271 5285 +14 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8862?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6805] Support peek message in pop consumption mode [rocketmq]
github-actions[bot] closed pull request #6806: [ISSUE #6805] Support peek message in pop consumption mode URL: https://github.com/apache/rocketmq/pull/6806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6805] Support peek message in pop consumption mode [rocketmq]
github-actions[bot] commented on PR #6806: URL: https://github.com/apache/rocketmq/pull/6806#issuecomment-2439066417 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 95b88ff8fcfecbd1942e1a35460f7417ee620673 / hqbfz <125714719+3424672...@users.noreply.github.com> [ISSUE #8442][RIP-70-3] Extract adaptive lock mechanism (#8663) * extract the adaptive lock * extract the adaptive lock * feat(): perfect the adaptive lock * feat(): perfect the adaptive lock * Optimized code type * Optimized code type * Optimized code type * fix fail test * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * feat:Adaptive locking mechanism adjustment * feat:Adaptive locking mechanism adjustment * feat:Adaptive locking mechanism adjustment * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * Optimize the adaptive locking mechanism logic * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * feat:Supports the hot activation of ABS locks * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Optimize code style * Updated the locking mechanism name * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * delete unused import * Optimize the logic of switching to spin locks * Revert "Optimize the logic of switching to spin locks" This reverts commit 1d7bac5c2fea0531af01d4c57c843084ba4fea61. * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimize the logic of switching to spin locks * Optimized locking logic * Optimized locking logic * Optimized locking logic * fix test * fix test * fix test * fix test * Optimize code style * Optimize code style * fix test * fix test * optimize client rebalancing logic - Co-authored-by: wanghuaiyuan Report URL: https://github.com/apache/rocketmq/actions/runs/11527271315 With regards, GitHub Actions via GitBox
