[I] [Bug] Bug title [rocketmq]
wmhammer opened a new issue, #8425: URL: https://github.com/apache/rocketmq/issues/8425 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment linux centos 7.5 ### RocketMQ version 4.9.7 ### JDK Version 1.8.0_11 ### Describe the Bug RocketMQ4.9.7开启acl后，是否会影响消费者的性能？是不是每次推送到消费端，都会进行鉴权？目前集群确实关闭acl后，消费端消费速度快了些，不知道是否有影响 ### Steps to Reproduce 开启acl，关闭acl，消费端并行消费 ### What Did You Expect to See? ACL鉴权无论开启、关闭，不会影响消费端并行消费的性能 ### What Did You See Instead? 开启ACl和关闭ACL，消费端的并行性能相差一倍 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8405] Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations [rocketmq]
caigy merged PR #8403: URL: https://github.com/apache/rocketmq/pull/8403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Deleting ConsumeQueue files may cause JVM crashes [rocketmq]
caigy closed issue #8405: [Bug] Deleting ConsumeQueue files may cause JVM crashes URL: https://github.com/apache/rocketmq/issues/8405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations (#8403)
This is an automated email from the ASF dual-hosted git repository.
caigy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 86d59d2485 Add the ability to write ConsumeQueue using fileChannel to
prevent JVM crashes in some situations (#8403)
86d59d2485 is described below
commit 86d59d2485b5fed162db3743e11c0902de3e34ad
Author: rongtong
AuthorDate: Mon Jul 22 17:20:11 2024 +0800
Add the ability to write ConsumeQueue using fileChannel to prevent JVM
crashes in some situations (#8403)
---
.../org/apache/rocketmq/store/ConsumeQueue.java| 15 ++--
.../rocketmq/store/config/MessageStoreConfig.java | 10
.../rocketmq/store/logfile/DefaultMappedFile.java | 27 ++
.../apache/rocketmq/store/logfile/MappedFile.java | 11 +
.../rocketmq/store/queue/BatchConsumeQueue.java| 7 +-
.../rocketmq/store/queue/SparseConsumeQueue.java | 10 +++-
6 files changed, 71 insertions(+), 9 deletions(-)
diff --git a/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
b/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
index 569cc3cfaa..eb8af4ab19 100644
--- a/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
+++ b/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java
@@ -833,7 +833,13 @@ public class ConsumeQueue implements
ConsumeQueueInterface, FileQueueLifeCycle {
}
}
this.setMaxPhysicOffset(offset + size);
-return mappedFile.appendMessage(this.byteBufferIndex.array());
+boolean appendResult;
+if
(messageStore.getMessageStoreConfig().isPutConsumeQueueDataByFileChannel()) {
+appendResult =
mappedFile.appendMessageUsingFileChannel(this.byteBufferIndex.array());
+} else {
+appendResult =
mappedFile.appendMessage(this.byteBufferIndex.array());
+}
+return appendResult;
}
return false;
}
@@ -846,7 +852,12 @@ public class ConsumeQueue implements
ConsumeQueueInterface, FileQueueLifeCycle {
int until = (int) (untilWhere %
this.mappedFileQueue.getMappedFileSize());
for (int i = 0; i < until; i += CQ_STORE_UNIT_SIZE) {
-mappedFile.appendMessage(byteBuffer.array());
+if
(messageStore.getMessageStoreConfig().isPutConsumeQueueDataByFileChannel()) {
+mappedFile.appendMessageUsingFileChannel(byteBuffer.array());
+} else {
+mappedFile.appendMessage(byteBuffer.array());
+}
+
}
}
diff --git
a/store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
b/store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
index 0060b144cf..5b2a1931b3 100644
---
a/store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
+++
b/store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
@@ -419,6 +419,8 @@ public class MessageStoreConfig {
*/
private boolean readUnCommitted = false;
+private boolean putConsumeQueueDataByFileChannel = true;
+
public boolean isEnabledAppendPropCRC() {
return enabledAppendPropCRC;
}
@@ -1832,4 +1834,12 @@ public class MessageStoreConfig {
public void setReadUnCommitted(boolean readUnCommitted) {
this.readUnCommitted = readUnCommitted;
}
+
+public boolean isPutConsumeQueueDataByFileChannel() {
+return putConsumeQueueDataByFileChannel;
+}
+
+public void setPutConsumeQueueDataByFileChannel(boolean
putConsumeQueueDataByFileChannel) {
+this.putConsumeQueueDataByFileChannel =
putConsumeQueueDataByFileChannel;
+}
}
diff --git
a/store/src/main/java/org/apache/rocketmq/store/logfile/DefaultMappedFile.java
b/store/src/main/java/org/apache/rocketmq/store/logfile/DefaultMappedFile.java
index 03477c3324..c490d093a1 100644
---
a/store/src/main/java/org/apache/rocketmq/store/logfile/DefaultMappedFile.java
+++
b/store/src/main/java/org/apache/rocketmq/store/logfile/DefaultMappedFile.java
@@ -97,14 +97,14 @@ public class DefaultMappedFile extends AbstractMappedFile {
protected long mappedByteBufferAccessCountSinceLastSwap = 0L;
/**
- * If this mapped file belongs to consume queue, this field stores
store-timestamp of first message referenced
- * by this logical queue.
+ * If this mapped file belongs to consume queue, this field stores
store-timestamp of first message referenced by
+ * this logical queue.
*/
private long startTimestamp = -1;
/**
- * If this mapped file belongs to consume queue, this field stores
store-timestamp of last message referenced
- * by this logical queue.
+ * If this mapped file belongs to consume queue, this field stores
store-timestamp of last message refere
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user caigy (triggered by caigy). Head commit for run: 86d59d2485b5fed162db3743e11c0902de3e34ad / rongtong Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations (#8403) Report URL: https://github.com/apache/rocketmq/actions/runs/10038121292 With regards, GitHub Actions via GitBox
[I] [Bug] When SendMessage asyncSendEnable is false will write response twice [rocketmq]
mxsm opened a new issue, #8426: URL: https://github.com/apache/rocketmq/issues/8426 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment windows ### RocketMQ version master ### JDK Version jdk8 ### Describe the Bug   ### Steps to Reproduce use asyncSendEnable false ### What Did You Expect to See? send once ### What Did You See Instead? send twice ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8426]Fix when SendMessage asyncSendEnable is false will write response twice [rocketmq]
mxsm opened a new pull request, #8427: URL: https://github.com/apache/rocketmq/pull/8427 ### Which Issue(s) This PR Fixes Fixes #8426 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 86d59d2485b5fed162db3743e11c0902de3e34ad / rongtong Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations (#8403) Report URL: https://github.com/apache/rocketmq/actions/runs/10043897510 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8426]Fix when SendMessage asyncSendEnable is false will write response twice [rocketmq]
codecov-commenter commented on PR #8427: URL: https://github.com/apache/rocketmq/pull/8427#issuecomment-2243303098 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8427?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review. > Project coverage is 45.37%. Comparing base [(`86d59d2`)](https://app.codecov.io/gh/apache/rocketmq/commit/86d59d2485b5fed162db3743e11c0902de3e34ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c0980e8`)](https://app.codecov.io/gh/apache/rocketmq/commit/c0980e8a0bff02fa74782d86c83bbf7cc5e4c09d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8427?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ocketmq/broker/processor/SendMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/8427?src=pr&el=tree&filepath=broker%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fbroker%2Fprocessor%2FSendMessageProcessor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8427 +/- ## = - Coverage 45.37% 45.37% -0.01% - Complexity 1099310997 +4 = Files 1274 1274 Lines 8899388994 +1 Branches 1143911439 = - Hits 4038540384 -1 - Misses 4357743580 +3 + Partials5031 5030 -1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8427?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1687252753
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
> ci automatically triggered.
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Feature] Customize AccessValidator [rocketmq]
github-actions[bot] commented on issue #7054: URL: https://github.com/apache/rocketmq/issues/7054#issuecomment-2244017772 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Customize AccessValidator [rocketmq]
github-actions[bot] closed issue #7054: [Feature] Customize AccessValidator URL: https://github.com/apache/rocketmq/issues/7054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6681] fix: fix pop retry message notification [rocketmq]
github-actions[bot] commented on PR #6682: URL: https://github.com/apache/rocketmq/pull/6682#issuecomment-2244017814 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(sec): upgrade com.google.guava:guava to 32.0.0-jre [rocketmq]
github-actions[bot] commented on PR #7051: URL: https://github.com/apache/rocketmq/pull/7051#issuecomment-2244017790 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(sec): upgrade com.google.guava:guava to 32.0.0-jre [rocketmq]
github-actions[bot] closed pull request #7051: fix(sec): upgrade com.google.guava:guava to 32.0.0-jre URL: https://github.com/apache/rocketmq/pull/7051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6681] fix: fix pop retry message notification [rocketmq]
github-actions[bot] closed pull request #6682: [ISSUE #6681] fix: fix pop retry message notification URL: https://github.com/apache/rocketmq/pull/6682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The default logic to generate clientId should make sure each client id needs to be unqiue [rocketmq-clients]
github-actions[bot] commented on issue #774: URL: https://github.com/apache/rocketmq-clients/issues/774#issuecomment-2244029556 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The default logic to generate clientId should make sure each client id needs to be unqiue [rocketmq-clients]
github-actions[bot] closed issue #774: [Bug] The default logic to generate clientId should make sure each client id needs to be unqiue URL: https://github.com/apache/rocketmq-clients/issues/774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: c762e70710d4226de7907263ccedc64280377b5b / qipingluo log error on process assignments Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10051187018 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: c762e70710d4226de7907263ccedc64280377b5b / qipingluo log error on process assignments Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10051187014 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 9ca1504395ee76a29730bcfa1695d8a1fc429597 / qipingluo fix tokio-util version Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10051317139 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Build" failed!
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 9ca1504395ee76a29730bcfa1695d8a1fc429597 / qipingluo fix tokio-util version Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10051317154 With regards, GitHub Actions via GitBox
[GH] (rocketmq-clients): Workflow run "Rust Coverage" is working again!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 9ee7f920563619ff8192a58d340a627f23517ebd / qipingluo implement Debug trait for AckEntryItem Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10051369838 With regards, GitHub Actions via GitBox
Re: [PR] [rust] implement pushconsumer [rocketmq-clients]
codecov-commenter commented on PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#issuecomment-2244109529 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `85.61976%` with `326 lines` in your changes missing coverage. Please review. > Project coverage is 52.48%. Comparing base [(`0149785`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/0149785a7d11ed9d8bccca3c2049283bfedd4e7c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9ee7f92`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/9ee7f920563619ff8192a58d340a627f23517ebd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 13 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [rust/src/push\_consumer.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fpush_consumer.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvcHVzaF9jb25zdW1lci5ycw==) | 86.99% | [128 Missing and 62 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/client.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fclient.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvY2xpZW50LnJz) | 72.66% | [68 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/session.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fsession.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvc2Vzc2lvbi5ycw==) | 71.73% | [26 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/conf.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fconf.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvY29uZi5ycw==) | 92.43% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/producer.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fproducer.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvcHJvZHVjZXIucnM=) | 81.25% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/util.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Futil.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvdXRpbC5ycw==) | 97.14% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/model/message.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fmodel%2Fmessage.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cnVzdC9zcmMvbW9kZWwvbWVzc2FnZS5ycw==) | 71.42% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [rust/src/model/common.rs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?src=pr&el=tree&filepath=rust%2Fsrc%2Fmodel%2Fcommon.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
Re: [PR] feat: add support for CoAP transport [rocketmq-mqtt]
Woguagua closed pull request #289: feat: add support for CoAP transport URL: https://github.com/apache/rocketmq-mqtt/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] corner case, pop of retryTopic from maxOffset will skip a few messages incorrectly when EscapeBridge enabled [rocketmq]
lizhimins closed issue #8402: [Bug] corner case, pop of retryTopic from maxOffset will skip a few messages incorrectly when EscapeBridge enabled URL: https://github.com/apache/rocketmq/issues/8402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled [rocketmq]
lizhimins merged PR #8404: URL: https://github.com/apache/rocketmq/pull/8404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled (#8404)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 8341c13d06 [ISSUE #8402] Fix init retry topic offset incorrect when
EscapeBridge enabled (#8404)
8341c13d06 is described below
commit 8341c13d064c96e9ef70da4fcf17e49d3e1847f9
Author: imzs
AuthorDate: Tue Jul 23 10:24:12 2024 +0800
[ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge
enabled (#8404)
---
.../broker/processor/PopMessageProcessor.java | 10 ++--
.../broker/processor/PopReviveService.java | 4 +-
.../broker/processor/PopMessageProcessorTest.java | 63 +-
3 files changed, 68 insertions(+), 9 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
index 0304a5dab0..89b4c39d72 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
@@ -723,8 +723,8 @@ public class PopMessageProcessor implements
NettyRequestProcessor {
private long getInitOffset(String topic, String group, int queueId, int
initMode, boolean init) {
long offset;
-if (ConsumeInitMode.MIN == initMode) {
-return
this.brokerController.getMessageStore().getMinOffsetInQueue(topic, queueId);
+if (ConsumeInitMode.MIN == initMode ||
topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX)) {
+offset =
this.brokerController.getMessageStore().getMinOffsetInQueue(topic, queueId);
} else {
if
(this.brokerController.getBrokerConfig().isInitPopOffsetByCheckMsgInMem() &&
this.brokerController.getMessageStore().getMinOffsetInQueue(topic, queueId) <=
0 &&
@@ -738,10 +738,10 @@ public class PopMessageProcessor implements
NettyRequestProcessor {
offset = 0;
}
}
-if (init) {
-this.brokerController.getConsumerOffsetManager().commitOffset(
+}
+if (init) { // whichever initMode
+this.brokerController.getConsumerOffsetManager().commitOffset(
"getPopOffset", group, topic, queueId, offset);
-}
}
return offset;
}
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
index e3ba492f28..8074af23bf 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java
@@ -125,7 +125,7 @@ public class PopReviveService extends ServiceThread {
msgInner.getProperties().put(MessageConst.PROPERTY_FIRST_POP_TIME,
String.valueOf(popCheckPoint.getPopTime()));
}
msgInner.setPropertiesString(MessageDecoder.messageProperties2String(msgInner.getProperties()));
-addRetryTopicIfNoExit(msgInner.getTopic(), popCheckPoint.getCId());
+addRetryTopicIfNotExist(msgInner.getTopic(), popCheckPoint.getCId());
PutMessageResult putMessageResult =
brokerController.getEscapeBridge().putMessageToSpecificQueue(msgInner);
PopMetricsManager.incPopReviveRetryMessageCount(popCheckPoint,
putMessageResult.getPutMessageStatus());
if (brokerController.getBrokerConfig().isEnablePopLog()) {
@@ -153,7 +153,7 @@ public class PopReviveService extends ServiceThread {
}
}
-private void addRetryTopicIfNoExit(String topic, String consumerGroup) {
+public void addRetryTopicIfNotExist(String topic, String consumerGroup) {
if (brokerController != null) {
TopicConfig topicConfig =
brokerController.getTopicConfigManager().selectTopicConfig(topic);
if (topicConfig != null) {
diff --git
a/broker/src/test/java/org/apache/rocketmq/broker/processor/PopMessageProcessorTest.java
b/broker/src/test/java/org/apache/rocketmq/broker/processor/PopMessageProcessorTest.java
index d8c8fa1034..8a2ce8a2ba 100644
---
a/broker/src/test/java/org/apache/rocketmq/broker/processor/PopMessageProcessorTest.java
+++
b/broker/src/test/java/org/apache/rocketmq/broker/processor/PopMessageProcessorTest.java
@@ -23,6 +23,7 @@ import java.util.concurrent.CompletableFuture;
import org.apache.rocketmq.broker.BrokerController;
import org.apache.rocketmq.broker.client.ClientChannelInfo;
import org.apache.rocketmq.common.BrokerConfig;
+import org.apache.rocketmq.common.KeyBuilder;
import org.apache.rocketmq.common.TopicConfig;
import org.apache.rocketmq.common.constant.ConsumeInitMode;
import org.apache.rocketmq.common.message.MessageDecoder;
Re: [I] [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize [rocketmq]
RongtongJin closed issue #8421: [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize URL: https://github.com/apache/rocketmq/issues/8421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8421] Add more test coverage for SlaveSynchronize (#8422)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 19ef754177 [ISSUE #8421] Add more test coverage for SlaveSynchronize
(#8422)
19ef754177 is described below
commit 19ef75417751ee81f690c318895ad3c1c5143ce4
Author: Tan Xiang <82364837+tanxian...@users.noreply.github.com>
AuthorDate: Tue Jul 23 10:26:21 2024 +0800
[ISSUE #8421] Add more test coverage for SlaveSynchronize (#8422)
---
.../broker/slave/SlaveSynchronizeTest.java | 206 +
1 file changed, 206 insertions(+)
diff --git
a/broker/src/test/java/org/apache/rocketmq/broker/slave/SlaveSynchronizeTest.java
b/broker/src/test/java/org/apache/rocketmq/broker/slave/SlaveSynchronizeTest.java
new file mode 100644
index 00..95db733d0d
--- /dev/null
+++
b/broker/src/test/java/org/apache/rocketmq/broker/slave/SlaveSynchronizeTest.java
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.broker.slave;
+
+import org.apache.rocketmq.broker.BrokerController;
+import org.apache.rocketmq.broker.loadbalance.MessageRequestModeManager;
+import org.apache.rocketmq.broker.offset.ConsumerOffsetManager;
+import org.apache.rocketmq.broker.out.BrokerOuterAPI;
+import org.apache.rocketmq.broker.processor.QueryAssignmentProcessor;
+import org.apache.rocketmq.broker.schedule.ScheduleMessageService;
+import org.apache.rocketmq.broker.subscription.SubscriptionGroupManager;
+import org.apache.rocketmq.broker.topic.TopicConfigManager;
+import org.apache.rocketmq.client.exception.MQBrokerException;
+import org.apache.rocketmq.common.BrokerConfig;
+import org.apache.rocketmq.common.TopicConfig;
+import org.apache.rocketmq.remoting.exception.RemotingConnectException;
+import org.apache.rocketmq.remoting.exception.RemotingSendRequestException;
+import org.apache.rocketmq.remoting.exception.RemotingTimeoutException;
+import org.apache.rocketmq.remoting.netty.NettyClientConfig;
+import org.apache.rocketmq.remoting.netty.NettyServerConfig;
+import org.apache.rocketmq.remoting.protocol.DataVersion;
+import
org.apache.rocketmq.remoting.protocol.body.ConsumerOffsetSerializeWrapper;
+import
org.apache.rocketmq.remoting.protocol.body.MessageRequestModeSerializeWrapper;
+import org.apache.rocketmq.remoting.protocol.body.SubscriptionGroupWrapper;
+import
org.apache.rocketmq.remoting.protocol.body.TopicConfigAndMappingSerializeWrapper;
+import org.apache.rocketmq.store.MessageStore;
+import org.apache.rocketmq.store.config.MessageStoreConfig;
+import org.apache.rocketmq.store.timer.TimerCheckpoint;
+import org.apache.rocketmq.store.timer.TimerMessageStore;
+import org.apache.rocketmq.store.timer.TimerMetrics;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import java.io.UnsupportedEncodingException;
+import java.util.concurrent.ConcurrentHashMap;
+
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public class SlaveSynchronizeTest {
+@Spy
+private BrokerController brokerController = new BrokerController(new
BrokerConfig(), new NettyServerConfig(), new NettyClientConfig(), new
MessageStoreConfig());
+
+private SlaveSynchronize slaveSynchronize;
+
+@Mock
+private BrokerOuterAPI brokerOuterAPI;
+
+@Mock
+private TopicConfigManager topicConfigManager;
+
+@Mock
+private ConsumerOffsetManager consumerOffsetManager;
+
+@Mock
+private MessageStoreConfig messageStoreConfig;
+
+@Mock
+private MessageStore messageStore;
+
+@Mock
+private ScheduleMessageService scheduleMessageService;
+
+@Mock
+private SubscriptionGroupManager subscriptionGroupManager;
+
+@Mock
+private QueryAssignmentProcessor queryAssignmentProcessor;
+
+@Mock
+private MessageRequestModeManager messageRequestModeManager;
+
+@Mock
+private TimerMessageStore
(rocketmq) branch develop updated: [ISSUE #8417] Add some test cases for org.apache.rocketmq.common.AclConfig (#8418)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 0e56d8761c [ISSUE #8417] Add some test cases for
org.apache.rocketmq.common.AclConfig (#8418)
0e56d8761c is described below
commit 0e56d8761cefbb3fcb47151ea969e7af375cbb71
Author: 我是管小亮_V0x3f <42903364+tefuirne...@users.noreply.github.com>
AuthorDate: Tue Jul 23 10:26:41 2024 +0800
[ISSUE #8417] Add some test cases for org.apache.rocketmq.common.AclConfig
(#8418)
* Which Issue(s) This PR Fixes
add test case for AclConfig in commom module
Fixes #8417
Brief Description
add test case for AclConfig in commom module by using tongyi tools.
How Did You Test This Change?
run test case successfull.
* Which Issue(s) This PR Fixes
[Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417
Fixes #8417
Brief Description
add some test cases for org.apache.rocketmq.common.AclConfig.
How Did You Test This Change?
run test case successfull.
---
.../org/apache/rocketmq/common/AclConfigTest.java | 107 +
1 file changed, 107 insertions(+)
diff --git a/common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
b/common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
new file mode 100644
index 00..141089f2de
--- /dev/null
+++ b/common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+@Test
+public void testGetGlobalWhiteAddrsWhenNull() {
+AclConfig aclConfig = new AclConfig();
+Assert.assertNull("The globalWhiteAddrs should return null",
aclConfig.getGlobalWhiteAddrs());
+}
+
+@Test
+public void testGetGlobalWhiteAddrsWhenEmpty() {
+AclConfig aclConfig = new AclConfig();
+List globalWhiteAddrs = new ArrayList<>();
+aclConfig.setGlobalWhiteAddrs(globalWhiteAddrs);
+assertNotNull("The globalWhiteAddrs should never return null",
aclConfig.getGlobalWhiteAddrs());
+assertEquals("The globalWhiteAddrs list should be empty", 0,
aclConfig.getGlobalWhiteAddrs().size());
+}
+
+@Test
+public void testGetGlobalWhiteAddrs() {
+AclConfig aclConfig = new AclConfig();
+List expected = Arrays.asList("192.168.1.1", "192.168.1.2");
+aclConfig.setGlobalWhiteAddrs(expected);
+assertEquals("Global white addresses should match", expected,
aclConfig.getGlobalWhiteAddrs());
+assertEquals("The globalWhiteAddrs list should be equal to 2", 2,
aclConfig.getGlobalWhiteAddrs().size());
+}
+
+@Test
+public void testGetPlainAccessConfigsWhenNull() {
+AclConfig aclConfig = new AclConfig();
+Assert.assertNull("The plainAccessConfigs should return null",
aclConfig.getPlainAccessConfigs());
+}
+
+@Test
+public void testGetPlainAccessConfigsWhenEmpty() {
+AclConfig aclConfig = new AclConfig();
+List plainAccessConfigs = new ArrayList<>();
+aclConfig.setPlainAccessConfigs(plainAccessConfigs);
+assertNotNull("The plainAccessConfigs should never return null",
aclConfig.getPlainAccessConfigs());
+assertEquals("The plainAccessConfigs list should be empty", 0,
aclConfig.getPlainAccessConfigs().size());
+}
+
+@Test
+public void testGetPlainAccessConfigs() {
+AclConfig aclConfig = new AclConfig();
+List expected = Arrays.asList(new
PlainAccessConfig(), new PlainAccessConfig());
+aclConfig.setPlainAccessConfigs(expected);
+assertEquals("Plain access configs should match", expected,
aclConfig.getPlainAccessConfigs());
+assertEquals("The pl
Re: [PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]
RongtongJin merged PR #8422: URL: https://github.com/apache/rocketmq/pull/8422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
RongtongJin merged PR #8418: URL: https://github.com/apache/rocketmq/pull/8418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
RongtongJin closed issue #8417: [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig URL: https://github.com/apache/rocketmq/issues/8417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 0e56d8761cefbb3fcb47151ea969e7af375cbb71 / 我是管小亮_V0x3f <42903364+tefuirne...@users.noreply.github.com> [ISSUE #8417] Add some test cases for org.apache.rocketmq.common.AclConfig (#8418) * Which Issue(s) This PR Fixes add test case for AclConfig in commom module Fixes #8417 Brief Description add test case for AclConfig in commom module by using tongyi tools. How Did You Test This Change? run test case successfull. * Which Issue(s) This PR Fixes [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417 Fixes #8417 Brief Description add some test cases for org.apache.rocketmq.common.AclConfig. How Did You Test This Change? run test case successfull. Report URL: https://github.com/apache/rocketmq/actions/runs/10051646023 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Message at the end of a file may never be uploaded if last commit failed [rocketmq]
lizhimins commented on issue #8409: URL: https://github.com/apache/rocketmq/issues/8409#issuecomment-2244131549 Good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user bxfjb (triggered by lizhimins). Head commit for run: 2331d5672fff348e51c21323768a5da0a478e9db / zhaoyuhan fix do not roll new file if commit async failed Report URL: https://github.com/apache/rocketmq/actions/runs/10005676816 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8341c13d064c96e9ef70da4fcf17e49d3e1847f9 / imzs [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled (#8404) Report URL: https://github.com/apache/rocketmq/actions/runs/10051620821 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8341c13d064c96e9ef70da4fcf17e49d3e1847f9 / imzs [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled (#8404) Report URL: https://github.com/apache/rocketmq/actions/runs/10051620831 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Bug title RocketMQ4.9.7开启ACL后，消费端并行消费性能减少为未开启ACL的一半 [rocketmq]
lizhimins commented on issue #8425: URL: https://github.com/apache/rocketmq/issues/8425#issuecomment-2244147172 可以 profile 分析下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Bug title RocketMQ4.9.7开启ACL后，消费端并行消费性能减少为未开启ACL的一半 [rocketmq]
wmhammer commented on issue #8425: URL: https://github.com/apache/rocketmq/issues/8425#issuecomment-2244151831 > 可以 profile 分析下 分析测试过了，但我想得到权威的回答 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 19ef75417751ee81f690c318895ad3c1c5143ce4 / Tan Xiang <82364837+tanxian...@users.noreply.github.com> [ISSUE #8421] Add more test coverage for SlaveSynchronize (#8422) Report URL: https://github.com/apache/rocketmq/actions/runs/10051642315 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 0e56d8761cefbb3fcb47151ea969e7af375cbb71 / 我是管小亮_V0x3f <42903364+tefuirne...@users.noreply.github.com> [ISSUE #8417] Add some test cases for org.apache.rocketmq.common.AclConfig (#8418) * Which Issue(s) This PR Fixes add test case for AclConfig in commom module Fixes #8417 Brief Description add test case for AclConfig in commom module by using tongyi tools. How Did You Test This Change? run test case successfull. * Which Issue(s) This PR Fixes [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417 Fixes #8417 Brief Description add some test cases for org.apache.rocketmq.common.AclConfig. How Did You Test This Change? run test case successfull. Report URL: https://github.com/apache/rocketmq/actions/runs/10051646021 With regards, GitHub Actions via GitBox
[PR] feat: add support for CoAP transport [rocketmq-mqtt]
Woguagua opened a new pull request, #308: URL: https://github.com/apache/rocketmq-mqtt/pull/308 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] rocketmq5.2，用的是支持5.2的dashboard，无法新增Topic，命令新增Topic后console查询不到，console topic页面报错Source must not be null [rocketmq-dashboard]
seart commented on issue #216: URL: https://github.com/apache/rocketmq-dashboard/issues/216#issuecomment-2244169140 我也遇到了同样的问 https://github.com/user-attachments/assets/6354e4f1-47b8-4ecd-8858-bab289143770";> 2024-07-23 11:13:04 [2024-07-23 03:13:04.044] ERROR http-nio-8080-exec-5 - op=global_exception_handler_print_error 2024-07-23 11:13:04 java.lang.IllegalArgumentException: Source must not be null 2024-07-23 11:13:04 at org.springframework.util.Assert.notNull(Assert.java:201) 2024-07-23 11:13:04 at org.springframework.beans.BeanUtils.copyProperties(BeanUtils.java:757) 2024-07-23 11:13:04 at org.springframework.beans.BeanUtils.copyProperties(BeanUtils.java:701) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.service.impl.TopicServiceImpl.examineTopicConfig(TopicServiceImpl.java:211) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.service.impl.TopicServiceImpl.checkTopicType(TopicServiceImpl.java:132) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.service.impl.TopicServiceImpl.examineAllTopicType(TopicServiceImpl.java:112) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.controller.TopicController.listTopicType(TopicController.java:62) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.controller.TopicController$$FastClassBySpringCGLIB$$8429e433.invoke() 2024-07-23 11:13:04 at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) 2024-07-23 11:13:04 at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:783) 2024-07-23 11:13:04 at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) 2024-07-23 11:13:04 at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) 2024-07-23 11:13:04 at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:89) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.permisssion.PermissionAspect.checkPermission(PermissionAspect.java:67) 2024-07-23 11:13:04 at sun.reflect.GeneratedMethodAccessor81.invoke(Unknown Source) 2024-07-23 11:13:04 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 2024-07-23 11:13:04 at java.lang.reflect.Method.invoke(Method.java:498) 2024-07-23 11:13:04 at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:634) 2024-07-23 11:13:04 at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:624) 2024-07-23 11:13:04 at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:72) 2024-07-23 11:13:04 at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175) 2024-07-23 11:13:04 at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) 2024-07-23 11:13:04 at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) 2024-07-23 11:13:04 at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) 2024-07-23 11:13:04 at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753) 2024-07-23 11:13:04 at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:698) 2024-07-23 11:13:04 at org.apache.rocketmq.dashboard.controller.TopicController$$EnhancerBySpringCGLIB$$e1b1c3d7.listTopicType() 2024-07-23 11:13:04 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2024-07-23 11:13:04 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 2024-07-23 11:13:04 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 2024-07-23 11:13:04 at java.lang.reflect.Method.invoke(Method.java:498) 2024-07-23 11:13:04 at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205) 2024-07-23 11:13:04 at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150) 2024-07-23 11:13:04 at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117) 2024-07-23 11:13:04 at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895) 2024-07-23 11:13:04 at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808) 2024-07-23 11:13:04 at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandl
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 8341c13d064c96e9ef70da4fcf17e49d3e1847f9 / imzs [ISSUE #8402] Fix init retry topic offset incorrect when EscapeBridge enabled (#8404) Report URL: https://github.com/apache/rocketmq/actions/runs/10051620816 With regards, GitHub Actions via GitBox
[I] [Bug] When the client tps is high, trace messages will be lost [rocketmq]
LetLetMe opened a new issue, #8429: URL: https://github.com/apache/rocketmq/issues/8429 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment all ### RocketMQ version all ### JDK Version all ### Describe the Bug 当客户端消息生成或者消费tps较高时，轨迹消息batch量会比较大，由于之前没限制batch size，当batch size太大时候会出现轨迹消息概率性丢失 When the TPS (Transactions Per Second) of client message generation or consumption is high, the batch size of trajectory messages can become quite large. Due to the lack of a batch size limit previously, when the batch size becomes too large, there is a probabilistic loss of trajectory messages. ### Steps to Reproduce 1. 限制batch siez 2. 部分重构客户端发送轨迹消息的逻辑 1. Limit batch size 2. Partially refactor the client's logic for sending trajectory messages ### What Did You Expect to See? nothing ### What Did You See Instead? nothing ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8429] When the client tps is high, trace messages will be lost [rocketmq]
LetLetMe opened a new pull request, #8430: URL: https://github.com/apache/rocketmq/pull/8430 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 54ac98c7355b4ca6dd70d4f238ac09c698567579 / LetLetMe 修复轨迹丢失的问题 Report URL: https://github.com/apache/rocketmq/actions/runs/10053437349 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 0e56d8761cefbb3fcb47151ea969e7af375cbb71 / 我是管小亮_V0x3f <42903364+tefuirne...@users.noreply.github.com> [ISSUE #8417] Add some test cases for org.apache.rocketmq.common.AclConfig (#8418) * Which Issue(s) This PR Fixes add test case for AclConfig in commom module Fixes #8417 Brief Description add test case for AclConfig in commom module by using tongyi tools. How Did You Test This Change? run test case successfull. * Which Issue(s) This PR Fixes [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417 Fixes #8417 Brief Description add some test cases for org.apache.rocketmq.common.AclConfig. How Did You Test This Change? run test case successfull. Report URL: https://github.com/apache/rocketmq/actions/runs/10053461052 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8429] When the client tps is high, trace messages will be lost [rocketmq]
codecov-commenter commented on PR #8430: URL: https://github.com/apache/rocketmq/pull/8430#issuecomment-2244335461 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8430?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `76.47059%` with `16 lines` in your changes missing coverage. Please review. > Project coverage is 45.48%. Comparing base [(`6c3781f`)](https://app.codecov.io/gh/apache/rocketmq/commit/6c3781f17e22ec35ddb2113bab5cdc4967cb8260?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`54ac98c`)](https://app.codecov.io/gh/apache/rocketmq/commit/54ac98c7355b4ca6dd70d4f238ac09c698567579?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 15 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8430?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://app.codecov.io/gh/apache/rocketmq/pull/8430?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Ftrace%2FAsyncTraceDispatcher.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | 76.27% | [7 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/rocketmq/client/ClientConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/8430?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2FClientConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvQ2xpZW50Q29uZmlnLmphdmE=) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8430?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8430 +/- ## = + Coverage 44.29% 45.48% +1.18% - Complexity 1075411029 +275 = Files 1274 1274 Lines 8895188970 +19 Branches 1143311436 +3 = + Hits 3940040465+1065 + Misses 4459543461-1134 - Partials4956 5044 +88 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8430?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8429] When the client tps is high, trace messages will be lost [rocketmq]
lizhimins commented on code in PR #8430:
URL: https://github.com/apache/rocketmq/pull/8430#discussion_r1687512070
##
client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java:
##
@@ -44,55 +44,55 @@
import org.apache.rocketmq.common.message.Message;
import org.apache.rocketmq.common.message.MessageQueue;
import org.apache.rocketmq.common.topic.TopicValidator;
-import org.apache.rocketmq.remoting.RPCHook;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
+import org.apache.rocketmq.remoting.RPCHook;
import static
org.apache.rocketmq.client.trace.TraceConstants.TRACE_INSTANCE_NAME;
public class AsyncTraceDispatcher implements TraceDispatcher {
private final static Logger log =
LoggerFactory.getLogger(AsyncTraceDispatcher.class);
private final static AtomicInteger COUNTER = new AtomicInteger();
private final static short MAX_MSG_KEY_SIZE = Short.MAX_VALUE - 1;
+private static final AtomicInteger INSTANCE_NUM = new AtomicInteger(0);
+private final int traceInstanceId = INSTANCE_NUM.getAndIncrement();
private final int queueSize;
private final int batchSize;
private final int maxMsgSize;
private final long pollingTimeMil;
private final long waitTimeThresholdMil;
private final DefaultMQProducer traceProducer;
-private final ThreadPoolExecutor traceExecutor;
-// The last discard number of log
private AtomicLong discardCount;
private Thread worker;
+private final ThreadPoolExecutor traceExecutor;
+
+private final int threadNum = Math.max(8,
Runtime.getRuntime().availableProcessors());
Review Comment:
要这么多线程吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Rust Coverage" failed!
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: cd02617b53e74e71d538bbde133a93c157cf1ac7 / qipingluo increase converage rate Report URL: https://github.com/apache/rocketmq-clients/actions/runs/10054101331 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Message at the end of a file may never be uploaded if last commit failed [rocketmq]
lizhimins closed issue #8409: [Bug] Message at the end of a file may never be uploaded if last commit failed URL: https://github.com/apache/rocketmq/issues/8409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8409] Fix tiered storage roll file logic if committing the last part of a file failed (#8410)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 6fb455a1d4 [ISSUE #8409] Fix tiered storage roll file logic if
committing the last part of a file failed (#8410)
6fb455a1d4 is described below
commit 6fb455a1d4dc7416c81ad447fbfe4f9429765609
Author: bxfjb <48467309+bx...@users.noreply.github.com>
AuthorDate: Tue Jul 23 14:53:39 2024 +0800
[ISSUE #8409] Fix tiered storage roll file logic if committing the last
part of a file failed (#8410)
Co-authored-by: zhaoyuhan
---
.../org/apache/rocketmq/tieredstore/file/FlatAppendFile.java | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatAppendFile.java
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatAppendFile.java
index d048413798..b9ba80d08d 100644
---
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatAppendFile.java
+++
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatAppendFile.java
@@ -175,8 +175,14 @@ public class FlatAppendFile {
FileSegment fileSegment = this.getFileToWrite();
result = fileSegment.append(buffer, timestamp);
if (result == AppendResult.FILE_FULL) {
-fileSegment.commitAsync().join();
-return
this.rollingNewFile(this.getAppendOffset()).append(buffer, timestamp);
+boolean commitResult = fileSegment.commitAsync().join();
+log.info("FlatAppendFile#append not successful for the file {}
is full, commit result={}",
+fileSegment.getPath(), commitResult);
+if (commitResult) {
+return
this.rollingNewFile(this.getAppendOffset()).append(buffer, timestamp);
+} else {
+return AppendResult.UNKNOWN_ERROR;
+}
}
} finally {
fileSegmentLock.writeLock().unlock();
Re: [PR] [ISSUE #8429] When the client tps is high, trace messages will be lost [rocketmq]
lollipopjin commented on code in PR #8430:
URL: https://github.com/apache/rocketmq/pull/8430#discussion_r1687520954
##
client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java:
##
@@ -197,26 +198,14 @@ public boolean append(final Object ctx) {
@Override
public void flush() {
-// The maximum waiting time for refresh,avoid being written all the
time, resulting in failure to return.
long end = System.currentTimeMillis() + 500;
-while (System.currentTimeMillis() <= end) {
-synchronized (taskQueueByTopic) {
-for (TraceDataSegment taskInfo : taskQueueByTopic.values()) {
-taskInfo.sendAllData();
-}
-}
-synchronized (traceContextQueue) {
-if (traceContextQueue.size() == 0 && appenderQueue.size() ==
0) {
-break;
-}
-}
+while (traceContextQueue.size() > 0 || appenderQueue.size() > 0 &&
System.currentTimeMillis() <= end) {
try {
-Thread.sleep(1);
-} catch (InterruptedException e) {
-break;
+flushTraceContext();
+} catch (Throwable e) {
}
}
-log.info("--end trace send " + traceContextQueue.size() + " " +
appenderQueue.size());
+log.warn("There are still some traces that haven't been sent " +
traceContextQueue.size() + " " + appenderQueue.size());
Review Comment:
no need to print warn log here if traceContextQueue's size is 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8409] Fix tiered storage roll file logic if committing the last part of a file failed [rocketmq]
lizhimins merged PR #8410: URL: https://github.com/apache/rocketmq/pull/8410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
