Re: [I] [Enhancement] Add test cases for common module #8413 [rocketmq]
TeFuirnever commented on issue #8417: URL: https://github.com/apache/rocketmq/issues/8417#issuecomment-2241514333 link https://github.com/apache/rocketmq/issues/8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Add test cases for common module #8413 [rocketmq]
TeFuirnever opened a new issue, #8417: URL: https://github.com/apache/rocketmq/issues/8417 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Add test cases for common module, org.apache.rocketmq.common.AclConfig ### Motivation for issue https://github.com/apache/rocketmq/issues/8262 , add test cases for common module ### Describe the Solution You'd Like create new test case by using tongyilingma and add comments. ### Describe Alternatives You've Considered NULL ### Additional Context With the ability of Tongyi Lingcode, the code test coverage of all modules of the supplementary project reached more than 50%. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig #8417 [rocketmq]
TeFuirnever opened a new pull request, #8418: URL: https://github.com/apache/rocketmq/pull/8418 ### Which Issue(s) This PR Fixes [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417 Fixes #8417 ### Brief Description add some test cases for org.apache.rocketmq.common.AclConfig. ### How Did You Test This Change? run test case successfull.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#issuecomment-2241521407 for soc in https://github.com/apache/rocketmq/issues/8262 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
yx9o commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685710344
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Test classes do not require method comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685710869
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Is it to remove all method level comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
yx9o commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685711325
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Yes, it's not necessary in test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685726409
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
By the way, why does my check item show "7 workflows awaiting approval"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
yx9o commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685739978
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Wait, it's first contribution, need the approval of the committer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685747817
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Thank you very much, I've modified it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
TeFuirnever commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685749292
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
Sorry to bother you again, is codecov-commenter triggered automatically or
do you need to trigger it manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" is working again!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d9d53d58cf7f32143485f12d4851d5c119d0855a / Tan Xiang <82364837+tanxiang...@users.noreply.github.com> add some tests for nameserver (#8349) Report URL: https://github.com/apache/rocketmq/actions/runs/10032532687 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Find ways to reduce tiered storage module's GC pressure [rocketmq]
bxfjb commented on issue #8408: URL: https://github.com/apache/rocketmq/issues/8408#issuecomment-2241895055 > It looks like your cache is holding SelectBufferResult, which wraps a ByteBuffer. From your description, it sounds like it’s non-direct (on-heap). Since they are long lived you might allocate them off heap as the cache itself being on heap shouldn’t be an issue. There’s quirks with direct byte buffers so they’re avoided until appropriate. You're right, the key is where the ByteBuffer is. The point is data source is objective storage SDK which means placing data in the heap seems inevitable. Perhaps the data still needs to be copied off the heap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] LitePullConsumer will Continuously print error logs util receive new msg [rocketmq]
keranbingaa opened a new issue, #8419: URL: https://github.com/apache/rocketmq/issues/8419 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment windows ### RocketMQ version develop branch ### JDK Version jdk8 ### Describe the Bug LitePullConsumer will Continuously print error logs like "consumerOffset is -1 in messageQueue" util receive new msg ### Steps to Reproduce just use demo LitePullConsumerSubscribe, and subscribe a topic which has consume group history early ### What Did You Expect to See? no Continuous error msg ### What Did You See Instead? Continuous error msg like: 2024-07-22 09:46:01 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=3]]. 2024-07-22 09:46:01 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=2]]. 2024-07-22 09:46:01 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=1]]. 2024-07-22 09:46:01 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=0]]. 2024-07-22 09:46:07 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=3]]. 2024-07-22 09:46:07 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=2]]. 2024-07-22 09:46:07 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=1]]. 2024-07-22 09:46:07 ERROR main - consumerOffset is -1 in messageQueue [MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=0]]. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] The wrong log type is used for log printing during error handling [rocketmq-spring]
LJiangTao opened a new issue, #670:
URL: https://github.com/apache/rocketmq-spring/issues/670
## environment
```xml
org.apache.rocketmq
rocketmq-spring-boot-starter
2.3.0
```
> current latest version also has issue.
## describe
using wrong log type in try-catch exception handle.
in
`org.apache.rocketmq.spring.support.DefaultRocketMQListenerContainer#doConvertMessage`
method used `log.info` instead of `log.error` in exception handling.
```java
private Object doConvertMessage(MessageExt messageExt) {
if (Objects.equals(messageType, MessageExt.class) ||
Objects.equals(messageType, org.apache.rocketmq.common.message.Message.class)) {
return messageExt;
} else {
String str = new String(messageExt.getBody(),
Charset.forName(charset));
if (Objects.equals(messageType, String.class)) {
return str;
} else {
// If msgType not string, use objectMapper change it.
try {
// ignored
} catch (Exception e) {
// here it is 👇
log.info("convert failed. str:{}, msgType:{}", str,
messageType);
throw new RuntimeException("cannot convert message to "
+ messageType, e);
}
}
}
}
```
`log.info` should print normal log, it shoud be using `log.error` instead of
`log.info`
## how to fix
```java
private Object doConvertMessage(MessageExt messageExt) {
if (Objects.equals(messageType, MessageExt.class) ||
Objects.equals(messageType, org.apache.rocketmq.common.message.Message.class)) {
return messageExt;
} else {
String str = new String(messageExt.getBody(),
Charset.forName(charset));
if (Objects.equals(messageType, String.class)) {
return str;
} else {
// If msgType not string, use objectMapper change it.
try {
// ignored
} catch (Exception e) {
// change like this
log.error("convert failed. str:{}, msgType:{}", str,
messageType);
throw new RuntimeException("cannot convert message to "
+ messageType, e);
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8405] Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations [rocketmq]
RongtongJin commented on PR #8403: URL: https://github.com/apache/rocketmq/pull/8403#issuecomment-2241907195 > How can this prevent JVM crashes? Is it because fileChannel uses off-heap memory? yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add more test coverage for DefaultMQPushConsumerImpl [rocketmq]
RongtongJin closed issue #8411: [Enhancement] Add more test coverage for DefaultMQPushConsumerImpl URL: https://github.com/apache/rocketmq/issues/8411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl [rocketmq]
RongtongJin merged PR #8412: URL: https://github.com/apache/rocketmq/pull/8412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412)
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new bd61774b1f [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) bd61774b1f is described below commit bd61774b1fc19f92c8c3a466420d50899ed61d9b Author: yx9o AuthorDate: Mon Jul 22 10:05:14 2024 +0800 [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl * Update * Update --- .../consumer/DefaultMQPushConsumerImplTest.java| 736 - 1 file changed, 719 insertions(+), 17 deletions(-) diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java index 879bbc593c..68563c0256 100644 --- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java +++ b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java @@ -17,17 +17,50 @@ package org.apache.rocketmq.client.impl.consumer; -import java.util.List; +import org.apache.commons.lang3.reflect.FieldUtils; +import org.apache.rocketmq.client.consumer.AckCallback; +import org.apache.rocketmq.client.consumer.AckResult; +import org.apache.rocketmq.client.consumer.AckStatus; import org.apache.rocketmq.client.consumer.DefaultMQPushConsumer; -import org.apache.rocketmq.client.consumer.listener.ConsumeConcurrentlyContext; +import org.apache.rocketmq.client.consumer.MessageSelector; +import org.apache.rocketmq.client.consumer.PopCallback; +import org.apache.rocketmq.client.consumer.PopResult; +import org.apache.rocketmq.client.consumer.PopStatus; +import org.apache.rocketmq.client.consumer.PullCallback; +import org.apache.rocketmq.client.consumer.PullResult; +import org.apache.rocketmq.client.consumer.PullStatus; import org.apache.rocketmq.client.consumer.listener.ConsumeConcurrentlyStatus; import org.apache.rocketmq.client.consumer.listener.MessageListenerConcurrently; +import org.apache.rocketmq.client.consumer.store.OffsetStore; +import org.apache.rocketmq.client.exception.MQBrokerException; import org.apache.rocketmq.client.exception.MQClientException; import org.apache.rocketmq.client.hook.ConsumeMessageContext; import org.apache.rocketmq.client.hook.ConsumeMessageHook; import org.apache.rocketmq.client.hook.FilterMessageContext; import org.apache.rocketmq.client.hook.FilterMessageHook; +import org.apache.rocketmq.client.impl.CommunicationMode; +import org.apache.rocketmq.client.impl.FindBrokerResult; +import org.apache.rocketmq.client.impl.MQAdminImpl; +import org.apache.rocketmq.client.impl.MQClientAPIImpl; +import org.apache.rocketmq.client.impl.factory.MQClientInstance; +import org.apache.rocketmq.client.stat.ConsumerStatsManager; +import org.apache.rocketmq.common.MixAll; +import org.apache.rocketmq.common.ServiceState; +import org.apache.rocketmq.common.message.MessageConst; import org.apache.rocketmq.common.message.MessageExt; +import org.apache.rocketmq.common.message.MessageQueue; +import org.apache.rocketmq.remoting.RPCHook; +import org.apache.rocketmq.remoting.exception.RemotingException; +import org.apache.rocketmq.remoting.protocol.body.ConsumeStatus; +import org.apache.rocketmq.remoting.protocol.body.ConsumerRunningInfo; +import org.apache.rocketmq.remoting.protocol.body.QueueTimeSpan; +import org.apache.rocketmq.remoting.protocol.header.AckMessageRequestHeader; +import org.apache.rocketmq.remoting.protocol.header.ChangeInvisibleTimeRequestHeader; +import org.apache.rocketmq.remoting.protocol.heartbeat.SubscriptionData; +import org.apache.rocketmq.remoting.protocol.route.BrokerData; +import org.apache.rocketmq.remoting.protocol.route.TopicRouteData; +import org.junit.Assert; +import org.junit.Before; import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; @@ -36,17 +69,85 @@ import org.junit.runner.RunWith; import org.mockito.Mock; import org.mockito.junit.MockitoJUnitRunner; +import java.net.InetSocketAddress; +import java.net.SocketAddress; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Set; +import java.util.TreeMap; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; +import java.util.concurrent.atomic.AtomicLong; + import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; +imp
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl * Update * Update Report URL: https://github.com/apache/rocketmq/actions/runs/10033402392 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user TeFuirnever (triggered by TeFuirnever). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl * Update * Update Report URL: https://github.com/apache/rocketmq/actions/runs/10033517320 With regards, GitHub Actions via GitBox
[PR] [ISSUE #8419] update consume offset when not get msg in litepullconsumer [rocketmq]
keranbingaa opened a new pull request, #8420: URL: https://github.com/apache/rocketmq/pull/8420 Fixes #8419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
codecov-commenter commented on PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#issuecomment-2241937943 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8418?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 45.09%. Comparing base [(`d9d53d5`)](https://app.codecov.io/gh/apache/rocketmq/commit/d9d53d58cf7f32143485f12d4851d5c119d0855a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`707911c`)](https://app.codecov.io/gh/apache/rocketmq/commit/707911c2e31aee7d0b46c39aaba34b7e5d7d2d27?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8418 +/- ## = - Coverage 45.12% 45.09% -0.03% - Complexity 1093110933 +2 = Files 1274 1274 Lines 8897088970 Branches 1143411434 = - Hits 4014440118 -26 - Misses 4382643848 +22 - Partials5000 5004 +4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8418?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user keranbingaa (triggered by keranbingaa). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl * Update * Update Report URL: https://github.com/apache/rocketmq/actions/runs/10033763584 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8419] update consume offset when not get msg in litepullconsumer [rocketmq]
codecov-commenter commented on PR #8420: URL: https://github.com/apache/rocketmq/pull/8420#issuecomment-2241957263 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review. > Project coverage is 45.38%. Comparing base [(`bd61774`)](https://app.codecov.io/gh/apache/rocketmq/commit/bd61774b1fc19f92c8c3a466420d50899ed61d9b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1c5b3d4`)](https://app.codecov.io/gh/apache/rocketmq/commit/1c5b3d44e6624d3499c120e2d2aa9e068e78648e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8420?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/8420?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Fconsumer%2FDefaultLitePullConsumerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8420 +/- ## = + Coverage 45.36% 45.38% +0.02% - Complexity 1098710991 +4 = Files 1274 1274 Lines 8897088972 +2 Branches 1143411435 +1 = + Hits 4035940382 +23 + Misses 4358143568 -13 + Partials5030 5022 -8 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8420?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8413]add some test cases for commom module [rocketmq]
RongtongJin merged PR #8414: URL: https://github.com/apache/rocketmq/pull/8414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add test cases for common module [rocketmq]
RongtongJin closed issue #8413: [Enhancement] Add test cases for common module URL: https://github.com/apache/rocketmq/issues/8413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8413] Add some test cases for commom module
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 6ecdc48223 [ISSUE #8413] Add some test cases for commom module
6ecdc48223 is described below
commit 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415
Author: yueran
AuthorDate: Mon Jul 22 11:14:35 2024 +0800
[ISSUE #8413] Add some test cases for commom module
---
.../rocketmq/common/BrokerConfigSingletonTest.java | 46 ++
1 file changed, 46 insertions(+)
diff --git
a/common/src/test/java/org/apache/rocketmq/common/BrokerConfigSingletonTest.java
b/common/src/test/java/org/apache/rocketmq/common/BrokerConfigSingletonTest.java
new file mode 100644
index 00..b98a6e37e6
--- /dev/null
+++
b/common/src/test/java/org/apache/rocketmq/common/BrokerConfigSingletonTest.java
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class BrokerConfigSingletonTest {
+
+/**
+ * Tests the behavior of getting the broker configuration when it has not
been initialized.
+ * Expects an IllegalArgumentException to be thrown, ensuring that the
configuration cannot be obtained without initialization.
+ */
+@Test(expected = IllegalArgumentException.class)
+public void getBrokerConfig_NullConfiguration_ThrowsException() {
+BrokerConfigSingleton.getBrokerConfig();
+}
+
+/**
+ * Tests the behavior of setting the broker configuration after it has
already been initialized.
+ * Expects an IllegalArgumentException to be thrown, ensuring that the
configuration cannot be reset once set.
+ * Also asserts that the returned brokerConfig instance is the same as the
one set, confirming the singleton property.
+ */
+@Test(expected = IllegalArgumentException.class)
+public void setBrokerConfig_AlreadyInitialized_ThrowsException() {
+BrokerConfig config = new BrokerConfig();
+BrokerConfigSingleton.setBrokerConfig(config);
+Assert.assertSame("Expected brokerConfig instance is not returned",
config, BrokerConfigSingleton.getBrokerConfig());
+BrokerConfigSingleton.setBrokerConfig(config);
+}
+
+}
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl * Update * Update Report URL: https://github.com/apache/rocketmq/actions/runs/10033402391 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https://github.com/apache/rocketmq/actions/runs/10034017993 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user keranbingaa (triggered by keranbingaa). Head commit for run: 1c5b3d44e6624d3499c120e2d2aa9e068e78648e / keranbingaa <397294...@qq.com> [ISSUE #8419] update consume offset when not get msg in litepullconsumer Report URL: https://github.com/apache/rocketmq/actions/runs/10033741736 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]
yx9o commented on code in PR #8418:
URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685931528
##
common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.common;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
+public class AclConfigTest {
+
+/**
+ * Test to verify that getGlobalWhiteAddrs returns null when no addresses
have been set.
Review Comment:
ci automatically triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize [rocketmq]
TanXiang7o opened a new issue, #8421: URL: https://github.com/apache/rocketmq/issues/8421 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary add more tests ### Motivation add more tests ### Describe the Solution You'd Like add more tests ### Describe Alternatives You've Considered add more tests ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]
TanXiang7o opened a new pull request, #8422: URL: https://github.com/apache/rocketmq/pull/8422 fix #8421 before:  after:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https://github.com/apache/rocketmq/actions/runs/10034017988 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user TanXiang7o (triggered by TanXiang7o). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https://github.com/apache/rocketmq/actions/runs/10034595980 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]
codecov-commenter commented on PR #8422: URL: https://github.com/apache/rocketmq/pull/8422#issuecomment-2242078258 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8422?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 45.48%. Comparing base [(`bd61774`)](https://app.codecov.io/gh/apache/rocketmq/commit/bd61774b1fc19f92c8c3a466420d50899ed61d9b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e24901f`)](https://app.codecov.io/gh/apache/rocketmq/commit/e24901f29a5c8aa0eb6cf440856a658d1e25af76?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8422 +/- ## = + Coverage 45.36% 45.48% +0.12% - Complexity 1098711003 +16 = Files 1274 1274 Lines 8897088970 Branches 1143411434 = + Hits 4035940470 +111 + Misses 4358143446 -135 - Partials5030 5054 +24 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8422?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] When will pushconsumer for go can be implemented? [rocketmq-clients]
AllenZMC opened a new issue, #800: URL: https://github.com/apache/rocketmq-clients/issues/800 ### Programming Language of the Client Go ### Is Your Feature Request Related to a Problem? We need to align features with Java/C++/... ### Describe the Solution You'd Like N/A ### Describe Alternatives You've Considered N/A ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize [rocketmq]
ShannonDing commented on issue #8421: URL: https://github.com/apache/rocketmq/issues/8421#issuecomment-2242159844 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]
ShannonDing commented on PR #8422: URL: https://github.com/apache/rocketmq/pull/8422#issuecomment-2242160413 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8392] add tests for QueryMessageProcessor [rocketmq]
ShannonDing commented on PR #8393: URL: https://github.com/apache/rocketmq/pull/8393#issuecomment-2242195357 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8372] Add more test coverage for AdminBrokerProcessor [rocketmq]
ShannonDing commented on PR #8373: URL: https://github.com/apache/rocketmq/pull/8373#issuecomment-2242196758 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add more test coverage for QueryMessageProcessor [rocketmq]
ShannonDing commented on issue #8392: URL: https://github.com/apache/rocketmq/issues/8392#issuecomment-2242200664 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Add more test coverage for AdminBrokerProcessor [rocketmq]
ShannonDing commented on issue #8372: URL: https://github.com/apache/rocketmq/issues/8372#issuecomment-2242202025 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
