[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 3d0cb77ba79030c509a123cb2d0c3ecf39cc13e3 / yuz10 <845238...@qq.com> fix macos test Report URL: https://github.com/apache/rocketmq/actions/runs/9169895777 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Implement Flow control in MQTT 5.0 [rocketmq-mqtt]
DongyuanPan commented on issue #246: URL: https://github.com/apache/rocketmq-mqtt/issues/246#issuecomment-2121927977 Looking forward to the implementation of this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 74ad424b630088f3da76c1c99c2b4813bbe96934 / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9170948102 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9170984138 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Support tiered storage run in primary/backup mode [rocketmq]
lizhimins commented on issue #8066: URL: https://github.com/apache/rocketmq/issues/8066#issuecomment-2122023640 如果要保留的话，一般想法就是等旧主恢复之后做一下 force upload，插入到 map -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by cserwen). Head commit for run: ff8fcea45548241a7b730dbf71b5edc9d372e560 / Hankunming <1109939...@qq.com> optimize: make compression type configurable in producer clinet level Report URL: https://github.com/apache/rocketmq/actions/runs/9168571071 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 74ad424b630088f3da76c1c99c2b4813bbe96934 / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9170948101 With regards, GitHub Actions via GitBox
Re: [PR] Support Topic Alias, User Properties, ContentType and payloadFormatIndicator [rocketmq-mqtt]
DongyuanPan commented on PR #254: URL: https://github.com/apache/rocketmq-mqtt/pull/254#issuecomment-2122076142 support SUBSCRIPTION_IDENTIFIER RESPONSE_TOPIC CORRELATION_DATA CONTENT_TYPE to close #240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: 3d0cb77ba79030c509a123cb2d0c3ecf39cc13e3 / yuz10 <845238...@qq.com> fix macos test Report URL: https://github.com/apache/rocketmq/actions/runs/9169895777 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 74ad424b630088f3da76c1c99c2b4813bbe96934 / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9170948106 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user humkum (triggered by cserwen). Head commit for run: ff8fcea45548241a7b730dbf71b5edc9d372e560 / Hankunming <1109939...@qq.com> optimize: make compression type configurable in producer clinet level Report URL: https://github.com/apache/rocketmq/actions/runs/9168571074 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9172224332 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9172610379 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9172806221 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 7320c705df8a22f0448bf2dc586c848482080554 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9172187706 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: d0f1707b5a07652456cc9c98932d63c3520550f4 / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9172570052 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user 3424672656 (triggered by 3424672656). Head commit for run: 5eb1e611d0502845c1aa52e93163ebb03f2d8eee / wanghuaiyuan <3424672...@qq.com> Fix semaphore exception that failed halfway in the case of asynchrono Report URL: https://github.com/apache/rocketmq/actions/runs/9172756360 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9173741005 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by lizhimins). Head commit for run: 7320c705df8a22f0448bf2dc586c848482080554 / LetLetMe [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) Report URL: https://github.com/apache/rocketmq/actions/runs/9172187706 With regards, GitHub Actions via GitBox
[PR] [ISSUE #246] feat: implement flow control [rocketmq-mqtt]
YxAc opened a new pull request, #279: URL: https://github.com/apache/rocketmq-mqtt/pull/279 ### Which Issue(s) This PR Fixes Close #246 ### Brief Description implement flow control for MQTT 5.0 ### How Did You Test This Change? UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8168]fix: There's no need to retry when async produce already timeout [rocketmq]
RongtongJin commented on PR #8169: URL: https://github.com/apache/rocketmq/pull/8169#issuecomment-2122614614 PTAL～@guyinyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 6c4186e9b44843b87f7f3424545daa869a66efea / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9173706855 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9176110476 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8168]fix: There's no need to retry when async produce already timeout [rocketmq]
Willhow-Gao commented on code in PR #8169:
URL: https://github.com/apache/rocketmq/pull/8169#discussion_r1608477337
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -704,7 +704,7 @@ public void operationFail(Throwable throwable) {
onExceptionImpl(brokerName, msg, timeoutMillis - cost,
request, sendCallback, topicPublishInfo, instance,
retryTimesWhenSendFailed, times, ex, context,
true, producer);
} else {
-MQClientException ex = new MQClientException("unknow
reseaon", throwable);
+MQClientException ex = new MQClientException("unknown
reason", throwable);
Review Comment:
If the exception here is a RemotingTooMuchRequestException, you should also
stop retrying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9183308425 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8084] fix typo [rocketmq]
RongtongJin commented on PR #8085: URL: https://github.com/apache/rocketmq/pull/8085#issuecomment-2123679386 Hi @hakusai22 , Could you help resolve the conflict？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8129] Support topic reserved time in tiered storage [rocketmq]
yuz10 commented on code in PR #8130:
URL: https://github.com/apache/rocketmq/pull/8130#discussion_r1609135617
##
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##
@@ -515,6 +519,33 @@ public void updateTopicConfig(final TopicConfig
topicConfig) {
this.persist(topicConfig.getTopicName(), topicConfig);
}
+private synchronized void updateTieredStoreTopicMetadata(final TopicConfig
topicConfig, Map newAttributes) {
+if (!(brokerController.getMessageStore() instanceof
TieredMessageStore)) {
+if
(newAttributes.get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName()) !=
null) {
+throw new IllegalArgumentException("Update topic reserveTime
not supported");
Review Comment:
这个是参数检查，更新或创建topic会失败。关闭分级存储之后，只要不传入reserveTIme就不会报错
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8084] fix typo [rocketmq]
hakusai22 commented on PR #8085: URL: https://github.com/apache/rocketmq/pull/8085#issuecomment-2123696629 > Hi @hakusai22 , Could you help resolve the conflict？ does > Hi @hakusai22 , Could you help resolve the conflict？ done . Why? The bug I found was merged in by others in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user hakusai22 (triggered by hakusai22). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9183783883 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user hakusai22 (triggered by hakusai22). Head commit for run: e7d4545cec1eb0f6793da427f4ea6c50321d3470 / yinpeng Merge branch 'develop' into fix_typo_v2 # Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java Report URL: https://github.com/apache/rocketmq/actions/runs/9183762607 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8168]fix: There's no need to retry when async produce already timeout [rocketmq]
humkum commented on code in PR #8169:
URL: https://github.com/apache/rocketmq/pull/8169#discussion_r1609156131
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -704,7 +704,7 @@ public void operationFail(Throwable throwable) {
onExceptionImpl(brokerName, msg, timeoutMillis - cost,
request, sendCallback, topicPublishInfo, instance,
retryTimesWhenSendFailed, times, ex, context,
true, producer);
} else {
-MQClientException ex = new MQClientException("unknow
reseaon", throwable);
+MQClientException ex = new MQClientException("unknown
reason", throwable);
Review Comment:
You are right, and the invokeAsync won't throw
RemotingTooMuchRequestException, I will make some changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 94bb64f73160e309438fb000719fff0619355dd4 / mxsm [ISSUE #8162]Optimize the logging printout for the ConfigManager#loadBak method (#8163) Report URL: https://github.com/apache/rocketmq/actions/runs/9184093293 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8168]fix: There's no need to retry when async produce already timeout [rocketmq]
guyinyou commented on PR #8169: URL: https://github.com/apache/rocketmq/pull/8169#issuecomment-2123737540 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user hakusai22 (triggered by hakusai22). Head commit for run: e7d4545cec1eb0f6793da427f4ea6c50321d3470 / yinpeng Merge branch 'develop' into fix_typo_v2 # Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java Report URL: https://github.com/apache/rocketmq/actions/runs/9183762599 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 0468a096f3229f4ec710a075b892de7d99164231 / Hankunming <1109939...@qq.com> fix: There's no need to retry when async produce already timeout Report URL: https://github.com/apache/rocketmq/actions/runs/9184069036 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user humkum (triggered by humkum). Head commit for run: 0468a096f3229f4ec710a075b892de7d99164231 / Hankunming <1109939...@qq.com> fix: There's no need to retry when async produce already timeout Report URL: https://github.com/apache/rocketmq/actions/runs/9184069027 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8058]Support for upgrading metadata in json to rocksdb (#8045) [rocketmq]
LetLetMe commented on PR #8116: URL: https://github.com/apache/rocketmq/pull/8116#issuecomment-2123820289 > I checked the code, and it seems that upgrading from the 5.2.0 version with RocksDB enabled to this modified version is fully compatible, isn't it? 没问题 No problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Remove duplicate code in TopicPublishInfo [rocketmq]
ling0900 commented on issue #6398: URL: https://github.com/apache/rocketmq/issues/6398#issuecomment-2123877225 Is it possible for this issue to be closed in the near future? If not, I'll try to follow up on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #264] fix: cherry pick #265 to fix compilation error [rocketmq-mqtt]
YxAc opened a new pull request, #280: URL: https://github.com/apache/rocketmq-mqtt/pull/280 cherry pick #265 to fix #264 compilation error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8129] Support topic reserved time in tiered storage [rocketmq]
lizhimins merged PR #8130: URL: https://github.com/apache/rocketmq/pull/8130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8129] Support topic reserved time in tiered storage (#8130)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 1b42515093 [ISSUE #8129] Support topic reserved time in tiered storage
(#8130)
1b42515093 is described below
commit 1b42515093fb56a2cabfa754564397e343a357be
Author: yuz10 <845238...@qq.com>
AuthorDate: Wed May 22 14:09:00 2024 +0800
[ISSUE #8129] Support topic reserved time in tiered storage (#8130)
Co-authored-by: yuzhou
---
broker/BUILD.bazel | 2 ++
.../rocketmq/broker/topic/TopicConfigManager.java | 31 ++
.../apache/rocketmq/common/TopicAttributes.java| 9 +++
tieredstore/README.md | 4 +--
.../rocketmq/tieredstore/file/FlatFileStore.java | 4 +--
.../rocketmq/tieredstore/file/FlatMessageFile.java | 7 +
.../metrics/TieredStoreMetricsManager.java | 5 ++--
7 files changed, 56 insertions(+), 6 deletions(-)
diff --git a/broker/BUILD.bazel b/broker/BUILD.bazel
index 785b765774..0dbc85f945 100644
--- a/broker/BUILD.bazel
+++ b/broker/BUILD.bazel
@@ -29,6 +29,7 @@ java_library(
"//remoting",
"//srvutil",
"//store",
+"//tieredstore",
"@maven//:ch_qos_logback_logback_classic",
"@maven//:com_alibaba_fastjson",
"@maven//:com_alibaba_fastjson2_fastjson2",
@@ -81,6 +82,7 @@ java_library(
"//filter",
"//remoting",
"//store",
+"//tieredstore",
"@maven//:com_alibaba_fastjson",
"@maven//:com_alibaba_fastjson2_fastjson2",
"@maven//:com_google_guava_guava",
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
b/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
index 511d29e12a..1ed9cbab5f 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
@@ -51,6 +51,9 @@ import org.apache.rocketmq.remoting.protocol.body.KVTable;
import
org.apache.rocketmq.remoting.protocol.body.TopicConfigAndMappingSerializeWrapper;
import org.apache.rocketmq.remoting.protocol.body.TopicConfigSerializeWrapper;
import org.apache.rocketmq.remoting.protocol.statictopic.TopicQueueMappingInfo;
+import org.apache.rocketmq.tieredstore.TieredMessageStore;
+import org.apache.rocketmq.tieredstore.metadata.MetadataStore;
+import org.apache.rocketmq.tieredstore.metadata.entity.TopicMetadata;
import static com.google.common.base.Preconditions.checkNotNull;
@@ -501,6 +504,7 @@ public class TopicConfigManager extends ConfigManager {
ImmutableMap.copyOf(newAttributes));
topicConfig.setAttributes(finalAttributes);
+updateTieredStoreTopicMetadata(topicConfig, newAttributes);
TopicConfig old = putTopicConfig(topicConfig);
if (old != null) {
@@ -515,6 +519,33 @@ public class TopicConfigManager extends ConfigManager {
this.persist(topicConfig.getTopicName(), topicConfig);
}
+private synchronized void updateTieredStoreTopicMetadata(final TopicConfig
topicConfig, Map newAttributes) {
+if (!(brokerController.getMessageStore() instanceof
TieredMessageStore)) {
+if
(newAttributes.get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName()) !=
null) {
+throw new IllegalArgumentException("Update topic reserveTime
not supported");
+}
+return;
+}
+
+String topic = topicConfig.getTopicName();
+long reserveTime =
TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getDefaultValue();
+String attr =
topicConfig.getAttributes().get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName());
+if (attr != null) {
+reserveTime = Long.parseLong(attr);
+}
+
+log.info("Update tiered storage metadata, topic {}, reserveTime {}",
topic, reserveTime);
+TieredMessageStore tieredMessageStore = (TieredMessageStore)
brokerController.getMessageStore();
+MetadataStore metadataStore = tieredMessageStore.getMetadataStore();
+TopicMetadata topicMetadata = metadataStore.getTopic(topic);
+if (topicMetadata == null) {
+metadataStore.addTopic(topic, reserveTime);
+} else if (topicMetadata.getReserveTime() != reserveTime) {
+topicMetadata.setReserveTime(reserveTime);
+metadataStore.updateTopic(topicMetadata);
+}
+}
+
public void updateOrderTopicConfig(final KVTable orderKVTableFromNs) {
if (orderKVTableFromNs != null && orderKVTableFromNs.getTable() !=
null) {
diff --git
a/common/src/main/java/org/apache/rocketmq/common/TopicAttributes.java
b/common/src/main/java/org/apache/rocketmq/common/TopicAttributes.jav
Re: [I] [Enhancement] support update topic reserved time for topic in tiered storage [rocketmq]
lizhimins closed issue #8129: [Enhancement] support update topic reserved time for topic in tiered storage URL: https://github.com/apache/rocketmq/issues/8129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PR-CI" failed!
The GitHub Actions job "PR-CI" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: c930b0853b88cbf29a937470d28ab23a8f034443 / weihu Merge remote-tracking branch 'refs/remotes/apache_master/develop' into weihubeats/develop Report URL: https://github.com/apache/rocketmq/actions/runs/9186297191 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: c930b0853b88cbf29a937470d28ab23a8f034443 / weihu Merge remote-tracking branch 'refs/remotes/apache_master/develop' into weihubeats/develop Report URL: https://github.com/apache/rocketmq/actions/runs/9186297190 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: 1b42515093fb56a2cabfa754564397e343a357be / yuz10 <845238...@qq.com> [ISSUE #8129] Support topic reserved time in tiered storage (#8130) Co-authored-by: yuzhou Report URL: https://github.com/apache/rocketmq/actions/runs/9186303987 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user weihubeats (triggered by weihubeats). Head commit for run: c930b0853b88cbf29a937470d28ab23a8f034443 / weihu Merge remote-tracking branch 'refs/remotes/apache_master/develop' into weihubeats/develop Report URL: https://github.com/apache/rocketmq/actions/runs/9186297186 With regards, GitHub Actions via GitBox
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
weihubeats commented on PR #740: URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2123948927 @lizhanhui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 1b42515093fb56a2cabfa754564397e343a357be / yuz10 <845238...@qq.com> [ISSUE #8129] Support topic reserved time in tiered storage (#8130) Co-authored-by: yuzhou Report URL: https://github.com/apache/rocketmq/actions/runs/9186202592 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 1b42515093fb56a2cabfa754564397e343a357be / yuz10 <845238...@qq.com> [ISSUE #8129] Support topic reserved time in tiered storage (#8130) Co-authored-by: yuzhou Report URL: https://github.com/apache/rocketmq/actions/runs/9186202588 With regards, GitHub Actions via GitBox
[PR] [ISSUE #166] fix concurrency for message property string [rocketmq-client-go]
absolute8511 opened a new pull request, #1141: URL: https://github.com/apache/rocketmq-client-go/pull/1141 ## What is the purpose of the change fix #166 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #274]: fix startup exception [rocketmq-mqtt]
YxAc commented on PR #276: URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124007685 hi @yx9o , can you cherry pick #265 to fix the compilation error and keep consistency with the main branch, thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
