[PR] [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance [rocketmq]
miles-ton opened a new pull request, #8165: URL: https://github.com/apache/rocketmq/pull/8165 ### Which Issue(s) This PR Fixes Fixes #8164 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user miles-ton (triggered by miles-ton). Head commit for run: 9bdc9db9c46873f948fad2bdac5cc14aa1918f57 / oopooa <41882826+oop...@users.noreply.github.com> [ISSUE #8155] Fix doc typo Report URL: https://github.com/apache/rocketmq/actions/runs/9145875374 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance [rocketmq]
codecov-commenter commented on PR #8165: URL: https://github.com/apache/rocketmq/pull/8165#issuecomment-2119135013 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8165?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review. > Project coverage is 42.90%. Comparing base [(`9bdc9db`)](https://app.codecov.io/gh/apache/rocketmq/commit/9bdc9db9c46873f948fad2bdac5cc14aa1918f57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`56b4bbf`)](https://app.codecov.io/gh/apache/rocketmq/pull/8165?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8165?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rocketmq/client/impl/factory/MQClientInstance.java](https://app.codecov.io/gh/apache/rocketmq/pull/8165?src=pr&el=tree&filepath=client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fclient%2Fimpl%2Ffactory%2FMQClientInstance.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8165?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#8165 +/- ## = - Coverage 42.93% 42.90% -0.04% + Complexity 1037210366 -6 = Files 1270 1270 Lines 8868988689 Branches 1140211402 = - Hits 3807738048 -29 - Misses 4591545937 +22 - Partials4697 4704 +7 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8165?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user miles-ton (triggered by miles-ton). Head commit for run: 56b4bbf6992ff8c4f8e8d19f1142d65b27da1fed / hiyo <244987...@qq.com> [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance Report URL: https://github.com/apache/rocketmq/actions/runs/9145855354 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Remove the pop mode from PushConsumer [rocketmq]
github-actions[bot] closed issue #6769: [Enhancement] Remove the pop mode from PushConsumer URL: https://github.com/apache/rocketmq/issues/6769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] WARN ReputMessageService - slave get many warnings "found a illegal magic code" [rocketmq]
github-actions[bot] closed issue #6767: [Bug] WARN ReputMessageService - slave get many warnings "found a illegal magic code" URL: https://github.com/apache/rocketmq/issues/6767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] WARN ReputMessageService - slave get many warnings "found a illegal magic code" [rocketmq]
github-actions[bot] commented on issue #6767: URL: https://github.com/apache/rocketmq/issues/6767#issuecomment-2119463947 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Remove the pop mode from PushConsumer [rocketmq]
github-actions[bot] commented on issue #6769: URL: https://github.com/apache/rocketmq/issues/6769#issuecomment-2119463935 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore(deps): bump golang.org/x/net from 0.0.0-20220809184613-07c6da5e1ced to 0.23.0 in /golang [rocketmq-clients]
github-actions[bot] commented on PR #731: URL: https://github.com/apache/rocketmq-clients/pull/731#issuecomment-2119469606 This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE#8142] Show time of create topic and subScriptionGroup [rocketmq]
RongtongJin merged PR #8143: URL: https://github.com/apache/rocketmq/pull/8143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] execution time of create topic and subscription [rocketmq]
RongtongJin closed issue #8142: execution time of create topic and subscription URL: https://github.com/apache/rocketmq/issues/8142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE#8142] Show time of create topic and subScriptionGroup (#8143)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 256217fb62 [ISSUE#8142] Show time of create topic and
subScriptionGroup (#8143)
256217fb62 is described below
commit 256217fb6283f8b4c535045682aaef6346be2a87
Author: superdev42 <138118491+superde...@users.noreply.github.com>
AuthorDate: Mon May 20 09:57:21 2024 +0800
[ISSUE#8142] Show time of create topic and subScriptionGroup (#8143)
* show time of create topic and subScriptionGroup
* show time of create topic and subScriptionGroup again
* show time of create topic and subScriptionGroup changed
-
Co-authored-by: wengxiaolong <22260...@zju.edu.cn>
---
.../apache/rocketmq/broker/processor/AdminBrokerProcessor.java | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
index 78a5ba92ee..a1a6f5bf6c 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
@@ -455,6 +455,7 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext ctx,
RemotingCommand request) throws RemotingCommandException {
+long startTime = System.currentTimeMillis();
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
final CreateTopicRequestHeader requestHeader =
(CreateTopicRequestHeader)
request.decodeCommandCustomHeader(CreateTopicRequestHeader.class);
@@ -514,8 +515,10 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
LOGGER.error("Update / create topic failed for [{}]", request, e);
response.setCode(ResponseCode.SYSTEM_ERROR);
response.setRemark(e.getMessage());
+return response;
}
-
+long executionTime = System.currentTimeMillis() - startTime;
+LOGGER.info("executionTime of create topic:{} is {} ms" , topic,
executionTime);
return response;
}
@@ -1450,6 +1453,7 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
private RemotingCommand
updateAndCreateSubscriptionGroup(ChannelHandlerContext ctx, RemotingCommand
request)
throws RemotingCommandException {
+long startTime = System.currentTimeMillis();
final RemotingCommand response =
RemotingCommand.createResponseCommand(null);
LOGGER.info("AdminBrokerProcessor#updateAndCreateSubscriptionGroup
called by {}",
@@ -1462,6 +1466,8 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
response.setCode(ResponseCode.SUCCESS);
response.setRemark(null);
+long executionTime = System.currentTimeMillis() - startTime;
+LOGGER.info("executionTime of create subscriptionGroup:{} is {} ms"
,config.getGroupName() ,executionTime);
return response;
}
@@ -3154,7 +3160,7 @@ public class AdminBrokerProcessor implements
NettyRequestProcessor {
}
private boolean validateBlackListConfigExist(Properties properties) {
-for (String blackConfig:configBlackList) {
+for (String blackConfig : configBlackList) {
if (properties.containsKey(blackConfig)) {
return true;
}
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 256217fb6283f8b4c535045682aaef6346be2a87 / superdev42 <138118491+superde...@users.noreply.github.com> [ISSUE#8142] Show time of create topic and subScriptionGroup (#8143) * show time of create topic and subScriptionGroup * show time of create topic and subScriptionGroup again * show time of create topic and subScriptionGroup changed - Co-authored-by: wengxiaolong <22260...@zju.edu.cn> Report URL: https://github.com/apache/rocketmq/actions/runs/9152361196 With regards, GitHub Actions via GitBox
Re: [I] [Bug] Response should not be discarded even the channel is unwritable [rocketmq]
drpmma commented on issue #8159: URL: https://github.com/apache/rocketmq/issues/8159#issuecomment-2119564792 I understand that the purpose of `isWriteable` is primarily to protect the server from memory overflow and to do backpressure, acting as a sort of fail-fast mechanism. It serves a definite purpose, and I am more inclined towards keeping this piece of logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance [rocketmq]
drpmma merged PR #8165: URL: https://github.com/apache/rocketmq/pull/8165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] make log more accurate fot the MQClientInstance#doRebalance [rocketmq]
drpmma closed issue #8164: [Enhancement] make log more accurate fot the MQClientInstance#doRebalance URL: https://github.com/apache/rocketmq/issues/8164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165)
This is an automated email from the ASF dual-hosted git repository.
zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 0ad0244fe5 [ISSUE #8164] Log more accurate for the
MQClientInstance#doRebalance (#8165)
0ad0244fe5 is described below
commit 0ad0244fe504d9e20a15e83222826f1172bdc4b3
Author: hiyo <77013030+miles-...@users.noreply.github.com>
AuthorDate: Mon May 20 10:47:59 2024 +0800
[ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165)
---
.../java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
index 1ff35a00d1..b4ebf69273 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
@@ -1070,7 +1070,7 @@ public class MQClientInstance {
balanced = false;
}
} catch (Throwable e) {
-log.error("doRebalance exception", e);
+log.error("doRebalance for consumer group [{}] exception",
entry.getKey(), e);
}
}
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 256217fb6283f8b4c535045682aaef6346be2a87 / superdev42 <138118491+superde...@users.noreply.github.com> [ISSUE#8142] Show time of create topic and subScriptionGroup (#8143) * show time of create topic and subScriptionGroup * show time of create topic and subScriptionGroup again * show time of create topic and subScriptionGroup changed - Co-authored-by: wengxiaolong <22260...@zju.edu.cn> Report URL: https://github.com/apache/rocketmq/actions/runs/9152361194 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 0ad0244fe504d9e20a15e83222826f1172bdc4b3 / hiyo <77013030+miles-...@users.noreply.github.com> [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165) Report URL: https://github.com/apache/rocketmq/actions/runs/9152769668 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 0ad0244fe504d9e20a15e83222826f1172bdc4b3 / hiyo <77013030+miles-...@users.noreply.github.com> [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165) Report URL: https://github.com/apache/rocketmq/actions/runs/9153175670 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 0ad0244fe504d9e20a15e83222826f1172bdc4b3 / hiyo <77013030+miles-...@users.noreply.github.com> [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165) Report URL: https://github.com/apache/rocketmq/actions/runs/9152769669 With regards, GitHub Actions via GitBox
[I] [Feature] Please Describe the Feature [rocketmq-clients]
woaishixiaoxiao opened a new issue, #757: URL: https://github.com/apache/rocketmq-clients/issues/757 ### Programming Language of the Client Java ### Is Your Feature Request Related to a Problem? popular consumption patterns generates a large amount of additional metadata information, which greatly wastes the performance of the server. The server already supports the batchAck interface, but the client currently doesn't seem to support it? ### Describe the Solution You'd Like sdk support batch ack ### Describe Alternatives You've Considered schedule batch ack instead of ack for each message ### Additional Context nothing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8124] Avoid scheduled tasks exiting because of unknown exceptions. [rocketmq]
colin719 commented on PR #8132: URL: https://github.com/apache/rocketmq/pull/8132#issuecomment-2119622197 @cserwen please merge it？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 96b68fff16fd6c1376f05e235eccd43ee28bf8a2 / LetLetMe 修改部分代码 Report URL: https://github.com/apache/rocketmq/actions/runs/9153157786 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8129] Support topic reserved time in tiered storage [rocketmq]
lizhimins commented on code in PR #8130:
URL: https://github.com/apache/rocketmq/pull/8130#discussion_r1606282322
##
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##
@@ -515,6 +519,33 @@ public void updateTopicConfig(final TopicConfig
topicConfig) {
this.persist(topicConfig.getTopicName(), topicConfig);
}
+private synchronized void updateTieredStoreTopicMetadata(final TopicConfig
topicConfig, Map newAttributes) {
+if (!(brokerController.getMessageStore() instanceof
TieredMessageStore)) {
+if
(newAttributes.get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName()) !=
null) {
+throw new IllegalArgumentException("Update topic reserveTime
not supported");
Review Comment:
tiered storage feature is optional, should not throw exception here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8129] Support topic reserved time in tiered storage [rocketmq]
lizhimins commented on code in PR #8130:
URL: https://github.com/apache/rocketmq/pull/8130#discussion_r1606283729
##
broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java:
##
@@ -515,6 +519,33 @@ public void updateTopicConfig(final TopicConfig
topicConfig) {
this.persist(topicConfig.getTopicName(), topicConfig);
}
+private synchronized void updateTieredStoreTopicMetadata(final TopicConfig
topicConfig, Map newAttributes) {
+if (!(brokerController.getMessageStore() instanceof
TieredMessageStore)) {
+if
(newAttributes.get(TopicAttributes.TOPIC_RESERVE_TIME_ATTRIBUTE.getName()) !=
null) {
+throw new IllegalArgumentException("Update topic reserveTime
not supported");
Review Comment:
如果没开启这个功能的时候更新了 topic config, 会抛异常？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user LetLetMe (triggered by LetLetMe). Head commit for run: 0ad0244fe504d9e20a15e83222826f1172bdc4b3 / hiyo <77013030+miles-...@users.noreply.github.com> [ISSUE #8164] Log more accurate for the MQClientInstance#doRebalance (#8165) Report URL: https://github.com/apache/rocketmq/actions/runs/9154573172 With regards, GitHub Actions via GitBox
