Re: [I] [Bug] The lettuce log appears in rocketmq_client.log, although rocketmq does not use this package, but why lettuce logs will be output to rocketmq_client.log? lettuce package when redis topolo
humkum commented on issue #8111: URL: https://github.com/apache/rocketmq/issues/8111#issuecomment-2099880177 RocketMQ client use Slf4j Log architecture，if you want to split the log output file, you can customize the log configuration file by yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f0c243d741dd0c7d47716efe557bc5a0e50ba29a / Willhow <65004897+willhow-...@users.noreply.github.com> [ISSUE #8090] Optimize isSetEqual for DefaultLitePullConsumerImpl (#8091) * [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a typo in MQAdminImpl * remove author message * Modify code style Report URL: https://github.com/apache/rocketmq/actions/runs/8997035836 With regards, GitHub Actions via GitBox
Re: [I] [Bug] The lettuce log appears in rocketmq_client.log, although rocketmq does not use this package, but why lettuce logs will be output to rocketmq_client.log? lettuce package when redis topolo
FrankCy commented on issue #8111: URL: https://github.com/apache/rocketmq/issues/8111#issuecomment-2099915057 > RocketMQ client use Slf4j Log architecture，if you want to split the log output file, you can customize the log configuration file by yourself. Hello, is this caused by lettuce and rocketmq using slf4j at the same time? Looking at the source code for both components does indeed use slf4j as a logging facade, and would like to analyse why this issue occurs. After setting lettuce's log output level to ERROR and rocketmq's log.level to debug, lettuce's logs are still being fed into rocketmq_client.log, I'm having trouble locating and resolving the issue here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8049] Fix tiered storage delete topic NPE in default metadata store [rocketmq]
bxfjb commented on PR #8050: URL: https://github.com/apache/rocketmq/pull/8050#issuecomment-2099935550 > Rebase master to solve the CI problem Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8049] Fix tiered storage delete topic NPE in default metadata store [rocketmq]
yuz10 merged PR #8050: URL: https://github.com/apache/rocketmq/pull/8050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] TieredMessageStore throws NPE when delete a topic without messages [rocketmq]
yuz10 closed issue #8049: [Bug] TieredMessageStore throws NPE when delete a topic without messages URL: https://github.com/apache/rocketmq/issues/8049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8049] fix tiered store delete empty topic NPE (#8050)
This is an automated email from the ASF dual-hosted git repository.
yuzhou pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new ad02756078 [ISSUE #8049] fix tiered store delete empty topic NPE
(#8050)
ad02756078 is described below
commit ad027560780c2af801e4bcb447d85bf0df62071a
Author: bxfjb <48467309+bx...@users.noreply.github.com>
AuthorDate: Wed May 8 15:39:49 2024 +0800
[ISSUE #8049] fix tiered store delete empty topic NPE (#8050)
Co-authored-by: zhaoyuhan
---
.../apache/rocketmq/tieredstore/metadata/DefaultMetadataStore.java | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/metadata/DefaultMetadataStore.java
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/metadata/DefaultMetadataStore.java
index 630276a97f..09500bf6da 100644
---
a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/metadata/DefaultMetadataStore.java
+++
b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/metadata/DefaultMetadataStore.java
@@ -164,7 +164,10 @@ public class DefaultMetadataStore extends ConfigManager
implements MetadataStore
@Override
public void iterateQueue(String topic, Consumer callback) {
-queueMetadataTable.get(topic).values().forEach(callback);
+ConcurrentMap metadataConcurrentMap =
queueMetadataTable.get(topic);
+if (metadataConcurrentMap != null) {
+metadataConcurrentMap.values().forEach(callback);
+}
}
@Override
[GH] (rocketmq): Workflow run "PUSH-CI" is working again!
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user yuz10 (triggered by yuz10). Head commit for run: ad027560780c2af801e4bcb447d85bf0df62071a / bxfjb <48467309+bx...@users.noreply.github.com> [ISSUE #8049] fix tiered store delete empty topic NPE (#8050) Co-authored-by: zhaoyuhan Report URL: https://github.com/apache/rocketmq/actions/runs/8998115193 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
dingshuangxi888 commented on PR #8102: URL: https://github.com/apache/rocketmq/pull/8102#issuecomment-2099983237 > If the client sets ak/sk, then all request headers will have ak/sk information, including heartbeats. And if ak/sk is not set on the client, those configurations should also be turned off on the server. Maybe this is not a bug @dingshuangxi888 > > ``` > authenticationEnabled=false > authorizationEnabled=false > ``` The old client has no ReqeustHeader, such as Heartbeat api, if the ak/sk is not set, it will get NPE error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
cserwen commented on PR #8102: URL: https://github.com/apache/rocketmq/pull/8102#issuecomment-219157 > > If the client sets ak/sk, then all request headers will have ak/sk information, including heartbeats. And if ak/sk is not set on the client, those configurations should also be turned off on the server. Maybe this is not a bug @dingshuangxi888 > > ``` > > authenticationEnabled=false > > authorizationEnabled=false > > ``` > > The old client may has no ReqeustHeader, such as Heartbeat api, if the ak/sk is not set, the extFields will be null and it will get NPE error. OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Implement Flow control in MQTT 5.0 [rocketmq-mqtt]
DongyuanPan commented on issue #246: URL: https://github.com/apache/rocketmq-mqtt/issues/246#issuecomment-2100022188 > I will work on this recently. > > By the doc of mqtt v5.0, the flow control just limit `publish qps`, not including `connection limit` and `publish bytes limit`, right? Do I need to provide a design document? Yes, and just focus on PUBLISH packet at QoS > 0. It should be noted that this restriction interacts through CONN, CONNACK, so for the server side, how to reject more Publish packets, and how to control the server to send Publish packets to the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: ad027560780c2af801e4bcb447d85bf0df62071a / bxfjb <48467309+bx...@users.noreply.github.com> [ISSUE #8049] fix tiered store delete empty topic NPE (#8050) Co-authored-by: zhaoyuhan Report URL: https://github.com/apache/rocketmq/actions/runs/8998523543 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: 38dd0d68f94d084f513522d85e876f50a886b4e8 / dingshuangxi888 Merge remote-tracking branch 'upstream/develop' into feature/fix_ext_field_2 Report URL: https://github.com/apache/rocketmq/actions/runs/8998488018 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #5838] retry to send when broker returns SYSTEM_BUSY [rocketmq]
cserwen commented on code in PR #5845:
URL: https://github.com/apache/rocketmq/pull/5845#discussion_r1593695472
##
client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java:
##
@@ -72,7 +72,8 @@ public class DefaultMQProducer extends ClientConfig
implements MQProducer {
ResponseCode.SYSTEM_ERROR,
ResponseCode.NO_PERMISSION,
ResponseCode.NO_BUYER_ID,
-ResponseCode.NOT_IN_CURRENT_UNIT
+ResponseCode.NOT_IN_CURRENT_UNIT,
+ResponseCode.SYSTEM_BUSY
Review Comment:
> How about removing TOPIC_NOT_EXIST?
Sometimes a topic will be deleted or disabled on a broker node. Maybe due to
the failed routing update, it may request this broker, so retrying here is
still necessary. @ShadowySpirits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
cserwen commented on PR #8102: URL: https://github.com/apache/rocketmq/pull/8102#issuecomment-2100128589 @dingshuangxi888 Some unit-tests maybe need to be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5838] retry to send when broker returns SYSTEM_BUSY [rocketmq]
codecov-commenter commented on PR #5845: URL: https://github.com/apache/rocketmq/pull/5845#issuecomment-2100178068 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/5845?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 42.85%. Comparing base [(`dcf892a`)](https://app.codecov.io/gh/apache/rocketmq/commit/dcf892a15662da858f0c6dadc93da272b18a0f00?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8c60f7f`)](https://app.codecov.io/gh/apache/rocketmq/pull/5845?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 6 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#5845 +/- ## = - Coverage 42.93% 42.85% -0.09% + Complexity 1038110356 -25 = Files 1270 1270 Lines 8869088691 +1 Branches 1139911399 = - Hits 3807838006 -72 - Misses 4592445987 +63 - Partials4688 4698 +10 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/5845?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
lizhanhui commented on PR #740: URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2100192370 > @lizhanhui Is there anything else wrong with this pr? Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Inconsistent Broker Data Retrieved from Different RocketMQ NameServers. [rocketmq-operator]
shangjin92 opened a new issue, #227: URL: https://github.com/apache/rocketmq-operator/issues/227 **Description of the issue:** There is inconsistent Broker data being retrieved when querying different RocketMQ NameServers. This inconsistency could potentially lead to issues with message routing and client connections within a distributed RocketMQ setup.   **Expected Result:** The Broker data retrieved from all NameServers should be consistent and identical, ensuring stable functionality throughout the RocketMQ cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove useless heartbeat success log prints [rocketmq-clients]
weihubeats commented on PR #740: URL: https://github.com/apache/rocketmq-clients/pull/740#issuecomment-2100207461 So this mr can merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8025] fix: fix topic route when topic deleted [rocketmq]
cserwen commented on code in PR #8027:
URL: https://github.com/apache/rocketmq/pull/8027#discussion_r1593806191
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -2007,6 +2007,7 @@ public TopicRouteData
getTopicRouteInfoFromNameServer(final String topic, final
case ResponseCode.TOPIC_NOT_EXIST: {
if (allowTopicNotExist) {
log.warn("get Topic [{}] RouteInfoFromNameServer is not
exist value", topic);
+return null;
Review Comment:
This may cause some npe, maybe need to check, such as
https://github.com/apache/rocketmq/blob/ad027560780c2af801e4bcb447d85bf0df62071a/proxy/src/main/java/org/apache/rocketmq/proxy/service/admin/DefaultAdminService.java#L60-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [ISSUE #8025] fix: fix topic route when topic deleted [rocketmq]
cserwen commented on code in PR #8027:
URL: https://github.com/apache/rocketmq/pull/8027#discussion_r1593806191
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -2007,6 +2007,7 @@ public TopicRouteData
getTopicRouteInfoFromNameServer(final String topic, final
case ResponseCode.TOPIC_NOT_EXIST: {
if (allowTopicNotExist) {
log.warn("get Topic [{}] RouteInfoFromNameServer is not
exist value", topic);
+return null;
Review Comment:
This may cause sime npe, maybe need to check, such as
https://github.com/apache/rocketmq/blob/ad027560780c2af801e4bcb447d85bf0df62071a/proxy/src/main/java/org/apache/rocketmq/proxy/service/admin/DefaultAdminService.java#L60-L85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [ISSUE #227] Fix inconsistent Broker data across different RocketMQ NameServers. [rocketmq-operator]
shangjin92 opened a new pull request, #228: URL: https://github.com/apache/rocketmq-operator/pull/228 1. fix #227 2. Refactor ReconcileBroker by extracting EnsureBrokerStatefulSets method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by drpmma). Head commit for run: 38dd0d68f94d084f513522d85e876f50a886b4e8 / dingshuangxi888 Merge remote-tracking branch 'upstream/develop' into feature/fix_ext_field_2 Report URL: https://github.com/apache/rocketmq/actions/runs/8998488018 With regards, GitHub Actions via GitBox
Re: [I] [Bug] org.apache.rocketmq.client.producer.DefaultMQProducer#request invoke timeout [rocketmq]
github-actions[bot] commented on issue #6726: URL: https://github.com/apache/rocketmq/issues/6726#issuecomment-2101693146 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] SubscriptionData may not be updated when the client's system time is rolled back [rocketmq]
github-actions[bot] closed issue #6679: SubscriptionData may not be updated when the client's system time is rolled back URL: https://github.com/apache/rocketmq/issues/6679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] SubscriptionData may not be updated when the client's system time is rolled back [rocketmq]
github-actions[bot] commented on issue #6679: URL: https://github.com/apache/rocketmq/issues/6679#issuecomment-2101693173 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6653] Remove duplicate code about validate topic [rocketmq]
github-actions[bot] commented on PR #6659: URL: https://github.com/apache/rocketmq/pull/6659#issuecomment-2101693198 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #6653] Remove duplicate code about validate topic [rocketmq]
github-actions[bot] closed pull request #6659: [ISSUE #6653] Remove duplicate code about validate topic URL: https://github.com/apache/rocketmq/pull/6659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Dledger Model。When a user consumes a delay message for an arbitrary period of time, when the broker performs a master-slave switch, will they repeatedly consume it? [rocketmq]
github-actions[bot] commented on issue #6427: URL: https://github.com/apache/rocketmq/issues/6427#issuecomment-2101693216 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 解决非标准的gzip压缩 [rocketmq-clients]
github-actions[bot] commented on PR #722: URL: https://github.com/apache/rocketmq-clients/pull/722#issuecomment-2101703199 This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" is working again!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: ad027560780c2af801e4bcb447d85bf0df62071a / bxfjb <48467309+bx...@users.noreply.github.com> [ISSUE #8049] fix tiered store delete empty topic NPE (#8050) Co-authored-by: zhaoyuhan Report URL: https://github.com/apache/rocketmq/actions/runs/9010325980 With regards, GitHub Actions via GitBox
Re: [I] [Bug] org.apache.rocketmq.client.producer.DefaultMQProducer#request invoke timeout [rocketmq]
haiyanghan closed issue #6726: [Bug] org.apache.rocketmq.client.producer.DefaultMQProducer#request invoke timeout URL: https://github.com/apache/rocketmq/issues/6726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8059] Fix some typos in DefaultLitePullConsumer and LitePullConsumer [rocketmq]
RongtongJin commented on PR #8060: URL: https://github.com/apache/rocketmq/pull/8060#issuecomment-2101791191 Hi @hanmz you need to merge the develop branch to include the latest unit test fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8079] Add unit test for MQClientAPIExtTest [rocketmq]
RongtongJin commented on PR #8080: URL: https://github.com/apache/rocketmq/pull/8080#issuecomment-2101791833 need to merge the develop branch to include the latest unit test fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #8061] Fix npe in netty remoting client [rocketmq]
RongtongJin commented on PR #8064: URL: https://github.com/apache/rocketmq/pull/8064#issuecomment-2101792396 Hi @fujian-zfj you need to merge the develop branch to include the latest unit test fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #264] fix(ds): fix building error of UT and Checkstyle [rocketmq-mqtt]
pingww merged PR #265: URL: https://github.com/apache/rocketmq-mqtt/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-mqtt) branch develop_mqtt5.0 updated (5fffacc -> 48968cd)
This is an automated email from the ASF dual-hosted git repository. pingww pushed a change to branch develop_mqtt5.0 in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git from 5fffacc Merge pull request #263 from YxAc/improve_readme_on_M2 add 0c19fe2 fix building error of UT and checkstyle new 48968cd Merge pull request #265 from YxAc/fix_build_failure The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../mqtt/ds/meta/MetaPersistManagerSample.java | 1 - .../ds/test/meta/TestMetaPersistManagerSample.java | 18 +++--- 2 files changed, 15 insertions(+), 4 deletions(-)
(rocketmq-mqtt) 01/01: Merge pull request #265 from YxAc/fix_build_failure
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop_mqtt5.0 in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git commit 48968cdb7edce86923283bdf731cf98c2e2ab03d Merge: 5fffacc 0c19fe2 Author: pingww AuthorDate: Thu May 9 10:32:41 2024 +0800 Merge pull request #265 from YxAc/fix_build_failure [ISSUE #264] fix(ds): fix building error of UT and Checkstyle .../mqtt/ds/meta/MetaPersistManagerSample.java | 1 - .../ds/test/meta/TestMetaPersistManagerSample.java | 18 +++--- 2 files changed, 15 insertions(+), 4 deletions(-)
Re: [PR] [ISSUE #266]: add connections_size metric [rocketmq-mqtt]
pingww merged PR #269: URL: https://github.com/apache/rocketmq-mqtt/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-mqtt) branch develop updated (4331ec4 -> 04971ff)
This is an automated email from the ASF dual-hosted git repository. pingww pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git from 4331ec4 Merge pull request #238 from zzjcool/feat/on-ssl-cert-change add 549d006 feat: add connections_size metric new 04971ff Merge pull request #269 from yx9o/dev-266 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../rocketmq/mqtt/cs/channel/DefaultChannelManager.java | 11 +++ .../mqtt/exporter/collector/MqttMetricsCollector.java | 4 .../rocketmq/mqtt/exporter/collector/MqttMetricsInfo.java | 4 +++- 3 files changed, 18 insertions(+), 1 deletion(-)
(rocketmq-mqtt) 01/01: Merge pull request #269 from yx9o/dev-266
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git commit 04971ffb3a259e51d9cc7709c57cf9a5281496aa Merge: 4331ec4 549d006 Author: pingww AuthorDate: Thu May 9 10:33:12 2024 +0800 Merge pull request #269 from yx9o/dev-266 [ISSUE #266]: add connections_size metric .../rocketmq/mqtt/cs/channel/DefaultChannelManager.java | 11 +++ .../mqtt/exporter/collector/MqttMetricsCollector.java | 4 .../rocketmq/mqtt/exporter/collector/MqttMetricsInfo.java | 4 +++- 3 files changed, 18 insertions(+), 1 deletion(-)
Re: [PR] [ISSUE #8058] Support for upgrading metadata in json to rocksdb [rocketmq]
lizhimins commented on code in PR #8081:
URL: https://github.com/apache/rocketmq/pull/8081#discussion_r1594894709
##
broker/src/main/java/org/apache/rocketmq/broker/RocksDBConfigManager.java:
##
@@ -62,6 +81,44 @@ public boolean load(String configFilePath,
BiConsumer biConsumer
return true;
}
+public boolean loadForbidden(String configFilePath, BiConsumer biConsumer) {
+if (!init(configFilePath)) {
+return false;
+}
+RocksIterator iterator = this.configRocksDBStorage.forbiddenIterator();
+try {
+iterator.seekToFirst();
+while (iterator.isValid()) {
+biConsumer.accept(iterator.key(), iterator.value());
+iterator.next();
+}
+} finally {
+iterator.close();
+}
+this.flushOptions = new FlushOptions();
Review Comment:
和上面重复了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] Build Failure for UT/Checkstyle on branch develop_mqtt5.0 [rocketmq-mqtt]
YxAc closed issue #264: [Bug] Build Failure for UT/Checkstyle on branch develop_mqtt5.0 URL: https://github.com/apache/rocketmq-mqtt/issues/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The lettuce log appears in rocketmq_client.log, although rocketmq does not use this package, but why lettuce logs will be output to rocketmq_client.log? lettuce package when redis topolo
leizhiyuan commented on issue #8111: URL: https://github.com/apache/rocketmq/issues/8111#issuecomment-2101850832 org.apache.rocketmq.client.log.ClientLogger set -Drocketmq.client.logUseSlf4j=true and try again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix bug: PULL_EVENT not create when PULL_SUCCESS [rocketmq-mqtt]
DongyuanPan opened a new pull request, #270: URL: https://github.com/apache/rocketmq-mqtt/pull/270 close #255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix bug: PULL_EVENT not create when PULL_SUCCESS [rocketmq-mqtt]
pingww merged PR #270: URL: https://github.com/apache/rocketmq-mqtt/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-mqtt) branch develop updated (04971ff -> 3529891)
This is an automated email from the ASF dual-hosted git repository. pingww pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git from 04971ff Merge pull request #269 from yx9o/dev-266 add beba2a0 fix bug: PULL_EVENT not create when PULL_SUCCESS add 727a476 add broker config item:MaxTransferCountOnMessageInDisk new 3529891 Merge pull request #270 from DongyuanPan/develop The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java | 10 ++ .../apache/rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-)
(rocketmq-mqtt) 01/01: Merge pull request #270 from DongyuanPan/develop
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git commit 352989167907c8ec81670064b8f89261c3e2123f Merge: 04971ff 727a476 Author: pingww AuthorDate: Thu May 9 11:16:47 2024 +0800 Merge pull request #270 from DongyuanPan/develop fix bug: PULL_EVENT not create when PULL_SUCCESS .../java/org/apache/rocketmq/mqtt/cs/config/ConnectConf.java | 10 ++ .../apache/rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-)
Re: [PR] [ISSUE #8046] Fix authentication context build for no extFields [rocketmq]
lizhimins merged PR #8102: URL: https://github.com/apache/rocketmq/pull/8102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #8046] Fix authentication context build for no extFields (#8102)
This is an automated email from the ASF dual-hosted git repository.
lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 89c1509014 [ISSUE #8046] Fix authentication context build for no
extFields (#8102)
89c1509014 is described below
commit 89c1509014b15c2ce91161356cf09a18c945a926
Author: dingshuangxi888
AuthorDate: Thu May 9 11:35:04 2024 +0800
[ISSUE #8046] Fix authentication context build for no extFields (#8102)
---
.../authentication/builder/DefaultAuthenticationContextBuilder.java | 6 +++---
.../authorization/builder/DefaultAuthorizationContextBuilder.java | 4
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git
a/auth/src/main/java/org/apache/rocketmq/auth/authentication/builder/DefaultAuthenticationContextBuilder.java
b/auth/src/main/java/org/apache/rocketmq/auth/authentication/builder/DefaultAuthenticationContextBuilder.java
index 6b178b9657..c1e970fa6e 100644
---
a/auth/src/main/java/org/apache/rocketmq/auth/authentication/builder/DefaultAuthenticationContextBuilder.java
+++
b/auth/src/main/java/org/apache/rocketmq/auth/authentication/builder/DefaultAuthenticationContextBuilder.java
@@ -98,12 +98,12 @@ public class DefaultAuthenticationContextBuilder implements
AuthenticationContex
@Override
public DefaultAuthenticationContext build(ChannelHandlerContext context,
RemotingCommand request) {
HashMap fields = request.getExtFields();
-if (MapUtils.isEmpty(fields)) {
-throw new AuthenticationException("authentication field is null.");
-}
DefaultAuthenticationContext result = new
DefaultAuthenticationContext();
result.setChannelId(context.channel().id().asLongText());
result.setRpcCode(String.valueOf(request.getCode()));
+if (MapUtils.isEmpty(fields)) {
+return result;
+}
if (!fields.containsKey(SessionCredentials.ACCESS_KEY)) {
return result;
}
diff --git
a/auth/src/main/java/org/apache/rocketmq/auth/authorization/builder/DefaultAuthorizationContextBuilder.java
b/auth/src/main/java/org/apache/rocketmq/auth/authorization/builder/DefaultAuthorizationContextBuilder.java
index daa039162b..d6d1556ca2 100644
---
a/auth/src/main/java/org/apache/rocketmq/auth/authorization/builder/DefaultAuthorizationContextBuilder.java
+++
b/auth/src/main/java/org/apache/rocketmq/auth/authorization/builder/DefaultAuthorizationContextBuilder.java
@@ -40,6 +40,7 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.collections.MapUtils;
import org.apache.commons.lang3.ArrayUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.acl.common.AclException;
@@ -160,6 +161,9 @@ public class DefaultAuthorizationContextBuilder implements
AuthorizationContextB
List result = new ArrayList<>();
try {
HashMap fields = command.getExtFields();
+if (MapUtils.isEmpty(fields)) {
+return result;
+}
Subject subject = null;
if (fields.containsKey(SessionCredentials.ACCESS_KEY)) {
subject = User.of(fields.get(SessionCredentials.ACCESS_KEY));
Re: [I] [Bug] Fix authentication context build for no extFields [rocketmq]
lizhimins closed issue #8046: [Bug] Fix authentication context build for no extFields URL: https://github.com/apache/rocketmq/issues/8046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 89c1509014b15c2ce91161356cf09a18c945a926 / dingshuangxi888 [ISSUE #8046] Fix authentication context build for no extFields (#8102) Report URL: https://github.com/apache/rocketmq/actions/runs/9011992166 With regards, GitHub Actions via GitBox
[I] springboot3.1.7 version can`t consum message [rocketmq]
kliein opened a new issue, #8112: URL: https://github.com/apache/rocketmq/issues/8112 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment windows 10 ### RocketMQ version release 5.2.0 ### JDK Version graalvm 17 ### Describe the Bug messages can be sent through the producer normally, but the consumer cannot consume, the console can see the producer information and queue, can not see the available consumer, and no error is reported at startup, when the springboot version 2.5.7 can be sent and consumed normally. ### Steps to Reproduce Create a springboo project using springboot 3.1.7 and add ` org.apache.rocketmq rocketmq-spring-boot-starter 2.2.2 ,` add a profile, create a consumer, and run the code to reproduce ### What Did You Expect to See? consumers can spend normally ### What Did You See Instead? consumers cant spend normally ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 89c1509014b15c2ce91161356cf09a18c945a926 / dingshuangxi888 [ISSUE #8046] Fix authentication context build for no extFields (#8102) Report URL: https://github.com/apache/rocketmq/actions/runs/9011992163 With regards, GitHub Actions via GitBox
[PR] [ISSUE #266]: add metrics for topic dimension read and write msg size [rocketmq-mqtt]
yx9o opened a new pull request, #271: URL: https://github.com/apache/rocketmq-mqtt/pull/271 Add metrics for topic dimension read and write msg size. https://github.com/apache/rocketmq-mqtt/assets/12792261/832fc52b-5069-40e9-aacd-a689e85a17a0";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 5.1版本的 启动Broker+Proxy 模式启动后直接占用了8080端口，导致RocketMQ Dashboard无法启动 [rocketmq]
kliein commented on issue #7185: URL: https://github.com/apache/rocketmq/issues/7185#issuecomment-2102039170 你不会给控制台换个端口？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
