[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 422f9bdadac4600eb3a74bfb75f0bfc0fe9718a4 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7772469214 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #196] enhance chart generate by helmify [rocketmq-operator]
caigy commented on code in PR #212: URL: https://github.com/apache/rocketmq-operator/pull/212#discussion_r1477204768 ## Makefile: ## @@ -40,6 +40,8 @@ IMG ?= controller:latest # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. ENVTEST_K8S_VERSION = 1.22 +OPERATOR_CAHRT_DIR ?= charts/rocketmq-operator Review Comment: pls fix the typo `CAHRT` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7803] Add try catch for lock and unlock [rocketmq]
lollipopjin merged PR #7804: URL: https://github.com/apache/rocketmq/pull/7804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7803] Add try catch for lock and unlock (#7804)
This is an automated email from the ASF dual-hosted git repository.
lollipop pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 702bbd2b83 [ISSUE #7803] Add try catch for lock and unlock (#7804)
702bbd2b83 is described below
commit 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda
Author: Zhouxiang Zhan
AuthorDate: Sun Feb 4 16:14:40 2024 +0800
[ISSUE #7803] Add try catch for lock and unlock (#7804)
* Add try catch for lock and unlock
---
.../proxy/processor/ConsumerProcessor.java | 90 +-
1 file changed, 53 insertions(+), 37 deletions(-)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/processor/ConsumerProcessor.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/processor/ConsumerProcessor.java
index 7870233576..3ff3423701 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/processor/ConsumerProcessor.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/processor/ConsumerProcessor.java
@@ -414,49 +414,59 @@ public class ConsumerProcessor extends AbstractProcessor {
public CompletableFuture> lockBatchMQ(ProxyContext ctx,
Set mqSet,
String consumerGroup, String clientId, long timeoutMillis) {
CompletableFuture> future = new
CompletableFuture<>();
-Set successSet = new CopyOnWriteArraySet<>();
-Set addressableMessageQueueSet =
buildAddressableSet(ctx, mqSet);
-Map> messageQueueSetMap =
buildAddressableMapByBrokerName(addressableMessageQueueSet);
-List> futureList = new ArrayList<>();
-messageQueueSetMap.forEach((k, v) -> {
-LockBatchRequestBody requestBody = new LockBatchRequestBody();
-requestBody.setConsumerGroup(consumerGroup);
-requestBody.setClientId(clientId);
-
requestBody.setMqSet(v.stream().map(AddressableMessageQueue::getMessageQueue).collect(Collectors.toSet()));
-CompletableFuture future0 =
serviceManager.getMessageService()
-.lockBatchMQ(ctx, v.get(0), requestBody, timeoutMillis)
-.thenAccept(successSet::addAll);
-futureList.add(FutureUtils.addExecutor(future0, this.executor));
-});
-CompletableFuture.allOf(futureList.toArray(new
CompletableFuture[0])).whenComplete((v, t) -> {
-if (t != null) {
-log.error("LockBatchMQ failed", t);
-}
-future.complete(successSet);
-});
+try {
+Set successSet = new CopyOnWriteArraySet<>();
+Set addressableMessageQueueSet =
buildAddressableSet(ctx, mqSet);
+Map> messageQueueSetMap =
buildAddressableMapByBrokerName(addressableMessageQueueSet);
+List> futureList = new ArrayList<>();
+messageQueueSetMap.forEach((k, v) -> {
+LockBatchRequestBody requestBody = new LockBatchRequestBody();
+requestBody.setConsumerGroup(consumerGroup);
+requestBody.setClientId(clientId);
+
requestBody.setMqSet(v.stream().map(AddressableMessageQueue::getMessageQueue).collect(Collectors.toSet()));
+CompletableFuture future0 =
serviceManager.getMessageService()
+.lockBatchMQ(ctx, v.get(0), requestBody, timeoutMillis)
+.thenAccept(successSet::addAll);
+futureList.add(FutureUtils.addExecutor(future0,
this.executor));
+});
+CompletableFuture.allOf(futureList.toArray(new
CompletableFuture[0])).whenComplete((v, t) -> {
+if (t != null) {
+log.error("LockBatchMQ failed, group={}", consumerGroup,
t);
+}
+future.complete(successSet);
+});
+} catch (Throwable t) {
+log.error("LockBatchMQ exception, group={}", consumerGroup, t);
+future.completeExceptionally(t);
+}
return FutureUtils.addExecutor(future, this.executor);
}
public CompletableFuture unlockBatchMQ(ProxyContext ctx,
Set mqSet,
String consumerGroup, String clientId, long timeoutMillis) {
CompletableFuture future = new CompletableFuture<>();
-Set addressableMessageQueueSet =
buildAddressableSet(ctx, mqSet);
-Map> messageQueueSetMap =
buildAddressableMapByBrokerName(addressableMessageQueueSet);
-List> futureList = new ArrayList<>();
-messageQueueSetMap.forEach((k, v) -> {
-UnlockBatchRequestBody requestBody = new UnlockBatchRequestBody();
-requestBody.setConsumerGroup(consumerGroup);
-requestBody.setClientId(clientId);
-
requestBody.setMqSet(v.stream().map(AddressableMessageQueue::getMessageQueue).collect(Collectors.toSet()));
-CompletableFuture future0 =
serviceManager.getMessageService().unlockBatchMQ(ctx, v.get(0), requestBody,
Re: [I] [Enhancement] Add try catch for lock and unlock [rocketmq]
lollipopjin closed issue #7803: [Enhancement] Add try catch for lock and unlock URL: https://github.com/apache/rocketmq/issues/7803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda / Zhouxiang Zhan [ISSUE #7803] Add try catch for lock and unlock (#7804) * Add try catch for lock and unlock Report URL: https://github.com/apache/rocketmq/actions/runs/7772709957 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" is working again!
The GitHub Actions job "PUSH-CI" on rocketmq.git has succeeded. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda / Zhouxiang Zhan [ISSUE #7803] Add try catch for lock and unlock (#7804) * Add try catch for lock and unlock Report URL: https://github.com/apache/rocketmq/actions/runs/7772709954 With regards, GitHub Actions via GitBox
Re: [I] Inconsistent serviceAccountNames [rocketmq-operator]
caigy closed issue #196: Inconsistent serviceAccountNames URL: https://github.com/apache/rocketmq-operator/issues/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda / Zhouxiang Zhan [ISSUE #7803] Add try catch for lock and unlock (#7804) * Add try catch for lock and unlock Report URL: https://github.com/apache/rocketmq/actions/runs/7772709955 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #196] enhance chart generate by helmify [rocketmq-operator]
caigy merged PR #212: URL: https://github.com/apache/rocketmq-operator/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-operator) branch master updated: [ISSUE #196] enhance chart generate by helmify (#212)
This is an automated email from the ASF dual-hosted git repository.
caigy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-operator.git
The following commit(s) were added to refs/heads/master by this push:
new 0ccad32 [ISSUE #196] enhance chart generate by helmify (#212)
0ccad32 is described below
commit 0ccad322b782617b26b5167a8ed3d750c1a8eec2
Author: yangw
AuthorDate: Sun Feb 4 16:36:11 2024 +0800
[ISSUE #196] enhance chart generate by helmify (#212)
* delete old chart
* add helmify target
* generate chart by `make manifest`
* upgrade appVersion
* remove helmify bundle
* remove redundant suffix
* fix typo
---
Makefile | 10 ++--
charts/rocketmq-operator/Chart.yaml| 3 -
charts/rocketmq-operator/templates/NOTES.txt | 4 --
charts/rocketmq-operator/templates/deployment.yaml | 56 +++
charts/rocketmq-operator/templates/operator.yaml | 65 --
.../{role.yaml => rocketmq-operator-rbac.yaml} | 36 ++--
.../rocketmq-operator/templates/role_binding.yaml | 29 --
.../templates/service_account.yaml | 19 ---
.../templates/serviceaccount.yaml | 8 +++
charts/rocketmq-operator/values.yaml | 38 ++---
10 files changed, 102 insertions(+), 166 deletions(-)
diff --git a/Makefile b/Makefile
index 8bcfc9a..00277b4 100644
--- a/Makefile
+++ b/Makefile
@@ -40,6 +40,8 @@ IMG ?= controller:latest
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be
downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.22
+OPERATOR_CHART_DIR ?= charts/rocketmq-operator
+
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is
set)
ifeq (,$(shell go env GOBIN))
GOBIN=$(shell go env GOPATH)/bin
@@ -80,12 +82,8 @@ manifests: controller-gen ## Generate WebhookConfiguration,
ClusterRole and Cust
$(CONTROLLER_GEN) rbac:roleName=rocketmq-operator
crd:generateEmbeddedObjectMeta=true webhook paths="./..." output:dir=deploy
output:crd:artifacts:config=deploy/crds
head -n 14 deploy/role_binding.yaml > deploy/role.yaml.bak
cat deploy/role.yaml >> deploy/role.yaml.bak
- rm deploy/role.yaml && mv deploy/role.yaml.bak deploy/role.yaml && \
-cp deploy/role.yaml charts/rocketmq-operator/templates/role.yaml && \
-cp deploy/operator.yaml charts/rocketmq-operator/templates/operator.yaml
&& \
-cp deploy/role_binding.yaml
charts/rocketmq-operator/templates/role_binding.yaml && \
-cp deploy/service_account.yaml
charts/rocketmq-operator/templates/service_account.yaml && \
-cp deploy/crds/* charts/rocketmq-operator/crds/
+ rm deploy/role.yaml && mv deploy/role.yaml.bak deploy/role.yaml
+ mkdir -p $(OPERATOR_CHART_DIR)/crds/ && cp deploy/crds/*
$(OPERATOR_CHART_DIR)/crds/
.PHONY: generate
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto,
and DeepCopyObject method implementations.
diff --git a/charts/rocketmq-operator/Chart.yaml
b/charts/rocketmq-operator/Chart.yaml
index 09af01c..4b82a30 100644
--- a/charts/rocketmq-operator/Chart.yaml
+++ b/charts/rocketmq-operator/Chart.yaml
@@ -1,7 +1,6 @@
apiVersion: v2
name: rocketmq-operator
description: A Helm chart for Kubernetes
-
# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into
versioned archives
@@ -11,12 +10,10 @@ description: A Helm chart for Kubernetes
# a dependency of application charts to inject those utilities and functions
into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be
deployed.
type: application
-
# This is the chart version. This version number should be incremented each
time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
-
# This is the version number of the application being deployed. This version
number should be
# incremented each time you make changes to the application. Versions are not
expected to
# follow Semantic Versioning. They should reflect the version the application
is using.
diff --git a/charts/rocketmq-operator/templates/NOTES.txt
b/charts/rocketmq-operator/templates/NOTES.txt
deleted file mode 100644
index a134945..000
--- a/charts/rocketmq-operator/templates/NOTES.txt
+++ /dev/null
@@ -1,4 +0,0 @@
-Your release is named {{ .Release.Name }}. To check the status of the release,
run:
-
- $ kubectl -n {{ .Release.Namespace }} get pods -l "name=rocketmq-operator"
-
diff --git a/charts/rocketmq-operator/templates/deployment.yaml
b/charts/rocketmq-operator/templates/deployment.yaml
new file mode 100644
index 000..c33b1c3
--- /dev/null
+++ b/charts/rocketmq-o
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda / Zhouxiang Zhan [ISSUE #7803] Add try catch for lock and unlock (#7804) * Add try catch for lock and unlock Report URL: https://github.com/apache/rocketmq/actions/runs/7772840396 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lollipopjin (triggered by lollipopjin). Head commit for run: 702bbd2b831d4fd97a5ad00f9587e79a0a3e5fda / Zhouxiang Zhan [ISSUE #7803] Add try catch for lock and unlock (#7804) * Add try catch for lock and unlock Report URL: https://github.com/apache/rocketmq/actions/runs/7772709953 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: e30e4097a8d97a3ff1581fb76af1cc2bb858daa5 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7772822038 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7815] Use createChannelAsync for async invoke rpc [rocketmq]
codecov-commenter commented on PR #7816: URL: https://github.com/apache/rocketmq/pull/7816#issuecomment-1925643755 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `66 lines` in your changes are missing coverage. Please review. > Comparison is base [(`1784213`)](https://app.codecov.io/gh/apache/rocketmq/commit/178421386f728f0320bad550e965b74a0b088d40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.31% compared to head [(`e30e409`)](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.99%. > Report is 10 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | 30.52% | [60 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7816 +/- ## = - Coverage 43.31% 42.99% -0.33% - Complexity 9886 9920 +34 = Files 1173 1190 +17 Lines 8504785969 +922 Branches 1101411072 +58 = + Hits 3683636959 +123 - Misses 436461 +795 - Partials4565 4569 +4 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7816?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: e30e4097a8d97a3ff1581fb76af1cc2bb858daa5 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7772822037 With regards, GitHub Actions via GitBox
[PR] [maven-release-plugin] prepare for next development iteration [rocketmq]
hong0220 opened a new pull request, #7817: URL: https://github.com/apache/rocketmq/pull/7817 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [maven-release-plugin] prepare for next development iteration [rocketmq]
hong0220 closed pull request #7817: [maven-release-plugin] prepare for next development iteration URL: https://github.com/apache/rocketmq/pull/7817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5931]Fix DefaultMQProducer some typo [rocketmq]
github-actions[bot] closed pull request #5932: [ISSUE #5931]Fix DefaultMQProducer some typo URL: https://github.com/apache/rocketmq/pull/5932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #5931]Fix DefaultMQProducer some typo [rocketmq]
github-actions[bot] commented on PR #5932: URL: https://github.com/apache/rocketmq/pull/5932#issuecomment-1926001169 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; [rocketmq]
github-actions[bot] commented on issue #5068: URL: https://github.com/apache/rocketmq/issues/5068#issuecomment-1926001198 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; [rocketmq]
github-actions[bot] closed issue #5068: java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; URL: https://github.com/apache/rocketmq/issues/5068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Permanent avoidance of uneven distribution of production queues after enabling "sendLatencyFaultEnable" [rocketmq]
RongtongJin closed issue #7812: [Bug] Permanent avoidance of uneven distribution of production queues after enabling "sendLatencyFaultEnable" URL: https://github.com/apache/rocketmq/issues/7812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7812] Remove reachable flag in brokers' available judgement. [rocketmq]
RongtongJin merged PR #7814: URL: https://github.com/apache/rocketmq/pull/7814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7812] Remove reachable flag in brokers' available judgement.
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new d9526e7ab2 [ISSUE #7812] Remove reachable flag in brokers' available
judgement.
d9526e7ab2 is described below
commit d9526e7ab2d7d1a01fc7456ee57dc655710e9c46
Author: Ji Juntao
AuthorDate: Mon Feb 5 08:55:26 2024 +0800
[ISSUE #7812] Remove reachable flag in brokers' available judgement.
---
.../org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java
b/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java
index d3ff7eb45a..f629fe44a8 100644
---
a/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java
+++
b/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java
@@ -238,7 +238,7 @@ public class LatencyFaultToleranceImpl implements
LatencyFaultTolerance
}
public boolean isAvailable() {
-return reachableFlag && System.currentTimeMillis() >=
startTimestamp;
+return System.currentTimeMillis() >= startTimestamp;
}
public boolean isReachable() {
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: d9526e7ab2d7d1a01fc7456ee57dc655710e9c46 / Ji Juntao [ISSUE #7812] Remove reachable flag in brokers' available judgement. Report URL: https://github.com/apache/rocketmq/actions/runs/7778081715 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: d9526e7ab2d7d1a01fc7456ee57dc655710e9c46 / Ji Juntao [ISSUE #7812] Remove reachable flag in brokers' available judgement. Report URL: https://github.com/apache/rocketmq/actions/runs/7778081713 With regards, GitHub Actions via GitBox
[I] Add support for authentication, proxy, custom headers, query parameters, and request body to HTTP Connector [rocketmq-connect]
ingdex opened a new issue, #528: URL: https://github.com/apache/rocketmq-connect/issues/528 1. The HTTP Connector should allow users to specify the HTTP request method (e.g., GET, POST, PUT, DELETE). 2. The HTTP Connector should support various authentication methods such as Basic Auth, OAuth, and API keys. 3. The HTTP Connector should allow users to customize the request header fields, query parameters, and request body. 4. The HTTP Connector should provide options to set timeout, request parallelism, and token. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #528] Add support for authentication, proxy, custom headers, query parameters, and request body to HTTP Connector [rocketmq-connect]
ingdex opened a new pull request, #529: URL: https://github.com/apache/rocketmq-connect/pull/529 ## What is the purpose of the change support authentication, proxy, custom headers, query parameters, and request body for http connector issue link: https://github.com/apache/rocketmq-connect/issues/528 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-connect/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7740] Optimize LocalFileOffsetStore [rocketmq]
redlsz commented on PR #7745: URL: https://github.com/apache/rocketmq/pull/7745#issuecomment-1926307066 > 可以再提一个develop分支的 https://github.com/apache/rocketmq/pull/7819, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d9526e7ab2d7d1a01fc7456ee57dc655710e9c46 / Ji Juntao [ISSUE #7812] Remove reachable flag in brokers' available judgement. Report URL: https://github.com/apache/rocketmq/actions/runs/7780350748 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 080c41aa072949d9a25a74d12e8af8ac435c154c / redlsz cherry-pick #7745 from 4.9.x Report URL: https://github.com/apache/rocketmq/actions/runs/7780434685 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 45a64429174f37b74d2ecf80cbd3a558215cfa25 / zhouxiang fix Report URL: https://github.com/apache/rocketmq/actions/runs/7780329342 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: d9526e7ab2d7d1a01fc7456ee57dc655710e9c46 / Ji Juntao [ISSUE #7812] Remove reachable flag in brokers' available judgement. Report URL: https://github.com/apache/rocketmq/actions/runs/7780454418 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 080c41aa072949d9a25a74d12e8af8ac435c154c / redlsz cherry-pick #7745 from 4.9.x Report URL: https://github.com/apache/rocketmq/actions/runs/7780434684 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7740] Optimize LocalFileOffsetStore [rocketmq]
codecov-commenter commented on PR #7819: URL: https://github.com/apache/rocketmq/pull/7819#issuecomment-1926331535 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `22 lines` in your changes are missing coverage. Please review. > Comparison is base [(`af1936d`)](https://app.codecov.io/gh/apache/rocketmq/commit/af1936d93ad9adab9527e19ceb5c89bb3a907e49?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.98% compared to head [(`080c41a`)](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.99%. > Report is 5 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...mq/client/consumer/store/LocalFileOffsetStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvTG9jYWxGaWxlT2Zmc2V0U3RvcmUuamF2YQ==) | 53.12% | [9 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/java/org/apache/rocketmq/common/JraftConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vSnJhZnRDb25maWcuamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@Coverage Diff @@ ## develop#7819 +/- ## == Coverage 42.98% 42.99% - Complexity 9911 9913+2 == Files 1190 1190 Lines 8593485978 +44 Branches 1107011078+8 == + Hits 3694336967 +24 - Misses 4441444426 +12 - Partials4577 4585+8 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
