[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
933aa5aa6026cba55ab69d699005d21108a85f59 / ShuangxiDing 

部分字段不要序列化

Report URL: https://github.com/apache/rocketmq/actions/runs/7651167881

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has failed.
Run started by GitHub user bazelisky (triggered by lizhanhui).

Head commit for run:
9c6d907def10d12626260b1ccb28136a1dbf5fdc / bazelisky 
<155456828+bazeli...@users.noreply.github.com>
Exclude flaky tests from test suite

Signed-off-by: bazelisky <155456828+bazeli...@users.noreply.github.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7394161026

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user bazelisky (triggered by bazelisky).

Head commit for run:
04eec3497895a1fa8a9c8fbe520406c62a05a5b0 / Zhouxiang Zhan 

Get namespace from header (#7782)

Report URL: https://github.com/apache/rocketmq/actions/runs/7652753598

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PR-CI" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "PR-CI" on rocketmq.git has failed.
Run started by GitHub user bazelisky (triggered by lizhanhui).

Head commit for run:
9c6d907def10d12626260b1ccb28136a1dbf5fdc / bazelisky 
<155456828+bazeli...@users.noreply.github.com>
Exclude flaky tests from test suite

Signed-off-by: bazelisky <155456828+bazeli...@users.noreply.github.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7394161023

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7715] Update Bazel toolchain to make the CI work [rocketmq]

2024-01-25 Thread via GitHub


lizhanhui commented on code in PR #7714:
URL: https://github.com/apache/rocketmq/pull/7714#discussion_r1466117225


##
remoting/BUILD.bazel:
##
@@ -73,7 +73,7 @@ java_library(
 GenTestRules(
 name = "GeneratedTestRules",
 test_files = glob(["src/test/java/**/*Test.java"]),
-deps = [
+deps = [

Review Comment:
   应该有问题



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user bazelisky (triggered by lizhanhui).

Head commit for run:
9c6d907def10d12626260b1ccb28136a1dbf5fdc / bazelisky 
<155456828+bazeli...@users.noreply.github.com>
Exclude flaky tests from test suite

Signed-off-by: bazelisky <155456828+bazeli...@users.noreply.github.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7394161022

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
succeeded.
Run started by GitHub user bazelisky (triggered by lizhanhui).

Head commit for run:
9c6d907def10d12626260b1ccb28136a1dbf5fdc / bazelisky 
<155456828+bazeli...@users.noreply.github.com>
Exclude flaky tests from test suite

Signed-off-by: bazelisky <155456828+bazeli...@users.noreply.github.com>

Report URL: https://github.com/apache/rocketmq/actions/runs/7394161019

With regards,
GitHub Actions via GitBox



[I] Release blocker of RocketMQ-Spring 2.3.0 [rocketmq-spring]

2024-01-25 Thread via GitHub


RongtongJin opened a new issue, #615:
URL: https://github.com/apache/rocketmq-spring/issues/615

   We are preparing to release rocketmq-spring 2.3.0, and the following tasks 
need to be completed:
   
   - [ ] Fixing security issues in related dependencies
   
   - [ ] Support for rocketmq-v5-client, which requires more detailed testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Java release 5.0.6 [rocketmq-clients]

2024-01-25 Thread via GitHub


francisoliverlee commented on code in PR #674:
URL: https://github.com/apache/rocketmq-clients/pull/674#discussion_r1466265376


##
java/client-apis/pom.xml:
##
@@ -18,7 +18,7 @@
 
 rocketmq-client-java-parent
 org.apache.rocketmq
-5.0.6-SNAPSHOT
+5.0.7-SNAPSHOT

Review Comment:
   it changed to 5.0.7-SNAPSHOT by maven release:prepare, and it is next version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
3a7c3f28fc6641cd0aacbb19248bf1f3b2cb5bed / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7654201118

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PR-CI" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "PR-CI" on rocketmq.git has succeeded.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
3a7c3f28fc6641cd0aacbb19248bf1f3b2cb5bed / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7654201129

With regards,
GitHub Actions via GitBox



[PR] Remove the redundant code [rocketmq]

2024-01-25 Thread via GitHub


wyyl1 opened a new pull request, #7784:
URL: https://github.com/apache/rocketmq/pull/7784

   ### Brief Description
   
   Remove the redundant code because Math.abs does not return negative numbers
   
   ### How Did You Test This Change?
   
   ```java
   @Test
   public void testResultOfResetIsGreaterThanOrEqualToZero() {
   ThreadLocalIndex localIndex = new ThreadLocalIndex();
   localIndex.reset();
   assertThat(localIndex.incrementAndGet() > 0).isTrue();
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
04eec3497895a1fa8a9c8fbe520406c62a05a5b0 / Zhouxiang Zhan 

Get namespace from header (#7782)

Report URL: https://github.com/apache/rocketmq/actions/runs/7654236083

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has succeeded.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
3a7c3f28fc6641cd0aacbb19248bf1f3b2cb5bed / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7654201109

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
3a7c3f28fc6641cd0aacbb19248bf1f3b2cb5bed / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7654201106

With regards,
GitHub Actions via GitBox



[I] [Enhancement] Remove the redundant code [rocketmq]

2024-01-25 Thread via GitHub


wyyl1 opened a new issue, #7785:
URL: https://github.com/apache/rocketmq/issues/7785

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   Remove the redundant code because Math.abs does not return negative numbers
   
   ### Motivation
   
   Make the code clean
   
   ### Describe the Solution You'd Like
   
   ## Remove the redundant code
   
   ### source code
   
   ```java
   public void reset() {
   int index = Math.abs(random.nextInt(Integer.MAX_VALUE));
   if (index < 0) {
   index = 0;
   }
   this.threadLocalIndex.set(index);
   }
   ```
   
   ### redundant code
   
   ```java
   if (index < 0) {
   index = 0;
   }
   ```
   
   ### Describe Alternatives You've Considered
   
   none
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] (golang) give a random index for NewSubscriptionLoadBalancer [rocketmq-clients]

2024-01-25 Thread via GitHub


github-actions[bot] commented on PR #657:
URL: https://github.com/apache/rocketmq-clients/pull/657#issuecomment-1911208269

   This PR is stale because it has been open for 30 days with no activity. It 
will be closed in 3 days if no further activity occurs. If you wish not to mark 
it as stale, please leave a comment in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] Use SimpleConsumer there will always be some messages that cannot be pulled [rocketmq-clients]

2024-01-25 Thread via GitHub


github-actions[bot] commented on issue #655:
URL: 
https://github.com/apache/rocketmq-clients/issues/655#issuecomment-1911208301

   This issue is stale because it has been open for 30 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] feat: change handleMessage to public [rocketmq-spring]

2024-01-25 Thread via GitHub


leizhiyuan opened a new pull request, #617:
URL: https://github.com/apache/rocketmq-spring/pull/617

   ## What is the purpose of the change
   
   fix #616 
   
   ## Brief changelog
   
   change handleMessage to public, so user can fetch some header info uniformly
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [ ] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. 
   - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq-spring): Workflow run "Java CI with Maven" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Java CI with Maven" on rocketmq-spring.git has 
succeeded.
Run started by GitHub user leizhiyuan (triggered by leizhiyuan).

Head commit for run:
7e9781af268e28bd50ff9ebcdd6808e33f4ba06e / leizhiyuan 
feat: change handleMessage to public, so user can fetch some header info 
uniformly

Report URL: https://github.com/apache/rocketmq-spring/actions/runs/7662315916

With regards,
GitHub Actions via GitBox



[GH] (rocketmq-spring): Workflow run "Coverage" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq-spring.git has succeeded.
Run started by GitHub user leizhiyuan (triggered by leizhiyuan).

Head commit for run:
7e9781af268e28bd50ff9ebcdd6808e33f4ba06e / leizhiyuan 
feat: change handleMessage to public, so user can fetch some header info 
uniformly

Report URL: https://github.com/apache/rocketmq-spring/actions/runs/7662315917

With regards,
GitHub Actions via GitBox



Re: [I] 使用starter的时候需要自定义全局拦截器在 listener onMessage 之前处理 MessageExt [rocketmq-spring]

2024-01-25 Thread via GitHub


leizhiyuan commented on issue #583:
URL: 
https://github.com/apache/rocketmq-spring/issues/583#issuecomment-1911230622

   ref https://github.com/apache/rocketmq-spring/issues/583
   
   只要这个方法改成public,就可以通过切面DefaultRocketMQListenerContainer 来做统一的处理了。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
4e7a1856a7993459d52ba2cbafd7e549e8e54320 / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7662955033

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
04eec3497895a1fa8a9c8fbe520406c62a05a5b0 / Zhouxiang Zhan 

Get namespace from header (#7782)

Report URL: https://github.com/apache/rocketmq/actions/runs/7662975992

With regards,
GitHub Actions via GitBox



Re: [I] Release blocker of RocketMQ-Spring 2.3.0 [rocketmq-spring]

2024-01-25 Thread via GitHub


leizhiyuan commented on issue #615:
URL: 
https://github.com/apache/rocketmq-spring/issues/615#issuecomment-1911315220

   Could this issue and PR be supported in the 2.3.0 version?
   
   https://github.com/apache/rocketmq-spring/pull/617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888).

Head commit for run:
4e7a1856a7993459d52ba2cbafd7e549e8e54320 / ShuangxiDing 

fix test

Report URL: https://github.com/apache/rocketmq/actions/runs/7662955026

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7772] Ensuring broker protection capabilities when POP does not return ACK [rocketmq]

2024-01-25 Thread via GitHub


RongtongJin merged PR #7773:
URL: https://github.com/apache/rocketmq/pull/7773


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Enhancement] Ensuring broker protection capabilities when POP does not return ACK [rocketmq]

2024-01-25 Thread via GitHub


RongtongJin closed issue #7772: [Enhancement] Ensuring broker protection 
capabilities when POP does not return ACK
URL: https://github.com/apache/rocketmq/issues/7772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7772] Ensuring broker protection capabilities when POP does not return ACK (#7773)

2024-01-25 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 3d357bb3ed [ISSUE #7772] Ensuring broker protection capabilities when 
POP does not return ACK (#7773)
3d357bb3ed is described below

commit 3d357bb3ed4dcee38cdde9b1525b15226820321a
Author: Ji Juntao 
AuthorDate: Fri Jan 26 14:34:53 2024 +0800

[ISSUE #7772] Ensuring broker protection capabilities when POP does not 
return ACK (#7773)

* add stop pop situation.

* refactor the imports

* modify the threadhold into threshold.

* checkstyle
---
 .../broker/processor/PopMessageProcessor.java | 12 
 .../java/org/apache/rocketmq/common/BrokerConfig.java | 19 +++
 2 files changed, 31 insertions(+)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
index 02e266a786..105e11643f 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java
@@ -519,6 +519,13 @@ public class PopMessageProcessor implements 
NettyRequestProcessor {
 return future;
 }
 
+if (isPopShouldStop(topic, requestHeader.getConsumerGroup(), queueId)) 
{
+POP_LOGGER.warn("Too much msgs unacked, then stop poping. 
topic={}, group={}, queueId={}", topic, requestHeader.getConsumerGroup(), 
queueId);
+restNum = 
this.brokerController.getMessageStore().getMaxOffsetInQueue(topic, queueId) - 
offset + restNum;
+future.complete(restNum);
+return future;
+}
+
 try {
 future.whenComplete((result, throwable) -> 
queueLockManager.unLock(lockKey));
 offset = getPopOffset(topic, requestHeader.getConsumerGroup(), 
queueId, requestHeader.getInitMode(),
@@ -667,6 +674,11 @@ public class PopMessageProcessor implements 
NettyRequestProcessor {
 });
 }
 
+private boolean isPopShouldStop(String topic, String group, int queueId) {
+return 
brokerController.getBrokerConfig().isEnablePopMessageThreshold() &&
+
brokerController.getPopInflightMessageCounter().getGroupPopInFlightMessageNum(topic,
 group, queueId) > 
brokerController.getBrokerConfig().getPopInflightMessageThreshold();
+}
+
 private long getPopOffset(String topic, String group, int queueId, int 
initMode, boolean init, String lockKey,
 boolean checkResetOffset) {
 
diff --git a/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java 
b/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
index 0a2c528f86..0a1bfa5d67 100644
--- a/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
+++ b/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java
@@ -407,6 +407,9 @@ public class BrokerConfig extends BrokerIdentity {
  */
 private boolean enableSplitRegistration = false;
 
+private long popInflightMessageThreshold = 1;
+private boolean enablePopMessageThreshold = false;
+
 private int splitRegistrationSize = 800;
 
 /**
@@ -1799,4 +1802,20 @@ public class BrokerConfig extends BrokerIdentity {
 public void setTransactionMetricFlushInterval(long 
transactionMetricFlushInterval) {
 this.transactionMetricFlushInterval = transactionMetricFlushInterval;
 }
+
+public long getPopInflightMessageThreshold() {
+return popInflightMessageThreshold;
+}
+
+public void setPopInflightMessageThreshold(long 
popInflightMessageThreshold) {
+this.popInflightMessageThreshold = popInflightMessageThreshold;
+}
+
+public boolean isEnablePopMessageThreshold() {
+return enablePopMessageThreshold;
+}
+
+public void setEnablePopMessageThreshold(boolean 
enablePopMessageThreshold) {
+this.enablePopMessageThreshold = enablePopMessageThreshold;
+}
 }



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
3d357bb3ed4dcee38cdde9b1525b15226820321a / Ji Juntao 

[ISSUE #7772] Ensuring broker protection capabilities when POP does not return 
ACK (#7773)

* add stop pop situation.

* refactor the imports

* modify the threadhold into threshold.

* checkstyle

Report URL: https://github.com/apache/rocketmq/actions/runs/7664804917

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-01-25 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
3d357bb3ed4dcee38cdde9b1525b15226820321a / Ji Juntao 

[ISSUE #7772] Ensuring broker protection capabilities when POP does not return 
ACK (#7773)

* add stop pop situation.

* refactor the imports

* modify the threadhold into threshold.

* checkstyle

Report URL: https://github.com/apache/rocketmq/actions/runs/7664804919

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-01-25 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
3d357bb3ed4dcee38cdde9b1525b15226820321a / Ji Juntao 

[ISSUE #7772] Ensuring broker protection capabilities when POP does not return 
ACK (#7773)

* add stop pop situation.

* refactor the imports

* modify the threadhold into threshold.

* checkstyle

Report URL: https://github.com/apache/rocketmq/actions/runs/7664804921

With regards,
GitHub Actions via GitBox



Re: [PR] feat: change handleMessage to public [rocketmq-spring]

2024-01-25 Thread via GitHub


lizhanhui commented on PR #617:
URL: https://github.com/apache/rocketmq-spring/pull/617#issuecomment-1911609997

   It makes sense and helps improve extensibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] feat: change handleMessage to public [rocketmq-spring]

2024-01-25 Thread via GitHub


lizhanhui merged PR #617:
URL: https://github.com/apache/rocketmq-spring/pull/617


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] will handleMessage be public,so users can do some intecept before consumeMessage [rocketmq-spring]

2024-01-25 Thread via GitHub


lizhanhui closed issue #616: will handleMessage be public,so users can do some 
intecept before consumeMessage
URL: https://github.com/apache/rocketmq-spring/issues/616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-spring) branch master updated (b5f52f7 -> 9ea8f71)

2024-01-25 Thread lizhanhui
This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-spring.git


from b5f52f7  [ISSUE #612] Support Springboot 3.X (#611)
 add 7e9781a  feat: change handleMessage to public, so user can fetch some 
header info uniformly
 new 9ea8f71  Merge pull request #617 from leizhiyuan/issue/616

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../rocketmq/spring/support/DefaultRocketMQListenerContainer.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



(rocketmq-spring) 01/01: Merge pull request #617 from leizhiyuan/issue/616

2024-01-25 Thread lizhanhui
This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-spring.git

commit 9ea8f71f5c6b4bd187820a6dc50f03ace49431aa
Merge: b5f52f7 7e9781a
Author: Zhanhui Li 
AuthorDate: Fri Jan 26 15:36:18 2024 +0800

Merge pull request #617 from leizhiyuan/issue/616

feat: change handleMessage to public

 .../rocketmq/spring/support/DefaultRocketMQListenerContainer.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)