[PR] [ISSUE #660] Add namespace in metadata [rocketmq-clients]
drpmma opened a new pull request, #671: URL: https://github.com/apache/rocketmq-clients/pull/671 ### Which Issue(s) This PR Fixes Add namespace in metadata Fixes #660 ### Brief Description Add namespace in metadata ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #660] Add namespace in metadata [rocketmq-clients]
codecov-commenter commented on PR #671: URL: https://github.com/apache/rocketmq-clients/pull/671#issuecomment-1900073846 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`0aaf9f9`)](https://app.codecov.io/gh/apache/rocketmq-clients/commit/0aaf9f9763d4353f09f1b04f297bf7e0bc24ad90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 55.89% compared to head [(`11c7e5e`)](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 47.12%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #671 +/- ## - Coverage 55.89% 47.12% -8.78% Complexity 668 668 Files 259 207 -52 Lines 1562612156-3470 Branches 3865 3513 -352 - Hits 8734 5728-3006 + Misses 6641 6177 -464 Partials251 251 ``` | [Flag](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.95% <100.00%> (+<0.01%)` | :arrow_up: | | [nodejs](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq-clients/pull/671?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #660] Add namespace in metadata [rocketmq-clients]
drpmma merged PR #671: URL: https://github.com/apache/rocketmq-clients/pull/671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq-clients) branch master updated: [ISSUE #660] Add namespace in metadata (#671)
This is an automated email from the ASF dual-hosted git repository.
zhouxzhan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new 90044056 [ISSUE #660] Add namespace in metadata (#671)
90044056 is described below
commit 90044056cee6eb009b70fb524077728d745057c7
Author: Zhouxiang Zhan
AuthorDate: Fri Jan 19 17:53:18 2024 +0800
[ISSUE #660] Add namespace in metadata (#671)
---
.../src/main/java/org/apache/rocketmq/client/java/rpc/Signature.java| 2 ++
1 file changed, 2 insertions(+)
diff --git
a/java/client/src/main/java/org/apache/rocketmq/client/java/rpc/Signature.java
b/java/client/src/main/java/org/apache/rocketmq/client/java/rpc/Signature.java
index c1db9e36..781f1977 100644
---
a/java/client/src/main/java/org/apache/rocketmq/client/java/rpc/Signature.java
+++
b/java/client/src/main/java/org/apache/rocketmq/client/java/rpc/Signature.java
@@ -43,6 +43,7 @@ public class Signature {
public static final String LANGUAGE_KEY = "x-mq-language";
public static final String CLIENT_VERSION_KEY = "x-mq-client-version";
public static final String PROTOCOL_VERSION = "x-mq-protocol";
+public static final String NAMESPACE_KEY = "x-mq-namespace";
public static final String ALGORITHM = "MQv2-HMAC-SHA1";
public static final String CREDENTIAL = "Credential";
@@ -69,6 +70,7 @@ public class Signature {
metadata.put(Metadata.Key.of(REQUEST_ID_KEY,
Metadata.ASCII_STRING_MARSHALLER), requestId);
metadata.put(Metadata.Key.of(CLIENT_ID_KEY,
Metadata.ASCII_STRING_MARSHALLER), clientId.toString());
+metadata.put(Metadata.Key.of(NAMESPACE_KEY,
Metadata.ASCII_STRING_MARSHALLER), config.getNamespace());
final Optional
optionalSessionCredentialsProvider =
config.getCredentialsProvider();
[I] [Enhancement] Integration test testEstimateLag can not pass [rocketmq]
RongtongJin opened a new issue, #7765: URL: https://github.com/apache/rocketmq/issues/7765 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Integration test testEstimateLag can not pass ### Motivation Integration test testEstimateLag can not pass ### Describe the Solution You'd Like Fix the test or related code ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Integration test testEstimateLag can not pass [rocketmq]
luvgupta014 commented on issue #7765: URL: https://github.com/apache/rocketmq/issues/7765#issuecomment-1901739829 can I fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
