Re: [I] 异常关闭导致启动异常 [rocketmq]

2024-01-10 Thread via GitHub


leizhiyuan commented on issue #7729:
URL: https://github.com/apache/rocketmq/issues/7729#issuecomment-1884404608

   再出现的时候,可以吧对应的启动信息发一下。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #7540] Fix query offset of compaction topic [rocketmq]

2024-01-10 Thread via GitHub


leizhiyuan commented on PR #7541:
URL: https://github.com/apache/rocketmq/pull/7541#issuecomment-1884432382

   any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
9d60afe6e1a13cfa6a2ed80b42b9a3774b564cce / zhouxiang 

fix

Report URL: https://github.com/apache/rocketmq/actions/runs/7472505469

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
3f99b1e96bedb0dc6854c92b2f753cdf9fa68197 / Zhouxiang Zhan 

[ISSUE #7707] Refector Context with link node implementation (#7708)

* Refector Context with link node implement

Report URL: https://github.com/apache/rocketmq/actions/runs/7472544101

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
9d60afe6e1a13cfa6a2ed80b42b9a3774b564cce / zhouxiang 

fix

Report URL: https://github.com/apache/rocketmq/actions/runs/7472505447

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #95]fix:flink source can not consume new queue's messages when topic queue expansion [rocketmq-flink]

2024-01-10 Thread via GitHub


SteNicholas merged PR #96:
URL: https://github.com/apache/rocketmq-flink/pull/96


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] 【Bug】Source cannot consume new queues' messages when topic queue expanded [rocketmq-flink]

2024-01-10 Thread via GitHub


SteNicholas closed issue #95: 【Bug】Source cannot consume new queues' messages 
when topic queue expanded
URL: https://github.com/apache/rocketmq-flink/issues/95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-flink) branch main updated: [ISSUE #95] Fix source can not consume new queue's messages when topic queue expansion (#96)

2024-01-10 Thread nicholasjiang
This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-flink.git


The following commit(s) were added to refs/heads/main by this push:
 new b686501  [ISSUE #95] Fix source can not consume new queue's messages 
when topic queue expansion (#96)
b686501 is described below

commit b6865013b7a54883727a2b4cd712087d6e8a6d4d
Author: Humkum <1109939...@qq.com>
AuthorDate: Wed Jan 10 17:29:24 2024 +0800

[ISSUE #95] Fix source can not consume new queue's messages when topic 
queue expansion (#96)
---
 .../connector/rocketmq/legacy/RocketMQSourceFunction.java  | 14 +-
 .../legacy/sourceFunction/RocketMQSourceFunctionTest.java  | 14 +-
 2 files changed, 26 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/apache/flink/connector/rocketmq/legacy/RocketMQSourceFunction.java
 
b/src/main/java/org/apache/flink/connector/rocketmq/legacy/RocketMQSourceFunction.java
index e445643..bedf97f 100644
--- 
a/src/main/java/org/apache/flink/connector/rocketmq/legacy/RocketMQSourceFunction.java
+++ 
b/src/main/java/org/apache/flink/connector/rocketmq/legacy/RocketMQSourceFunction.java
@@ -62,6 +62,7 @@ import org.slf4j.LoggerFactory;
 
 import java.lang.management.ManagementFactory;
 import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -536,7 +537,7 @@ public class RocketMQSourceFunction extends 
RichParallelSourceFunction
 }
 }
 
-public void initOffsetTableFromRestoredOffsets(List 
messageQueues) {
+public void initOffsetTableFromRestoredOffsets(List 
messageQueues) throws MQClientException {
 Preconditions.checkNotNull(restoredOffsets, "restoredOffsets can't be 
null");
 restoredOffsets.forEach(
 (mq, offset) -> {
@@ -544,6 +545,17 @@ public class RocketMQSourceFunction extends 
RichParallelSourceFunction
 offsetTable.put(mq, offset);
 }
 });
+
+List extMessageQueue = new ArrayList<>();
+for (MessageQueue messageQueue : messageQueues) {
+if (!offsetTable.containsKey(messageQueue)) {
+extMessageQueue.add(messageQueue);
+}
+}
+if (extMessageQueue.size() != 0) {
+log.info("no restoredOffsets for {}, so init offset for these 
queues", extMessageQueue);
+initOffsets(extMessageQueue);
+}
 log.info("init offset table [{}] from restoredOffsets successful.", 
offsetTable);
 }
 
diff --git 
a/src/test/java/org/apache/flink/connector/rocketmq/legacy/sourceFunction/RocketMQSourceFunctionTest.java
 
b/src/test/java/org/apache/flink/connector/rocketmq/legacy/sourceFunction/RocketMQSourceFunctionTest.java
index cd514cd..08371b3 100644
--- 
a/src/test/java/org/apache/flink/connector/rocketmq/legacy/sourceFunction/RocketMQSourceFunctionTest.java
+++ 
b/src/test/java/org/apache/flink/connector/rocketmq/legacy/sourceFunction/RocketMQSourceFunctionTest.java
@@ -25,12 +25,16 @@ import 
org.apache.flink.connector.rocketmq.legacy.common.config.StartupMode;
 import 
org.apache.flink.connector.rocketmq.legacy.common.serialization.SimpleStringDeserializationSchema;
 import org.apache.flink.connector.rocketmq.legacy.common.util.TestUtils;
 
+import org.apache.rocketmq.client.consumer.DefaultLitePullConsumer;
+import org.apache.rocketmq.client.consumer.DefaultMQPullConsumer;
 import org.apache.rocketmq.common.message.MessageQueue;
 import org.junit.Assert;
 import org.junit.Test;
+import org.mockito.Mockito;
 
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 import java.util.concurrent.ConcurrentHashMap;
@@ -69,6 +73,8 @@ public class RocketMQSourceFunctionTest {
 
 @Test
 public void testRestartFromCheckpoint() throws Exception {
+DefaultLitePullConsumer consumer = 
Mockito.mock(DefaultLitePullConsumer.class);
+Mockito.when(consumer.committed(Mockito.any())).thenReturn(40L);
 Properties properties = new Properties();
 properties.setProperty(RocketMQConfig.CONSUMER_GROUP, 
"${ConsumerGroup}");
 properties.setProperty(RocketMQConfig.CONSUMER_TOPIC, 
"${SourceTopic}");
@@ -82,13 +88,19 @@ public class RocketMQSourceFunctionTest {
 map.put(new MessageQueue("tpc", "broker-0", 1), 21L);
 map.put(new MessageQueue("tpc", "broker-1", 0), 30L);
 map.put(new MessageQueue("tpc", "broker-1", 1), 31L);
+List allocateMessageQueues = new 
ArrayList<>(map.keySet());
+MessageQueue newMessageQueue = new MessageQueue("tpc", "broker-2", 0);
+allocateMessageQueues.add(newMessageQueue);
+TestUtils.setFieldValue(source, "messageQueues", 
allocateMessageQueues);
+TestUtils.setFieldValue(source, "con

Re: [PR] [ISSUE #105] Fix sink retryTimes does not work [rocketmq-flink]

2024-01-10 Thread via GitHub


SteNicholas merged PR #106:
URL: https://github.com/apache/rocketmq-flink/pull/106


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] 【Bug】retryTimes didn't work [rocketmq-flink]

2024-01-10 Thread via GitHub


SteNicholas closed issue #105: 【Bug】retryTimes didn't work
URL: https://github.com/apache/rocketmq-flink/issues/105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] err=create grpc conn failed, err=context deadline exceeded [rocketmq-clients]

2024-01-10 Thread via GitHub


mirror6Y commented on issue #492:
URL: 
https://github.com/apache/rocketmq-clients/issues/492#issuecomment-1884486349

   get . thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-flink) branch main updated: [ISSUE #105] Fix sink retryTimes does not work (#106)

2024-01-10 Thread nicholasjiang
This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-flink.git


The following commit(s) were added to refs/heads/main by this push:
 new 0a1a033  [ISSUE #105] Fix sink retryTimes does not work (#106)
0a1a033 is described below

commit 0a1a03367ca422f3f4d5011b368e8e0ab0f91db8
Author: Humkum <1109939...@qq.com>
AuthorDate: Wed Jan 10 17:31:20 2024 +0800

[ISSUE #105] Fix sink retryTimes does not work (#106)
---
 .../rocketmq/sink/table/RocketMQDynamicTableSink.java |  1 +
 .../rocketmq/sink/table/RocketMQDynamicTableSinkFactory.java  | 11 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git 
a/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSink.java
 
b/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSink.java
index 73e8af7..98a15e6 100644
--- 
a/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSink.java
+++ 
b/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSink.java
@@ -239,6 +239,7 @@ public class RocketMQDynamicTableSink implements 
DynamicTableSink, SupportsWriti
 Properties producerProps = new Properties();
 producerProps.setProperty(RocketMQConfig.PRODUCER_GROUP, 
producerGroup);
 producerProps.setProperty(RocketMQConfig.NAME_SERVER_ADDR, 
nameServerAddress);
+producerProps.setProperty(RocketMQConfig.PRODUCER_RETRY_TIMES, 
String.valueOf(retryTimes));
 if (accessKey != null && secretKey != null) {
 producerProps.setProperty(RocketMQConfig.ACCESS_KEY, accessKey);
 producerProps.setProperty(RocketMQConfig.SECRET_KEY, secretKey);
diff --git 
a/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSinkFactory.java
 
b/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSinkFactory.java
index 03a89b1..9c1ca11 100644
--- 
a/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSinkFactory.java
+++ 
b/src/main/java/org/apache/flink/connector/rocketmq/sink/table/RocketMQDynamicTableSinkFactory.java
@@ -64,6 +64,8 @@ public class RocketMQDynamicTableSinkFactory implements 
DynamicTableSinkFactory
 Set> requiredOptions = new HashSet<>();
 requiredOptions.add(TOPIC);
 requiredOptions.add(PRODUCER_GROUP);
+requiredOptions.add(ENDPOINTS);
+
 // requiredOptions.add(PERSIST_OFFSET_INTERVAL);
 return requiredOptions;
 }
@@ -76,6 +78,13 @@ public class RocketMQDynamicTableSinkFactory implements 
DynamicTableSinkFactory
 optionalOptions.add(OPTIONAL_FIELD_DELIMITER);
 optionalOptions.add(OPTIONAL_ACCESS_KEY);
 optionalOptions.add(OPTIONAL_SECRET_KEY);
+optionalOptions.add(OPTIONAL_WRITE_DYNAMIC_TAG_COLUMN);
+optionalOptions.add(OPTIONAL_WRITE_RETRY_TIMES);
+optionalOptions.add(OPTIONAL_WRITE_SLEEP_TIME_MS);
+optionalOptions.add(OPTIONAL_WRITE_IS_DYNAMIC_TAG);
+optionalOptions.add(OPTIONAL_WRITE_DYNAMIC_TAG_COLUMN_WRITE_INCLUDED);
+optionalOptions.add(OPTIONAL_WRITE_KEYS_TO_BODY);
+optionalOptions.add(OPTIONAL_WRITE_KEY_COLUMNS);
 return optionalOptions;
 }
 
@@ -122,8 +131,8 @@ public class RocketMQDynamicTableSinkFactory implements 
DynamicTableSinkFactory
 dynamicColumn,
 fieldDelimiter,
 encoding,
-sleepTimeMs,
 retryTimes,
+sleepTimeMs,
 isDynamicTag,
 isDynamicTagIncluded,
 writeKeysToBody,



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
9d60afe6e1a13cfa6a2ed80b42b9a3774b564cce / zhouxiang 

fix

Report URL: https://github.com/apache/rocketmq/actions/runs/7472505442

With regards,
GitHub Actions via GitBox



[I] 磁盘空间充足却频繁告警 [rocketmq]

2024-01-10 Thread via GitHub


1925747950 opened a new issue, #7738:
URL: https://github.com/apache/rocketmq/issues/7738

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   $ sudo cat /etc/os-release 
   NAME="Anolis OS"
   VERSION="8.8"
   ID="anolis"
   ID_LIKE="rhel fedora centos"
   VERSION_ID="8.8"
   PLATFORM_ID="platform:an8"
   PRETTY_NAME="Anolis OS 8.8"
   ANSI_COLOR="0;31"
   HOME_URL="https://openanolis.cn/";
   
   ### RocketMQ version
   
   rocketmq-all-5.1.3-bin-release
   
   ### JDK Version
   
   $ java -version
   java version "1.8.0_202"
   Java(TM) SE Runtime Environment (build 1.8.0_202-b08)
   Java HotSpot(TM) 64-Bit Server VM (build 25.202-b08, mixed mode)
   
   ### Describe the Bug
   
   
目前mq生产业务3台虚机部署的三主三从集群,所使用的磁盘data总容量为500G,总会在几天内磁盘使用率从4%上升到100%触发告警,达到100%后立即恢复正常使用率4%,三台虚机仅部署rocketmq,且均出现此现象,同一局域网内其他虚机一切正常,且都是使用同一模板创建虚机,无法定位此现象原因,,,特来寻求帮助,有人遇到过这个现象吗?
   
![mq](https://github.com/apache/rocketmq/assets/41810884/43b66ad1-ef6b-4ec7-a2f8-1d2d00062616)
   
![mq01](https://github.com/apache/rocketmq/assets/41810884/0ad26ff3-ffdd-415b-a48a-a5a16d23cc56)
   
   ### Steps to Reproduce
   
   生产环境正式启用后出现
   
   ### What Did You Expect to See?
   
   希望能得到解决办法
   
   ### What Did You See Instead?
   
   emmm
   
   ### Additional Context
   
   nil


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Insufficient disk space but frequent alarms [rocketmq]

2024-01-10 Thread via GitHub


RongtongJin commented on issue #7738:
URL: https://github.com/apache/rocketmq/issues/7738#issuecomment-1884612263

   出现问题的时候看看哪个文件占用高


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user redlsz (triggered by redlsz).

Head commit for run:
87cb899c628c61bc1d28a7c6c734a6d2d330a326 / redlsz 
Fix revive incorrect message when the original message is not alive

Report URL: https://github.com/apache/rocketmq/actions/runs/7473857605

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
cc375fd51855ec86400ccdd9a94314ed0e714a31 / zhouxiang 

fix unit test

Report URL: https://github.com/apache/rocketmq/actions/runs/7473917807

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #660] Add namespace in java client [rocketmq-clients]

2024-01-10 Thread via GitHub


drpmma merged PR #661:
URL: https://github.com/apache/rocketmq-clients/pull/661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Enhancement] Add namespace in java client [rocketmq-clients]

2024-01-10 Thread via GitHub


drpmma closed issue #660: [Enhancement] Add namespace in java client
URL: https://github.com/apache/rocketmq-clients/issues/660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-clients) branch master updated: [ISSUE #660] Add namespace in java client (#661)

2024-01-10 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git


The following commit(s) were added to refs/heads/master by this push:
 new 0aaf9f97 [ISSUE #660] Add namespace in java client (#661)
0aaf9f97 is described below

commit 0aaf9f9763d4353f09f1b04f297bf7e0bc24ad90
Author: Zhouxiang Zhan 
AuthorDate: Wed Jan 10 19:01:24 2024 +0800

[ISSUE #660] Add namespace in java client (#661)

* Add namespace for java client

* Add checkNotNull
---
 .../rocketmq/client/apis/ClientConfiguration.java  |  8 +-
 .../client/apis/ClientConfigurationBuilder.java| 13 -
 .../rocketmq/client/java/impl/ClientImpl.java  |  5 +++-
 .../apache/rocketmq/client/java/impl/Settings.java | 11 +---
 .../client/java/impl/consumer/ConsumerImpl.java| 14 --
 .../java/impl/consumer/PushConsumerImpl.java   | 16 +++
 .../impl/consumer/PushSubscriptionSettings.java|  9 --
 .../java/impl/consumer/SimpleConsumerImpl.java |  6 ++--
 .../impl/consumer/SimpleSubscriptionSettings.java  |  8 --
 .../client/java/impl/producer/ProducerImpl.java| 12 +---
 .../java/impl/producer/PublishingSettings.java | 15 ++
 .../client/java/message/PublishingMessageImpl.java |  4 +--
 .../consumer/PushSubscriptionSettingsTest.java | 30 ++--
 .../consumer/SimpleSubscriptionSettingsTest.java   | 32 +++---
 .../apache/rocketmq/client/java/tool/TestBase.java | 13 +++--
 15 files changed, 140 insertions(+), 56 deletions(-)

diff --git 
a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfiguration.java
 
b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfiguration.java
index 27148103..042c352f 100644
--- 
a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfiguration.java
+++ 
b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfiguration.java
@@ -28,17 +28,19 @@ public class ClientConfiguration {
 private final SessionCredentialsProvider sessionCredentialsProvider;
 private final Duration requestTimeout;
 private final boolean sslEnabled;
+private final String namespace;
 
 /**
  * The caller is supposed to have validated the arguments and handled 
throwing exceptions or
  * logging warnings already, so we avoid repeating args check here.
  */
 ClientConfiguration(String endpoints, SessionCredentialsProvider 
sessionCredentialsProvider,
-Duration requestTimeout, boolean sslEnabled) {
+Duration requestTimeout, boolean sslEnabled, String namespace) {
 this.endpoints = endpoints;
 this.sessionCredentialsProvider = sessionCredentialsProvider;
 this.requestTimeout = requestTimeout;
 this.sslEnabled = sslEnabled;
+this.namespace = namespace;
 }
 
 public static ClientConfigurationBuilder newBuilder() {
@@ -60,4 +62,8 @@ public class ClientConfiguration {
 public boolean isSslEnabled() {
 return sslEnabled;
 }
+
+public String getNamespace() {
+return namespace;
+}
 }
diff --git 
a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfigurationBuilder.java
 
b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfigurationBuilder.java
index eb40c88c..25cc54a4 100644
--- 
a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfigurationBuilder.java
+++ 
b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientConfigurationBuilder.java
@@ -31,6 +31,7 @@ public class ClientConfigurationBuilder {
 private SessionCredentialsProvider sessionCredentialsProvider = null;
 private Duration requestTimeout = Duration.ofSeconds(3);
 private boolean sslEnabled = true;
+private String namespace = "";
 
 /**
  * Configure the access point with which the SDK should communicate.
@@ -82,6 +83,16 @@ public class ClientConfigurationBuilder {
 return this;
 }
 
+/**
+ * Configure namespace for client
+ * @param namespace namespace
+ * @return The {@link ClientConfigurationBuilder} instance, to allow for 
method chaining.
+ */
+public ClientConfigurationBuilder setNamespace(String namespace) {
+this.namespace = checkNotNull(namespace, "namespace should not be 
null");
+return this;
+}
+
 /**
  * Finalize the build of {@link ClientConfiguration}.
  *
@@ -90,6 +101,6 @@ public class ClientConfigurationBuilder {
 public ClientConfiguration build() {
 checkNotNull(endpoints, "endpoints should not be null");
 checkNotNull(requestTimeout, "requestTimeout should not be null");
-return new ClientConfiguration(endpoints, sessionCredentialsProvider, 
requestTimeout, sslEnabled);
+return new ClientConfiguration(endpoints, sessionC

[GH] (rocketmq-clients): Workflow run "Node.js Coverage" is working again!

2024-01-10 Thread GitBox


The GitHub Actions job "Node.js Coverage" on rocketmq-clients.git has succeeded.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
0aaf9f9763d4353f09f1b04f297bf7e0bc24ad90 / Zhouxiang Zhan 
[ISSUE #660] Add namespace in java client (#661)

* Add namespace for java client

* Add checkNotNull

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/7473929637

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user redlsz (triggered by redlsz).

Head commit for run:
3f99b1e96bedb0dc6854c92b2f753cdf9fa68197 / Zhouxiang Zhan 

[ISSUE #7707] Refector Context with link node implementation (#7708)

* Refector Context with link node implement

Report URL: https://github.com/apache/rocketmq/actions/runs/7473889941

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
3f99b1e96bedb0dc6854c92b2f753cdf9fa68197 / Zhouxiang Zhan 

[ISSUE #7707] Refector Context with link node implementation (#7708)

* Refector Context with link node implement

Report URL: https://github.com/apache/rocketmq/actions/runs/7473956277

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" is working again!

2024-01-10 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has succeeded.
Run started by GitHub user redlsz (triggered by redlsz).

Head commit for run:
87cb899c628c61bc1d28a7c6c734a6d2d330a326 / redlsz 
Fix revive incorrect message when the original message is not alive

Report URL: https://github.com/apache/rocketmq/actions/runs/7473857618

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7724] Fix revive incorrect message when the original message is not alive [rocketmq]

2024-01-10 Thread via GitHub


codecov-commenter commented on PR #7739:
URL: https://github.com/apache/rocketmq/pull/7739#issuecomment-1884656797

   ## 
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: `4 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`3f99b1e`)](https://app.codecov.io/gh/apache/rocketmq/commit/3f99b1e96bedb0dc6854c92b2f753cdf9fa68197?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.19% compared to head 
[(`87cb899`)](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.19%.
   
   | 
[Files](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...he/rocketmq/broker/processor/PopReviveService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==)
 | 0.00% | [4 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff @@
   ## develop#7739   +/-   ##
   ==
 Coverage  43.19%   43.19%   
   + Complexity  9829 9827-2 
   ==
 Files   1166 1166   
 Lines  8456484568+4 
 Branches   1098510986+1 
   ==
   + Hits   3652736531+4 
 Misses 4349943499   
 Partials4538 4538   
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7739?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #7543] Add enableRetryTopicV2 brokerConfig [rocketmq]

2024-01-10 Thread via GitHub


codecov-commenter commented on PR #7734:
URL: https://github.com/apache/rocketmq/pull/7734#issuecomment-1884666997

   ## 
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: `77 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`6fce427`)](https://app.codecov.io/gh/apache/rocketmq/commit/6fce427e109d905530b17e64aa5dc9bc19795c5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.21% compared to head 
[(`cc375fd`)](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.18%.
   > Report is 1 commits behind head on develop.
   
   | 
[Files](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...cketmq/broker/processor/NotificationProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL05vdGlmaWNhdGlvblByb2Nlc3Nvci5qYXZh)
 | 0.00% | [24 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...cketmq/remoting/protocol/header/ExtraInfoUtil.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL2hlYWRlci9FeHRyYUluZm9VdGlsLmphdmE=)
 | 21.42% | [20 Missing and 2 partials :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...ocketmq/broker/processor/PeekMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BlZWtNZXNzYWdlUHJvY2Vzc29yLmphdmE=)
 | 0.00% | [8 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...rocketmq/broker/processor/PopMessageProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==)
 | 75.00% | [5 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...apache/rocketmq/common/consumer/ReceiptHandle.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vY29uc3VtZXIvUmVjZWlwdEhhbmRsZS5qYXZh)
 | 0.00% | [5 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...in/java/org/apache/rocketmq/common/KeyBuilder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vS2V5QnVpbGRlci5qYXZh)
 | 0.00% | [4 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[.../java/org/apache/rocketmq/common/BrokerConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=)
 | 25.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...rocketmq/broker/metrics/ConsumerLagCalcu

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user redlsz (triggered by redlsz).

Head commit for run:
87cb899c628c61bc1d28a7c6c734a6d2d330a326 / redlsz 
Fix revive incorrect message when the original message is not alive

Report URL: https://github.com/apache/rocketmq/actions/runs/7473857611

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
cc375fd51855ec86400ccdd9a94314ed0e714a31 / zhouxiang 

fix unit test

Report URL: https://github.com/apache/rocketmq/actions/runs/7473917825

With regards,
GitHub Actions via GitBox



[I] [Bug] BROADCASTING DefaultMQPushConsumer can't fix illegal pull offset [rocketmq]

2024-01-10 Thread via GitHub


redlsz opened a new issue, #7740:
URL: https://github.com/apache/rocketmq/issues/7740

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   centos7
   
   ### RocketMQ version
   
   4.9.x | 5.1.x
   
   ### JDK Version
   
   JDK 1.8
   
   ### Describe the Bug
   
   https://github.com/apache/rocketmq/assets/103550934/d2f1a0bb-b7b6-4af4-b6ce-71b6281b4a8a";>
   
   We encountered a issue that the BROADCASTING DefaultMQPushConsumer was 
unable to consume: As shown in the log, the client received the OFFSET_ILLEGAL 
response returned by the broker and kept trying to fix nextOffset but failed, 
resulting in the inability to consume messages.
   
   我们遇到了一个 Push 消费者广播模式无法消费的问题:如日志所显示,客户端收到了服务端返回的 OFFSET_ILLEGAL,一直在尝试纠正 
nextOffset 但始终不能成功,导致无法消费。
   
   ### Steps to Reproduce
   
   1. Create a topic and produce certain messages.
   2. Wait for message to expire (queue minOffset >0).
   3. Create a subscription group and start a DefaultMQPushConsumer 
(MessageModel=BROADCASTING, ConsumeFromWhere=CONSUME_FROM_FIRST_OFFSET).
   4. Produce more messages.
   
   ### What Did You Expect to See?
   
   Normal message consumption.
   
   ### What Did You See Instead?
   
   The consumer is unable to consume any messages.
   
   ### Additional Context
   
   https://github.com/apache/rocketmq/assets/103550934/471d7b87-6552-4ea9-9b11-9a2002e9e7e1";>
   https://github.com/apache/rocketmq/assets/103550934/faa1b6cc-d6f2-48c6-bdc7-e153b00374d7";>
   https://github.com/apache/rocketmq/assets/103550934/a29222d4-bf7e-407d-a191-61ce3b5fa35e";>
   
   Possible cause we located after reviewing code:
   
   When the consumer handles OFFSET_ILLEGAL error, it will first set the 
correct nextOffset returned by the broker as the consumerOffset (in memory), 
and then delete the PQ corresponding to the MQ. When the next time the 
rebalance is triggered, it is expected to set the new consumerOffset as the 
nextOffset, reinitialize PQ and start pulling messages. But at this time the 
consumerOffset is read from the store (ReadOffsetType=READ_FROM_STORE), so it 
will always  get -1. As a result, the client will fall into an infinite loop of 
the above process.
   
   消费端在处理 OFFSET_ILLEGAL 时,首先会将服务端返回的正确的 nextOffset 更新为消费位点(内存),接着删除 MQ 对应的 
PQ。下次重平衡触发时,预期是将新的消费位点作为 nextOffset 重新初始化 PQ 并开始拉取消息。但此时是从持久化介质读取消费位点 
(ReadOffsetType=READ_FROM_STORE),因此永远只会读到 -1。于是,客户端会陷入上述过程的无限循环中。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Client will not retry to send message when broker busy [rocketmq]

2024-01-10 Thread via GitHub


github-actions[bot] commented on issue #5838:
URL: https://github.com/apache/rocketmq/issues/5838#issuecomment-1885959482

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [code discussition] Should the method queryAssignment request again? [rocketmq]

2024-01-10 Thread via GitHub


github-actions[bot] commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1885959519

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has 
failed.
Run started by GitHub user lizhanhui (triggered by lizhanhui).

Head commit for run:
3f99b1e96bedb0dc6854c92b2f753cdf9fa68197 / Zhouxiang Zhan 

[ISSUE #7707] Refector Context with link node implementation (#7708)

* Refector Context with link node implement

Report URL: https://github.com/apache/rocketmq/actions/runs/7482449709

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user drpmma (triggered by RongtongJin).

Head commit for run:
cc375fd51855ec86400ccdd9a94314ed0e714a31 / zhouxiang 

fix unit test

Report URL: https://github.com/apache/rocketmq/actions/runs/7473917825

With regards,
GitHub Actions via GitBox



Re: [PR] 开启proxy时,消费者启动时,不会生成对应的重试队列 [rocketmq]

2024-01-10 Thread via GitHub


onejimmyboy commented on PR #7257:
URL: https://github.com/apache/rocketmq/pull/7257#issuecomment-1886114794

   > I personally think that you should modify the code of the dashboard 
instead of modifying the broker to add this topic. This topic is unnecessary.
   
   The dashboard has not been updated for a long time, and it feels a bit late 
to create it in the dashboard. Before RocketMQ 5.0, the creation retry topic 
was also automatically created in the broker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq) branch develop updated: [ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734)

2024-01-10 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository.

zhouxzhan pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
 new 8a36471a19 [ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734)
8a36471a19 is described below

commit 8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d
Author: Zhouxiang Zhan 
AuthorDate: Thu Jan 11 11:11:53 2024 +0800

[ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734)

* Add enableRetryTopicV2
---
 .../broker/metrics/ConsumerLagCalculator.java  |   4 +-
 .../broker/offset/ConsumerOrderInfoManager.java|   4 +-
 .../broker/processor/AckMessageProcessor.java  |   2 +-
 .../broker/processor/AdminBrokerProcessor.java |   6 +-
 .../broker/processor/NotificationProcessor.java|  68 +++--
 .../broker/processor/PeekMessageProcessor.java |  12 ++-
 .../broker/processor/PopMessageProcessor.java  | 105 +
 .../broker/processor/PopReviveService.java |   2 +-
 .../broker/processor/AdminBrokerProcessorTest.java |   7 +-
 .../rocketmq/client/impl/MQClientAPIImplTest.java  |   8 +-
 .../org/apache/rocketmq/common/BrokerConfig.java   |   9 ++
 .../org/apache/rocketmq/common/KeyBuilder.java |  11 +++
 .../rocketmq/common/consumer/ReceiptHandle.java|  11 ++-
 .../org/apache/rocketmq/common/KeyBuilderTest.java |  10 +-
 .../proxy/processor/ConsumerProcessorTest.java |   5 +-
 .../proxy/processor/ProducerProcessorTest.java |   3 +-
 .../service/message/LocalMessageServiceTest.java   |   4 +-
 .../remoting/protocol/header/ExtraInfoUtil.java|  68 -
 .../protocol/header/ExtraInfoUtilTest.java |   4 +-
 .../test/container/PopSlaveActingMasterIT.java |  12 ++-
 20 files changed, 204 insertions(+), 151 deletions(-)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java
 
b/broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java
index d1f3fffde7..1930d0dfcb 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java
@@ -176,7 +176,7 @@ public class ConsumerLagCalculator {
 }
 
 if (isPop) {
-String retryTopic = KeyBuilder.buildPopRetryTopic(topic, 
group);
+String retryTopic = KeyBuilder.buildPopRetryTopic(topic, 
group, brokerConfig.isEnableRetryTopicV2());
 TopicConfig retryTopicConfig = 
topicConfigManager.selectTopicConfig(retryTopic);
 if (retryTopicConfig != null) {
 int retryTopicPerm = retryTopicConfig.getPerm() & 
brokerConfig.getBrokerPermission();
@@ -185,7 +185,7 @@ public class ConsumerLagCalculator {
 continue;
 }
 }
-if (brokerConfig.isRetrieveMessageFromPopRetryTopicV1()) {
+if (brokerConfig.isEnableRetryTopicV2() && 
brokerConfig.isRetrieveMessageFromPopRetryTopicV1()) {
 String retryTopicV1 = 
KeyBuilder.buildPopRetryTopicV1(topic, group);
 TopicConfig retryTopicConfigV1 = 
topicConfigManager.selectTopicConfig(retryTopicV1);
 if (retryTopicConfigV1 != null) {
diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java
 
b/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java
index 2e2850dbbc..4eccc6c037 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/offset/ConsumerOrderInfoManager.java
@@ -121,7 +121,7 @@ public class ConsumerOrderInfoManager extends ConfigManager 
{
 Set offsetSet = offsetConsumedCount.keySet();
 for (Long offset : offsetSet) {
 Integer consumedTimes = 
offsetConsumedCount.getOrDefault(offset, 0);
-ExtraInfoUtil.buildQueueOffsetOrderCountInfo(orderInfoBuilder, 
isRetry, queueId, offset, consumedTimes);
+ExtraInfoUtil.buildQueueOffsetOrderCountInfo(orderInfoBuilder, 
topic, queueId, offset, consumedTimes);
 minConsumedTimes = Math.min(minConsumedTimes, consumedTimes);
 }
 
@@ -136,7 +136,7 @@ public class ConsumerOrderInfoManager extends ConfigManager 
{
 
 // for compatibility
 // the old pop sdk use queueId to get consumedTimes from orderCountInfo
-ExtraInfoUtil.buildQueueIdOrderCountInfo(orderInfoBuilder, isRetry, 
queueId, minConsumedTimes);
+ExtraInfoUtil.buildQueueIdOrderCountInfo(orderInfoBuilder, topic, 
queueId, minConsumedTimes);
 updateLockFreeTimestamp(topic, group, queueId, orderInfo);
 }
 
d

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d / Zhouxiang Zhan 

[ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734)

* Add enableRetryTopicV2

Report URL: https://github.com/apache/rocketmq/actions/runs/7483763988

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7543] Add enableRetryTopicV2 brokerConfig [rocketmq]

2024-01-10 Thread via GitHub


drpmma merged PR #7734:
URL: https://github.com/apache/rocketmq/pull/7734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-01-10 Thread GitBox


The GitHub Actions job "PUSH-CI" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d / Zhouxiang Zhan 

[ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734)

* Add enableRetryTopicV2

Report URL: https://github.com/apache/rocketmq/actions/runs/7483763989

With regards,
GitHub Actions via GitBox



Re: [I] [Doc] hope to add docker or k8s deployment guide in official quick start documents [rocketmq]

2024-01-10 Thread via GitHub


CzyerChen commented on issue #7736:
URL: https://github.com/apache/rocketmq/issues/7736#issuecomment-1886263159

   > ref https://github.com/apache/rocketmq-docker
   That's great!
   Is it possible to give a  title referenced to the project in Quick Start? or 
I missed that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Insufficient disk space but frequent alarms [rocketmq]

2024-01-10 Thread via GitHub


1925747950 commented on issue #7738:
URL: https://github.com/apache/rocketmq/issues/7738#issuecomment-1886378673

   > 出现问题的时候看看哪个文件占用高
   
   文件占用都不高:使用du -sh /data/*查看目录占用只用20G左右,并且没有看到大的隐藏文件


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug] BROADCASTING DefaultMQPushConsumer can't fix illegal pull offset [rocketmq]

2024-01-10 Thread via GitHub


humkum commented on issue #7740:
URL: https://github.com/apache/rocketmq/issues/7740#issuecomment-1886382753

   之前我也遇到过这个问题,可以提个 patch 修复下


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

2024-01-10 Thread via GitHub


humkum commented on PR #7652:
URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1886384979

   LGTM~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] enableLmq = true 已开启,mqtt发布的消息,mqttConsumer订阅不到消息。使用其他三方mqtt服务,mqttConsumer代码就可以。而且使用mqttConsumer不需要配置consumerGroup? [rocketmq-mqtt]

2024-01-10 Thread via GitHub


DongyuanPan commented on issue #234:
URL: https://github.com/apache/rocketmq-mqtt/issues/234#issuecomment-1886407567

   检查一下系统Topic是否创建,事件通知、重试topic等
   检查一下first topic是否提前创建,并配置到namesrv 的kv里面。
   如果通配符用到了,也需要配置到kv里面。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] enableLmq = true 已开启,mqtt发布的消息,mqttConsumer订阅不到消息。使用其他三方mqtt服务,mqttConsumer代码就可以。而且使用mqttConsumer不需要配置consumerGroup? [rocketmq-mqtt]

2024-01-10 Thread via GitHub


DongyuanPan commented on issue #234:
URL: https://github.com/apache/rocketmq-mqtt/issues/234#issuecomment-1886408596

   而且使用mqttConsumer不需要配置consumerGroup?
   不需要,MQTT协议没有consumerGroup的概念


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] 测试环境开启TLS后,使用自定义证书,报错javax.net.ssl.SSLException: Received fatal alert: certificate_unknown [rocketmq-mqtt]

2024-01-10 Thread via GitHub


DongyuanPan commented on issue #233:
URL: https://github.com/apache/rocketmq-mqtt/issues/233#issuecomment-1886418297

   是不是生产者没有带证书链?只带了设备证书?
   可以参考 
https://help.aliyun.com/zh/apsaramq-for-mqtt/user-guide/certificate-management/?spm=a2c4g.11186623.0.0.796e2017B5AlMC
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org